Re: [ros-svn] [jimtabor] 20958: Port Wine GetCharWidth32A.

[Magnus Olsen]

This implention is wrong please revert it
it shall and must be implement in win32k not direcly to gdi32
NtGdiGetCharWidth

----- Original Message ----- 
From: <jimtabor(a)svn.reactos.org>
To: <ros-svn(a)reactos.org>
Sent: den 21 January 2006 01:52
Subject: [ros-svn] [jimtabor] 20958: Port Wine GetCharWidth32A.


>   Port Wine GetCharWidth32A.
>
>
>  Updated files:
>  trunk/reactos/lib/gdi32/objects/font.c
>
>  _______________________________________________
>  Ros-svn mailing list
>  Ros-svn(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-svn

[James Tabor]

Magnus Olsen wrote:
>   This implention is wrong please revert it
>  it shall and must be implement in win32k not direcly to gdi32
>  NtGdiGetCharWidth
>   
Hi,
You mean NtGdiGetCharWidthW right? So all this is done in win32k
NtGdiGetCharWidth32 (it should be called NtGdiGetCharWidthW). I
guess I did not see the char being processed right. Yes I see.
Okay,
Thanks,
James

[James Tabor]

Hi,
Done some thinking on this!

James Tabor wrote:
>   Magnus Olsen wrote:
>  
> >   This implention is wrong please revert it
> >  it shall and must be implement in win32k not direcly to gdi32
> >  NtGdiGetCharWidth
> >  
>  Hi,
>  You mean NtGdiGetCharWidthW right? So all this is done in win32k
>  NtGdiGetCharWidth32 (it should be called NtGdiGetCharWidthW). I
>  guess I did not see the char being processed right. Yes I see.
>  Okay,
>  Thanks,
>  James 
Based on what I know now, GetCharWidthA is done in gdi32. Later,it calls
NtGdiGetCharWidthW. We have NtGdiGetCharWidth32 witch is the wrong name
for it, if anyone wants to be a purest about it.

There is a wine test "gdi32_crosstest font".
Thanks,
James