Re: [ros-dev] [ros-diffs] [tkreuzer] 53494: [INTRIN] - add __nop()

[Alex Ionescu]

Can you also add __noop please?

Best regards,
Alex Ionescu

On Mon, Aug 29, 2011 at 11:10 PM, [e-mail] wrote:
> Author: tkreuzer
> Date: Mon Aug 29 23:10:04 2011
> New Revision: 53494
>
> URL: http://svn.reactos.org/svn/reactos?rev=53494&view=rev
> Log:
> [INTRIN]
> add  __nop()
>
> Modified:
>    trunk/reactos/include/crt/mingw32/intrin_x86.h
>
> Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin_...
>
> ==============================================================================
> --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original)
> +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Mon Aug 29
> 23:10:04 2011
> @@ -1505,11 +1505,18 @@
>        __asm__ __volatile__("sidt %0" : : "m"(*(short*)Destination) :
> "memory");
>  }
>
> +/*** Misc operations ***/
>
> __INTRIN_INLINE void _mm_pause(void)
>  {
>        __asm__ __volatile__("pause" : : : "memory");
>  }
>
> +__INTRIN_INLINE void __nop(void)
> +{
>   __asm__ __volatile__("nop");
>
> +}
>
> #ifdef __cplusplus
>  }
>  #endif

[Timo Kreuzer]

On 30.08.2011 02:09, Alex Ionescu wrote:
> Can you also add __noop please?
>
> Best regards,
> Alex Ionescu

We already have it, its in intrin.h, instead of intrin_x86.h (it's 
completely portable :))

Timo