Re: [ros-cvs] CVS Update: reactos

[e-mail] wrote:
> CVSROOT:	/CVS/ReactOS
> Module name:	reactos
> Repository:	reactos/w32api/include/
> Changes by:	[e-mail]	04/12/05 18:23:06
>
> Modified files:
>    reactos/include/win32k/: ntuser.h 
>    reactos/lib/user32/misc/: misc.c 
>    reactos/subsys/system/winlogon/: winlogon.h 
>    reactos/subsys/win32k/include/: desktop.h 
>    reactos/subsys/win32k/ntuser/: desktop.c misc.c stubs.c 
>    reactos/w32api/include/: winuser.h
>
> Log message:
> Basic implementation of (NtUser)UpdatePerUserSystemParameters.
> Move code querying for "PaintDesktopVersion" to NtUserUpdatePerUserSystemParameters.

I think the code to query for "PaintDesktopVersion" should be moved back 
to its old location and get called from 
NtUserUpdatePerUserSystemParameters becaus this function needs to do a 
lot more initialization work on behalf of the user. For example, 
updating system colors, system metrics and setting the background 
pattern or wallpaper.

Regatds,
Eric

[Filip Navara]

----- PŮVODNÍ ZPRÁVA -----
Od: "Eric Kohl" [e-mail]
Komu: [e-mail]
Předmět: [ros-dev] Re: [ros-cvs] CVS Update: reactos
Datum: 6.12.2004 - 15:49:28
> [e-mail] wrote:
> > CVSROOT:	/CVS/ReactOS
> > Module name:	reactos
> > Repository:	reactos/w32api/include/
> > Changes by:	[e-mail]	04/12/05 18:23:06
> >
> > Modified files:
> >    reactos/include/win32k/: ntuser.h 
> >    reactos/lib/user32/misc/: misc.c 
> >    reactos/subsys/system/winlogon/: winlogon.h 
> >    reactos/subsys/win32k/include/: desktop.h 
> >    reactos/subsys/win32k/ntuser/: desktop.c misc.c stubs.c 
> >    reactos/w32api/include/: winuser.h
> >
> > Log message:
> > Basic implementation of
> > (NtUser)UpdatePerUserSystemParameters.
> > Move code querying for "PaintDesktopVersion" to
> > NtUserUpdatePerUserSystemParameters.
>
> I think the code to query for "PaintDesktopVersion" should be
> moved back 
> to its old location and get called from 
> NtUserUpdatePerUserSystemParameters becaus this function needs
> to do a 
> lot more initialization work on behalf of the user. For
> example, 
> updating system colors, system metrics and setting the
> background 
> pattern or wallpaper.

I agree with you. I've done that in my local tree along with fixes
to token functions that actually make the code work two days ago,
but unfortunately my main computer (the one with local ROS CVS tree
copy) is currently out of order and so i can't commit the code.
Please wait a few days...

Regards,
Filip