Re: [ros-dev] [ros-diffs] [akhaldi] 71183: [CLASSPNP] Fix MSVC build. Brought to you by Timo.

[Thomas Faber]

On 2016-04-20 14:16, [e-mail] wrote:
> [CLASSPNP] Fix MSVC build. Brought to you by Timo.
> --- trunk/reactos/drivers/storage/classpnp/class.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/storage/classpnp/class.c	[iso-8859-1] Wed Apr 20 12:16:16 2016
> @@ -877,7 +877,7 @@
>                  status = devInfo->ClassStopDevice(DeviceObject, IRP_MN_STOP_DEVICE);
>              ASSERTMSG("ClassDispatchPnp !! STOP_DEVICE should "
>                      "never be failed\n", NT_SUCCESS(status));
>                      L"never be failed\n", NT_SUCCESS(status));
>
>            if(isFdo) {
>                status = ClassForwardIrpSynchronous(commonExtension, Irp);

This makes no sense to me at all. You're now concatenating a narrow and
a wide string (which should be an error, but compilers suck), and
passing it to a macro that calls RtlAssert -- which expects a narrow
string.
Am I missing something here?