Re: [ros-dev] Differences in Windows and Linux builds

> >   - At the boot
> > screen, the version compiled under Windows shows
> >  "Service Pack  1" correctly, but the version compiled under Linux
> >  shows "Service Pac 1" 
>  
>  I see this "Service Pac 1" in ReactOS compiled under Windows with GCC 4.1.2
> (from RosBE).  
In ExpInitializeExecutive():

   ...
   ANSI_STRING CsdString;
   ...
   RtlInitAnsiString(&CsdString, MsgEntry->Text);
   CsdString.Length -= sizeof(UNICODE_NULL);
   ...

Why Unicode?

[Colin Finck]

This bug is fixed now in r26764.

The line 'CsdString.Length -= sizeof(UNICODE_NULL);' was used to remove the
new line at the end of the message.
But on Windows, the compiled message table had a "\r\n" as the newline
character and on Linux it was just "\n". So the "Service Pack" string
was
chopped on Linux builds.

This is mainly a problem in wmc, which should compile the same line ending
into the message table on different platforms.
But the changes of r26764 also work around this problem in the kernel.

Regards,

Colin


>   -----Original Message-----
>  From: ros-dev-bounces(a)reactos.org 
>  [mailto:[e-mail]] On Behalf Of hto(a)mail.cnt.ru
>  Sent: Sunday, May 13, 2007 9:17 PM
>  To: ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] Differences in Windows and Linux builds
>  
> > >   - At the
> > > boot screen, the version compiled under Windows shows
> > >  "Service Pack  1" correctly, but the version compiled under Linux
> > >  shows "Service Pac 1" 
> >  
> >  I see this "Service Pac 1" in ReactOS compiled under  
>  Windows with GCC
> 4.1.2 (from RosBE). 
>  
>  In ExpInitializeExecutive():
>  
>     ...
>     ANSI_STRING CsdString;
>     ...
>     RtlInitAnsiString(&CsdString, MsgEntry->Text);
>     CsdString.Length -= sizeof(UNICODE_NULL);
>     ...
>  
>  Why Unicode?
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev