Re: [ros-dev] [ros-diffs] [ekohl] 63330: [NTOSKRNL] Partial revert of r63326! The correct partition numbers cause boot failures.

[Alex Ionescu]

Lol so maybe you should think twice next time you see "FIXFIX REACTOS
HACK" like I originally wrote it ;-)
Best regards,
Alex Ionescu


On Sat, May 17, 2014 at 4:42 PM,  <ekohl(a)svn.reactos.org> wrote:
>   Author: ekohl
>  Date: Sat May 17 14:42:28 2014
>  New Revision: 63330
>
>  URL: http://svn.reactos.org/svn/reactos?rev=63330&view=rev
>  Log:
>  [NTOSKRNL]
>  Partial revert of r63326! The correct partition numbers cause boot failures.
>
>  Modified:
>      trunk/reactos/ntoskrnl/fstub/disksup.c
>
>  Modified: trunk/reactos/ntoskrnl/fstub/disksup.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/fstub/disksup.c      [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/fstub/disksup.c      [iso-8859-1] Sat May 17 14:42:28 2014
>  @@ -1655,7 +1655,9 @@
>                       UInt32x32To64(GET_PARTITION_LENGTH(PartitionDescriptor),
>                                     SectorSize);
>
>  -                PartitionInfo->PartitionNumber =
> (!IsContainerPartition(PartitionType)) ? i : 0;
>  +                // BUGBUGBUG: The correct partition numbers seem to cause boot
> failures!!!
>  +//                PartitionInfo->PartitionNumber =
> (!IsContainerPartition(PartitionType)) ? i : 0;
>  +                PartitionInfo->PartitionNumber = i + 1;
>               }
>               else
>               {
>
>

[Eric Kohl]

Thank you for this very helpful comment!


Am 20.05.2014 12:18, schrieb Alex Ionescu:
>   Lol so maybe you should think twice next time you see
> "FIXFIX REACTOS
>  HACK" like I originally wrote it ;-)
>  Best regards,
>  Alex Ionescu