We do not support some binutils for diffent reason and I do not think this patch is good, for it active least one version of binutils that always break reactos, it does not the linking right or was it some other issue. And I do not want see this patch in reactos for that reason. see older mails why we support 2.15.94 or higher.
----- Original Message ----- From: "Alex Buell" alex.buell@munted.org.uk To: "ReactOS Development" Ros-dev@reactos.org Sent: den 29 November 2005 17:52 Subject: [ros-dev] Patch for lib/rtl/i386/math_asm.S
The following might be better for those of us using older binutils
--- lib/rtl/i386/math_asm.S.orig 2005-11-29 15:47:23.000000000 +0000 +++ lib/rtl/i386/math_asm.S 2005-11-29 15:47:09.000000000 +0000 @@ -731,7 +731,7 @@ mov al,ah // Move condition flags to AL lahf // Load Flags into AH and al, 0b01000101 // Isolate C0, C2 and C3
and ah,not 0b01000101 // Turn off CF, PF and ZF
and ah, 0b10111010 // Turn off CF, PF and ZF or ah,al // Set new CF, PF and ZF sahf // Store AH into Flags jb __fpow1 // Re-direct if x < 0@@ -743,7 +743,7 @@ mov al,ah // Move condition flags to AL lahf // Load Flags into AH and al, 0b01000101 // Isolate C0, C2 and C3
and ah,not 0b01000101 // Turn off CF, PF and ZF
and ah, 0b10111010 // Turn off CF, PF and ZF or ah,al // Set new CF, PF and ZF sahf // Store AH into Flags ja __fpow3 // Re-direct if y > 0@@ -759,7 +759,7 @@ mov al,ah // Move condition flags to AL lahf // Load Flags into AH and al, 0b01000101 // Isolate C0, C2 and C3
and ah,not 0b01000101 // Turn off CF, PF and ZF
and ah, 0b10111010 // Turn off CF, PF and ZF or ah,al // Set new CF, PF and ZF sahf // Store AH into Flags je __fpow2 // Proceed if y = int(y)Cheers, Alex -- http://www.munted.org.uk
Anyone that thinks an imaginary deity is going to protect them against earthquakes and hurricanes needs psychiatric help. _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.1.362 / Virus Database: 267.13.9/185 - Release Date: 2005-11-28
From: Magnus Olsen
We do not support some binutils for diffent reason and I do not think this patch is good, for it active least one version of binutils that always break reactos, it does not the linking right or was it some other issue. And I do not want see this patch in reactos for that reason. see older mails why we support 2.15.94 or higher.
You are right that some binutils result in broken ReactOS builds, but at least 2.15.90 is perfectly capable of creating correct builds but doesn't support the "not" operator. So I've applied the patch, there's no reason "not" too :)
GvG
If I rember correct it was some 2.15.9x did break ros I do not rember wich version.
----- Original Message ----- From: "Ge van Geldorp" gvg@reactos.org To: "'ReactOS Development List'" ros-dev@reactos.org Sent: den 30 November 2005 18:28 Subject: RE: [ros-dev] Patch for lib/rtl/i386/math_asm.S
From: Magnus Olsen
We do not support some binutils for diffent reason and I do not think this patch is good, for it active least one version of binutils that always break reactos, it does not the linking right or was it some other issue. And I do not want see this patch in reactos for that reason. see older mails why we support 2.15.94 or higher.
You are right that some binutils result in broken ReactOS builds, but at least 2.15.90 is perfectly capable of creating correct builds but doesn't support the "not" operator. So I've applied the patch, there's no reason "not" too :)
GvG
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-- No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.1.362 / Virus Database: 267.13.10/188 - Release Date:
2005-11-29
-
Ge van Geldorp -
Magnus Olsen -
Royce Mitchell III