Re: [ros-dev] [ros-diffs] [rmessiant] 50076: [CLASSPNP] - Use correct type in sizeof expression (CID 1646 and 10401). - Simplify signature define (CID 3653 and 3654). - Remove funky 0xFF characters.

[Timo Kreuzer]

Am 21.12.2010 01:41, schrieb [e-mail]:
> Author: rmessiant
> Date: Tue Dec 21 00:41:52 2010
> New Revision: 50076
>
> ...
>
> -#define DICTIONARY_SIGNATURE (((ULONG)'dict'<<  32) + 'sig ')
>
> -struct _DICTIONARY_HEADER {
> +#define DICTIONARY_SIGNATURE 'dsig'

I think it was supposed to be something like (ULONGLONG)'dictsig '

[Roel Messiant]

True, but the signature or the structure aren't defined in a public
header, just in a private file.
So we can do whatever we want with it, and this version just seemed "easier".

If you want to change it to your version, that's fine too.

2010/12/21 Timo Kreuzer [e-mail]:
> Am 21.12.2010 01:41, schrieb [e-mail]:
> > Author: rmessiant
> > Date: Tue Dec 21 00:41:52 2010
> > New Revision: 50076
> >
> > ...
> >
> > -#define DICTIONARY_SIGNATURE (((ULONG)'dict'<<  32) + 'sig ')
> >
> > -struct _DICTIONARY_HEADER {
> > +#define DICTIONARY_SIGNATURE 'dsig'
>
> I think it was supposed to be something like (ULONGLONG)'dictsig '
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev