Re: [ros-dev] [ros-diffs] [jimtabor] 60682: [Win32ss] - Prevent a potential kernel exception.

[Thomas Faber]

On 2013-10-16 00:14, jimtabor(a)svn.reactos.org wrote:
>   URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window…
>  ==============================================================================
>  --- trunk/reactos/win32ss/user/user32/windows/prop.c	[iso-8859-1] (original)
>  +++ trunk/reactos/win32ss/user/user32/windows/prop.c	[iso-8859-1] Tue Oct 15 22:14:48
> 2013
>  @@ -53,6 +53,7 @@
>     for (i = 0; i < pWnd->PropListItems; i++ )
>     {
>         Property = CONTAINING_RECORD(ListEntry, PROPERTY, PropListEntry);
>  +      if (!Property) break;
>         if (Property->Atom == Atom)
>         {
>            return(Property);
>  
>   
That can't happen unless the list is corrupt.
And even if the list contains a null pointer (which it's not supposed
to), ListEntry would be NULL, not Property.

[James Tabor]

Yes, at first is seemed to be the issue but it was something else. The
user memory heap is unreachable (pointer to the property) when opening
and closing cmd and explorer windows (more than 10). This happens in
win32k not user32. So the patch for user32 is just an artifact that
can be removed later.

On 10/15/13, Thomas Faber <thomas.faber(a)reactos.org> wrote:
>  
>  That can't happen unless the list is corrupt.
>  And even if the list contains a null pointer (which it's not supposed
>  to), ListEntry would be NULL, not Property.
>