Re: [ros-dev] [ros-diffs] [hbelusca] 63506: [NTOS:CM] Replace a hardcoded value with something more readable.

[Timo Kreuzer]

Am 30.05.2014 23:47, schrieb hbelusca(a)svn.reactos.org:
>   Author: hbelusca
>  Date: Fri May 30 21:47:22 2014
>  New Revision: 63506
>
>  URL: http://svn.reactos.org/svn/reactos?rev=63506&view=rev
>  Log:
>  [NTOS:CM]
>  Replace a hardcoded value with something more readable. 
>   -    RootKey->Type = '20yk';
>  +    RootKey->Type = CM_KEY_BODY_TYPE;
>       RootKey->NotifyBlock = NULL; 
>   +//
>  +#define CM_KEY_BODY_TYPE                                0x6B793032 
Why not '20yk' ? This hex constant looks fishy.

[Hermès BÉLUSCA - MAÏTO]

Well Timo, it looks as fishy as the already existing constants here:
http://git.reactos.org/?p=reactos.git;a=blob;f=reactos/lib/cmlib/hivedata.h;
hb=HEAD#l47
(where you have 'regf' and 'hbin' declared), and the constants there:
http://git.reactos.org/?p=reactos.git;a=blob;f=reactos/ntoskrnl/include/inte
rnal/cm.h;hb=HEAD#l71

... :P

Hermès.


-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Timo Kreuzer
Envoyé : samedi 31 mai 2014 21:07
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 63506: [NTOS:CM] Replace a
hardcoded value with something more readable.

Am 30.05.2014 23:47, schrieb hbelusca(a)svn.reactos.org:
>   Author: hbelusca
>  Date: Fri May 30 21:47:22 2014
>  New Revision: 63506
>
>  URL: http://svn.reactos.org/svn/reactos?rev=63506&view=rev
>  Log:
>  [NTOS:CM]
>  Replace a hardcoded value with something more readable. 
>   -    RootKey->Type = '20yk';
>  +    RootKey->Type = CM_KEY_BODY_TYPE;
>       RootKey->NotifyBlock = NULL; 
>   +//
>  +#define CM_KEY_BODY_TYPE                                0x6B793032 
Why not '20yk' ? This hex constant looks fishy.


_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev