RE: [ros-svn] [gvg] 20175: Don't pop-up device installer screen.

[Ge van Geldorp]

> From: [e-mail]
>
> Don't pop-up device installer screen.
> Fixes bug 1026

I've committed this to the branch only, not sure if it should be committed
to trunk also. I'd like to hear how the PnP guys feel about this.

GvG

[Hervé Poussineau]

> -----Message d'origine-----
> De : [e-mail] [mailto:[e-mail]] De la

part de Ge van Geldorp
> Envoyé : mercredi 14 décembre 2005 21:40
> À : [e-mail]
> Objet : [ros-dev] RE: [ros-svn] [gvg] 20175: Don't pop-up device

installerscreen.
> > From: [e-mail]
> >
> > Don't pop-up device installer screen.
> > Fixes bug 1026
>
> I've committed this to the branch only, not sure if it should be committed

to trunk
> also. I'd like to hear how the PnP guys feel about this.
>
> GvG

I think the bug 1026 should be correctly fixed by disabling the device. Why
exactly can't we access the "Do not show this dialog anymore", and what are
the functions needed (in setupapi?) to disable the device properly? Are they
implemented?

I think we should also be able to provide a custom path for the driver; the
dialog is already done, but it doesn't seem functional :(

Hervé

[Ge van Geldorp]

> From: Hervé Poussineau
>
> I think the bug 1026 should be correctly fixed by disabling 
> the device.

Ok, both you and Thomas feel this way, good enough for me. I won't commit to
trunk and won't press this matter any further.

GvG

[Thomas Weidenmueller]

Ge van Geldorp wrote:
> Ok, both you and Thomas feel this way, good enough for me. I won't commit to
> trunk and won't press this matter any further.

The wizard already is able to disable the device, however the checkbox
is disabled because ReactOS reports that the device cannot be disabled.

- Thomas

[Thomas Weidenmueller]

Ge van Geldorp wrote:
> I've committed this to the branch only, not sure if it should be committed
> to trunk also. I'd like to hear how the PnP guys feel about this.

No, the wizard is supposed to pop up unless the devices are disabled or
installed. It works this way in windows.

- Thomas

[Ged Murphy]

Thomas Weidenmueller wrote:
> Ge van Geldorp wrote:
> > I've committed this to the branch only, not sure if it should be committed
> > to trunk also. I'd like to hear how the PnP guys feel about this.
>
> No, the wizard is supposed to pop up unless the devices are disabled or
> installed. It works this way in windows.
> Thomas

It's ok as a quick fix until the method you describe can be implemented.
I'm assuming this is why Gé only committed to the branch

[Ge van Geldorp]

> From: Thomas Weidenmueller
>
> Ge van Geldorp wrote:
> > I've committed this to the branch only, not sure if it should be 
> > committed to trunk also. I'd like to hear how the PnP guys 
> > feel about this.
>
> No, the wizard is supposed to pop up unless the devices are 
> disabled or installed. It works this way in windows.

I fully understand that. I also understand that the code to properly support
this (disable the device if the user indicates so in the wizard) isn't
present yet. Please note that I didn't close bug 1026, it's only a
workaround, not a fix.

The point is that for the last month or so we've had a currently pretty
useless wizard popup multiple times each boot. I would just like to disable
that unti the wizard does become usefull.

GvG