Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits b ecause your eyes are inventing the word "copyright". I tried r eally hard, I really did, but I could not find even the word "copy", much less "copy right". - Lesson Two: What do yo

[Murphy, Ged (Bolton)]

Whether headers are added or not, my point was simply that a translator
shouldn't put himself into the header as the programmer.
It's a little discourteous to the actual programmer (although most devs
won't actually care), and it creates a false piece of information.

Consider the following scenario:

foo: Hi. one of the buttons is sending the wrong message in the German
dialog. Can you fix it please
bar: Sorry, I'm not a programmer
foo: But it has your name as the programmer in the header...

Perhaps if translators want to be named in resource files, and we feel a
need to put headers in all our resource files too (which I think is a bit
overkill, they should be kept in the main code only) we could include an
extra line for TRANSLATOR:

Anyway, it wasn't my intention to drag this through ros-dev.

-----Original Message-----
From: Peter Dolding [mailto:[e-mail]] 
Sent: 27 June 2006 14:27
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [ion] 22649: - Lesson One: Don't revert
commits b ecause your eyes are inventing the word "copyright". I tried
really hard, I really did, but I could not find even the word "copy", much
less "copy right". - Lesson Two: What do yo

Sorry to stick my nose in here.
Two critical points have been missed.  Fine in this case since the code 
was declare public domain.
Other cases it will not be fine.   The new alterations started under a 
new copyright.  Can override public domain.  If it was a GPL licence 
even a BSD licence how can you say it up the creek without a paddle.

If a document was created by X person then altered by Y.  X persons 
copyright still stands until what time it becomes public domain.  Even 
that Y holds copyright on the alterations so is also allowed a credit 
mark under the most country's.
Personally think both have stuffed up minorly.  Note strange I could not 
find the files in the Reactos tree.

Its also a fault I find with MSVS it does not licence tag the .rc 
files.  It would make job simpler.  If there is no simpler code as all 
between the .rc files it would be fine.  I totally don't expect that.
The lines I would normally add are.
/*
 From project Solitaire
That was under license: Freeware, permission to use under Public Domain
based on  <filename>
By Daniel "EmuandCo" Reimer ([e-mail])
New content licensed under <GPL Reactos as per above>
Translation/Alterations by
<list people here><< People to track down to prove that the license 
change was done under permitted grounds ie new content.
*/
Now the file has two licences ie GPL alterations and Public domain 
content.  If person takes the new content they are stuffed.  But a 
person could return it to public domain if the remove the content we 
have altered.

The other option is just to over license it since its public domain and 
it part of a new work.  Its still a good idea to leave a marker in case 
of future audits.

If someone comes along and said hey your file looks like ours.  And we 
have markers can quickly say hey did you acquire that file from there.

Yes I know its large.  It gets more complex with BSD and GPL.  Its all 
about tracking.  GPL master copyrighter stays.  No option to relicense 
is given.  Alteration by the Reactos team or author marks is all that 
could be added.  BSD can be overlicened as long as the old BSD header 
with first copyright holder stays and the new license is not 
incomparable with BSD.

Playing with these things can turn into breach of copyright very quickly.
Murphy, Ged (Bolton) wrote:
> This is still James' code, it's just been moved out of sol.rc and into a
> separate file.
> My point was, if someone translated my code and named themselves as the
> programmer (ok, not using the word copyright) it would p!ss me off a

little
> bit.
>
> I wasn't having a go at anyone, my commit message was entirely civil and
> just correcting something which seemed wrong to me. God only knows why
> you've taken offence, or needed to revert to belittling.
>
> Apologies to EmuandCo, this is not aimed at you.
>
> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]] 
> Sent: 27 June 2006 00:50
> To: [e-mail]
> Subject: [ros-diffs] [ion] 22649: - Lesson One: Don't revert commits

because
> your eyes are inventing the word "copyright". I tried really hard, I

really
> did, but I could not find even the word "copy", much less "copyright". -
> Lesson Two: What do you know! En and D
>
> Author: ion
> Date: Tue Jun 27 03:50:03 2006
> New Revision: 22649
>
> URL: http://svn.reactos.org/svn/reactos?rev=22649&view=rev
> Log:
> Lesson One: Don't revert commits because your eyes are inventing the

word
> "copyright". I tried really hard, I really did, but I could not find even
> the word "copy", much less "copyright".
> Lesson Two: What do you know! En and De.rc actually *are* our files, not
>
> James Brown's (his is sol.rc, which hasn't been altered with a ROS

Header).
> Lesson Three: It is official (voted) ROS Policy that all ROS files have

a
> header. Reverting this header violated it.
>
> Modified:
>     trunk/reactos/base/applications/games/solitaire/de.rc
>     trunk/reactos/base/applications/games/solitaire/en.rc
>
> Modified: trunk/reactos/base/applications/games/solitaire/de.rc
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol
> itaire/de.rc?rev=22649&r1=22648&r2=22649&view=diff

============================================================================
> ==
> --- trunk/reactos/base/applications/games/solitaire/de.rc (original)
> +++ trunk/reactos/base/applications/games/solitaire/de.rc Tue Jun 27
> 03:50:03 2006
> @@ -1,3 +1,10 @@
> +/*
> PROJECT:     Solitaire
> LICENSE:     Freeware, permission to use under Public Domain
> FILE:        base/applications/games/solitaire/de.rc
> PURPOSE:     German Language File for Solitaire
> PROGRAMMERS: Daniel "EmuandCo" Reimer ([e-mail])
> */
>
> #include "resource.h"
>
> #define APSTUDIO_READONLY_SYMBOLS
>
> Modified: trunk/reactos/base/applications/games/solitaire/en.rc
> URL:

http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sol
> itaire/en.rc?rev=22649&r1=22648&r2=22649&view=diff

============================================================================
> ==
> --- trunk/reactos/base/applications/games/solitaire/en.rc (original)
> +++ trunk/reactos/base/applications/games/solitaire/en.rc Tue Jun 27
> 03:50:03 2006
> @@ -1,3 +1,10 @@
> +/*
> PROJECT:     Solitaire
> LICENSE:     Freeware, permission to use under Public Domain
> FILE:        base/applications/games/solitaire/en.rc
> PURPOSE:     English Language File for Solitaire
> PROGRAMMERS: Daniel "EmuandCo" Reimer ([e-mail])
> */
>
> #include "resource.h"
>
> #define APSTUDIO_READONLY_SYMBOLS
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Daniel Reimer]

I was asked by janderwald to add a header, so I added it as described in 
Wiki. If I made it wrong, sorry for that. I did not want to cause 
problems with that... Now back to Chat with that. This is nothig to be 
discussed here.

[Alex Ionescu]

Murphy, Ged (Bolton) wrote:
> Whether headers are added or not, my point was simply that a translator
> shouldn't put himself into the header as the programmer.
> It's a little discourteous to the actual programmer (although most devs
> won't actually care), and it creates a false piece of information.
>
> Consider the following scenario:
>
> foo: Hi. one of the buttons is sending the wrong message in the German
> dialog. Can you fix it please
> bar: Sorry, I'm not a programmer
> foo: But it has your name as the programmer in the header...
>
> Perhaps if translators want to be named in resource files, and we feel a
> need to put headers in all our resource files too (which I think is a bit
> overkill, they should be kept in the main code only) we could include an
> extra line for TRANSLATOR:
>
> Anyway, it wasn't my intention to drag this through ros-dev.

Like I said, PROGRAMMER implies the person who wrote this file, not the
programmer of the entire project (I don't see why you'd think that...
just because my name is in lib\rtl\foo.c doesn't mean I wrote *all* the
kernel).

Best regards,
Alex Ionescu