Re: [ros-dev] [ros-diffs] [gadamopoulos] 74151: [BROWSEUI] -CExplorerBand: Stub QueryService method and set the site of the context menu so as to let the context menu find the SID_IShellBrowser when the open menu item is cl...

[Thomas Faber]

On 2017-03-12 10:48, [e-mail] wrote:
> // *** IServiceProvider methods ***
>  HRESULT STDMETHODCALLTYPE CExplorerBand::QueryService(REFGUID guidService, REFIID riid, void **ppvObject)
>  {
> UNIMPLEMENTED;
> return E_NOTIMPL;
> /* FIXME: we probably want to handle more services here */
> return IUnknown_QueryService(pSite, SID_SShellBrowser, riid, ppvObject);
>
> }

This seems dangerous. If someone requests something other than
SID_SShellBrowser, we'll just return them a different object without
any indication that something is wrong.
Shouldn't we either pass guidService down or fail somehow if it's not
asking for ShellBrowser?