RE: [Spam] [ros-diffs] [royce] 13154: require attributes to have values

[Casper Hornstrup]

The magic number 1 may be obvious to some, but it isn't to all.
It should be true/false, yes/no or all of the above.

Casper

________________________________

	From: ros-diffs-bounces(a)reactos.com [mailto:[e-mail]] On Behalf Of
royce(a)svn.reactos.com
	Sent: 20. januar 2005 07:37
	To: ros-diffs(a)reactos.com
	Subject: [Spam] [ros-diffs] [royce] 13154: require attributes to have values
	
	
	require attributes to have values
	Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
	Modified: branches/xmlbuildsystem/reactos/tools/rbuild/XML.cpp
	Modified: branches/xmlbuildsystem/reactos/tools/rbuild/module.cpp
	
________________________________

	Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
	--- branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml	2005-01-20 06:29:08 UTC (rev
13153)
	+++ branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml	2005-01-20 06:36:37 UTC (rev
13154)
	@@ -29,7 +29,7 @@
	
	 	<directory name="ke">
	 		<if property="ARCH" value="i386">
	 			<directory name="i386">
	
	-				<file first>multiboot.S</file>
	
	+				<file first="1">multiboot.S</file>
	
	 				<file>bios.c</file>
	 				<file>brkpoint.c</file>
	 				<file>bthread.S</file>

[Royce Mitchell III]

Casper Hornstrup wrote:

>   
> The magic number 1 may be obvious to some, but it isn't to all.
> It should be true/false, yes/no or all of the above.
>
>   
>  
I can't seem to make anybody happy, here! ;)

Anyways, it's checking for anything non-zero, but I suppose I could make 
it true/false, too.

>  ________________________________
>
> 	From: ros-diffs-bounces(a)reactos.com [mailto:[e-mail]] On Behalf Of
> royce(a)svn.reactos.com
> 	Sent: 20. januar 2005 07:37
> 	To: ros-diffs(a)reactos.com
> 	Subject: [Spam] [ros-diffs] [royce] 13154: require attributes to have values
> 	
> 	
> 	require attributes to have values
> 	Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
> 	Modified: branches/xmlbuildsystem/reactos/tools/rbuild/XML.cpp
> 	Modified: branches/xmlbuildsystem/reactos/tools/rbuild/module.cpp
> 	
> ________________________________
>
> 	Modified: branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml
> 	--- branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml	2005-01-20 06:29:08 UTC (rev
> 13153)
> 	+++ branches/xmlbuildsystem/reactos/ntoskrnl/ntoskrnl.xml	2005-01-20 06:36:37 UTC (rev
> 13154)
> 	@@ -29,7 +29,7 @@
> 	
> 	 	<directory name="ke">
> 	 		<if property="ARCH" value="i386">
> 	 			<directory name="i386">
> 	
> 	-				<file first>multiboot.S</file>
> 	
> 	+				<file first="1">multiboot.S</file>
> 	
> 	 				<file>bios.c</file>
> 	 				<file>brkpoint.c</file>
> 	 				<file>bthread.S</file>
> 	
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev(a)reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>
> .
>
>   
>