This code change doesn't help to make the code more readable.
Am 28.01.2015 um 21:41 schrieb pschweitzer@svn.reactos.org:
Author: pschweitzer Date: Wed Jan 28 20:41:23 2015 New Revision: 66101
URL: http://svn.reactos.org/svn/reactos?rev=66101&view=rev Log: [CDMAKE] It's totally pointless to nullify after calloc
Modified: trunk/reactos/tools/cdmake/dirhash.c
Modified: trunk/reactos/tools/cdmake/dirhash.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev=... ============================================================================== --- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Wed Jan 28 20:41:23 2015 @@ -137,8 +137,6 @@ free(parentcase);
de = calloc(1, sizeof(*de));
- de->head = NULL;
- de->child = NULL; de->parent = parent_de; de->normalized_name = strdup(targetnorm); de->case_name = strdup(chop_filename(casename));
It wasn't intended. Then, if you want to rethink the usage of calloc and/or redundant code, feel free.
On 29/01/2015 00:03, Timo Kreuzer wrote:
This code change doesn't help to make the code more readable.
Am 28.01.2015 um 21:41 schrieb pschweitzer@svn.reactos.org:
Author: pschweitzer Date: Wed Jan 28 20:41:23 2015 New Revision: 66101
URL: http://svn.reactos.org/svn/reactos?rev=66101&view=rev Log: [CDMAKE] It's totally pointless to nullify after calloc
Modified: trunk/reactos/tools/cdmake/dirhash.c
Modified: trunk/reactos/tools/cdmake/dirhash.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev=...
==============================================================================
--- trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] (original) +++ trunk/reactos/tools/cdmake/dirhash.c [iso-8859-1] Wed Jan 28 20:41:23 2015 @@ -137,8 +137,6 @@ free(parentcase); de = calloc(1, sizeof(*de));
- de->head = NULL;
- de->child = NULL; de->parent = parent_de; de->normalized_name = strdup(targetnorm); de->case_name = strdup(chop_filename(casename));
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev