Re: [ros-dev] [ros-diffs] [weiden] 25828: - Move around definitions to make the code a bit more modular - Use an about menu instead of an button

[Murphy, Ged (Bolton)]

[e-mail] wrote:
> Modified: trunk/reactos/base/applications/charmap/charmap.c
>    case WM_SYSCOMMAND:
>    {
>        switch(wParam)
>        {
>            case ID_ABOUT:
>                DialogBox(hInstance,
>                          MAKEINTRESOURCE(IDD_ABOUTBOX),
>                          hDlg,
>                          AboutDialogProc);

Modified: trunk/reactos/base/applications/charmap/map.c

+    if (RegisterClass(&wc))
+    {
+        wc.lpfnWndProc = LrgCellWndProc;
+        wc.cbWndExtra = 0;
+        wc.lpszClassName = szLrgCellWndClass;
> Modified: trunk/reactos/base/applications/charmap/precomp.h
> -INT_PTR CALLBACK AboutDialogProc(HWND hDlg, UINT message, WPARAM wParam,

LPARAM lParam);
> -LRESULT CALLBACK LrgCellWndProc(HWND hwnd, UINT uMsg, WPARAM wParam,

LPARAM lParam);

Maybe I'm reading the diff wrong, but does this not break the build? (not
been able to svn up this weekend)
I'm guessing the 'case ID_ABOUT' should now call ShowAboutDlg, but what
about the assignment of LrgCellWndProc?

Ged.

Registered Office: PO Box 1 Salford Road, Over Hulton, Bolton, BL5 1DD.
Registered in England: No. 2375355 
The information contained in this message or any of its attachments is
confidential and is intended for the exclusive use of the addressee. The
information may also be legally privileged. The views expressed may not be
company policy, but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other dissemination
or use of this communication is strictly prohibited. If you have received
this message in error, please contact [e-mail]
mailto:[e-mail] and then delete this message. 
Exide Technologies is an industrial and transportation battery producer and
recycler with operations in 89 countries. Further information can be found
at www.exide.com <www.exide.com>