Ros-dev October 2005

ros-dev@reactos.org

76 participants
164 discussions

by Emanuele Aliberti

There should be a bug in the envp creation. ProcessParameters->Environment is a PWCHAR and envp is a char*. -- :Emanuele Aliberti

19 years, 2 months

Re: [ros-diffs] [ea] 18230: More fixes to compile.

by Alex Ionescu

ea(a)svn.reactos.com wrote: >More fixes to compile. > >Modified: trunk/reactos/subsys/csr/csrsrv/api.c >Modified: trunk/reactos/subsys/csr/csrsrv/process.c > > > ------------------------------------------------------------------------ > *Mo* What compiler are you using? My gcc 3.4.4 compiled the files perfectly, so did msvc 2k5 with maximum prefast warnings on. Initializing all those variables to NULL seems an awful waste to me.. Best regards, Alex Ionescu

19 years, 2 months

RE: [ros-diffs] [ekohl] 18240: - Add german resources.

by Hervé Poussineau

> Modified: trunk/reactos/lib/cpl/hdwwiz/En.rc >--- trunk/reactos/lib/cpl/hdwwiz/En.rc 2005-10-03 07:48:59 UTC (rev 18239) > +++ trunk/reactos/lib/cpl/hdwwiz/En.rc 2005-10-03 09:14:57 UTC (rev 18240) > @@ -1,4 +1,4 @@ > -LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > > STRINGTABLE > BEGIN Why are you changing this? According to http://support.microsoft.com/kb/169483/en-us , English (Neutral) is not always searched by the resource loader, but English (US) is. I don't know exactly what are the rules followed by ReactOS, but English (US) allow the control panel to have correct resources on all Windows versions. > Modified: trunk/reactos/lib/cpl/hdwwiz/Fr.rc > --- trunk/reactos/lib/cpl/hdwwiz/Fr.rc 2005-10-03 07:48:59 UTC (rev 18239) > +++ trunk/reactos/lib/cpl/hdwwiz/Fr.rc 2005-10-03 09:14:57 UTC (rev 18240) > @@ -1,4 +1,4 @@ > > -LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL > +LANGUAGE LANG_FRENCH, SUBLANG_DEFAULT > > STRINGTABLE > BEGIN According to the same page, Primary Lang/Sub Lang is first searched, followed by Primary Lang/Sublang_neutral. Primany Lang/Sublang_default is not searched. With your changes, French/Canadian and other would not have French resources. Just try it on Windows, and you will see. This change is also in contradiction with changes done in Wine some months ago. (ChangeLog 0.2.7: "From Wine: changed SUBLANG_DEFAULT to SUBLANG_NEUTRAL for LANG_SPANISH in all resources, so that Spanish locales other than Spain also use Spanish resources") Please revert these changes. Hervé

19 years, 2 months

Re: [ros-diffs] [ea] 18199: - add copyright notice

by Alex Ionescu

ea(a)svn.reactos.com wrote: >- add copyright noti > Hi, Please don't add these -- we already have the COPYRIGHT: Please see COPYING file at the top-level directory. It is a long overdue janitorial task to remove all the per-file copyright headers, adding more won't help ;) Best regards, Alex Ionescu

19 years, 2 months

Re: [ros-svn] [ea] 18219: A do-nothing crt0 for native NT processes.

by Alex Ionescu

ea(a)svn.reactos.com wrote: >A do-nothing crt0 for native NT processes. >(see note by A.Ionescu in reactos/subsys/crt/main.c) > > >Added files: >trunk/reactos/lib/ntrt0lib/ >trunk/reactos/lib/ntrt0lib/args.c >trunk/reactos/lib/ntrt0lib/entry_point.c >trunk/reactos/lib/ntrt0lib/ntrt0.h >trunk/reactos/lib/ntrt0lib/ntrt0lib.xml > >Updated files: >trunk/reactos/lib/directory.xml > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Hi, Thanks, I didn't have time last night ( I went to bed at 5AM). Do you mind if I rename this to "nt" ? It's the official name of the DDK static lib, and would mean that we don't have to have 2 .XML files for anyone using the library (for the msvc build). Anyways, I'm going to commit the code now, I have it on my disk. Best regards, Alex Ionescu

19 years, 2 months

Re: [ros-svn] [ion] 18183: - KeRundownThread:

by Witukind

On Sat, 1 Oct 2005 09:50:08 +0200 <ion(a)svn.reactos.com> wrote: >> which means the mutant has been already freed). omfg! we're all going to die!!! ;)

19 years, 2 months

Re: [ros-svn] [ion] 18202: - Small semaphore code simplification/optimization.

by Hartmut Birr

ion(a)svn.reactos.com wrote: >- Small semaphore code simplification/optimization. > > >Updated files: >trunk/reactos/ntoskrnl/ke/kthread.c >trunk/reactos/ntoskrnl/ke/sem.c > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Have you tried to compile sem.c before you did commit? - Hartmut

19 years, 2 months

Plug and Play status - Device installation

by Hervé Poussineau

Hello, Since some weeks/months, I've done some work in setupapi.dll. I'm now able to install devices using provided .inf files, ie copy needed files and create registry entries. Syntax: rundll32.exe newdev.dll,DevInstall [InstanceID] where InstanceID is something like ACPI\PNP0501\1 or PCI\VEN_8086&DEV_7112&SUBSYS_00000000&REV_01\3&61aaa01&0&3A However, I've still some bugs and some missing features: - OpenSCManagerW freezes ReactOS [1] - CreateServiceW is unimplemented [2] - Service image path provided to CreateServiceW looks like "C:\ReactOS\System32\drivers\driver.sys", instead of "System32\drivers\driver.sys" [3] - You have no way to use a .inf file which is not in ReactOS\Inf directory [4] - Files to be copied are always searched in ReactOS\Inf directory (so they can't be found) [5] - Files to be copied need to be already decompressed (ie not in a .cab file) [6] - A reboot is needed before being able to use the newly installed device [7] - Having multiple times a same device is not supported, if the bus driver can't provide a unique DeviceID [8] - Last, but not least, device installation is not started automatically when a new device is found/plugged [9] [1] See bug #826: http://www.reactos.org/bugzilla/show_bug.cgi?id=826 [2] In lib/advapi32/service/scm.c. It needs to call umpnpmgr.exe by RPC, as in OpenServiceW implementation [3] In lib/setupapi/dirid.c: the value returned by create_system_dirid() is always a full path [4] It's due to missing functionnality in newdev.dll (lib/newdev/*), which should ask the user when no driver is found [5] In lib/setupapi/queue.c. If a file can't be found, SetupCommitFileQueueW should ask the user where to find the file [6] We need to support the [SourceDisksNames] section in .inf files [7] Maybe calling IoInvalidateDeviceRelations() at the end of SetupDiInstallDevice (lib/setupapi/devinst.c) would be enough [8] We need to generate a ParentIdPrefix entry in registry in some(?) cases [9] I suppose it should be initiated by umpnpmgr.exe, when it sees a device for the first time Hervé PS: If someone is interested to work on one of this parts, please answer this email

19 years, 2 months

Re: [ros-diffs] [weiden] 18213: minor changes (mostly formatting)

by Hartmut Birr

weiden(a)svn.reactos.com wrote: >minor changes (mostly formatting) > >Modified: trunk/reactos/lib/hid/hid.c >Modified: trunk/reactos/lib/shellext/slayer/slayer.c > > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/hid/hid.c* > >--- trunk/reactos/lib/hid/hid.c 2005-10-02 12:27:54 UTC (rev 18212) >+++ trunk/reactos/lib/hid/hid.c 2005-10-02 12:46:49 UTC (rev 18213) >@@ -368,8 +368,8 @@ > > HidD_Hello(OUT PCHAR Buffer, > IN ULONG BufferLength) > { > > >- const PCHAR HelloString = "Hello\n"; >- ULONG StrSize = (lstrlenA(HelloString) + 1) * sizeof(CHAR); > > >+ const CHAR HelloString[] = "Hello\n"; >+ ULONG StrSize = sizeof(HelloString) + sizeof(HelloString[0]); > > > > if(BufferLength > 0) > { > > > ------------------------------------------------------------------------ Hi, sizeof(HelloString) does already contain the terminating NULL. - Hartmut

19 years, 2 months

Re: [ros-svn] [ion] 18201: - Add RtlSetProcessCritical

by Hartmut Birr

ion(a)svn.reactos.com wrote: >- Add RtlSetProcessCritical >- Some fixes. > > >Updated files: >trunk/reactos/include/ndk/ketypes.h >trunk/reactos/include/ndk/pstypes.h >trunk/reactos/include/ndk/rtlfuncs.h >trunk/reactos/include/ndk/rtltypes.h >trunk/reactos/include/ndk/umtypes.h > >_______________________________________________ >Ros-svn mailing list >Ros-svn(a)reactos.org >http://www.reactos.org/mailman/listinfo/ros-svn > > > Hi, the header changes breaks compiling for me: gcc -c boot\freeldr\freeldr\cache\blocklist.c -o .\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o -nostdlib -ffreestanding -fno-builtin -fno-inline -fno-zero-initialized-in-bss -Os -Iboot\freeldr\freeldr\include -Iboot\freeldr\freeldr\cache -Intoskrnl\include -D__USE_W32API -DDEBUG -Iinclude -Iinclude\reactos -Iinclude\libs -Iinclude\drivers -Iinclude\subsys -Iw32api\include -Iw32api\include\ddk -D_M_IX86 -DDBG -Wall -Os -Wno-strict-aliasing -ftracer -momit-leaf-frame-pointer -mpreferred-stack-boundary=2 -Wpointer-arith -g -pipe In file included from include/ndk/psfuncs.h:13, from include/ndk/ntndk.h:34, from boot/freeldr/freeldr/include/freeldr.h:24, from boot\freeldr\freeldr\cache\blocklist.c:21: include/ndk/pstypes.h:627: error: syntax error before 'PHANDLE_TABLE' include/ndk/pstypes.h:627: warning: no semicolon at end of struct or union include/ndk/pstypes.h:628: warning: type defaults to 'int' in declaration of 'Token' include/ndk/pstypes.h:628: warning: data definition has no type or storage class include/ndk/pstypes.h:655: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:668: error: syntax error before 'PrefetchTrace' include/ndk/pstypes.h:668: warning: type defaults to 'int' in declaration of 'PrefetchTrace' include/ndk/pstypes.h:668: warning: data definition has no type or storage class include/ndk/pstypes.h:718: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:730: warning: unnamed struct/union that defines no instances include/ndk/pstypes.h:745: error: syntax error before '}' token include/ndk/pstypes.h:745: warning: type defaults to 'int' in declaration of 'EPROCESS' include/ndk/pstypes.h:745: warning: data definition has no type or storage class _make: *** [.\up\obj-i386\boot\freeldr\freeldr\cache\blocklist.o] Error 1 - Hartmut

19 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev October 2005