~1700 lines to add a check? In the future, please do reformatting in its own patch without semantic changes. This patch would
require an hour or more to review if anyone dared to do it and even if someone did, that person would have be superhuman to be able
to keep track of that many lines of information.
The risk of introducing a bug is higher with some types of operations than others. Formatting is a relatively safe operation while
semantic changes to complex code is a highly risky operation. This means that reviewing a formatting patch is not as important as
reviewing a patch with semantic changes to complex code (and thus it doesn't hurt so much if a formatting change is large). When
mixing safe and unsafe operations, the overall risk of a introducing a bug in a given patch is the same as if the changes were
spread over several patches. However, the risk of the individual patch is equal to risk of the most risky operation in the patch. So
if a 1 line highly risky change is hidden in a 1700 line otherwise safe patch, then the overall risk for the whole patch is highly
risky.
It may not seem important to have only a few bugs in releases now. We can always use the excuse that ReactOS is alpha software.
However, if we ever want to have an 1.x release which is more than a toy-OS, then we have to learn to build better software. And I
would prefer that we learn it before 1 day before the deadline for 1.0.0 since that might give us some years to get really good at
it. I've written several school papers the night before the deadline, and they were never any good ;-( Another side effect of
starting early is that some might even be able to use ReactOS before 1.0.0.
Casper
I used Depends.exe and examined gdi32.dll. I found out that at least there functions are missing in the gdi32.dll api status at svn.reactos.com:
AnimatePalette
Arc
ArcTo
BitBlt
cGetTTFFromFOT
CombineRgn
CombineTransform
CreateBitmap
CreateBitmapIndirect
CreateCompatibleBitmap
CreateCompatibleDC
CreateDiscardableBitmap
CreateEllipticRgn
CreateEllipticRgnIndirect
CreateHalftonePalette
CreateHatchBrush
CreatePalette
CreatePatternBrush
CreatePen
CreatePenIndirect
CreatePolygonRgn
CreatePolyPolygonRgn
CreateRectRgn
CreateRectRgnIndirect
CreateRoundRectRgn
CreateSolidBrush
DdEntry0
DdEntry1
DdEntry10
---------------------------------
Gesendet von Yahoo! Mail - Jetzt mit 1GB kostenlosem Speicher
> > It's been 7 days since the TC position was put up for
> discussion, thus
> > I have created the poll for voting to commence.
> > _http://www.reactos.org/forum/viewtopic.php?t=1140_
> >
> > Anyone wanna take a bet on the outcome ;)
> >
> I think the only bet that could be placed would be on whether
> it's going
> to be unanimous :P
That's what I was referring too, and I know what my money would be on ;)
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
It's been 7 days since the TC position was put up for discussion, thus I
have created the poll for voting to commence.
http://www.reactos.org/forum/viewtopic.php?t=1140
<http://www.reactos.org/forum/viewtopic.php?t=1140>
Anyone wanna take a bet on the outcome ;)
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
Hi, all
Just went through this file, and fixed parts of the Shutdown messages,
so they actually look right. (Like replacing "i'm" with "I'm", and
"signal" to "signals", for example). No changes to the important
code.
I do have one question, though. How does it tell the difference
between whether or not to include one line, or two, in the quote at
shutdown? A few extend to two (One even, to four)
- TwoTailedFox
--
"I had a handle on life, but then it broke"
Also, just 2 things i noticed:
1) int -> INT and void -> VOID
2) the name of the function should be the first word on the line per our
unspoken formatting.
Brandon
ReactOS.Bugzilla(a)reactos.org wrote:
>http://www.reactos.org/bugzilla/show_bug.cgi?id=986
>
>
>
>
>
>------- Additional Comments From w3seek(a)reactos.com 2005-11-14 16:21 CET -------
>If you happen to use TortoiseSVN, there's an option 'Create Patch' in the menu,
>otherwise see help for svn diff. Anyway, here are the things I'd like you to fix
>before I'm going to commit it to svn:
>
>- add missing definitions to cfgmgr32.h if missing (instead of defining it in
>the .c file)
>- please don't mix tchar and unicode-only stuff like here (just use unicode
>stuff in there): wsprintf( resData, TEXT("%s %s"), resData, textData);
>- the code lacks a lot important failure case checks, making it unpredictable
>when a single function call fails
>
>This may sound like a lot, I'm just trying to preserve a certain level of
>quality ;) We already have more than enough code that needs a serious overhaul
>or even rewrite.
>
>
>
Reuben Perelman wrote:
> With the activity of reactos, you'd be crazy to use anything older than an
hour.
I'm not sure about that. I'm using 0.2.8 for testing at the moment, HEAD is
too broken .... Heh ;)
************************************************************************
The information contained in this message or any of its
attachments is confidential and is intended for the exclusive
use of the addressee. The information may also be legally
privileged. The views expressed may not be company policy,
but the personal views of the originator. If you are not the
addressee, any disclosure, reproduction, distribution or other
dissemination or use of this communication is strictly prohibited.
If you have received this message in error, please contact
postmaster(a)exideuk.co.uk
<mailto:postmaster@exideuk.co.uk> and then delete this message.
Exide Technologies is an industrial and transportation battery
producer and recycler with operations in 89 countries.
Further information can be found at www.exide.com
Understanding and Replacing Microsoft Exchange
by Tom Adelstein
http://www.linuxjournal.com/article/6368
I've downloaded it in connection with something entirely different (shades of
Monty Python! ;) and discoverred this article.
So, we've got some network functionality already, we've got a NetBEUI in the
form of Sambs-NG, we've got most of the specialized stuff already out there.
We've just got to get it all fitting together. (famous last words ;)
Wesley Parish
--
Clinersterton beademung, with all of love - RIP James Blish
-----
Mau e ki, he aha te mea nui?
You ask, what is the most important thing?
Maku e ki, he tangata, he tangata, he tangata.
I reply, it is people, it is people, it is people.