Ros-dev November 2005

ros-dev@reactos.org

64 participants
176 discussions

Re: [ros-svn] [weiden] 19334: - define STATUS_* codes correctly in winnt.h and ntstatus.h
by James Tabor 20 Nov '05

20 Nov '05

Hi, We need to check RosApps too. Thanks, James [CC] modules/rosapps/sysutils/ctm/ctm.c In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:30:1: "DBG_EXCEPTION_HANDLED" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:251:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:31:1: "DBG_CONTINUE" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:252:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:34:1: "DBG_TERMINATE_THREAD" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:253:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:35:1: "DBG_TERMINATE_PROCESS" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:254:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:36:1: "DBG_CONTROL_C" redefined <Snip. ..> w32api/include/ntstatus.h:772:1: "STATUS_FLOAT_MULTIPLE_FAULTS" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:245:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:773:1: "STATUS_FLOAT_MULTIPLE_TRAPS" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:246:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:786:1: "STATUS_REG_NAT_CONSUMPTION" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:247:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:1114:1: "STATUS_SXS_EARLY_DEACTIVATION" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:248:1: this is the location of the previous definition In file included from include/ndk/umtypes.h:18, from include/ndk/ntndk.h:19, from modules/rosapps/sysutils/ctm/ctm.c:45: w32api/include/ntstatus.h:1115:1: "STATUS_SXS_INVALID_DEACTIVATION" redefined In file included from w32api/include/windef.h:253, from w32api/include/windows.h:49, from modules/rosapps/sysutils/ctm/ctm.c:35: w32api/include/winnt.h:249:1: this is the location of the previous definition make: *** [obj-i386/modules/rosapps/sysutils/ctm/ctm.o] Error 1

2 1

Announce mailing list, newsletter, TC & automated testing
by Drew Scott Daniels 19 Nov '05

19 Nov '05

Hi, It'd be nice if the announcement mailing list was still used. I'd suggest announcing the weekly newsletter in order to keep the list alive between releases. Can the "splash" newsletter be marked as dead? I enjoyed splash's RSS feed. Even more I'd enjoy if the ReactOS (ros) newsletter could become part of kernel cousin or have alike services. The job of the TC came up recently, and thus automated testing. Does the wine test suite run on ReactOS (it runs on Windows and wine)? Would it's results be useful to the TC? Could it be extended? Maybe it needs to be supplemented by something else. Codeweavers have software for automated testing that may be worth looking at too. Drew Daniels Resume: http://www.boxheap.net/ddaniels/resume.html

2 3

RE: [ros-diffs] [ion] 19327: Due to CcRos's abusive usage and dep endency on our broken Fast Mutex implementation, Fast Mutex can't be fixe d until the Cc Rewrite is complete. Since that seems to take longer and w e've identified drivers which need the corre
by Murphy, Ged (Bolton) 19 Nov '05

19 Nov '05

lmao @ these function names ..... -----Original Message----- From: ion(a)svn.reactos.com [mailto:ion@svn.reactos.com] Sent: 18 November 2005 18:52 To: ros-diffs(a)reactos.com Subject: [ros-diffs] [ion] 19327: Due to CcRos's abusive usage and dependency on our broken Fast Mutex implementation, Fast Mutex can't be fixed until the Cc Rewrite is complete. Since that seems to take longer and we've identified drivers which need the correct F +VOID +FASTCALL +CcAcquireBrokenMutex(PFAST_MUTEX FastMutex); + +VOID +FASTCALL +CcReleaseBrokenMutex(PFAST_MUTEX FastMutex); + +BOOLEAN +FASTCALL +CcTryToAcquireBrokenMutex(PFAST_MUTEX FastMutex); + ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

Re: [ros-diffs] [hbirr] 19329: - Changed all registry functions to WCHAR.
by Alex Ionescu 18 Nov '05

18 Nov '05

hbirr(a)svn.reactos.com wrote: >- Changed all registry functions to WCHAR. >- Implemented packed/unpacked names for keys and values. >- Fixed the hash values for very short data. >- Fixed the debug build. >- Don't search for a serial mouse, if the port is used for debug prints. > Hi Hartmut, Microsoft have managed to write their Cm code in a very portable way so that the Hv* (Hive) and Cm* (NT Config Manager) APIs are very seperated. The result of this is that they've been able to share the registry code between the kernel and the boot loader. Is there any way we can do the same? Certaintly having two pieces of code that are very similar but have subtle differences creates only more avenues for bugs. (Casper, you agree?) Best regards, Alex Ionescu

2 1

[Fwd: [ros-general] BIOS]
by David Hinz 18 Nov '05

18 Nov '05

jh schrieb: > From dev mailing list archive > >> From bblaauw at home.nl Thu Nov 17 16:09:23 2005 >> From: bblaauw at home.nl (Bernd Blaauw) >> Date: Thu Nov 17 16:12:08 2005 >> Subject: [ros-dev] 0.3 release plan - Again >> >> Would "USB working" also mean "boot from USB" ? Not even MS allows this. >> Sadly no PC BIOS supports "boot from FireWire", like Apples do. Guess >> we'd need LinuxBIOS for that, as current motherboard manufacturers don't >> want to pay AMI/Phoenix/Award for including the "boot from firewire" >> >module. >> >> Bernd >> > > Would these be of any interest. > > http://freebios.sourceforge.net/ > > http://www.openbios.info/ > > I am not subscribed to the dev mailing list, so does anyone want to > pass this on. > > Regards, > jh > _______________________________________________ > ros-general mailing list > ros-general(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-general >

1 0

Re: [ros-svn] [sedwards] 19259: created crt public headers directory. Moved excpt.h there
by Thomas Weidenmueller 18 Nov '05

18 Nov '05

sedwards(a)svn.reactos.com wrote: > created crt public headers directory. Moved excpt.h there > > > Added files: > trunk/reactos/w32api/include/crt/ > trunk/reactos/w32api/include/crt/excpt.h > > Updated files: > trunk/reactos/ReactOS.xml > > Deleted files: > trunk/reactos/w32api/include/excpt.h This change or r19260 causes compiling with GCC4 to fail: [CC] apps\utils\ps\ps.c In file included from include/ndk/ntndk.h:52, from apps\utils\ps\ps.c:28: include/ndk/rtltypes.h:544: error: conflicting types for 'PEXCEPTION_HANDLER' w32api/include/crt/excpt.h:56: error: previous declaration of 'PEXCEPTION_HANDLER' was here mingw32-make: *** [obj-i386\apps\utils\ps\ps.o] Error 1 - Thomas

2 1

RE: [ros-dev] Re: [ros-diffs] [gedmurphy] 19312: Improve stopping control of the service
by Murphy, Ged (Bolton) 18 Nov '05

18 Nov '05

> -----Original Message----- > From: Thomas Weidenmueller [mailto:w3seek@reactos.com] > Sent: 18 November 2005 12:03 > To: ReactOS Development List > Subject: Re: [ros-dev] Re: [ros-diffs] [gedmurphy] 19312: > Improve stopping control of the service > > > Murphy, Ged (Bolton) wrote: > > This function is new to me. > Now that you're writing multithreaded code it's about time to learn > about these functions ;) > > > I'm just doing a bit of research on it now to better > understand it, but > > could you just give me a bit of background of the > difference between this, > > and using something like a mutex or CS, and why it's better in this > > scenario? > Of course you can use mutexes or critical sections, but for > this purpose > interlocked operations are much more lightweight because with > mutexes or > critical sections you'd have to protect the read operation as > well. The > Interlocked* functions basically guarantee that a certain > operation on a > variable shared by multiple threads is performed in an atomic > matter. I > probably should mention that reads are always atomic, so reading a > variable with the size smaller or equal as the size of a > general purpose > register does not need to be protected, writes however have > to be protected. > > You should read the following articles: > http://msdn.microsoft.com/library/default.asp?url=/library/en- > us/dllproc/base/interlocked_variable_access.asp > http://blogs.msdn.com/oldnewthing/archive/2004/09/15/229915.aspx Thanks for the info, much appreciated. I've been reading up on Interlocked Variable Access this morning and have now implemented it into the code. Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

1 0

RE: [ros-dev] Re: [ros-diffs] [gedmurphy] 19312: Improve stopping control of the service
by Murphy, Ged (Bolton) 18 Nov '05

18 Nov '05

> -----Original Message----- > From: Thomas Weidenmueller [mailto:w3seek@reactos.com] > Sent: 17 November 2005 23:38 > To: ReactOS Development List > Subject: Re: [ros-dev] Re: [ros-diffs] [gedmurphy] 19312: > Improve stopping control of the service > > > Ged Murphy wrote: > > Could you explain what you mean? > As you want to change the value of the variables which are used in a > multithreaded environment you need to used the Interlocked* > functions to > ensure an atomic change in all environments (UP, MP, ...), and also to > make sure it's portable. > > > Those variables are only modified within the base thread, all other > > threads just check the value and act upon it. > > Why would that not be thread safe? > You're assuming the code will only run on a x86 system. In > fact, as long > as the variables are aligned properly it is an atomic operation. But > don't forget the other architectures and possibly upcoming > technologies > based on x86 that could void this assumption. > > I have to admit that the code wouldn't break, even in circumstances > where the operation wouldn't be atomic, but technically the code still > isn't thread-safe this way. > > - Thomas This function is new to me. I'm just doing a bit of research on it now to better understand it, but could you just give me a bit of background of the difference between this, and using something like a mutex or CS, and why it's better in this scenario? Thanks, Ged. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

2 1

RE: [ros-dev] Microsoft Office files in the trunk
by Murphy, Ged (Bolton) 18 Nov '05

18 Nov '05

Mike Swanson wrote: > In the branch of press-media, there are two documents currently. An MS > Word and MS PowerPoint document. > > I'm calling for SVN committers for _no more_ MS Office documents. They > are a proprietary format, of which not all the features are currently > known. I recommend instead the use of OASIS OpenDocument. Not only > does it save much space, but it also does not contain any secrets in > which need to be reverse engineered to discover. > [...] > > Please, for the good of the project, use the free OpenDocument format. > If not for the reason of being open or free, but simply for the fact > that it ensures that everybody will be able to view such documents (no > need to buy any pricey office suites here!). I disagree with this. I don't know how to use oo.o or variants, and I don't intend on learning something I have no interest in. I'm currently putting together a presentation for the speeches I have coming up on ReactOS. If a rule was put in place where we could only commit OpenDocument files, I would simply not put it into the repository and would instead share it with anyone who wanted it via email. This isn't because I'm being awkward, it's because I have no time or interest to learn a new office suite .... and I certainly don't want to install oo.o on my machine. I suppose it's this attitude which keeps MS Office up as a monopoly, which now make me realise why they don't want to support OpenDocument. ************************************************************************ The information contained in this message or any of its attachments is confidential and is intended for the exclusive use of the addressee. The information may also be legally privileged. The views expressed may not be company policy, but the personal views of the originator. If you are not the addressee, any disclosure, reproduction, distribution or other dissemination or use of this communication is strictly prohibited. If you have received this message in error, please contact postmaster(a)exideuk.co.uk <mailto:postmaster@exideuk.co.uk> and then delete this message. Exide Technologies is an industrial and transportation battery producer and recycler with operations in 89 countries. Further information can be found at www.exide.com

6 7

Re: [ros-diffs] [gedmurphy] 19312: Improve stopping control of the service
by Thomas Weidenmueller 17 Nov '05

17 Nov '05

gedmurphy(a)svn.reactos.com wrote: > Improve stopping control of the service > > @@ -137,14 +137,14 @@ > > { > case SERVICE_CONTROL_SHUTDOWN: /* fall through */ > case SERVICE_CONTROL_STOP: > > - bShutDownFlag = TRUE; > > + bShutDown = TRUE; > > UpdateStatus(SERVICE_STOP_PENDING, -1); > break; > case SERVICE_CONTROL_PAUSE: > > - bPauseFlag = TRUE; > > + bPause = TRUE; > > break; > case SERVICE_CONTROL_CONTINUE: > > - bPauseFlag = FALSE; > > + bPause = FALSE; You might want to use InterlockedExchange to make it thread-safe. - Thomas

2 2

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev November 2005