Ros-dev September 2005

ros-dev@reactos.org

67 participants
129 discussions

Re: [ros-svn] [hbirr] 17910: Don't check the share access for directories.
by KJKHyperion 18 Sep '05

18 Sep '05

hbirr(a)svn.reactos.com wrote: >Don't check the share access for directories. > are you sure this is right? I quite remember share access being enforced on directories

2 3

Re: [ros-diffs] [hbirr] 17912: The share disposition isn't necessary for FILE_READ_ATTRIBUTES.
by Gunnar Dalsnes 18 Sep '05

18 Sep '05

Is this correct? I can't see how... Even GENERIC_READ imply FILE_READ_ATTRIBUTES and using your "share disposition isn't necessary for FILE_READ_ATTRIBUTES rule" this means file sharing isnt needed for GENERIC_READ either... hbirr(a)svn.reactos.com wrote: > The share disposition isn't necessary for FILE_READ_ATTRIBUTES. > > Modified: trunk/reactos/lib/kernel32/file/file.c > > ------------------------------------------------------------------------ > *Modified: trunk/reactos/lib/kernel32/file/file.c* > > --- trunk/reactos/lib/kernel32/file/file.c 2005-09-18 13:36:29 UTC (rev 17911) > +++ trunk/reactos/lib/kernel32/file/file.c 2005-09-18 13:46:37 UTC (rev 17912) > @@ -873,7 +873,7 @@ > > SYNCHRONIZE | FILE_READ_ATTRIBUTES, > &ObjectAttributes, > &IoStatusBlock, > > - FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, > > + 0, > > FILE_SYNCHRONOUS_IO_NONALERT); > RtlFreeUnicodeString (&FileName); > if (!NT_SUCCESS (Status)) >

2 2

Re: [ros-diffs] [greatlrd] 17909: give GetFileAttributesExW more NtOpenFile right to prevent reactos crash if u using CreateFile then GetFileAttributesExW. It also fix a bug for me for livecd it booting on first try now in vmware. instead second or more booting try.
by Gunnar Dalsnes 18 Sep '05

18 Sep '05

greatlrd(a)svn.reactos.com wrote: > give GetFileAttributesExW more NtOpenFile right to prevent reactos crash if u using CreateFile then GetFileAttributesExW. It also fix a bug for me for livecd it booting on first try now in vmware. instead second or more booting try. "crash if using CreateFile then GetFileAttributesExW" ??? What?? It looks like you are working around the real bug by using a _very_ dirty workaround. > > Modified: trunk/reactos/lib/kernel32/file/file.c > > - SYNCHRONIZE | FILE_READ_ATTRIBUTES, > > + SYNCHRONIZE | GENERIC_ALL, > FILE_READ_ATTRIBUTES access is surely sufficient for reading a files attributes...

1 0

found it! the "dce porting" header file
by Luke Kenneth Casson Leighton 18 Sep '05

18 Sep '05

http://examples.oreilly.de/english_examples/dce/dce_nt/dceport.h.aug95 o joy o joy. also, i found _this_!!! http://sourceware.org/pthreads-win32/ which is an implementation of pthreads on win32. _also_ i found - was reminded - by judicious searching on google, that of course entegrity.com have "PC-DCE" which is of course a _commercial_ product that has done exactly the work required: making dce (1.1? 1.2.2?) compile on Win32. including exceptions, dealing with mapping the names, blah blahhh. now. anyone got any brainy ideas on how to reverse dceport.h - in particular the thingy. wotsit. TRY/FINALLY/CATCH stuff? what i'm going to try to do is take a shot at simply compiling dcethreads - on win32. if that _works_ (the tests pass) it'll be great - it will prove two things: 1) that pthreads-win32 works 2) that the dce exception handling will fly, on win32, and _that_ means pretty much zero (urk! let's hope!) work. for now. my main goal: "GetItWorking(tm)". i couldn't care less about binary compatibility for now: i want "services" - i want srvsvcd, i want winregd, i want lsarpcd, i want samrd - all compiled, all working, using TCP/IP. i can then work on rewriting freedce's ntlmsspauth.so to be a DLL (starting off as my favourite - a stub with username and password of "test"). i can then work on writing an "ncalrpc" plugin transport (which is very straightforward: a matter of filling in about 25 functions in a vector table). and also on a ncacn_np plugin transport. "working" means that other people will then be able to focus on issues like binary compatibility. guys (wine team) i have to say this. you were utterly insane to not use freedce as your starting point - and i am still bewildered by you not even looking at its source code (which is topologically identical in almost all areas, to what you've created) or the opengroup's documentation. i say that with the greatest of respect for what you've achieved without freedce. l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

8 11

compiling botched version of dcethreads exception using pthread-win32 - WORKS!
by Luke Kenneth Casson Leighton 18 Sep '05

18 Sep '05

okay, it's not time to get totally excited yet, but i have successfully compiled - and run, and confirmed as working on ros - some of the test programs from dcethreads (http://sf.net/projects/freedce) when cross-compiled with mingw32 and linked with pthreads-win32. this is _very_ significant because it means that there is a good chance of replicating entegrity's work - PC-DCE - with zero modifications to the freedce source code. i've cut out entirely the dcethreads "emulation" stuff, which means that dcethreads posix draft 4 compliance - including the ability to pass on thread cancellation across an RPC client/server app boundary, and including the ability to pass on signals across an RPC client/server app boundary - are completely out the window... ... but i don't care. so. the bits "remaining" in my hacked-together-version of dcethreads is _just_ the exception handling - exc_handling.c and exc_handling.h pretty much. that means that the DCE "TRY", "RAISE", "CATCH" and "EXCEPT" macros are all there. it's early days, but this is good news. now. here's what i don't want to hear from anyone: q) "why in hell's name are you doing this? why can't you just remove all references to posix threads and all references to DCE/RPC exception handling?" a) lkcl@highfield:~/sf/freedce/freedce$ find . | xargs grep pthread | wc 770 3965 64010 lkcl@highfield:~/sf/freedce/freedce$ find . -name "*.[ch]" | xargs grep ENDTRY | wc 105 248 4490 lkcl@highfield:~/sf/freedce/freedce$ find . -name "*.[ch]" | xargs grep RAISE | wc 202 731 12799 lkcl@highfield:~/sf/freedce/freedce$ find . -name "*.[ch]" | xargs grep CATCH | wc 217 685 12392 in short: modifying several thousand lines of code, by hand, is something that microsoft can happily pay some donut code-dunker to do (and did, probably back in 1990-1993) but i sure as hell ain't doing it for a proof-of-concept bit of work. q) "why are you doing this and doing it to _us_? go away!!" a) you are inflicting much pain upon yourselves, even though you probably don't know it. don't like what i'm doing, don't like what i have to say? tough - get over it: i don't have time or money to waste to stroke egos. i'll give you what time i can and what facts i can and also i will present you with an opinion: if you don't like that opinion or the way it's presented, that is your choice. live with it, deal with it or ignore it - i'll pretend i don't care which. i give you information, present you with choices: where you go from there - as neo says as the end of matrix 1.... l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

2 1

Trunk Freeze
by WaxDragon 17 Sep '05

17 Sep '05

It's only been two weeks since I sent out the August State of the Repository, but the tree has already had 271 revisions. There have been several large commits, and trunk has had several build breakages, and instability in general. Just today we had three commits reversing and unreversing some of Alex's changes. I'm calling for a trunk freeze until several issues have been addressed. * The release build is broken. So far the string library and the usb code have been fixed. I was working with Alex on a break in the exception handling when this topic came up. * There seems to be a mysterious hang when shutting down ReactOS in qemu. I've seen it personally and heard reports of it, but since it locks up qemu so bad you can't free the mouse, no one has gotten a trace (that I am aware of). * Gunnar's win32k changes introduced several bugs, many of which were fixed, but I still feel unsure about others that may be hiding. * Hartmut fixed the MP build. See, I didn't even know that was broken. I would like to freeze the tree for 72 hours, over the weekend, allowing bugfixes only. I think we all need to grab a fresh copy and run it under every platform we have, checking all the options. According to the rules set forth, I need three developers. Who agrees to a trunk freeze?

7 11

RE: [ros-dev] Problem with compiling 17859
by Ge van Geldorp 17 Sep '05

17 Sep '05

> From: Ge van Geldorp > > Complaints to alex It turns out there was a communication problem between Alex and myself. A little background: in r17811 Alex introduced a line in an asm file which failed to compile on older binutils. I talked to him about this on IRC and proposed a workaround. The communication problem was that I thought he rejected the workaround, while Alex thought he ok'ed the workaround and thought I would make the change. Result: workaround not applied and 2 people pissed-off at each other. My apologies to Alex for the remark quoted above, which was inappropriate even if he hadn't agreed to the workaround. Ge van Geldorp.

1 0

Disassempler
by Rick Langschultz 17 Sep '05

17 Sep '05

Does anyone have any examples of a disassembler or decompiler that I could use for my ReactOS program I am writing... Does anyone know about a disassembler or decompiler for Mac OS X also? Rick Langschultz rlangschultz(a)cox.net (Home) rlangschultz(a)ellemaespa.com (Work) rlangschultz(a)email.uophx.edu (School)

2 1

set /a implementation for review
by Royce Mitchell III 17 Sep '05

17 Sep '05

recursive-descent implementation of set /a. I'm sure not all error messages are going to match MS's exactly. I didn't really try to do that. since trunk is frozen, I'm submitting this patch for anybody that wants to review. I'll commit it Monday evening (if I have time) pending any suggestions for improvements or bug-fixes, etc that ppl may have for it. Index: set.c =================================================================== --- set.c (revision 17890) +++ set.c (working copy) @@ -35,6 +35,8 @@ */ #include <precomp.h> +#include <malloc.h> +#include <stdio.h> #include "resource.h" #ifdef INCLUDE_CMD_SET @@ -43,7 +45,15 @@ /* initial size of environment variable buffer */ #define ENV_BUFFER_SIZE 1024 +static BOOL +seta_eval ( LPCTSTR expr ); +static LPCTSTR +skip_ws ( LPCTSTR p ) +{ + return p + strspn ( p, " \t" ); +} + INT cmd_set (LPTSTR cmd, LPTSTR param) { TCHAR szMsg[RC_STRING_MAX_SIZE]; @@ -83,6 +93,12 @@ return 0; } + if ( !_tcsnicmp (param, _T("/A"), 2) ) + { + // TODO FIXME - what are we supposed to return? + return seta_eval ( skip_ws(param+2) ); + } + p = _tcschr (param, _T('=')); if (p) { @@ -124,4 +140,386 @@ return 0; } +static INT +ident_len ( LPCTSTR p ) +{ + LPCTSTR p2 = p; + if ( __iscsymf(*p) ) + { + ++p2; + while ( __iscsym(*p2) ) + ++p2; + } + return p2-p; +} + +#define dup_ident(p) _tcsncpy_s(alloca((ident_len(p)+1)*sizeof(TCHAR)), p, +#define PARSE_IDENT(ident,identlen,p) \ + identlen = ident_len(p); \ + ident = (LPTSTR)alloca ( ( identlen + 1 ) * sizeof(TCHAR) ); \ + memmove ( ident, p, identlen * sizeof(TCHAR) ); \ + ident[identlen] = 0; + +static BOOL +seta_identval ( LPCTSTR ident, INT* result ) +{ + // get size of buffer for env var + LPTSTR buf; + DWORD dwBuffer = GetEnvironmentVariable ( ident, NULL, 0 ); + // if GetEnvironmentVariable() fails, it returns 0 + if ( !dwBuffer ) + { + // TODO FIXME - is it correct to report a value of 0 for non-existant variables? + *result = 0; + return FALSE; + } + buf = (LPTSTR)alloca ( dwBuffer * sizeof(TCHAR) ); + if ( !buf ) + { + // TODO FIXME - is it correct to report 0 when report resources low... should we error somehow? + *result = 0; + return FALSE; + } + GetEnvironmentVariable ( ident, buf, dwBuffer ); + *result = atoi ( buf ); + return TRUE; +} + +static BOOL +calc ( INT* lval, TCHAR op, INT rval ) +{ + switch ( op ) + { + case '*': + *lval *= rval; + break; + case '/': + *lval /= rval; + break; + case '%': + *lval %= rval; + break; + case '+': + *lval += rval; + break; + case '-': + *lval -= rval; + break; + case '&': + *lval &= rval; + break; + case '^': + *lval ^= rval; + break; + case '|': + *lval |= rval; + break; + default: + printf ( "Invalid operand.\n" ); + return FALSE; + } + return TRUE; +} + +static BOOL +seta_assignment ( LPCTSTR* p_, INT* result ); + +static BOOL +seta_unaryTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + if ( *p == '(' ) + { + INT rval; + p = skip_ws ( p + 1 ); + if ( !seta_assignment ( &p, &rval ) ) + return FALSE; + if ( *p != ')' ) + { + _tprintf ( _T("Expected ')'\n") ); + return FALSE; + } + p = skip_ws ( p + 1 ); + *p_ = p; + return TRUE; + } + if ( isdigit(*p) ) + { + *result = atoi ( p ); + p = skip_ws ( p + strspn ( p, "1234567890" ) ); + } + else if ( __iscsymf(*p) ) + { + LPTSTR ident; + INT identlen; + PARSE_IDENT(ident,identlen,p); + if ( !seta_identval ( ident, result ) ) + return FALSE; + } + else + { + _tprintf ( _T("Expected number or variable name\n") ); + return FALSE; + } + *p_ = p; + return TRUE; +} + +static BOOL +seta_mulTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + TCHAR op = 0; + INT rval; + if ( _tcschr(_T("!~-"),*p) ) + { + op = *p; + p = skip_ws ( p + 1 ); + } + if ( !seta_unaryTerm ( &p, &rval ) ) + return FALSE; + switch ( op ) + { + case '!': + rval = !rval; + break; + case '~': + rval = ~rval; + break; + case '-': + rval = -rval; + break; + } + + *result = rval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_addTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_mulTerm ( &p, &lval ) ) + return FALSE; + while ( *p && _tcschr(_T("*/%"),*p) ) + { + INT rval; + TCHAR op = *p; + + p = skip_ws ( p+1 ); + + if ( !seta_mulTerm ( &p, &rval ) ) + return FALSE; + + if ( !calc ( &lval, op, rval ) ) + return FALSE; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_logShiftTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_addTerm ( &p, &lval ) ) + return FALSE; + while ( *p && _tcschr(_T("+-"),*p) ) + { + INT rval; + TCHAR op = *p; + + p = skip_ws ( p+1 ); + + if ( !seta_addTerm ( &p, &rval ) ) + return FALSE; + + if ( !calc ( &lval, op, rval ) ) + return FALSE; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_bitAndTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_logShiftTerm ( &p, &lval ) ) + return FALSE; + while ( *p && _tcschr(_T("<>"),*p) && p[0] == p[1] ) + { + INT rval; + TCHAR op = *p; + + p = skip_ws ( p+2 ); + + if ( !seta_logShiftTerm ( &p, &rval ) ) + return FALSE; + + if ( !calc ( &lval, op, rval ) ) + return FALSE; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_bitExclOrTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_bitAndTerm ( &p, &lval ) ) + return FALSE; + while ( *p == _T('&') ) + { + INT rval; + + p = skip_ws ( p+1 ); + + if ( !seta_bitAndTerm ( &p, &rval ) ) + return FALSE; + + lval &= rval; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_bitOrTerm ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_bitExclOrTerm ( &p, &lval ) ) + return FALSE; + while ( *p == _T('^') ) + { + INT rval; + + p = skip_ws ( p+1 ); + + if ( !seta_bitExclOrTerm ( &p, &rval ) ) + return FALSE; + + lval ^= rval; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_expr ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + INT lval; + if ( !seta_bitOrTerm ( &p, &lval ) ) + return FALSE; + while ( *p == _T('|') ) + { + INT rval; + + p = skip_ws ( p+1 ); + + if ( !seta_bitOrTerm ( &p, &rval ) ) + return FALSE; + + lval |= rval; + } + + *result = lval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_assignment ( LPCTSTR* p_, INT* result ) +{ + LPCTSTR p = *p_; + LPTSTR ident; + TCHAR op = 0; + INT identlen, exprval; + + PARSE_IDENT(ident,identlen,p); + if ( identlen ) + { + if ( *p == _T('=') ) + op = *p, p++; + else if ( _tcschr ( _T("*/%+-&^|"), *p ) && p[1] == _T('=') ) + op = *p, p += 2; + else if ( _tcschr ( _T("<>"), *p ) && *p == p[1] && p[2] == _T('=') ) + op = *p, p += 3; + else + { + _tprintf ( _T("Missing operand.\n") ); + return FALSE; + } + p += strspn ( p, " \t" ); + } + + if ( !seta_expr ( &p, &exprval ) ) + return FALSE; + + if ( identlen ) + { + INT identval; + LPTSTR buf; + + if ( !seta_identval ( ident, &identval ) ) + return FALSE; + if ( op == '=' ) + identval = *result; + else if ( !calc ( &identval, op, exprval ) ) + return FALSE; + buf = (LPTSTR)alloca ( 32 * sizeof(TCHAR) ); + _sntprintf ( buf, 32, _T("%i"), identval ); + SetEnvironmentVariable ( ident, buf ); // TODO FIXME - check return value + exprval = identval; + } + + *result = exprval; + *p_ = p; + return TRUE; +} + +static BOOL +seta_eval ( LPCTSTR p ) +{ + INT rval; + if ( !*p ) + { + _tprintf ( _T("The syntax of the command is incorrect.\n") ); + return FALSE; + } + for ( ;; ) + { + if ( !seta_assignment ( &p, &rval ) ) + return FALSE; + if ( !*p ) + break; + if ( *p != _T(',') ) + { + _tprintf ( _T("Missing operator.\n") ); + return FALSE; + } + ++p; // skip comma + } + _tprintf ( _T("%i\n"), rval ); + return TRUE; +} + #endif

2 1

Problem with compiling 17859
by Saveliy Tretiakov 17 Sep '05

17 Sep '05

What's this? [GAS] lib\rtl\i386\except.s lib\rtl\i386\except.s: Assembler messages: lib\rtl\i386\except.s:207: Error: Unrecognized token `|4)' lib\rtl\i386\except.s:207: Error: Unexpected token `' lib\rtl\i386\except.s:232: Error: Unrecognized token `|4)' lib\rtl\i386\except.s:232: Error: Unexpected token `' make: *** [obj-i386\lib\rtl\i386\except.o] Error 1

5 6

← Newer
1
2
3
4
5
6
7
8
9
...
13
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev September 2005