Ros-dev February 2009

ros-dev@reactos.org

28 participants
36 discussions

Start a nNew thread

Test mail

by Andrew Greenwood

Can we e-mail? Yes we can! (I hope...)

16 years, 1 month

Hello Everyone...

by Richard Campbell

Hi Guys, So After a LONG hiatus I've finally decided to get back into writing code for ReactOS. Some (most?) of you may not remember me. I've been lurking on the lists since 2000-2001, and was an active developer with CVS access for a while back in 2002-2003 (check the commit messages for rcampbell, also submitted quite a few patches). have never stopped reading (although i was/am using a different email address), but haven't touched the code before now. I have a couple of questions: 1) Is my SVN username active? The username is rcampbell. If not, I'll just use bugzilla. 2) Any documentation on coding guidelines such as styles, etc. or rules? I'm sure this has changed since my heyday. Thanks, Richard Campbell

16 years, 1 month

ping pong

by Richard Campbell

ping?

16 years, 1 month

Re: [ros-dev] [ros-diffs] [tkreuzer] 39637: fix formatting

by Hervé Poussineau

tkreuzer(a)svn.reactos.org a écrit : > Author: tkreuzer > Date: Mon Feb 16 21:57:45 2009 > New Revision: 39637 > > URL: http://svn.reactos.org/svn/reactos?rev=39637&view=rev > Log: > fix formatting ... > @@ -118,7 +122,7 @@ > KeAcquireSpinLock(Lock, &OldIrql); > Result = *Destination; > if(*Destination == Result) > - *Destination = *Exchange; > + *Destination = *Exchange; > KeReleaseSpinLock(Lock, OldIrql); > return Result; > } > Is formatting really better now?

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

> No, it's just a matter of coding style used in the kernel. What is a logical basis for adopting this particular rule? Sometimes it is not just a matter of preference. These parentheses are unnecessary for humans, and if they are not needed for compilers or some other tools, they are bad! Without them, the bug could be noticed earlier. Cheers, Dmitry

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

Well, there should be some limit of the number of parentheses, you will probably not want to use them in the a + b * c expression.

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

> I personally feel consistent application of the style is also important, > and that there does not exist a reason to deviate from the established > coding style in this situation. I agree that it is good to follow the consistent coding style. The question is this style itself is good. I meant the abstract case of ((a = b) && (c = d)), not the concrete case of ((ConvKey == HashEntry->ConvKey) && (Length == Ncb->NameLength)).

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

Actually, no reasons were given to use extra parentheses *in this case*. Past mistakes do not justify future mistakes.

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

> This is just a one-off case of a silly programming error. Many such one-off cases were discovered, though not in your code. :)

16 years, 1 month

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

Why this 'fix' is needed? For MSVC?

16 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2009