Ros-dev February 2009

ros-dev@reactos.org

28 participants
36 discussions

Re: [ros-dev] [ros-diffs] [arty] 39613: Fix loopback adapter locking and make traffic work consistently. Fix zero-address binding. Local tcp services should work now.

by Steven Edwards

Hi Arty! On Sun, Feb 15, 2009 at 4:52 PM, <arty(a)svn.reactos.org> wrote: > URL: http://svn.reactos.org/svn/reactos?rev=39613&view=rev > Log: > Fix loopback adapter locking and make traffic work consistently. > Fix zero-address binding. > Local tcp services should work now. I take this to mean telnetd should be talking on the network now? Hello remote process control and the 1980's! Thanks a lot of looking in to this. When I have time I am going to do further cleanup of telnetd and move it in to the ReactOS tree proper. Next on my list is a tftp server I found which I will attempt to get license clarification on, cleanup and add to ReactOS so that we can look in to using ReactOS tftpd to support kickstart like deployment with netboot. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 7 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 39622: - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests

by Timo Kreuzer

This is yet another time where SEH is misused in user mode. Yes, you can see from OpenRCE call chains that ms is using SEH in that function, too. But the way it's used is not a good idea. EXCEPTION_EXECUTE_HANDLER eats all exceptions, including guard pages, invalid opcodes, etc. That's probably not what you want. For everyone wanting to use SEH in user mode I suggest reading this article: http://blogs.msdn.com/oldnewthing/archive/2006/09/27/773741.aspx Thanks, Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon Feb 16 06:07:27 2009 > New Revision: 39622 > > URL: http://svn.reactos.org/svn/reactos?rev=39622&view=rev > Log: > - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests > > Modified: > trunk/reactos/lib/rtl/unicode.c > > Modified: trunk/reactos/lib/rtl/unicode.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/unicode.c?rev=3962… > ============================================================================== > --- trunk/reactos/lib/rtl/unicode.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/unicode.c [iso-8859-1] Mon Feb 16 06:07:27 2009 > @@ -1559,56 +1559,56 @@ > IN ULONG Length, > IN OUT PCHAR String) > { > - NTSTATUS Status = STATUS_SUCCESS; > - ULONG Radix; > - CHAR temp[65]; > - ULONGLONG v = Value->QuadPart; > - ULONG i; > - PCHAR tp; > - PCHAR sp; > - > - Radix = Base; > - if (Radix == 0) > - Radix = 10; > - > - if ((Radix != 2) && (Radix != 8) && > - (Radix != 10) && (Radix != 16)) > - return STATUS_INVALID_PARAMETER; > - > - tp = temp; > - while (v || tp == temp) > - { > - i = v % Radix; > - v = v / Radix; > - if (i < 10) > - *tp = i + '0'; > - else > - *tp = i + 'A' - 10; > - tp++; > - } > - > - if ((ULONG)((ULONG_PTR)tp - (ULONG_PTR)temp) > Length) > - return STATUS_BUFFER_OVERFLOW; > - > - //_SEH2_TRY > - { > - sp = String; > - while (tp > temp) > - *sp++ = *--tp; > - > - if((ULONG)((ULONG_PTR)sp - (ULONG_PTR)String) < Length) > - *sp = 0; > - } > -#if 0 > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - /* Get the error code */ > - Status = _SEH2_GetExceptionCode(); > - } > - _SEH2_END; > -#endif > - > - return Status; > + ULONGLONG Val = Value->QuadPart; > + NTSTATUS Status = STATUS_SUCCESS; > + CHAR Buffer[65]; > + CHAR Digit; > + ULONG Len; > + PCHAR Pos; > + > + if (Base == 0) Base = 10; > + > + if ((Base != 2) && (Base != 8) && > + (Base != 10) && (Base != 16)) > + { > + return STATUS_INVALID_PARAMETER; > + } > + > + Pos = &Buffer[64]; > + *Pos = '\0'; > + > + do > + { > + Pos--; > + Digit = Val % Base; > + Val = Val / Base; > + if (Digit < 10) > + *Pos = '0' + Digit; > + else > + *Pos = 'A' + Digit - 10; > + } > + while (Val != 0L); > + > + Len = &Buffer[64] - Pos; > + > + if (Len > Length) > + return STATUS_BUFFER_OVERFLOW; > + > + _SEH2_TRY > + { > + if (Len == Length) > + RtlCopyMemory(String, Pos, Len); > + else > + RtlCopyMemory(String, Pos, Len + 1); > + } > + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > + { > + /* Get the error code */ > + Status = _SEH2_GetExceptionCode(); > + } > + _SEH2_END; > + > + return Status; > } > > /* > > >

15 years, 7 months

[ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

by Dmitry Gorbachev

> By reformatting my code and breaking ReactOS > 1) Coding Style and 2) Commit Rules? I'm not sure, what, exactly, it breaks?

15 years, 7 months

[ros-diffs] [khornicek] 39617: - add more pixel formats

by James Tabor

Hi, I know this is in a branch, but~ WINAPI DdUnlock(LPDDHAL_UNLOCKDATA Unlock) { + /* Fixme for opengl hel emulations */ + HEL_OGL_STUB; +#if 0 /* Call win32k */ return NtGdiDdUnlock((HANDLE)Unlock->lpDDSurface->hDDSurface, (PDD_UNLOCKDATA)Unlock); +#endif } It is a direct call and this is correct. Why if it out? Don't add non standard functionality to the gdi interface unless this is a upgrade from XP. Thanks, James

15 years, 7 months

RosBE-Unix 1.4 is out!

by Colin Finck

Hello everyone, A new release of RosBE-Unix is finally available. It mostly features updated build tools compatible to the versions used in RosBE-Windows 1.4 and initial multi-architecture support through additional RosBE-Unix packages (which still don't exist though :P) I highly recommend the update, because our previous binutils contains a critical bug in dlltool. (see http://sourceware.org/bugzilla/show_bug.cgi?id=9766 for details) Some components affected by that bug were our msvcrt*.dll and mapi32.dll. The new release is now available from SourceForge, just like RosBE-Windows (https://sourceforge.net/project/showfiles.php?group_id=6553&package_id=3084 58) Best regards, Colin

15 years, 7 months

Forwarding functions to a file with a non-dll extension

by Colin Finck

Hello everyone, Recently, the problem came up that Wine's spoolss.dll tries to forward its "EnumPortsW" function to the similar function in winspool.drv. Wine added a forward entry "winspool.drv.EnumPortsW" for this reason. Unfortunately, such forwarders weren't supported by binutils, thus Christoph opened this bug for them: http://sourceware.org/bugzilla/show_bug.cgi?id=9811 The provided patch now makes such entries possible in the .def file, but that still doesn't help as Windows' and ReactOS' ntdll both forward to .dll files only. So after all, this non-dll forwarding thing seems to be a Wine invention we cannot support and have to avoid when importing Wine stuff. Additionally, the proposed patch on the binutils Bugzilla won't find its way into RosBE now. Best regards, Colin

15 years, 7 months

fosdem

by Ged

Considering about 6 of you went to FOSDEM, is anyone actually gonna release any info about what happened? If I am completely unaware, I can imagine how expectant users feel Communication is really terrible. Ged.

15 years, 7 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 39580: - Add LCIDToLocaleName from Wine. Used by Wine Gecko

by Aleksey Bragin

Wine's Gecko shouldn't rely on non-exported functions... On Feb 13, 2009, at 3:04 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Fri Feb 13 06:04:20 2009 > New Revision: 39580 > > URL: http://svn.reactos.org/svn/reactos?rev=39580&view=rev > Log: > - Add LCIDToLocaleName from Wine. Used by Wine Gecko > > Modified: > trunk/reactos/dll/win32/kernel32/kernel32.spec > trunk/reactos/dll/win32/kernel32/misc/lang.c

15 years, 7 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 39558: Implement hpp - the header preprocessor It can parse headers and create new headers from them based on a simple prepreprocessing language that's compatible with the C preprocessor, so the source file stays a valid header. It works, but doesn't yet support different folders.

by Aleksey Bragin

Please add a standard header, with license information. On Feb 11, 2009, at 11:37 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Wed Feb 11 14:37:25 2009 > New Revision: 39558 > > URL: http://svn.reactos.org/svn/reactos?rev=39558&view=rev > Log: > Implement hpp - the header preprocessor > It can parse headers and create new headers from them based on a > simple prepreprocessing language that's compatible with the C > preprocessor, so the source file stays a valid header. It works, > but doesn't yet support different folders. > > Added: > trunk/reactos/tools/hpp/ (with props) > trunk/reactos/tools/hpp/hpp.c (with props) > trunk/reactos/tools/hpp/hpp.rbuild (with props) > > Propchange: trunk/reactos/tools/hpp/ > ---------------------------------------------------------------------- > -------- > svn:mergeinfo = > > Added: trunk/reactos/tools/hpp/hpp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/hpp/ > hpp.c?rev=39558&view=auto > ====================================================================== > ======== > --- trunk/reactos/tools/hpp/hpp.c (added) > +++ trunk/reactos/tools/hpp/hpp.c [iso-8859-1] Wed Feb 11 14:37:25 > 2009 > @@ -1,0 +1,509 @@ > +#include <stdio.h>

15 years, 7 months

Re: [ros-dev] [ros-diffs] [fireball] 39578: Igor Koshpaev <tower@reactos.org> - Include missing modules into bootcd

by Timo Kreuzer

fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Fri Feb 13 05:20:59 2009 > New Revision: 39578 > > URL: http://svn.reactos.org/svn/reactos?rev=39578&view=rev > Log: > Igor Koshpaev <tower(a)reactos.org> > - Include missing modules into bootcd > ... > +modules\rostests\apitests\w32kdll\w32kdll_2k3sp2\w32kdll_2k3sp2.dll 1 optional > +modules\rostests\apitests\w32kdll\w32kdll_2ksp4\w32kdll_2ksp4.dll 1 optional > ... > +modules\rostests\apitests\w32kdll\w32kdll_xpsp2\w32kdll_xpsp2.dll 1 optional > These make no sense on reactos. They only work on the respective OS.

15 years, 7 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev February 2009