Ros-dev May 2009

ros-dev@reactos.org

36 participants
34 discussions

Re: [ros-dev] [ros-diffs] [cgutman] 41090: - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions - Sorry for so many commits on the same function
by Alex Ionescu 24 May '09

24 May '09

May I ask, why not use simple C for this?: DriverBlock->DriverObject->MajorFunction = MajorFunctions; Or if that doesn't work, use a casting trick... Best regards, Alex Ionescu On Sun, May 24, 2009 at 2:49 AM, <cgutman(a)svn.reactos.org> wrote: > Author: cgutman > Date: Sun May 24 04:49:02 2009 > New Revision: 41090 > > URL: http://svn.reactos.org/svn/reactos?rev=41090&view=rev > Log: > - MajorFunction has IRP_MJ_MAXIMUM_FUNCTION positions > - Sorry for so many commits on the same function > > Modified: > trunk/reactos/drivers/network/ndis/ndis/miniport.c > > Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Sun May 24 04:49:02 2009 > @@ -2788,7 +2788,7 @@ > return NDIS_STATUS_RESOURCES; > } > > - for (i = 0; i < IRP_MJ_MAXIMUM_FUNCTION; i++) > + for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) > DriverBlock->DriverObject->MajorFunction[i] = MajorFunctions[i]; > > DriverBlock->DriverObject->MajorFunction[IRP_MJ_PNP] = NdisIDispatchPnp; > >

2 1

Re: [ros-dev] [ros-diffs] [cwittich] 41096: fix secur32 main winetest crash by returning 0 packages in EmumSecurityPackagesA/W
by Timo Kreuzer 24 May '09

24 May '09

What is the reason we don't sync wine's secur32? Thanks, Timo cwittich(a)svn.reactos.org schrieb: > Author: cwittich > Date: Sun May 24 13:40:15 2009 > New Revision: 41096 > > URL: http://svn.reactos.org/svn/reactos?rev=41096&view=rev > Log: > fix secur32 main winetest crash by returning 0 packages in EmumSecurityPackagesA/W > > Modified: > trunk/reactos/dll/win32/secur32/sspi.c > >

1 0

I have left ReactOS
by Andrew Greenwood 23 May '09

23 May '09

Hi, This mail is a little bit late as I didn't find time to write it earlier. Basically, I've decided that I do not want to continue working on ReactOS. I just don't find it "fun" or interesting to do any more. I spent months trying to get my head around Kernel Streaming and its associated components, how they fit together let alone how they actually function. And really, it's not enjoyable. I don't fully understand Windows kernel-mode coding, and coding the sound system really isn't as straightforward a task as I had originally anticipated. It has become more of a chore over time. Considering I made the switch from Windows to Linux around 2005 and have rarely actually needed to use Windows at home since then, there doesn't seem to be any benefit for me to put my time into working on ReactOS. Also I never really seemed to get very far with sound... I see Janderwald has taken up the challenge on this and is making good progress on it. I had been considering leaving a few months ago, but stuck around for our gathering in Brussels, which was great (aside from the restaurant which seemed like it was going to cook its customers, and the overly-smiley waiter who didn't fully explain what "special sauce" contained...) To be honest I think putting the hybrid CD together for that to be my best and also most hacky achievement for ReactOS. Starflow produced all the fliers/badges/etc. and I think altogether, FOSDEM was a success. And I hope it sparked interest for other people to join the project. I intend on working on some of my own projects from this point on (possibly audio related still...) All the best for the future, Andrew Greenwood

7 7

[ros-diffs] [dchapyshev] 41068: - Sync comctl32 with Wine 1.1.22 (without listview.c. Somebody help to sync listview! Now after sync listview there is a bug: http://opendn.org/listview.png)
by James Tabor 23 May '09

23 May '09

Hi all! What is missing with this? Do we need to fix User32? Did we not sync user32 controls? Edit, Combo, etc...? Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged?
by Ged 23 May '09

23 May '09

I have the code to complete this functionality locally, I just haven't committed it yet as it's not tested. Thanks for the conflict :-P -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: 22 May 2009 23:18 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged? Author: tkreuzer Date: Sat May 23 02:17:55 2009 New Revision: 41046 URL: http://svn.reactos.org/svn/reactos?rev=41046&view=rev Log: #if out an unused static funtion. Don't know if it's still useful. Ged? Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] Sat May 23 02:17:55 2009 @@ -50,6 +50,7 @@ return TreeView_InsertItem(hTreeView, &tvins); } +#if 0 // FIXME: What is this good for? static VOID AddServiceDependency(PSERVICEPROPSHEET dlgInfo, HWND hTreeView, @@ -123,6 +124,7 @@ } } +#endif static VOID AddServiceDependent(HWND hTreeView,

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 41042: - Formatting fix. No code change
by Aleksey Bragin 23 May '09

23 May '09

I hope you asked James and Timo, who may have uncommitted patches to this file (which would fail to apply now). WBR, Aleksey Bragin. On May 22, 2009, at 4:50 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Fri May 22 16:50:31 2009 > New Revision: 41042 > > URL: http://svn.reactos.org/svn/reactos?rev=41042&view=rev > Log: > - Formatting fix. No code change > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/hook.c >

3 2

Network source code
by Timo Kreuzer 22 May '09

22 May '09

2 1

Re: [ros-dev] [ros-diffs] [sedwards] 40919: imported the MT snapshot of the GPL tftp-server for win32 from sourceforge. Minor changes such as formatting and renaming the files, totally untested except for building, will be used later to serve up Reac
by Steven Edwards 20 May '09

20 May '09

On Thu, May 14, 2009 at 2:52 PM, KJK::Hyperion <hackbunny(a)reactos.org> wrote: > Ged wrote: >> Another unix like addition? >> Do we really need this and the previous telnet server in our source? > > to be fair, Windows does provide a command line TFTP client/server. So > far, I've only seen it used for malware spreading, but it's there and we > should provide one too Where I work we use dhcpd/tftp and PXEboot on both Linux and Windows to do automagical deployment services. The end goal with all of this is a ReactOS deployment system from a single image that can provision ReactOS thinkclients/diskless workstations without the need of a Linux or Windows host. Pushing out a freeldr or grub+freeldr or even pxelinux+grub+freeldr image with a blob containing a ROS ramdisk should be pretty simple using isc-dhcpd/tftp on Linux but I'm more interested in the infrastructure side of things right now. Currently the dhcpd with PXE support is the only part we are really missing. We COULD do it from Linux or Windows right now, but I want to get all the infrastructure in place where we don't need any other OS. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

10 16

Re: [ros-dev] runtime time function question in freeldr
by Zhang Fan 20 May '09

20 May '09

Thank you for your answer. But I'm still perplexd. pushl %eax //at that time ,%eax=0? so BootMain will receive NULL parameter? call _BootMain --- On Wed, 5/20/09, pay7n(a)o2.pl <pay7n(a)o2.pl> wrote: > From: pay7n(a)o2.pl <pay7n(a)o2.pl> > Subject: Re: [ros-dev] runtime time function question in freeldr > To: "ReactOS Development List" <ros-dev(a)reactos.org> > Date: Wednesday, May 20, 2009, 3:18 AM > This is not an Intel syntax. > Operands in memory operations have inverted order: > > mov src, dest > > not > > mov dest, src > > thus eax == 0 > > > Zhang Fan pisze: > > Hi everybody, > > I'm a newbie of ReactOS, and I've just looked a piece > of code in freeldr module. I found some runtime function > such as strstr(). I want to know if the run time lib should > be initialized, and where the initialized code. > > Another question is that a piece of code in arch.S > > > > > > EXTERN(RealEntryPoint) > > > > //.... > > .code32 > > > > /* Zero BootDrive and BootPartition > */ > > xorl %eax,%eax > > movl > %eax,(_BootDrive) > > movl > %eax,(_BootPartition) > > > > /* Store the boot drive */ > > movb > %dl,(_BootDrive) > > > > /* Store the boot partition */ > > movb > %dh,(_BootPartition) > > > > /* GO! */ > > pushl %eax > > call _BootMain > > > > At there, I think %eax should equal zero, and BootMain > will call CmdLineParse(),and CmdLineParse will call > strstr(). So it cause strstr will receive a NULL parameter. > Is it right? > > > > Thank you. > > > > Fan Zhang > > > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

runtime time function question in freeldr
by Zhang Fan 19 May '09

19 May '09

Hi everybody, I'm a newbie of ReactOS, and I've just looked a piece of code in freeldr module. I found some runtime function such as strstr(). I want to know if the run time lib should be initialized, and where the initialized code. Another question is that a piece of code in arch.S EXTERN(RealEntryPoint) //.... .code32 /* Zero BootDrive and BootPartition */ xorl %eax,%eax movl %eax,(_BootDrive) movl %eax,(_BootPartition) /* Store the boot drive */ movb %dl,(_BootDrive) /* Store the boot partition */ movb %dh,(_BootPartition) /* GO! */ pushl %eax call _BootMain At there, I think %eax should equal zero, and BootMain will call CmdLineParse(),and CmdLineParse will call strstr(). So it cause strstr will receive a NULL parameter. Is it right? Thank you. Fan Zhang

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2009