Ros-dev May 2009

ros-dev@reactos.org

36 participants
34 discussions

Re: [ros-dev] [ros-diffs] [janderwald] 40823: - Use a spinlock with list functions over interlocked list functions - Use a bitmap for storing reference count of the mappings as mapping are complete async and not very likely in determined order

by Alex Ionescu

RtlBitmap? Best regards, Alex Ionescu On Thu, May 7, 2009 at 12:58 AM, <janderwald(a)svn.reactos.org> wrote: > Author: janderwald > Date: Thu May 7 02:58:57 2009 > New Revision: 40823 > > URL: http://svn.reactos.org/svn/reactos?rev=40823&view=rev > Log: > - Use a spinlock with list functions over interlocked list functions > - Use a bitmap for storing reference count of the mappings as mapping are > complete async and not very likely in determined order > > Modified: > trunk/reactos/drivers/wdm/audio/backpln/portcls/irpstream.c > trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.c > > Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/irpstream.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… > > ============================================================================== > --- trunk/reactos/drivers/wdm/audio/backpln/portcls/irpstream.c > [iso-8859-1] (original) > +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/irpstream.c > [iso-8859-1] Thu May 7 02:58:57 2009 > @@ -14,6 +14,7 @@ > KSSTREAM_HEADER *Header; > PIRP Irp; > > + ULONG References; > ULONG NumTags; > PVOID * Tag; > }IRP_MAPPING, *PIRP_MAPPING; > @@ -141,6 +142,7 @@ > IN PIRP Irp) > { > PIRP_MAPPING Mapping; > + ULONG Index; > IIrpQueueImpl * This = (IIrpQueueImpl*)iface; > > Mapping = AllocateItem(NonPagedPool, sizeof(IRP_MAPPING), > TAG_PORTCLASS); > @@ -166,7 +168,6 @@ > { > Mapping->NumTags++; > } > - ASSERT(Mapping->NumTags < 32); > } > } > else > @@ -181,12 +182,18 @@ > FreeItem(Mapping, TAG_PORTCLASS); > return STATUS_UNSUCCESSFUL; > } > + ASSERT(Mapping->NumTags < 32); > + for(Index = 0; Index < Mapping->NumTags; Index++); > + Mapping->References |= (1 << Index); > > This->NumDataAvailable += Mapping->Header->DataUsed; > > - DPRINT("IIrpQueue_fnAddMapping NumMappings %u SizeOfMapping %lu > NumDataAvailable %lu Mapping %p NumTags %u FrameSize %u\n", > This->NumMappings, Mapping->Header->DataUsed, This->NumDataAvailable, > Mapping, Mapping->NumTags, This->MaxFrameSize); > - > - ExInterlockedInsertTailList(&This->ListHead, &Mapping->Entry, > &This->Lock); > + DPRINT("IIrpQueue_fnAddMapping NumMappings %u SizeOfMapping %lu > NumDataAvailable %lu Mapping %p NumTags %u References %x FrameSize %u\n", > This->NumMappings, Mapping->Header->DataUsed, This->NumDataAvailable, > Mapping, Mapping->NumTags, Mapping->References, This->MaxFrameSize); > + > + KeAcquireSpinLockAtDpcLevel(&This->Lock); > + InsertTailList(&This->ListHead, &Mapping->Entry); > + KeReleaseSpinLockFromDpcLevel(&This->Lock); > + > (void)InterlockedIncrement((volatile long*)&This->NumMappings); > > if (Irp) > @@ -253,7 +260,10 @@ > { > This->CurrentOffset = 0; > > - (void)ExInterlockedRemoveHeadList(&This->ListHead, &This->Lock); > + KeAcquireSpinLockAtDpcLevel(&This->Lock); > + RemoveHeadList(&This->ListHead); > + KeReleaseSpinLockFromDpcLevel(&This->Lock); > + > InterlockedDecrement(&This->NumMappings); > FreeMappingRoutine(CurMapping); > } > @@ -339,7 +349,7 @@ > > /* calculate the offset */ > if (Index) > - Offset = (Index + 1) * This->MaxFrameSize; > + Offset = Index * This->MaxFrameSize; > else > Offset = 0; > > @@ -416,6 +426,7 @@ > KeReleaseSpinLockFromDpcLevel(&This->Lock); > This->OutOfMapping = TRUE; > This->StartStream = FALSE; > + DPRINT("No Mapping available\n"); > return STATUS_UNSUCCESSFUL; > } > > @@ -425,9 +436,9 @@ > IN IIrpQueue *iface, > IN PVOID Tag) > { > - PIRP_MAPPING CurMapping; > + PIRP_MAPPING CurMapping = NULL; > PLIST_ENTRY CurEntry; > - ULONG Index; > + ULONG Index = 0; > ULONG Found; > IIrpQueueImpl * This = (IIrpQueueImpl*)iface; > > @@ -440,40 +451,48 @@ > return STATUS_UNSUCCESSFUL; > } > > - CurMapping = CONTAINING_RECORD(CurEntry, IRP_MAPPING, Entry); > Found = FALSE; > - > - for(Index = 0; Index < CurMapping->NumTags; Index++) > - { > - if (CurMapping->Tag[Index] == Tag) > + MapIndex = 0; > + while (CurEntry != &This->ListHead) > + { > + CurMapping = CONTAINING_RECORD(CurEntry, IRP_MAPPING, Entry); > + for(Index = 0; Index < CurMapping->NumTags; Index++) > { > - Found = TRUE; > + if (CurMapping->Tag[Index] == Tag) > + { > + Found = TRUE; > + break; > + } > + } > + if (Found) > break; > - } > - } > - KeReleaseSpinLockFromDpcLevel(&This->Lock); > + > + CurEntry = CurEntry->Flink; > + } > > if (!Found) > { > - DPRINT("Tag %p not in first mapping %p\n", Tag, CurMapping); > - return STATUS_UNSUCCESSFUL; > - } > - > - if (Index != CurMapping->NumTags - 1) > + DPRINT1("Tag %p not found\n", Tag); > + ASSERT(Found); > + } > + DPRINT("References %x\n", CurMapping->References); > + CurMapping->References &= ~(1 << Index); > + > + if (CurMapping->References) > { > /* released mapping is not the last mapping of the irp */ > - DPRINT1("IIrpQueue_fnReleaseMappingWithTag Tag %p Index %u NumTags > %u\n", Tag, Index, CurMapping->NumTags); > + DPRINT1("IIrpQueue_fnReleaseMappingWithTag Tag %p Index %u NumTags > %u Refs %x\n", Tag, Index, CurMapping->NumTags, CurMapping->References); > + KeReleaseSpinLockFromDpcLevel(&This->Lock); > return STATUS_SUCCESS; > } > > - CurEntry = ExInterlockedRemoveHeadList(&This->ListHead, &This->Lock); > - ASSERT(CurEntry); > - CurMapping = CONTAINING_RECORD(CurEntry, IRP_MAPPING, Entry); > + RemoveEntryList(&CurMapping->Entry); > > /* last mapping of the irp, free irp */ > DPRINT("Freeing mapping %p\n", CurMapping); > InterlockedDecrement(&This->NumMappings); > FreeMappingRoutine(CurMapping); > + KeReleaseSpinLockFromDpcLevel(&This->Lock); > > return STATUS_SUCCESS; > } > > Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… > > ============================================================================== > --- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.c > [iso-8859-1] (original) > +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.c > [iso-8859-1] Thu May 7 02:58:57 2009 > @@ -636,6 +636,7 @@ > if (This->IrpQueue->lpVtbl->HasLastMappingFailed(This->IrpQueue)) > { > /* notify port driver that new mapping is available */ > + DPRINT("Notifying of new mapping\n"); > This->Stream->lpVtbl->MappingAvailable(This->Stream); > } > > >

16 years

announcing roscms4 beta

by Danny Götte

As some of you already know, the ReactOS web team was working on roscms4 for some time. Now it has reached a point where we feel that it is stable. But before we run it in our production system we want to ensure that it runs correct, so we're starting a beta test. With this mail we'd like to invite everyone who has already worked with RosCMS, to do some testing and helping us to get a stable RosCMS. You can use your normal login data from www.reactos.org, we're using a copy from 5. May 2009. Beta-Test Website: http://backend.reactos.org Beta-Test RosCMS: http://backend.reactos.org/roscms please report bugs to http://roscms.dblounge.org/doku.php?id=bugs Thank you for helping

16 years, 1 month

Re: [ros-dev] [ros-diffs] [hpoussin] 40710: Remove MachGetMemoryMap() and replace it by ArcGetMemoryDescriptor(). Rework memory initialization to use it. As a bonus, we're not limited anymore to 32 memory descriptors, and having more than 4GB of RAM doesn't lead to out of bounds accesses

by Timo Kreuzer

hpoussin(a)svn.reactos.org schrieb: > Author: hpoussin > Date: Mon Apr 27 00:22:16 2009 > New Revision: 40710 > > [...] > > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/amd64/hwacpi.c > > Author: hpoussin > Date: Sat Apr 25 00:35:11 2009 > New Revision: 40686 > > [...] > > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/amd64/mach.c > trunk/reactos/boot/freeldr/freeldr/arch/amd64/pcrtc.c > Umm, how did you manage to do that? These files don't/shouldn't even exist. Are you using git? Or voodoo? Black magic haxx0ry? ;) Timo

16 years, 1 month

Bugzilla categories and default CC

by Colin Finck

Hello devs, Cameron just asked whether I could configure Bugzilla to automatically add him to the CC list for "Networking" bugs. This was done now. If you want to be automatically on the CC list for a specific bug category as well, just let me know and I'll add you. Maybe it's even time to rethink our categories and use more practical ones. I'm open for constructive ideas in this direction. Best regards, Colin

16 years, 1 month

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev May 2009