Ros-dev July 2009

ros-dev@reactos.org

49 participants
52 discussions

Code hacking rules, currently applying for NTOSKRNL

by Aleksey Bragin

I decided to make this as a separate post, though it's a follow up to the previous one. I would like to set, officially, a couple of simple code hacking rules, which are going to apply immediately for the NTOSKRNL module, and to other modules after discussion/acceptance. They apply only to committers (which commit their own or someone else's patches). 1. If you change someone's code, and believe it's a correct change - go ahead and commit. 2. If you need to add a hack to someone's code, and: 2.1. you want to either hack or revert the offending commit which breaks booting: This is allowed only after 24hrs after trying to contact the author / posting to the ros-dev mailing list about the problem. 2.2. you want to either hack or revert the offending commit which contains a certain regression but doesn't cause important consequences like inability to install the OS, or major loss of functionality: This is allowed only from permission of author of the code which you want to hack or, as alternative, from my permission. I think this way we can get some order into the coming commits flow, which is hard to track. Also, please comment on this, so that we can alter those rules and maybe accept them for all modules. Thanks for understanding, Aleksey Bragin.

15 years, 2 months

ReactOS 3.1.0... what???

by Javier Agustìn Fernàndez Arroyo

hi guys, if you see latest compatibility database entries you will note that reported ROS version is 3.1.0 why? any clue? some examples: http://www.reactos.org/support/index.php?page=db&view=comp&sec=category&ite… http://www.reactos.org/support/index.php?page=db&view=comp&sec=category&ite…

15 years, 2 months

Re: [ros-dev] [ros-diffs] [cgutman] 41783: - Fix return value of tdiGetMibForIfEntity so it doesn't return a failure status on success

by Ged

This looks hackish It also breaks the log as you're potentially returning something different from what the log states -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of cgutman(a)svn.reactos.org Sent: 06 July 2009 08:54 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [cgutman] 41783: - Fix return value of tdiGetMibForIfEntity so it doesn't return a failure status on success Author: cgutman Date: Mon Jul 6 11:54:28 2009 New Revision: 41783 URL: http://svn.reactos.org/svn/reactos?rev=41783&view=rev Log: - Fix return value of tdiGetMibForIfEntity so it doesn't return a failure status on success Modified: trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c Modified: trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/ifenum_… ============================================================================== --- trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/iphlpapi/ifenum_reactos.c [iso-8859-1] Mon Jul 6 11:54:28 2009 @@ -280,7 +280,7 @@ entry->ent.if_descr); TRACE("} status %08x\n",status); - return status; + return STATUS_SUCCESS; } NTSTATUS tdiGetEntityIDSet( HANDLE tcpFile,

15 years, 2 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 41788: "Fix" MDL PROBE FAILED! bug #4663.

by Aleksey Bragin

Uhm, why hack the kernel again? Testing on the buildbot was fixed to accept this, so there is no urge. I was just trying to help RPG to find the issue, along with vmware/vbox video drivers regression, due to a MmMapIoSpace(128Mb) call. Please read the next email. WBR, Aleksey. On Jul 6, 2009, at 10:28 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Mon Jul 6 22:28:11 2009 > New Revision: 41788 > > URL: http://svn.reactos.org/svn/reactos?rev=41788&view=rev > Log: > "Fix" MDL PROBE FAILED! bug #4663.

15 years, 2 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 41788: "Fix" MDL PROBE FAILED! bug #4663.

by KJK::Hyperion

dgorbachev(a)svn.reactos.org wrote: > --- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Mon Jul 6 22:28:11 2009 > @@ -679,6 +679,7 @@ > // Oops :( > // > ProbeStatus = _SEH2_GetExceptionCode(); > + _SEH2_YIELD(break); > } > _SEH2_END; What's that supposed to do?

15 years, 2 months

Re: [ros-dev] [ros-diffs] [jimtabor] 41776: - Implement the client shutdown procedure. Tested with wine user32 msg undocumented 0x3B tests. Wine tests: msg: 6175 tests executed (0 marked as todo, 937 failures), 5 skipped. - Add missing end session types. - Reference: winproc.c WM_CLIENTSHUTDOWN http://wiki.winprog.org/wiki/Windows_messages

by Timo Kreuzer

jimtabor(a)svn.reactos.org schrieb: > Author: jimtabor > Date: Sun Jul 5 06:21:35 2009 > New Revision: 41776 > > URL: http://svn.reactos.org/svn/reactos?rev=41776&view=rev > Log: > - Implement the client shutdown procedure. Tested with wine user32 msg undocumented 0x3B tests. Wine tests: msg: 6175 tests executed (0 marked as todo, 937 failures), 5 skipped. > - Add missing end session types. > - Reference: winproc.c WM_CLIENTSHUTDOWN http://wiki.winprog.org/wiki/Windows_messages > > [...] > > + List = IntWinListChildren(pWindow); > Oh, how I loathe this function. It walks through the chain of windows to count them, allocates a buffer from paged pool. Walks through the chain again, fills the buffer with the windows' handles and returns the buffer so that the calling function can walk through the buffer and use the handles to query the pointers to the windows again. And this all happens while holding the global user lock. Hint: you can remove 11 lines of code and change 2 lines and get the same result, only faster. Regards, Timo

15 years, 2 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 41755: - Fixes return values for PeekMessageA/W

by Steven Edwards

On Fri, Jul 3, 2009 at 5:53 AM, <dchapyshev(a)svn.reactos.org> wrote: > - if (-1 == (int) Res || ! Res) > - { > - return Res; > + if (-1 == (int) Res || !Res) > + { > + return FALSE; I know you didn't write the check and were just changing the return values but as a matter of style could we do something like if (((int) Res || !Res) == -1) or would the extra parens mess up the order of operations? Not a big deal, its just easier on my eyes. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 2 months

Commit log

by Ged

I think we all agree that the process of filling out a changelog is a task we would rather avoid. Collibri has made some efforts to alleviate this and despite getting some good results we're also seeing a lot of information which isn't changelog oriented. This now leaves us with a new problem of having to manually go through data output from Collibri's tool and reformat it. This is arguably more time consuming than the original method and isn't working for us in its current form. The current problem with this method is that a commit log is not a changelog and getting something which can be classed as a changelog from this without human intervention is an impossible task. There are also some people who would rather write their own changelog instead of allowing a tool to generate it for you. The problem as I see it is two fold : - Commit messages generally contain cryptic message, humour, idioms and frustration - Patches can spread over a wide range of modules making it difficult to insert them into the correct position in the changelog. A possible solution to this is to wrap up a changelog in XML elements. Such a commit log would be as follows : ............................................................................ .......................... - Stop mixing unicode and ANSI strings - Don't dereference NULL pointers <changelog> <notepad>Converted the application to Unicode</notepad> <user32>Fixed a crash highlighted via adobe acrobat</user32> </changelog> ............................................................................ .......................... This will allow anyone who wants to have a changelog autogenerated at release time to take advantage and anyone who wants to do their own to ignore it. The problem with this method lies in getting the XML tags correct. Anyone have any other ideas? Ged.

15 years, 2 months

Re: [ros-dev] Ros-dev Digest, Vol 59, Issue 3

by Olaf Siejka

Sorry for not deleting the post content:/ Back to sysreg... i`d issue a deadline, like 24-48h and until then i`d lock the trunk. If this issue is not fixed until the deadline, offending revision should be reverted and trunk unfrozen. I can only hope we arent getting many regressions in the meantime.

15 years, 2 months

Regression after ARM commit

by Olaf Siejka

Hiya Revision 41657 introduces a regression with VirtualBox Guest Additions video driver. Please see http://www.reactos.org/bugzilla/show_bug.cgi?id=4650 for more details. Regards 2009/7/2 <ros-dev-request(a)reactos.org> > Send Ros-dev mailing list submissions to > ros-dev(a)reactos.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.reactos.org/mailman/listinfo/ros-dev > or, via email, send a message with subject or body 'help' to > ros-dev-request(a)reactos.org > > You can reach the person managing the list at > ros-dev-owner(a)reactos.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Ros-dev digest..." > > > Today's Topics: > > 1. Re: [ros-diffs] [mkupfer] 41733: Mikhail Denisenko > <denisenkom AT gmail DOT com> - Add symbols to system menu by > using marlett font. - See issue #4450 for details. (Ged) > 2. Re: [ros-diffs] [mkupfer] 41733: Mikhail Denisenko > <denisenkom AT gmail DOT com> - Add symbols to system menu by > using marlett font. - See issue #4450 for details. (James Tabor) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 1 Jul 2009 23:10:03 +0100 > From: "Ged" <gedmurphy(a)gmail.com> > Subject: Re: [ros-dev] [ros-diffs] [mkupfer] 41733: Mikhail Denisenko > <denisenkom AT gmail DOT com> - Add symbols to system menu by > using > marlett font. - See issue #4450 for details. > To: <ros-dev(a)reactos.org> > Message-ID: <001801c9fa98$af921810$0eb64830$@com> > Content-Type: text/plain; charset="utf-8" > > Did you read this patch before committing it? > Your last patch fixed tchar usage and then this next patch introduces new > ones. > > > -----Original Message----- > From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] > On Behalf Of mkupfer(a)svn.reactos.org > Sent: 01 July 2009 22:57 > To: ros-diffs(a)reactos.org > Subject: [ros-diffs] [mkupfer] 41733: Mikhail Denisenko <denisenkom AT > gmail DOT com> - Add symbols to system menu by using marlett font. - See > issue #4450 for details. > > Author: mkupfer > Date: Thu Jul 2 01:56:44 2009 > New Revision: 41733 > > URL: http://svn.reactos.org/svn/reactos?rev=41733&view=rev > Log: > Mikhail Denisenko <denisenkom AT gmail DOT com> > - Add symbols to system menu by using marlett font. > - See issue #4450 for details. > > Modified: > trunk/reactos/dll/win32/user32/windows/menu.c > > Modified: trunk/reactos/dll/win32/user32/windows/menu.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… > > ============================================================================== > --- trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] Thu Jul 2 > 01:56:44 2009 > @@ -42,7 +42,6 @@ > #define IS_SYSTEM_POPUP(MenuInfo) \ > (0 != ((MenuInfo)->Flags & MF_POPUP) && 0 != ((MenuInfo)->Flags & > MF_SYSMENU)) > > -#define IS_MAGIC_ITEM(Bmp) ((int) Bmp <12) > #define IS_MAGIC_BITMAP(id) ((id) && ((INT_PTR)(id) < 12) && > ((INT_PTR)(id) >= -1)) > > #define MENU_ITEM_HBMP_SPACE (5) > @@ -307,7 +306,7 @@ > Size->cx = Size->cy = 0; > > /* check if there is a magic menu item associated with this item */ > - if (0 != Bmp && IS_MAGIC_ITEM((INT)(Bmp))) > + if (IS_MAGIC_BITMAP(Bmp)) > { > switch((INT_PTR) Bmp) > { > @@ -339,18 +338,15 @@ > case (INT_PTR) HBMMENU_MBAR_CLOSE: > case (INT_PTR) HBMMENU_MBAR_MINIMIZE_D: > case (INT_PTR) HBMMENU_MBAR_CLOSE_D: > + case (INT_PTR) HBMMENU_POPUP_CLOSE: > + case (INT_PTR) HBMMENU_POPUP_RESTORE: > + case (INT_PTR) HBMMENU_POPUP_MAXIMIZE: > + case (INT_PTR) HBMMENU_POPUP_MINIMIZE: > /* FIXME: Why we need to subtract these magic values? */ > /* to make them smaller than the menu bar? */ > Size->cx = GetSystemMetrics(SM_CXSIZE) - 2; > Size->cy = GetSystemMetrics(SM_CYSIZE) - 4; > return; > - case (INT_PTR) HBMMENU_POPUP_CLOSE: > - case (INT_PTR) HBMMENU_POPUP_RESTORE: > - case (INT_PTR) HBMMENU_POPUP_MAXIMIZE: > - case (INT_PTR) HBMMENU_POPUP_MINIMIZE: > - default: > - FIXME("Magic menu bitmap not implemented\n"); > - return; > } > } > > @@ -359,6 +355,70 @@ > Size->cx = Bm.bmWidth; > Size->cy = Bm.bmHeight; > } > +} > + > +/*********************************************************************** > + * MenuDrawPopupGlyph > + * > + * Draws popup magic glyphs (can be found in system menu). > + */ > +static void FASTCALL > +MenuDrawPopupGlyph(HDC dc, LPRECT r, INT_PTR popupMagic, BOOL inactive, > BOOL hilite) > +{ > + LOGFONTW lf; > + HFONT hFont, hOldFont; > + COLORREF clrsave; > + INT bkmode; > + TCHAR symbol; > + switch (popupMagic) > + { > + case (INT_PTR) HBMMENU_POPUP_RESTORE: > + symbol = '2'; > + break; > + case (INT_PTR) HBMMENU_POPUP_MINIMIZE: > + symbol = '0'; > + break; > + case (INT_PTR) HBMMENU_POPUP_MAXIMIZE: > + symbol = '1'; > + break; > + case (INT_PTR) HBMMENU_POPUP_CLOSE: > + symbol = 'r'; > + break; > + default: > + ERR("Invalid popup magic bitmap %d\n", (int)popupMagic); > + return; > + } > + ZeroMemory(&lf, sizeof(LOGFONTW)); > + InflateRect(r, -2, -2); > + lf.lfHeight = r->bottom - r->top; > + lf.lfWidth = 0; > + lf.lfWeight = FW_NORMAL; > + lf.lfCharSet = DEFAULT_CHARSET; > + lstrcpy(lf.lfFaceName, TEXT("Marlett")); > + hFont = CreateFontIndirect(&lf); > + /* save font and text color */ > + hOldFont = SelectObject(dc, hFont); > + clrsave = GetTextColor(dc); > + bkmode = GetBkMode(dc); > + /* set color and drawing mode */ > + SetBkMode(dc, TRANSPARENT); > + if (inactive) > + { > + /* draw shadow */ > + if (!hilite) > + { > + SetTextColor(dc, GetSysColor(COLOR_HIGHLIGHTTEXT)); > + TextOut(dc, r->left + 1, r->top + 1, &symbol, 1); > + } > + } > + SetTextColor(dc, GetSysColor(inactive ? COLOR_GRAYTEXT : (hilite ? > COLOR_HIGHLIGHTTEXT : COLOR_MENUTEXT))); > + /* draw selected symbol */ > + TextOut(dc, r->left, r->top, &symbol, 1); > + /* restore previous settings */ > + SetTextColor(dc, clrsave); > + SelectObject(dc, hOldFont); > + SetBkMode(dc, bkmode); > + DeleteObject(hFont); > } > > /*********************************************************************** > @@ -382,7 +442,7 @@ > Bmp = hbmpToDraw; > > /* Check if there is a magic menu item associated with this item */ > - if (IS_MAGIC_ITEM(hbmpToDraw)) > + if (IS_MAGIC_BITMAP(hbmpToDraw)) > { > UINT Flags = 0; > RECT r; > @@ -459,8 +519,7 @@ > case (INT_PTR) HBMMENU_POPUP_RESTORE: > case (INT_PTR) HBMMENU_POPUP_MAXIMIZE: > case (INT_PTR) HBMMENU_POPUP_MINIMIZE: > - default: > - FIXME("Magic menu bitmap not implemented\n"); > + MenuDrawPopupGlyph(Dc, &r, (INT_PTR)hbmpToDraw, Item->fState & > MF_GRAYED, Item->fState & MF_HILITE); > return; > } > InflateRect(&r, -1, -1); > @@ -736,9 +795,17 @@ > checked = TRUE; > } > } > - if ((Item->hbmpItem)&& !( checked && (MenuInfo->dwStyle & > MNS_CHECKORBMP))) > + if (Item->hbmpItem) > { > - MenuDrawBitmapItem(Dc, Item, &Rect, MenuInfo->Self, WndOwner, > Action, MenuBar); > + RECT bmpRect; > + CopyRect(&bmpRect, &Rect); > + if (!(MenuInfo->dwStyle & MNS_CHECKORBMP) && !(MenuInfo->dwStyle & > MNS_NOCHECK)) > + bmpRect.left += CheckBitmapWidth + 2; > + if (!(checked && (MenuInfo->dwStyle & MNS_CHECKORBMP))) > + { > + bmpRect.right = bmpRect.left + MenuInfo->maxBmpSize.cx; > + MenuDrawBitmapItem(Dc, Item, &bmpRect, MenuInfo->Self, WndOwner, > Action, MenuBar); > + } > } > /* Draw the popup-menu arrow */ > if (0 != (Item->fType & MF_POPUP)) > @@ -767,7 +834,9 @@ > UINT uFormat = MenuBar ? DT_CENTER | DT_VCENTER | DT_SINGLELINE > : DT_LEFT | DT_VCENTER | DT_SINGLELINE; > > - if( !(MenuInfo->dwStyle & MNS_CHECKORBMP)) > + if(MenuInfo->dwStyle & MNS_CHECKORBMP) > + Rect.left += max(0, MenuInfo->maxBmpSize.cx - > GetSystemMetrics(SM_CXMENUCHECK)); > + else > Rect.left += MenuInfo->maxBmpSize.cx; > > if (0 != (Item->fState & MFS_DEFAULT)) > @@ -779,11 +848,6 @@ > { > Rect.left += MENU_BAR_ITEMS_SPACE / 2; > Rect.right -= MENU_BAR_ITEMS_SPACE / 2; > - } > - if (Item->hbmpItem == HBMMENU_CALLBACK || MenuInfo->maxBmpSize.cx != > 0 ) > - { > - Rect.left += MenuInfo->maxBmpSize.cx; > - Rect.right -= MenuInfo->maxBmpSize.cx; > } > > Text = (PWCHAR) Item->dwTypeData; > @@ -1103,8 +1167,30 @@ > NTSTATUS WINAPI > User32LoadSysMenuTemplateForKernel(PVOID Arguments, ULONG ArgumentLength) > { > - LRESULT Result; > - Result = (LRESULT)LoadMenuW(User32Instance, L"SYSMENU"); > + HMENU hmenu = LoadMenuW(User32Instance, L"SYSMENU"); > + LRESULT Result = (LRESULT)hmenu; > + > + // removing space for checkboxes from menu > + MENUINFO menuinfo = {0}; > + menuinfo.cbSize = sizeof(menuinfo); > + menuinfo.fMask = MIM_STYLE; > + GetMenuInfo(hmenu, &menuinfo); > + menuinfo.dwStyle |= MNS_NOCHECK; > + SetMenuInfo(hmenu, &menuinfo); > + > + // adding bitmaps to menu items > + MENUITEMINFOW info = {0}; > + info.cbSize = sizeof(info); > + info.fMask |= MIIM_BITMAP; > + info.hbmpItem = HBMMENU_POPUP_MINIMIZE; > + SetMenuItemInfoW(hmenu, SC_MINIMIZE, FALSE, &info); > + info.hbmpItem = HBMMENU_POPUP_RESTORE; > + SetMenuItemInfoW(hmenu, SC_RESTORE, FALSE, &info); > + info.hbmpItem = HBMMENU_POPUP_MAXIMIZE; > + SetMenuItemInfoW(hmenu, SC_MAXIMIZE, FALSE, &info); > + info.hbmpItem = HBMMENU_POPUP_CLOSE; > + SetMenuItemInfoW(hmenu, SC_CLOSE, FALSE, &info); > + > return(ZwCallbackReturn(&Result, sizeof(LRESULT), STATUS_SUCCESS)); > } > > @@ -1247,7 +1333,6 @@ > MenuInfo->maxBmpSize.cy = abs(Size.cy); > } > MenuSetRosMenuInfo(MenuInfo); > - ItemInfo->Rect.right += Size.cx + 2; > itemheight = Size.cy + 2; > > if( !(MenuInfo->dwStyle & MNS_NOCHECK)) > > > > > ------------------------------ > > Message: 2 > Date: Wed, 1 Jul 2009 20:26:20 -0500 > From: James Tabor <jimtabor.rosdev(a)gmail.com> > Subject: Re: [ros-dev] [ros-diffs] [mkupfer] 41733: Mikhail Denisenko > <denisenkom AT gmail DOT com> - Add symbols to system menu by > using > marlett font. - See issue #4450 for details. > To: ReactOS Development List <ros-dev(a)reactos.org> > Message-ID: > <b93fa9340907011826s2b31d0d3va7674a0446a00020(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Hi! > > On Wed, Jul 1, 2009 at 5:10 PM, Ged<gedmurphy(a)gmail.com> wrote: > > Did you read this patch before committing it? > > Your last patch fixed tchar usage and then this next patch introduces new > ones. > > > > > Looks okay, interesting way for setting up the system menu for kernel > space. Need to test this with every application in our test library to > make sure this all works! > > > @@ -1103,8 +1167,30 @@ > > NTSTATUS WINAPI > > User32LoadSysMenuTemplateForKernel(PVOID Arguments, ULONG > ArgumentLength) > > { > > - LRESULT Result; > > - Result = (LRESULT)LoadMenuW(User32Instance, L"SYSMENU"); > > + HMENU hmenu = LoadMenuW(User32Instance, L"SYSMENU"); > > + LRESULT Result = (LRESULT)hmenu; > > + > > + // removing space for checkboxes from menu > > + MENUINFO menuinfo = {0}; > > + menuinfo.cbSize = sizeof(menuinfo); > > + menuinfo.fMask = MIM_STYLE; > > + GetMenuInfo(hmenu, &menuinfo); > > + menuinfo.dwStyle |= MNS_NOCHECK; > > + SetMenuInfo(hmenu, &menuinfo); > > + > > + // adding bitmaps to menu items > > + MENUITEMINFOW info = {0}; > > + info.cbSize = sizeof(info); > > + info.fMask |= MIIM_BITMAP; > > + info.hbmpItem = HBMMENU_POPUP_MINIMIZE; > > + SetMenuItemInfoW(hmenu, SC_MINIMIZE, FALSE, &info); > > + info.hbmpItem = HBMMENU_POPUP_RESTORE; > > + SetMenuItemInfoW(hmenu, SC_RESTORE, FALSE, &info); > > + info.hbmpItem = HBMMENU_POPUP_MAXIMIZE; > > + SetMenuItemInfoW(hmenu, SC_MAXIMIZE, FALSE, &info); > > + info.hbmpItem = HBMMENU_POPUP_CLOSE; > > + SetMenuItemInfoW(hmenu, SC_CLOSE, FALSE, &info); > > + > > return(ZwCallbackReturn(&Result, sizeof(LRESULT), STATUS_SUCCESS)); > > } > > > > > ------------------------------ > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > End of Ros-dev Digest, Vol 59, Issue 2 > ************************************** >

15 years, 2 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev July 2009