Ros-dev August 2009

ros-dev@reactos.org

29 participants
35 discussions

Re: [ros-dev] [ros-diffs] [fireball] 42833: - Implement windows moving (with contents).
by Steven Edwards 22 Aug '09

22 Aug '09

On Fri, Aug 21, 2009 at 3:13 PM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Fri Aug 21 21:13:00 2009 > New Revision: 42833 > > URL: http://svn.reactos.org/svn/reactos?rev=42833&view=rev > Log: > - Implement windows moving (with contents). This is one of the Greatest. Commits. Ever. I wish that we could make Office 2007 run just by removing half the commented out code. ;) -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Re: [ros-dev] [ros-diffs] [sginsberg] 42829: - svchost: #ifdef _MSC_VER doesn't mean "using Microsoft's headers" anymore - ddraw, imm32, msxml3, oleaut32, riched20: Include typeof.h for typeof emulation when compiling under MSVC and remove from ReactOS-generic.rbuild (this can't go to port.h as the modules do not include it). - TCPIP: Fix a check for MSVC. - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying to link to ftol (gcc inlined the operation). - SAMLIB: Use __VA_ARG
by Timo Kreuzer 22 Aug '09

22 Aug '09

lol+1! sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Fri Aug 21 17:57:26 2009 > New Revision: 42829 > > URL: http://svn.reactos.org/svn/reactos?rev=42829&view=rev > Log: > [...] > - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying to link to ftol (gcc inlined the operation). > [...] > > > Modified: trunk/reactos/drivers/network/ndis/ndis/config.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] Fri Aug 21 17:57:26 2009 > @@ -705,7 +705,14 @@ > > while (j < str.Length && str.Buffer[j] != '\0') j++; > > - *NetworkAddressLength = (UINT)((j/2)+0.5); > + if ((j % 2) == 0) > + { > + *NetworkAddressLength = (UINT)(j/2); > + } > + else > + { > + *NetworkAddressLength = (UINT)((j/2)+1); > + } > > if ((*NetworkAddressLength) == 0) > { > >

2 1

Some upcoming changes
by Colin Finck 18 Aug '09

18 Aug '09

Hello all, I just wanted to announce some upcoming changes. Comments are appreciated. Official removal of i486 support --------------------------------- The Mingw-w64 project held an internal meeting today. One of the decisions was to remove support for architectures older than i586 from their code. As we already use some of their runtime code and loosely planned to switch to a mingw-w64 x86/x64 multilib toolchain once that is released and stable (which should be the case in gcc 4.5.x), we will be affected by this change, too. Of course, the Mingw-w64 code would just add another problem to the pot of i486 incompatibilities. For example, some of our assembly code makes use of the CMPXCHG8B instruction (introduced in the Pentium). Though I don't know anybody, who tried a recent ReactOS build on an i486 machine, I also never found a statement about the official removal of i486 support. So as long as nobody objects, let's officially declare i486 support abandoned now. ISO cleaning on iso.reactos.org -------------------------------- As we were right before running out of space on the ISO storage server (in fact, that would have happened when Aleksey was on his planned holiday trip :D), I've installed a script to clean old ISOs automatically now. The script will remove bootcd-dbg ISOs older than 2 years and all other ISOs older than half a year. This should free enough space while keeping enough important ISOs for tracking down old regressions. Testman log cleaning --------------------- Another service that takes more space than you might think is Testman. Logs for ~1300 revisions currently take around 2 GB. My plan would be to delete logs (not the actual test result numbers) older than half a year to keep the used space for them on an almost constant level. If nobody objects, such a script will be installed in the upcoming days. Best regards, Colin

3 5

Re: [ros-dev] [ros-diffs] [dchapyshev] 42694: - Add README.ENG - Change rapps.cab to rappmgr.cab (in CreateCabFile.bat)
by Colin Finck 15 Aug '09

15 Aug '09

dchapyshev(a)svn.reactos.org wrote: > Modified: trunk/reactos/base/applications/rapps/CreateCabFile.bat If you want to create a raw CAB file, you should rather try the "cabinet" module of rbuild (see /trunk/reactos/media/vgafonts/vgafonts.rbuild for an example). Though I'm certainly in favor of a solution involving multiple plain XML files (instead of several INI-like files put into a single cabinet) if this is going to become a client/server system in the future. This would make it more flexible and we could think about future usages such as showing that application database on a website. Reading XML shouldn't be that hard to implement considering that probably no other source tree contains as many XML libraries as ours ;-) After all, I think that rapps is a step in the right direction! :-) Best regards, Colin

1 0

Webtest manager
by Timo Kreuzer 11 Aug '09

11 Aug '09

Hi, I tried to access the webtest manager http://79.99.5.181/testman/ works but seems to be outdated, 42522 being the last revision. http://www.reactos.org/testman/ doesn't show any revisions. Regards, Timo

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 42596: Implement EngFileIoControl and EngFileWrite
by Hervé Poussineau 10 Aug '09

10 Aug '09

tkreuzer(a)svn.reactos.org a écrit : > Author: tkreuzer > Date: Mon Aug 10 17:09:14 2009 > New Revision: 42596 > > +static > +DWORD > +EngpFileIoRequest( > + PFILE_OBJECT pFileObject, > + ULONG ulMajorFunction, > + LPVOID lpBuffer, > + DWORD nBufferSize, > + ULONGLONG ullStartOffset, > + OUT LPDWORD lpInformation) > +{ [...] > + return STATUS_INVALID_PARAMETER; [...] > + return FALSE; [...] > + return NT_SUCCESS(Status); > +} I don't really understand what is supposed to return EngpFileIoRequest? A DWORD, a BOOLEAN, or a NTSTATUS? Hervé

3 2

Re: [ros-dev] [ros-diffs] [dgorbachev] 42566: Fix IDT limit.
by Aleksey Bragin 10 Aug '09

10 Aug '09

Good catch, thanks! (I'm getting used to finding a real change in reformatting commits nowadays :)). WBR, Aleksey Bragin. On Aug 9, 2009, at 6:40 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Sun Aug 9 16:40:05 2009 > New Revision: 42566 > > URL: http://svn.reactos.org/svn/reactos?rev=42566&view=rev > Log: > Fix IDT limit. > > Modified: > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386idt.S > trunk/reactos/boot/freeldr/freeldr/windows/wlmemory.c

1 0

Re: [ros-dev] [ros-diffs] [hyperion] 42530: modified base/setup/vmwinst/vmwinst.c modified base/setup/vmwinst/vmwinst.rbuild Implement VMWare detection for Visual C++ as well For cleaner code, use SEH instead of VEH, even if it means losing this pearl of ReactOS wisdom: /* Setup a vectored exception handler to protect the detection. Don't use SEH here so we notice the next time someone removes support for vectored exception handling from ros... */ (www.passiveaggressivecommits.com, brought to you by Arch Bl
by Aleksey Bragin 10 Aug '09

10 Aug '09

On Aug 8, 2009, at 10:03 PM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Sat Aug 8 20:03:48 2009 > New Revision: 42530 > > URL: http://svn.reactos.org/svn/reactos?rev=42530&view=rev > Log: > modified base/setup/vmwinst/vmwinst.c > modified base/setup/vmwinst/vmwinst.rbuild > Implement VMWare detection for Visual C++ as well > For cleaner code, use SEH instead of VEH, even if it means > losing this pearl of ReactOS wisdom: > > /* Setup a vectored exception handler to protect the > detection. Don't use SEH > here so we notice the next time someone removes support for > vectored > exception handling from ros... */ > > (www.passiveaggressivecommits.com, brought to you by Arch > Blackmann!) > Of course, it also means trading our VEH bugs for our SEH bugs, > so I'm not sure if it was worth changing This test should be added to the test suite which we have now (or maybe it is there already?). Putting various tests inside unrelated apps was a great idea back then but reactos evolved from that. WBR, Aleksey Bragin.

2 1

Re: [ros-dev] [ros-diffs] [hpoussin] 42538: Fix some typos and make PFILE a ULONG
by Timo Kreuzer 09 Aug '09

09 Aug '09

hpoussin(a)svn.reactos.org wrote: > Author: hpoussin > Date: Sat Aug 8 23:11:40 2009 > New Revision: 42538 > > URL: http://svn.reactos.org/svn/reactos?rev=42538&view=rev > Log: > Fix some typos and make PFILE a ULONG > I hope this is fully 64 bit compatible... I think FILEID would look better and is less likely to confuse other devs when working with it ;-)

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 42569: Do not call CcUnpinData() with NULL PtrBCB.
by Filip Navara 09 Aug '09

09 Aug '09

This is very wrong! PtrBCB should never ever be NULL... and if it is then it means that CcMapData few lines above failed. In fact the whole chunk of code is wrong. CcMapData return value is not properly checked. If it got far enough that CcUnpinData crashed then PtrParentFCB->NTRequiredFCB.CommonFCBHeader.FileSize == 0 and obviously the mapping will fail. This case can easily be checked without even attempting to map the data... Best regards, Filip Navara On Sun, Aug 9, 2009 at 7:26 PM, <dgorbachev(a)svn.reactos.org> wrote: > Author: dgorbachev > Date: Sun Aug 9 19:26:10 2009 > New Revision: 42569 > > URL: http://svn.reactos.org/svn/reactos?rev=42569&view=rev > Log: > Do not call CcUnpinData() with NULL PtrBCB. > > Modified: > trunk/reactos/drivers/filesystems/ext2/src/create.c > > Modified: trunk/reactos/drivers/filesystems/ext2/src/create.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/s… > ============================================================================== > --- trunk/reactos/drivers/filesystems/ext2/src/create.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/ext2/src/create.c [iso-8859-1] Sun Aug 9 19:26:10 2009 > @@ -1410,8 +1410,12 @@ > } > } > > - CcUnpinData( PtrBCB ); > - PtrBCB = NULL; > + // FIXME > + if( PtrBCB ) > + { > + CcUnpinData( PtrBCB ); > + PtrBCB = NULL; > + } > > return InodeNo; > } > > >

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2009