Ros-dev August 2009

ros-dev@reactos.org

29 participants
35 discussions

Re: [ros-dev] [ros-diffs] [sginsberg] 42369: - mingw: __builtin_return_address -> _ReturnAddress, __builtin_frame_address -> _AddressOfReturnAddress - ReactOS-generic.rbuild: Define __STDC__ for MSVC to fix some code depending on it (not using /Za as it breaks other code)

by Timo Kreuzer

We have _ReturnAddress() and _AddressOfReturnAddress defined in intrin_x86.h sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Mon Aug 3 20:02:07 2009 > New Revision: 42369 > > URL: http://svn.reactos.org/svn/reactos?rev=42369&view=rev > Log: > - mingw: __builtin_return_address -> _ReturnAddress, __builtin_frame_address -> _AddressOfReturnAddress > - ReactOS-generic.rbuild: Define __STDC__ for MSVC to fix some code depending on it (not using /Za as it breaks other code) > > Modified: > trunk/reactos/ReactOS-generic.rbuild > trunk/reactos/lib/3rdparty/mingw/gs_support.c > > Modified: trunk/reactos/ReactOS-generic.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-generic.rbuild?rev… > ============================================================================== > --- trunk/reactos/ReactOS-generic.rbuild [iso-8859-1] (original) > +++ trunk/reactos/ReactOS-generic.rbuild [iso-8859-1] Mon Aug 3 20:02:07 2009 > @@ -95,6 +95,7 @@ > > <group compilerset="msc"> > <define name="inline" compiler="cc">__inline</define> > + <define name="__STDC__" compiler="cc">1</define> > <compilerflag>/Zl</compilerflag> > <compilerflag>/Zi</compilerflag> > <compilerflag>/W1</compilerflag> > > Modified: trunk/reactos/lib/3rdparty/mingw/gs_support.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/gs_supp… > ============================================================================== > --- trunk/reactos/lib/3rdparty/mingw/gs_support.c [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/mingw/gs_support.c [iso-8859-1] Mon Aug 3 20:02:07 2009 > @@ -108,12 +108,22 @@ > else > #endif > { > +#ifdef __GNUC__ > #ifdef _WIN64 > GS_ContextRecord.Rip = (ULONGLONG) __builtin_return_address (0); > GS_ContextRecord.Rsp = (ULONGLONG) __builtin_frame_address (0) + 8; > #else > GS_ContextRecord.Eip = (DWORD) __builtin_return_address (0); > GS_ContextRecord.Esp = (DWORD) __builtin_frame_address (0) + 4; > +#endif > +#else > +#ifdef _WIN64 > + GS_ContextRecord.Rip = (ULONGLONG) _ReturnAddress(); > + GS_ContextRecord.Rsp = (ULONGLONG) _AddressOfReturnAddress(); > +#else > + GS_ContextRecord.Eip = (DWORD) _ReturnAddress(); > + GS_ContextRecord.Esp = (DWORD) _AddressOfReturnAddress(); > +#endif > #endif > } > > > > >

15 years, 1 month

Re: [ros-dev] [ros-diffs] [fireball] 42333: - Handle case when RosGdiSetDeviceClipping is being called without rects at all (with a respective DPRINT1). - Use combined clipping object everywhere to ensure drawing happens only in allowed rectangle, se

by Alex Ionescu

A similar question would apply to the ninjas' "issue #" that crept up once or twice... Best regards, Alex Ionescu On Sun, Aug 2, 2009 at 3:26 PM, Steven Edwards <winehacker(a)gmail.com> wrote: > On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > > - Use combined clipping object everywhere to ensure drawing happens only > in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox > and other apps which would corrupt memory if trying to blit to area outside > of DC. > > I keep seeing these comments, 'see arwinss nr. #'. Where do I go to > look this up? > > Thanks > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

15 years, 1 month

by Steven Edwards

On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > - Use combined clipping object everywhere to ensure drawing happens only in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox and other apps which would corrupt memory if trying to blit to area outside of DC. I keep seeing these comments, 'see arwinss nr. #'. Where do I go to look this up? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 1 month

by Javier Agustìn Fernàndez Arroyo

http://www.reactos.org/wiki/Arwinss ? On Mon, Aug 3, 2009 at 12:26 AM, Steven Edwards <winehacker(a)gmail.com>wrote: > On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > > - Use combined clipping object everywhere to ensure drawing happens only > in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox > and other apps which would corrupt memory if trying to blit to area outside > of DC. > > I keep seeing these comments, 'see arwinss nr. #'. Where do I go to > look this up? > > Thanks > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

15 years, 1 month

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.

by Aleksey Bragin

That function is not supposed to be called by old bootloader directly. Why is that needed? And why in this function? WBR, Aleksey Bragin. On Jul 30, 2009, at 9:54 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Thu Jul 30 19:54:01 2009 > New Revision: 42305 > > URL: http://svn.reactos.org/svn/reactos?rev=42305&view=rev > Log: > Add a hack in KiSystemStartupReal function until Better Times. > > Modified: > trunk/reactos/ntoskrnl/ke/i386/kiinit.c > > Modified: trunk/reactos/ntoskrnl/ke/i386/kiinit.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/ > i386/kiinit.c?rev=42305&r1=42304&r2=42305&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/ke/i386/kiinit.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/i386/kiinit.c [iso-8859-1] Thu Jul 30 > 19:54:01 2009 > @@ -712,18 +712,34 @@ > Ke386SetDs(KGDT_R3_DATA | RPL_MASK); > Ke386SetEs(KGDT_R3_DATA | RPL_MASK); > > - /* Save NMI and double fault traps */ > - RtlCopyMemory(&NmiEntry, &Idt[2], sizeof(KIDTENTRY)); > - RtlCopyMemory(&DoubleFaultEntry, &Idt[8], sizeof(KIDTENTRY)); > - > - /* Copy kernel's trap handlers */ > - RtlCopyMemory(Idt, > - (PVOID)KiIdtDescriptor.Base, > - KiIdtDescriptor.Limit + 1); > - > - /* Restore NMI and double fault */ > - RtlCopyMemory(&Idt[2], &NmiEntry, sizeof(KIDTENTRY)); > - RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); > + /* HACK compensates for KiRosPrepareForSystemStartup hack */ > + if ((ULONG)Idt == KiIdtDescriptor.Base) > + { > + USHORT FlippedSelector; > + > + FlippedSelector = KiIdt[2].Selector; > + KiIdt[2].Selector = KiIdt[2].ExtendedOffset; > + KiIdt[2].ExtendedOffset = FlippedSelector; > + > + FlippedSelector = KiIdt[8].Selector; > + KiIdt[8].Selector = KiIdt[8].ExtendedOffset; > + KiIdt[8].ExtendedOffset = FlippedSelector; > + } > + else > + { > + /* Save NMI and double fault traps */ > + RtlCopyMemory(&NmiEntry, &Idt[2], sizeof(KIDTENTRY)); > + RtlCopyMemory(&DoubleFaultEntry, &Idt[8], sizeof(KIDTENTRY)); > + > + /* Copy kernel's trap handlers */ > + RtlCopyMemory(Idt, > + (PVOID)KiIdtDescriptor.Base, > + KiIdtDescriptor.Limit + 1); > + > + /* Restore NMI and double fault */ > + RtlCopyMemory(&Idt[2], &NmiEntry, sizeof(KIDTENTRY)); > + RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); > + } > > AppCpuInit: > /* Loop until we can release the freeze lock */ > >

15 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev August 2009