Ros-dev January 2010

ros-dev@reactos.org

41 participants
64 discussions

Re: [ros-dev] [ros-diffs] [dreimer] 45031: R.I.P. raddr2line.

by Timo Kreuzer

Please keep raddr2line. dreimer(a)svn.reactos.org schrieb: > Author: dreimer > Date: Sun Jan 10 17:21:53 2010 > New Revision: 45031 > > URL: http://svn.reactos.org/svn/reactos?rev=45031&view=rev > Log: > R.I.P. raddr2line. > > Modified: > trunk/tools/RosBE/RosBE-Windows/Powershell/reladdr2line.ps1 > trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt > trunk/tools/RosBE/RosBE-Windows/Root/raddr2line.cmd > trunk/tools/RosBE/RosBE-Windows/RosBE.nsi > > Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/reladdr2line.ps1 > URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Powershe… > ============================================================================== > --- trunk/tools/RosBE/RosBE-Windows/Powershell/reladdr2line.ps1 [iso-8859-1] (original) > +++ trunk/tools/RosBE/RosBE-Windows/Powershell/reladdr2line.ps1 [iso-8859-1] Sun Jan 10 17:21:53 2010 > @@ -35,11 +35,11 @@ > $baseaddr = (objdump -p $FILEPATH | select-string "ImageBase").tostring().split() > $baseaddr = "0x" + ($baseaddr.get($baseaddr.length - 1)) > if ($baseaddr -lt $ADDRESS) { > - IEX "& '$_ROSBE_BASEDIR\Tools\raddr2line.exe' '$FILEPATH' '$ADDRESS'" > + IEX "& '$_ROSBE_BASEDIR\Tools\log2lines.exe' '$FILEPATH' '$ADDRESS'" > } else { > $baseaddr = ($baseaddr | % {[Convert]::ToInt32($_,16)}) + ($ADDRESS | % {[Convert]::ToInt32($_,16)}) > $relbase = "0x" + ("{0:X}" -f $baseaddr) > - IEX "& '$_ROSBE_BASEDIR\Tools\raddr2line.exe' '$FILEPATH' '$relbase'" > + IEX "& '$_ROSBE_BASEDIR\Tools\log2lines.exe' '$FILEPATH' '$relbase'" > } > > $host.ui.RawUI.WindowTitle = "ReactOS Build Environment $_ROSBE_VERSION" > > Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt > URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… > ============================================================================== > --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] (original) > +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt [iso-8859-1] Sun Jan 10 17:21:53 2010 > @@ -6,7 +6,7 @@ > - Updated w32api to 3.14 (Daniel Reimer) > - Updated NSIS to 2.46 (Daniel Reimer) > - Added Remake command (Daniel Reimer) > -- Added log2lines v1.9 to RosBE (Daniel Reimer) > +- Replaced raddr2line with log2lines v1.9 (Daniel Reimer) > - Added a chinese translation to the options tool (Elton Chung) > - Added ARM Arch support to RosBE (Daniel Reimer) > - Added ARM Settings to options.exe, too (Daniel Reimer) > > Modified: trunk/tools/RosBE/RosBE-Windows/Root/raddr2line.cmd > URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/rad… > ============================================================================== > --- trunk/tools/RosBE/RosBE-Windows/Root/raddr2line.cmd [iso-8859-1] (original) > +++ trunk/tools/RosBE/RosBE-Windows/Root/raddr2line.cmd [iso-8859-1] Sun Jan 10 17:21:53 2010 > @@ -63,12 +63,12 @@ > for /f "tokens=2" %%i in ('"objdump -p "%FILEPATH%" 2>NUL | findstr ImageBase"') do set BASEADDRESS=0x%%i > > if %%i lss %ADDRESS% ( > - "%_ROSBE_BASEDIR%\Tools\raddr2line.exe" "%FILEPATH%" "%ADDRESS%" > + "%_ROSBE_BASEDIR%\Tools\log2lines.exe" "%FILEPATH%" "%ADDRESS%" > ) else ( > set /a BASEADDRESS+=0x%ADDRESS% > > for /f %%i in ('""%_ROSBE_BASEDIR%\Tools\echoh.exe" !BASEADDRESS!"') do set RELBASE=%%i > - "%_ROSBE_BASEDIR%\Tools\raddr2line.exe" "!FILEPATH!" "!RELBASE!" > + "%_ROSBE_BASEDIR%\Tools\log2lines.exe" "!FILEPATH!" "!RELBASE!" > ) > > :EOC > > Modified: trunk/tools/RosBE/RosBE-Windows/RosBE.nsi > URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/RosBE.ns… > ============================================================================== > --- trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] (original) > +++ trunk/tools/RosBE/RosBE-Windows/RosBE.nsi [iso-8859-1] Sun Jan 10 17:21:53 2010 > @@ -269,7 +269,6 @@ > SetOutPath "$INSTDIR\Tools" > SetOverwrite try > File /r Components\Tools\echoh.exe > - File /r Components\Tools\raddr2line.exe > File /r Components\Tools\log2lines.exe > File /r Components\Tools\chkslash.exe > SectionEnd > > > >

14 years, 11 months

Re: [ros-dev] [ros-diffs] [ekohl] 45020: Removed outdated email addresses.

by Aleksey Bragin

What do you all think about developer's email in source code? Is there a need for it at all there? WBR, Aleksey. On Jan 10, 2010, at 1:43 AM, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sat Jan 9 23:43:16 2010 > New Revision: 45020 > > URL: http://svn.reactos.org/svn/reactos?rev=45020&view=rev > Log: > Removed outdated email addresses. > Modified: trunk/reactos/ntoskrnl/ke/queue.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/ > queue.c?rev=45020&r1=45019&r2=45020&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/ke/queue.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/queue.c [iso-8859-1] Sat Jan 9 > 23:43:16 2010 > @@ -5,7 +5,7 @@ > * PURPOSE: Implements kernel queues > * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) > * Gunnar Dalsnes > - * Eric Kohl (ekohl(a)rz-online.de) > + * Eric Kohl > */

14 years, 11 months

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 44861: NMI Support Patch 7: [NTOS]: Improve UNHANDLED_PATH macro with a new "Reason" parameter which displays why the path is unhandled (ie: what the unexpected/unlikely/untested scenario is). This is better than just displaying the current PC which is typically useless. [NTOS]: Separate UNHANDLED_PATH from UNHANDLED_V86_PATH which is specifically for paths that are unimplemented due to lack of VDM support. [HAL]: Update to new macros in V8086 support, and handle

by Alexander Potashev

On 21:03 Fri 01 Jan , ros-arm-bringup(a)svn.reactos.org wrote: > Author: ros-arm-bringup > Date: Fri Jan 1 22:03:22 2010 > New Revision: 44861 > > Modified: trunk/reactos/ntoskrnl/include/internal/i386/asmmacro.S > @@ -87,18 +87,47 @@ > // > // @name UNHANDLED_PATH > // > -// This macro TODO > +// This macro prints out that the current code path is not expected yet > // > // @param None > // > // @remark None. > // > -.macro UNHANDLED_PATH > +.macro UNHANDLED_PATH Reason > + > + /* Push reason */ > + push offset 1f > + > /* Get EIP */ > call $+5 > > /* Print debug message */ > push offset _UnhandledMsg > + call _DbgPrint > + add esp, 12 > + > + /* Loop indefinitely */ > + jmp $ > + > +1: > + .asciz \Reason I think, this should be: .asciz "\Reason" I don't know why, but this line (both variants) doesn't compile for me with RosBE 1.4.2 (Linux): ntoskrnl/ke/i386/trap.s: Assembler messages: ntoskrnl/ke/i386/trap.s:290: Error: junk at end of line, first unrecognized character is `o' ntoskrnl/ke/i386/trap.s:290: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:290: Error: junk at end of line, first unrecognized character is `o' ntoskrnl/ke/i386/trap.s:425: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:425: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:425: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:439: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:439: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:439: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:467: Error: junk at end of line, first unrecognized character is `A' ntoskrnl/ke/i386/trap.s:1677: Error: junk at end of line, first unrecognized character is `R' ntoskrnl/ke/i386/trap.s:1677: Error: junk at end of line, first unrecognized character is `j' ntoskrnl/ke/i386/trap.s:1677: Error: junk at end of line, first unrecognized character is `R' ntoskrnl/ke/i386/trap.s:2415: Error: junk at end of line, first unrecognized character is `c' ntoskrnl/ke/i386/trap.s:2594: Error: junk at end of line, first unrecognized character is `m' make: *** [obj-i386/ntoskrnl/ke/i386/trap_ntoskrnl.o] Error 1 -- Alexander Potashev

14 years, 11 months

Move from GPL Permission Denied

by James Tabor

Public Notice: First and last warning! You do not have my permission to switch from GPL unless it is LGPL! I've coded most of all parts of the project and hold the copyrights with other developers from this project. We have a primary copyright to GPL, take it or leave it! I've imported other projects code into ReactOS and kept and respected their copyrights! Flamed baited by wine for forgetting to pass on copyrights as well and having to recommit them back into code! If it is good for me it is good for you! If you have a problem with this I will have my people contact your people! You have my email address! James

14 years, 11 months

Re: [ros-dev] [ros-diffs] [martinf] 45001: define _tcscpy_s and _tsplitpath_s again for native VC++ builds

by Gabriel ilardi

Hi Martin, With latest changes, after booting to third stage I get two identical message boxes with no text, just "ROS Explorer" as the title and ok (before seeing explorer) after clicking on ok both times explorer comes up. Regards, Gabriel. > Date: Fri, 8 Jan 2010 15:10:50 +0000 > To: ros-diffs(a)reactos.org > From: martinf(a)svn.reactos.org > Subject: [ros-diffs] [martinf] 45001: define _tcscpy_s and _tsplitpath_s again for native VC++ builds > > Author: martinf > Date: Fri Jan 8 16:10:50 2010 > New Revision: 45001 > > URL: http://svn.reactos.org/svn/reactos?rev=45001&view=rev > Log: > define _tcscpy_s and _tsplitpath_s again for native VC++ builds > > Modified: > trunk/reactos/base/shell/explorer/utility/utility.h > > Modified: trunk/reactos/base/shell/explorer/utility/utility.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/utilit… > ============================================================================== > --- trunk/reactos/base/shell/explorer/utility/utility.h [iso-8859-1] (original) > +++ trunk/reactos/base/shell/explorer/utility/utility.h [iso-8859-1] Fri Jan 8 16:10:50 2010 > @@ -194,10 +194,20 @@ > #define strcpy_s(d, l, s) strcpy(d, s) > #define wcscpy_s(d, l, s) wcscpy(d, s) > #define wcsncpy_s(d, l, s, n) wcsncpy(d, s, n) > + > +#if defined(_tcscpy) && !defined(_tcscpy_s) > +#define _tcscpy_s(d, l, s) _tcscpy(d, s) > +#endif > + > +#if defined(_tsplitpath) && !defined(_tsplitpath_s) > +#define _tsplitpath_s(f, d,dl, p,pl, n,nl, e,el) _tsplitpath(f, d, p, n, e) > +#else > +#define _wsplitpath_s(f, d,dl, p,pl, n,nl, e,el) _wsplitpath(f, d, p, n, e) > +#define _splitpath_s(f, d,dl, p,pl, n,nl, e,el) _splitpath(f, d, p, n, e) > +#endif > + > #define _stprintf_s1(b, l, f, p1) _stprintf(b, f, p1) > #define _stprintf_s2(b, l, f, p1,p2) _stprintf(b, f, p1,p2) > -#define _wsplitpath_s(f, d,dl, p,pl, n,nl, e,el) _wsplitpath(f, d, p, n, e) > -#define _splitpath_s(f, d,dl, p,pl, n,nl, e,el) _splitpath(f, d, p, n, e) > > #endif // __STDC_WANT_SECURE_LIB__ > > > _________________________________________________________________ Un mondo di personalizzazioni per Messenger, PC e cellulare http://www.pimpit.it/

14 years, 11 months

Re: [ros-dev] [ros-diffs] [martinf] 44998: update XMLStorage to 2010 version

by Ged Murphy

martinf(a)svn.reactos.org wrote: > -#if defined(__STDC_WANT_SECURE_LIB__) && defined(_MS_VER) // secure CRT functions using VS 2005 > +#ifdef __STDC_WANT_SECURE_LIB__ > if (_tfopen_s(&_pfile, path, mode) != 0) Hi Martin, This change will break the build, reactos now has partial but not full support for secure CRT functions. __STDC_WANT_SECURE_LIB__ is now defined in our build headers, but some areas are missing, _wfopen_s being one of these. I added the '&& defined(_MS_VER)' check to get around this for our build env until we support it. Regards, Ged.

14 years, 11 months

Re: [ros-dev] [ros-priv] [ros-diffs] [ros-arm-bringup] 44841: NMI Support Patch 1: [HAL]: T #2

by Daniel Reimer

And now we all get back to a polite discussion about this topic and stop comparing the lengths of our wieners, ok? I hate the way all this goes to... last time we came to that point in the past, we lost some long term devs and put the whole project into a big crisis. So PLEASE, I just expect a mature talk and no kindergarten from you all. (OK, its a bit funny that I say something like that :-P ) Ros Arm Devs: I understand that you don't wanna tell us who exactly you are are, whatever your reasons are and I accept that, but you have to understand that some here fear harm for the project if ppl noone ever saw write risky components with the highest possibility to copyright problems. Almost every kernel dev in here was suspected to write tainted code at least once in their whole time here. That's the result of some big crisis we had in the past, we became a bit afraid of great code outta nowhere which just works. So don't take it personally, plz. *fearabigdramacoming* Regarding the Devs in the header and the license. Why not just readd the ppl if some of their code still exists in the file? Noone would have any harm if there's one more guy in this list. Lets discuss the relicense after the guys are in the headers again. But, and this goes out to all ppl, in a kind and mature way. You all, forget your "He stepped on my tail!!" behavior just for a moment and think about the project we all code for and we try to get mature. We can talk about anything, but not in this way. Thank you very much. Daniel Reimer Not soo 1337 ReactOS Dev

14 years, 11 months

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 44841: NMI Support Patch 1: [HAL]: The I/O Permissions Map on a typical Privileged Mode x86 OS is all 0xFF's, so it's quite wasteful to copy-in/out the entire map each single BIOS Call. As an optimization, only save and restore non-0xFF entries. [NTOS]: Define and use constants for different IOPM values, instead of using hardcoded values.

by Alex Ionescu

"You may relicense my code as BSD" != "You make strip away copyright/ownership of my code". Revert this. On 2009-12-31, at 6:51 PM, ros-arm-bringup(a)svn.reactos.org wrote: > > - * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) > + * PROGRAMMERS: ReactOS Portable Systems Group Best regards, Alex Ionescu

14 years, 11 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 44974: [freeldr] - Do not use GetSystemMemorySize(), which truncates size to 32 bit. - Other minor changes.

by Aleksey Bragin

On Jan 6, 2010, at 2:44 PM, dgorbachev(a)svn.reactos.org wrote: > - // Always contigiously map low 1Mb of memory > + // Always contiguously map low 1Mb of memory Thanks for fixing my typos ;)

14 years, 11 months

Unable to compile; infcore error

by Evans Jahja

Hi, I'm trying to compile React OS, however I encountered this error when I'm trying to compile: [HOST-CC] lib/inflib/infcore.c lib/inflib/infcore.c: In function `InfpAddSection': lib/inflib/infcore.c:184: warning: implicit declaration of function `__builtin_offsetof' lib/inflib/infcore.c:184: error: parse error before "INFCACHESECTION" lib/inflib/infcore.c:184: error: parse error before ']' token lib/inflib/infcore.c: In function `InfpAddFieldToLine': lib/inflib/infcore.c:289: error: parse error before "INFCACHEFIELD" lib/inflib/infcore.c:289: error: parse error before ']' token make: *** No rule to make target `makefile.auto', needed by `all'. Stop. Please help me, thanks. Evans Get your new Email address! Grab the Email name you've always wanted before someone else does! http://mail.promotions.yahoo.com/newdomains/aa/

14 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev January 2010