Ros-dev April 2010

ros-dev@reactos.org

28 participants
35 discussions

Re: [ros-dev] [ros-diffs] [tkreuzer] 46998: Disable gdi batch for SelectObject with fonts. Fixes font regression.

by Gabriel ilardi

Hi Jim, Please don't take this personal, the code has been #iffed out not reverted. I agree with you that we should keep good code, problem is that lately someone introduces a regression with new or modified code (even correct), and the regression stays there forever, we should try to avoid such a case. In this specific case we know the gdibatch code introduced that regression, so my suggestion is: do the commit anyway with a specific roadmap to fix the regression or disable it temporary until the regression is fixed. Perception is really important, what's gonna think about ros someone that tried it before, now after a new release tries it again and sees that what was working before doesn't work anymore or works worse than it did, your references are a good example of this scenario, but see also: 4461 Regression: Notepad Lite doesn't install 4677 Regression: Can't restore minimized windows 4948 Regression: Can't close locale dialog 5276 Regression: shell about dialog doesn't display header bitmap And there are more... I'm not gonna blame win32k only here as regressions are not its exclusivity, it's funny that before uniata we were suggesting people to rename uniata to atapi to test in boxes with sata controllers, now we do the oposite (atapi -> uniata )to let people test in pata. I've mentioned in ros-dev also that ros takes more than 2 minutes in my virtual machine to install when it tooks some seconds before (two hd attached to the primary channel), I'm not able to test ros so frequently now because of this. I've also mentioned that AC97 stopped working, has regressed for several reasons several revisions away, now I'm not being prompted anymore for its driver as 46998... We can't keep working like this, testers should work in a coordinated way with developers, both of them are important, there aren't many skilled testers to be honest just take a look at bugzilla... Sometimes I test and see regressions and don't know what to do anymore, stop testing, tell ros-dev, bug the dev, give up... Gabriel. > Date: Thu, 22 Apr 2010 20:47:52 -0500 > From: jimtabor.rosdev(a)gmail.com > To: ros-dev(a)reactos.org > Subject: [ros-dev] [ros-diffs] [tkreuzer] 46998: Disable gdi batch for SelectObject with fonts. Fixes font regression. > > Not surprised! > > I guess ReactOS new polices are for hiding the real issues and not > fixing them and revert all the correct code. Since the kernel rewrites > and the new order of coding, these oddities have now surfaced. The > TEB, is inaccessible from kernel mode as in bug 5265 and 5314, and the > strange processes access issues in bug 5310. This revert silliness > will result in moving the project back to post windows 95 architecture > (arwinss). ReactOS is about moving forward and taking chances with > innovations from learned information then moving away to make it work > even better. Personally, I hope someone will take up where this left > off and move on. > > Good luck! > > Reference: > > http://www.reactos.org/bugzilla/show_bug.cgi?id=5265 > http://www.reactos.org/bugzilla/show_bug.cgi?id=5310 > http://www.reactos.org/bugzilla/show_bug.cgi?id=5314 > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev _________________________________________________________________ Messenger e Hotmail in tasca. Provali sul tuo cellulare! http://new.windowslivemobile.msn.com/it-it/Default.aspx

14 years, 8 months

Re: [ros-dev] [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources

by Andrew Faulds

Isn't that just a audio driver regression not an Install wizard one? "Starting a device node without DNF_ADDED" On 22 April 2010 14:09, Gabriel ilardi <gabrielilardi(a)hotmail.it> wrote: > Hi, > Device installation wizard has regressed again, now if you try to install > the AC97 driver, it remains in a loop, and ros slows down at the point of > being unusabe, > the debug log shows: > > (ntoskrnl/io/pnpmgr/pnpmgr.c:190) Warning: Starting a device node without > DNF_ADDED or DNF_ENUMERATED (Root\LEGACY_kmixer\0000) > > Thanks, > > Gabriel. > > > Date: Wed, 21 Apr 2010 22:33:12 +0000 > > To: ros-diffs(a)reactos.org > > From: cgutman(a)svn.reactos.org > > Subject: [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken > CM_RESOURCE_LIST_SIZE with a better function that actually works with > resource lists that have device-specific data in them (fixes missing device > specific data when resources are retrieved with IoGetDeviceProperty) - > Separate the resource code out of pnpmgr.c and into pnpres.c - Simplify > resource assigning to simply calling one function, IopAssignDeviceResources, > which takes care of the registry configuration, translation, etc. - Set the > DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not > before - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails - Fix a bug in > IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > > > Author: cgutman > > Date: Thu Apr 22 00:33:11 2010 > > New Revision: 46983 > > > > URL: http://svn.reactos.org/svn/reactos?rev=46983&view=rev > > Log: > > [NTOSKRNL] > > - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that > actually works with resource lists that have device-specific data in them > (fixes missing device specific data when resources are retrieved with > IoGetDeviceProperty) > > - Separate the resource code out of pnpmgr.c and into pnpres.c > > - Simplify resource assigning to simply calling one function, > IopAssignDeviceResources, which takes care of the registry configuration, > translation, etc. > > - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is > actually started not before > > - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails > > - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to > wrong place > > > > Added: > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c (with props) > > Modified: > > trunk/reactos/ntoskrnl/include/internal/io.h > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c > > trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c > > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild > > ------------------------------ > Condividi le tue emozioni e proteggi la tua privacy. Chiacchiera su > Messenger <http://www.windowslive.it/importaAmici.aspx> > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Andrew Faulds (andrewros) http://ajf.me/

14 years, 8 months

Improvement: Foxit Reader 2.1

by victor martinez

After asking in ReactOS-dev what is the antonym of "Regression" (thanks DosX for telling me :) ), I am glad to show you an "IMPROVEMENT". It´s easy to complain about Regressions but we should try to show our little improvements. Congrats to our Devs because their efforts :) == Foxit Reader 2.1 is much more usable. 0.3.11 screenshot vs Trunk screenshot.== Screenshot: http://img696.imageshack.us/img696/8839/foxit2.jpg _________________________________________________________________ Tus datos personales, más seguros con Internet Explorer 8. http://www.microsoft.com/spain/windows/internet-explorer/default.aspx

14 years, 8 months

by Gabriel ilardi

Hi, Device installation wizard has regressed again, now if you try to install the AC97 driver, it remains in a loop, and ros slows down at the point of being unusabe, the debug log shows: (ntoskrnl/io/pnpmgr/pnpmgr.c:190) Warning: Starting a device node without DNF_ADDED or DNF_ENUMERATED (Root\LEGACY_kmixer\0000) Thanks, Gabriel. > Date: Wed, 21 Apr 2010 22:33:12 +0000 > To: ros-diffs(a)reactos.org > From: cgutman(a)svn.reactos.org > Subject: [ros-diffs] [cgutman] 46983: [NTOSKRNL] - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources are retrieved with IoGetDeviceProperty) - Separate the resource code out of pnpmgr.c and into pnpres.c - Simplify resource assigning to simply calling one function, IopAssignDeviceResources, which takes care of the registry configuration, translation, etc. - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not before - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > Author: cgutman > Date: Thu Apr 22 00:33:11 2010 > New Revision: 46983 > > URL: http://svn.reactos.org/svn/reactos?rev=46983&view=rev > Log: > [NTOSKRNL] > - Replace the broken CM_RESOURCE_LIST_SIZE with a better function that actually works with resource lists that have device-specific data in them (fixes missing device specific data when resources are retrieved with IoGetDeviceProperty) > - Separate the resource code out of pnpmgr.c and into pnpres.c > - Simplify resource assigning to simply calling one function, IopAssignDeviceResources, which takes care of the registry configuration, translation, etc. > - Set the DNF_NEED_ENUMERATION_ONLY flag only AFTER the device is actually started not before > - Set DNF_START_FAILED if IRP_MN_START_DEVICE fails > - Fix a bug in IoReportDetectedDevice that wrote the AllocConfig value to wrong place > > Added: > trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c (with props) > Modified: > trunk/reactos/ntoskrnl/include/internal/io.h > trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c > trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c > trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild _________________________________________________________________ Messenger e Hotmail in tasca. Provali sul tuo cellulare! http://new.windowslivemobile.msn.com/it-it/Default.aspx

14 years, 8 months

test/fix building fastfat_new

by Alexey Komarov

Hi. Can somebody test/fix building fastfat_new? It seems, that it's problem with headers. Log: [CC] drivers\filesystems\fastfat_new\fastio.c [CC] drivers\filesystems\fastfat_new\fcb.c cc1.exe: warnings being treated as errors drivers\filesystems\fastfat_new\fcb.c: In function 'FatFindFcb': drivers\filesystems\fastfat_new\fcb.c:85: error: implicit declaration of functio n 'RtlLeftChild' drivers\filesystems\fastfat_new\fcb.c:85: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c:90: error: implicit declaration of functio n 'RtlRightChild' drivers\filesystems\fastfat_new\fcb.c:90: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c:95: error: implicit declaration of functio n 'RtlSplay' drivers\filesystems\fastfat_new\fcb.c:95: error: assignment makes pointer from i nteger without a cast drivers\filesystems\fastfat_new\fcb.c: In function 'FatInsertName': drivers\filesystems\fastfat_new\fcb.c:904: error: implicit declaration of functi on 'RtlInitializeSplayLinks' drivers\filesystems\fastfat_new\fcb.c:946: error: implicit declaration of functi on 'RtlInsertAsLeftChild' drivers\filesystems\fastfat_new\fcb.c:963: error: implicit declaration of functi on 'RtlInsertAsRightChild' drivers\filesystems\fastfat_new\fcb.c: In function 'FatRemoveNames': drivers\filesystems\fastfat_new\fcb.c:993: error: implicit declaration of functi on 'RtlDelete' drivers\filesystems\fastfat_new\fcb.c:993: error: assignment makes pointer from integer without a cast drivers\filesystems\fastfat_new\fcb.c:1002: error: assignment makes pointer from integer without a cast make.exe: *** [obj-i386\drivers\filesystems\fastfat_new\fcb_fastfatn.o] Error 1 WBR, Alexey Komarov.

14 years, 8 months

0.3.12 Changelog opened.

by victor martinez

Hi, i am happy of telling you that "0.3.12 Changelog" has been opened to recive all your commits in an ordered way. 0.3.11 was released on 16 December(2009), more than 4 months ago, this means a huge number of commits that we have to order before we can make attempts to create a 0.3.12 release. The link is(as usual): http://www.reactos.org/wiki/ChangeLog-0.3.12 I hope opening the Changelog before trying to release will help to solve the Changelog bottleneck and will give us more time to create it. Let´s move towards 0.3.12... Thanks for your minute :) _________________________________________________________________ Recibe un SMS de tu Hotmail vayas donde vayas. ¡Date de alta! http://home.mobile.live.com/MobileAttach.mvc/?mkt=es-es

14 years, 8 months

[ros-diff]rev 46907.gschneider[SHELL32] - Simplify checks for success of ShellExecuteEx

by victor martinez

Hi, i have been giving a look to this patch and i have some doubts(just learning :) ) The code is: @@ -1298,8 +1298,8 @@ static HRESULT WINAPI ICPanel_IContextMenu2_InvokeCommand( sei.hwnd = lpcmi->hwnd; sei.nShow = SW_SHOWNORMAL; sei.lpVerb = L"open"; - ShellExecuteExW(&sei); - if (sei.hInstApp <= (HINSTANCE)32) + + if (ShellExecuteExW(&sei) == FALSE) return E_FAIL; MSDN says that if ShellExecuteExW fails it sets hInstApp to a value lower than 32 and,also, returns FALSE. (MSDN: http://msdn.microsoft.com/en-us/library/bb762154(VS.85).aspx ) So both lines of codes(buggy and patched) are,at first sight,doing the same.Just using a different way. The Commit says: - Simplify checks for success of ShellExecuteEx, field hInst may be an unreliable indicator according to http://msdn.microsoft.com/en-us/library/bb759784%28v=VS.85%29.aspx Why is it unreliable? :) I am not saying it is reliable, just that i dont find the reason there...my skills are limited.. :( I have just found: "Although hInstApp is declared as an HINSTANCE for compatibility with 16-bit Windows applications, it is not a true HINSTANCE. It can be cast only to an int and compared to either 32 or the following SE_ERR_XXX error codes ". So my question is: Is the Bug in the cast to (HINSTANCE) instead to (INT)?I mean,do this solve the bug too?: - if (sei.hInstApp <= (HINSTANCE)32) + if ((INT)sei.hInstApp <= 32) As you see i am just learning, so thanks in advance. And yes, i prefer the new way that patch is using.Using the returned the value seems much more logic than using a "collateral damage". :) Btw, thanks Gregor for your hunting-fixing week ;) _________________________________________________________________ ¡Citas! ¡Ligues! ¿Salimos? ¿Cómo es tu pareja ideal? Búscala en el sitio nº1… ¡Regístrate ya! http://contactos.es.msn.com/?mtcmk=015352

14 years, 8 months

Commit by sir_richard :: r46904 reactos/ntoskrnl/mm/ARM3/miarm.h

by breakoutbox

Hello, "[NTOS]: 1MB is not 1000 * 1KB... " http://en.wikipedia.org/wiki/Megabyte 1 KB = 1000 byte (decimal) 1 KiB = 1024 byte (binary) 1 MB = 1000 KB 1 MiB = 1024 KiB Would be nice if ReactOS goes across the border and also uses the modern SI unit definitions ;-) If in code definitions or shown as text to the user .. Cheers, Peter

14 years, 8 months

[ros-diffs] [fireball] 46914: - Get rid of the last hardcoded screen size. - Remove unnecessary function declaration. See issue #5304 for more details.

by James Tabor

For one that bitches about trunk being broken all the time and punish everyone trying to get it fixed! Why not push this much effort to help fix the same issue in trunk.... Or is it done so truck stays broken?

14 years, 8 months

Re: [ros-dev] [ros-diffs] [mpiulachs] 46862: My first commit in a very long time. I'm releasing the source code of my C# implementation of Rbuild by popular demand :) I would have preferred to release the code under a BSD licence but there is a small

by Sir Gallantmon (ニール・ゴンパ)

Does this work under Mono? AFAIK, Mono supports C# 3.5 and C# 4.0 language features.... so...? On Sat, Apr 17, 2010 at 7:56 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > Official URL for that component is http://dev.skybound.ca/download.aspx > Just for reference, it indeed crashes when running the HTML report backend, > I'm investigating this in the free time. > > WBR, > Aleksey. > > > On Apr 14, 2010, at 6:41 PM, Ged Murphy wrote: > > It partially works. >> Can't build the designer due to a Skybound.VisualStyles dependency. I >> assume we get that from here? >> http://windowsclient.net/downloads/folders/controlgallery/entry1590.aspx >> >> It then crashes when running the html report >> >> Just in case you were interested.... >> >> Ged. >> >> -----Original Message----- >> From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] >> On Behalf Of mpiulachs(a)svn.reactos.org >> Sent: 13 April 2010 23:00 >> To: ros-diffs(a)reactos.org >> Subject: [ros-diffs] [mpiulachs] 46862: My first commit in a very long >> time. I'm releasing the source code of my C# implementation of Rbuild by >> popular demand :) I would have preferred to release the code under a BSD >> licence but there is a small portion of ancient >> >> Author: mpiulachs >> Date: Tue Apr 13 23:59:21 2010 >> New Revision: 46862 >> >> URL: http://svn.reactos.org/svn/reactos?rev=46862&view=rev >> Log: >> My first commit in a very long time. I'm releasing the source code of my >> C# implementation of Rbuild by popular demand :) I would have preferred to >> release the code under a BSD licence but there is a small portion of ancient >> Nant GPL code that would have been to be rewritten first. >> >> There are two executables (SysGen.Designer) and (SysGen.Make) >> >> SysGen.Designer is a windows forms tool that allows to generate customized >> reactos images, it is similar in concept to Windows CE Platfom Builder. >> SysGen.Make is the actual Rbuild clone, It has three main parts, the .rbuild >> file parser + in-memory tree representation, the backends , and the auto >> generated files. The Mingw backend used to work 1'5 years ago and produced a >> 100% valid makefile.auto but have to be updated to be able to build a recent >> revision. Rewriting parts of it to take advantage of C# 3.5 extension >> methods would probably reduce the code by 50%. The other two parts are quite >> stable. >> >> This code was only a proof of concept and was never intended to be >> released so there is a ton of unpolished code and hacks required by the >> current C++ implementation that should be removed. >> >> How to test it: >> >> Select SysGen.Make as the Start-up Project in Visual Studio and edit >> Program.cs to point to the correct path to ReactOS-i386.rbuild Edit >> SysGenEngine.cs:639 to enable/disable specific backends, The HtmlBackend in >> \SysGen.BuildEngine\Backends\Html\HtmlBackend.cs is a very simple >> illustration of how powerful this framework is. >> >> Happy hacking! >> >> >> >> >> _______________________________________________ >> Ros-dev mailing list >> Ros-dev(a)reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

14 years, 8 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev April 2010