Ros-dev April 2010

ros-dev@reactos.org

28 participants
35 discussions

Re: [ros-dev] [ros-diffs] [jimtabor] 46758: [Win32k|Gdi32] - Enable font batch and fixed setting brush origion. Use the new delete object functions in win32k.

by Timo Kreuzer

> + > +#define GDIOBJ_GetKernelObj(Handle) \ > + ((PGDI_TABLE_ENTRY)&GdiHandleTable->Entries[GDI_HANDLE_GET_INDEX(Handle)])->KernelData > This function shouldn't even exist. > pdcattr->hlfntNew = NtGdiGetStockObject(SYSTEM_FONT); > TextIntRealizeFont(pdcattr->hlfntNew,NULL); > + NewDC->hlfntCur = pdcattr->hlfntNew; > + NewDC->dclevel.plfnt = GDIOBJ_GetKernelObj(pdcattr->hlfntNew); > Looks like a good way to introduce bugs. There's a reason we have locking functions. The fact that in this case it's a stockfont that won't get deleted, doesn't mean we can do this always. If you want performance, keep a global pointer to the font and use GDIOBJ_IncrementShareCount

14 years, 12 months

Spanish translation for the new log off confirmation dialog (bug 1494, revision r46722)

by Javier Agustìn Fernàndez Arroyo

@DosX, hi, i updated bug #1494 with the spanish translation updated... translation URL is http://www.reactos.org/bugzilla/attachment.cgi?id=4882 hope its correct :)

14 years, 12 months

[ros-diffs] [jgardou] 46698: [WIN32K] Unlock surface when deleting DC

by James Tabor

Since no one is listening (reading) to me about this issue and the response I receive is "WTF are you talking about"! Let me explain one more time..... In reference to commit 46679, I attempted to provide the project an example on how information contexts (IC) are created and removed. Works as a toggle between switching flags and moving the pdc->dclevel.pSurface pointer to and from pdc->pSurfInfo. The name of pSurfInfo should give a good clue. I was surprised when no one on IRC knew anything about this and it explains why the yarotows branch is not taking this into consideration. Remember my rant? Building code from broke code creates more broken code! Thus, increasing the amount of wasted time rewriting it. --- branches/reactos-yarotows/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] Sat Apr 3 18:42:04 2010 @@ -377,6 +377,9 @@ PATH_Delete(pdc->dclevel.hPath); + if(pdc->dclevel.pSurface) + SURFACE_ShareUnlockSurface(pdc->dclevel.pSurface); + PDEVOBJ_vRelease(pdc->ppdev) ; return TRUE; __________ Need to check for DC_TYPE_INFO and sometimes for DC_FLAG_TEMPINFODC. Quick check for pSurfInfo if NULL might be helpful too. I'm keeping track of yarotows and I see some needed merging into trunk (head, main branch) soon. 46630 is a good start. Thanks, James Referance: [ros-diffs] [jimtabor] 46679: [Win32k] - Implement MakeInfoDC and support functions. Dedicated to Timo. http://www.reactos.org/archives/public/ros-diffs/2010-April/036412.html

14 years, 12 months

Re: [ros-dev] [ros-diffs] [jgardou] 46505: svn will drive me nuts, part 1/x

by Ged Murphy

This is not a valid commit message... -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of jgardou(a)svn.reactos.org Sent: 27 March 2010 23:28 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [jgardou] 46505: svn will drive me nuts, part 1/x Author: jgardou Date: Sun Mar 28 00:28:24 2010 New Revision: 46505 URL: http://svn.reactos.org/svn/reactos?rev=46505&view=rev Log: svn will drive me nuts, part 1/x Added: branches/reactos-yarotows/drivers/bus/acpi/eval.c (with props) branches/reactos-yarotows/drivers/bus/acpi/interface.c (with props) branches/reactos-yarotows/drivers/storage/scsiport/scsiport.pspec (with props) branches/reactos-yarotows/drivers/storage/scsiport/stubs.c (with props) branches/reactos-yarotows/hal/halx86/up/pic.c (with props) branches/reactos-yarotows/hal/halx86/up/processor.c (with props) branches/reactos-yarotows/include/dxsdk/bdatif.idl branches/reactos-yarotows/include/ndk/peb_teb.h (with props) Modified: branches/reactos-yarotows/ (props changed) branches/reactos-yarotows/drivers/bus/acpi/cmbatt/cmbpnp.c branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.c branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.h branches/reactos-yarotows/drivers/bus/acpi/compbatt/comppnp.c branches/reactos-yarotows/media/inf/machine.inf branches/reactos-yarotows/ntoskrnl/io/pnpmgr/pnpmgr.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/reactos-yarotows/drivers/bus/acpi/cmbatt/cmbpnp.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/compbatt.h URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Modified: branches/reactos-yarotows/drivers/bus/acpi/compbatt/comppnp.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/bus/acpi/eval.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/bus/acpi/interface.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/bus/ac… Added: branches/reactos-yarotows/drivers/storage/scsiport/scsiport.pspec URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/storag… Added: branches/reactos-yarotows/drivers/storage/scsiport/stubs.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/drivers/storag… Added: branches/reactos-yarotows/hal/halx86/up/pic.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/hal/halx86/up/… Added: branches/reactos-yarotows/hal/halx86/up/processor.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/hal/halx86/up/… Added: branches/reactos-yarotows/include/dxsdk/bdatif.idl URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/include/dxsdk/… Added: branches/reactos-yarotows/include/ndk/peb_teb.h URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/include/ndk/pe… Modified: branches/reactos-yarotows/media/inf/machine.inf URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/media/inf/mach… Modified: branches/reactos-yarotows/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/ntoskrnl/io/pn…

15 years

Re: [ros-dev] [ros-diffs] [tkreuzer] 46677: Remove svn:mergeinfo property from several files

by Colin Finck

tkreuzer(a)svn.reactos.org wrote: > Remove svn:mergeinfo property from several files We should rather try to eliminate the root of these constant merge artifacts, which seem to be the remaining svn:keywords properties. As these ones instruct Subversion to update the revision number in the affected files, they probably also include the revision numbers of merges maintained by svn:mergeinfo. I've already removed some svn:keywords properties in the same files (for example in r41694), but I believe that this doesn't help much unless the properties are also removed in all branches we use for merging. Cheers, Colin

15 years

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev April 2010