- Ros-dev - ReactOS.org

Re: [ros-dev] [ros-diffs] [pschweitzer] 50612: [NTOSKRNL/PPC] Fix the fix, spotted by "ThFabba" on IRC

by Timo Kreuzer

Under "normal conditions" sizeof of an array covers the whole array. is this different for function paramters? Am 06.02.2011 14:50, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Feb 6 13:50:57 2011 > New Revision: 50612 > > URL: http://svn.reactos.org/svn/reactos?rev=50612&view=rev > Log: > [NTOSKRNL/PPC] > Fix the fix, spotted by "ThFabba" on IRC > > Modified: > trunk/reactos/ntoskrnl/ke/powerpc/cpu.c > > Modified: trunk/reactos/ntoskrnl/ke/powerpc/cpu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/cpu.c?… > ============================================================================== > --- trunk/reactos/ntoskrnl/ke/powerpc/cpu.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/powerpc/cpu.c [iso-8859-1] Sun Feb 6 13:50:57 2011 > @@ -44,7 +44,7 @@ > CPUID(IN ULONG CpuInfo[4], > IN ULONG InfoType) > { > - RtlZeroMemory(CpuInfo, sizeof(CpuInfo) * sizeof(ULONG)); > + RtlZeroMemory(CpuInfo, 4 * sizeof(ULONG)); > } > > VOID > > >

14 years, 7 months

3
2
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 50605: [WIN32K] Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. Fixes bug 2372

by Gabriel ilardi

What about the patch in that bug http://www.reactos.org/bugzilla/attachment.cgi?id=1568 :) ? > Date: Fri, 4 Feb 2011 13:53:50 +0000 > To: ros-diffs(a)reactos.org > From: tkreuzer(a)svn.reactos.org > Subject: [ros-diffs] [tkreuzer] 50605: [WIN32K] Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. Fixes bug 2372 > > Author: tkreuzer > Date: Fri Feb 4 13:53:49 2011 > New Revision: 50605 > > URL: http://svn.reactos.org/svn/reactos?rev=50605&view=rev > Log: > [WIN32K] > Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. > Fixes bug 2372 > > Modified: > trunk/reactos/subsystems/win32/win32k/eng/xlate.c > > Modified: trunk/reactos/subsystems/win32/win32k/eng/xlate.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/eng/xlate.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/eng/xlate.c [iso-8859-1] Fri Feb 4 13:53:49 2011 > @@ -91,7 +91,7 @@ > iColor >>= 13; > iNewColor |= iColor & 0x3E0; > > - /* Copy green */ > + /* Copy blue */ > iColor >>= 13; > iNewColor |= iColor & 0x1F; > > @@ -417,11 +417,11 @@ > pexlo->aulXlate[0] = > PALETTE_ulGetNearestPaletteIndex(ppalSrc, crSrcBackColor); > } > + else if (ppalSrc->flFlags & PAL_RGB) > + { > + pexlo->aulXlate[0] = crSrcBackColor; > + } > else if (ppalSrc->flFlags & PAL_BGR) > - { > - pexlo->aulXlate[0] = crSrcBackColor; > - } > - else if (ppalSrc->flFlags & PAL_RGB) > { > pexlo->aulXlate[0] = RGB(GetBValue(crSrcBackColor), > GetGValue(crSrcBackColor), > >

14 years, 7 months

2
1
0 0

ReactOS Project at Chemnitzer Linux-Tage 2011

by Colin Finck

Hi all, Even if it has already been reported through the newsletter, here is the announcement for mailing list readers: The ReactOS Project will have a booth at the Chemnitzer Linux-Tage 2011, the second-largest Open-Source-related exhibition in Germany, from 19th to 20th March. Our project is going to be represented by the ReactOS developers Colin Finck, Timo Kreuzer, Matthias Kupfer, Daniel Reimer and Christoph von Wittich. This year, we will also be joined by Kai Tietz from the MinGW-w64 Project. Like in the last years, you will be able to try out the latest development state of ReactOS as well as getting some merchandising articles. So if you have the time to visit Chemnitz, stop by and say hello at our booth. Cheers, Colin

14 years, 7 months

1
0
0 0

About debugging ROS

by Xu Liu

I am just a new person who wants to debug ROS, so my questions may be stupid. I have checked http://www.reactos.org/wiki/Debugging . It seems the main debugging way is "Debugging through text messages" (I think it is more like "checking logs"). If I want to use GDB, I have to use QEMU. Would you please tell me is Kdbg the only way to debug code in VMWare or VirtualBox? And if I want to debug ReactOS, do I have to install QEMU or VMWare or VirtualBox? Using "make install" in RosBE can generate many binary files. Is there any build-in way to start ROS from these bin files without any virtual machine? Thank you in advance.

14 years, 7 months

3
4
0 0

BuildBot changes

by Colin Finck

Hello all, As you have certainly noticed, Amine, Olaf and me have upgraded the BuildBot some days ago. While doing this, we have added Olaf's build slaves which used to be available at http://reactos.ath.cx:8081. The new BuildBot version finally enables authenticated access for features like forcing a build. When you want to do this now, you have to enter your SVN credentials into the respective fields. If you are a tester and need these BuildBot features, please ask Aleksey or me for getting the appropriate credentials. In the next few days, we're probably going to make the testing results of his CMake bot available at http://reactos.org/testman and upload his builds to http://iso.reactos.org. I might also change the BuildBot Web page design. Now that the main part has got wider, we might remove the ReactOS design around it to get some space for the real important stuff. - Colin

14 years, 7 months

4
4
0 0

Re: [ros-dev] [ros-diffs] [spetreolle] 50454: [CMAKE] Use cmake subversion capabilities to generate buildno.h and version.h.

by Colin Finck

spetreolle(a)svn.reactos.org wrote: > + subversion_wc_info(${CMAKE_CURRENT_SOURCE_DIR} SVNINFO) This will fail when we're not inside a working copy (see http://www.vtk.org/Bug/view.php?id=10200), because the macro outputs an error in this case. Please take a look into http://svn.reactos.org/svn/project-tools/trunk/rosev_ircsystem/src/CMakeLis… to see how you can easily reimplement this step properly. Apart from that, nice to see that we finally get rid of this old stuff! :-) - Colin

14 years, 7 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 50443: [GDI32] Fix broken portable implementation of _lrintf, 2nd try :)

by Aleksey Bragin

I bet _lrintf just needed more underscores! ;) On Jan 19, 2011, at 9:10 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Wed Jan 19 18:10:50 2011 > New Revision: 50443 > > URL: http://svn.reactos.org/svn/reactos?rev=50443&view=rev > Log: > [GDI32] > Fix broken portable implementation of _lrintf, 2nd try :) > > Modified: > trunk/reactos/dll/win32/gdi32/include/gdi32p.h > > Modified: trunk/reactos/dll/win32/gdi32/include/gdi32p.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ > gdi32/include/gdi32p.h?rev=50443&r1=50442&r2=50443&view=diff > ====================================================================== > ======== > --- trunk/reactos/dll/win32/gdi32/include/gdi32p.h [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/gdi32/include/gdi32p.h [iso-8859-1] Wed > Jan 19 18:10:50 2011 > @@ -413,7 +413,7 @@ > } > #else > /* slow, but portable */ > - return (int)(x >= 0 ? x+0.5 : x-0.5); > + return (int)(f >= 0 ? f+0.5 : f-0.5); > #endif > } > > >

14 years, 8 months

1
0
0 0

Getting a Windows Server 2003 license for the project?

by Colin Finck

Hi everybody, I've been thinking about getting a license of an English Windows Server 2003 Standard 32-Bit for the project. It could be installed on one of our servers and be made available over RDP. This would enable project members to do development and testing work on our actual target platform. Considering that some developers even use a non-Windows platform for development work, it might simplify their work as well. We may as well use the license for other purposes (Buildslave, Testslave, whatever), but at least native building could be done by any Windows version. And in this case, I might be able to donate an XP Pro license myself (German though). As I don't know about the needs of the other members, I'd like to hear your opinion about my idea. It would also be nice to hear if anybody knows a cheap (but legal!) way to get such a license or can even donate one (e.g. unused OEM license shipped with a server, unused license after getting Server 2008, etc.) English Windows licenses are rare/expensive on German eBay, so this would only be a last resort :-) Cheers, Colin P.S.: If you have the opposite problem and actually need a Linux VM available over SSH/RDP (e.g. for testing build system changes), just let me know and I could set it up.

14 years, 8 months

12
32
0 0

Re: [ros-dev] [ros-diffs] [mkupfer] 50398: - Fix draw of cursors in static controls - Last part of fix for bug #4874

by Timo Kreuzer

Shouldn't that work the same way (at least if there is any hbmColor)? Cursors can have a different size as well, so maybe we should rather query the hbmMask, if hbmColor is 0(=) I didn't bother reading the context of the function though. Am 16.01.2011 13:51, schrieb mkupfer(a)svn.reactos.org: > Author: mkupfer > Date: Sun Jan 16 12:51:14 2011 > New Revision: 50398 > > URL: http://svn.reactos.org/svn/reactos?rev=50398&view=rev > Log: > - Fix draw of cursors in static controls > - Last part of fix for bug #4874 > > Modified: > trunk/reactos/dll/win32/user32/controls/static.c > > Modified: trunk/reactos/dll/win32/user32/controls/static.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… > ============================================================================== > --- trunk/reactos/dll/win32/user32/controls/static.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/user32/controls/static.c [iso-8859-1] Sun Jan 16 12:51:14 2011 > @@ -863,7 +863,15 @@ > else > { > BITMAP bm; > - if (!GetObjectW(info.hbmColor, sizeof(BITMAP),&bm)) return; > + if (info.fIcon) > + { > + GetObjectW(info.hbmColor, sizeof(BITMAP),&bm); > + } > + else > + { > + bm.bmWidth = GetSystemMetrics(SM_CXCURSOR); > + bm.bmHeight = GetSystemMetrics(SM_CYCURSOR); > + } > if (style& SS_CENTERIMAGE) > { > iconRect.left = (rc.right - rc.left) / 2 - bm.bmWidth / 2; > > >

14 years, 8 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [weiden] 50396: Portability bugfixes

by Ged Murphy

Thomas the 2nd?? On 16 January 2011 01:32, <weiden(a)svn.reactos.org> wrote: > Author: weiden > Date: Sun Jan 16 01:32:45 2011 > New Revision: 50396 > > URL: http://svn.reactos.org/svn/reactos?rev=50396&view=rev > Log: > Portability bugfixes > > Modified: > trunk/reactos/lib/rtl/srw.c > > Modified: trunk/reactos/lib/rtl/srw.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/srw.c?rev=50396&r1… > > ============================================================================== > --- trunk/reactos/lib/rtl/srw.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/srw.c [iso-8859-1] Sun Jan 16 01:32:45 2011 > @@ -131,7 +131,7 @@ > } >

14 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [gadamopoulos] 50381: [rosautotest] -Implement closing any dialog that shows and stays visible for some time. This way rosautotest can now continue if a test application crashes or asserts.

by Timo Kreuzer

Am 13.01.2011 10:58, schrieb gadamopoulos(a)svn.reactos.org: > Author: gadamopoulos > Date: Thu Jan 13 09:58:04 2011 > New Revision: 50381 > > URL: http://svn.reactos.org/svn/reactos?rev=50381&view=rev > Log: > [rosautotest] > -Implement closing any dialog that shows and stays visible for some time. This way rosautotest can now continue if a test application crashes or asserts. > Seems it causes a regression in testbot: *http://www.reactos.org/testman/compare.php?ids=4355,4356 *

14 years, 8 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [fireball] 50309: [HEAP] - Fix a typo (assignment) in the ASSERT, spotted by Johannes Anderwald.

by Ged Murphy

fireball(a)svn.reactos.org wrote: > if (Locked) RtlLeaveHeapLock(Heap->LockVariable); > + DbgBreakPoint(); > return FALSE; Doh

14 years, 8 months

3
2
0 0

coordinate transformation

by Timo Kreuzer

Hi, I'm currently working on the coordinate transformation code in win32k. While Windows does this in win32k, I wonder why its not done in user mode and if we could depart from windows design here. The advantages would be decreased complexity in the kernel and no use of floating point emulation on x86 (better performance). Are there any things that would make it unreasonable? I don't plan to go and change this now, I just like to discuss whether we might or might not do that at some point. Timo

14 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 50243: [CMAKE] Add generation of a depencency graph for shared libraries. The output is a graphml file. Can be enabled with GENERATE_DEPENDENCY_GRAPH switch.

by Ged Murphy

I didn't know about this feature. Will this help the effort towards a minwin effort in fixing the dependency hierarchy (mess)? Ged. On 31 December 2010 16:49, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Fri Dec 31 16:49:49 2010 > New Revision: 50243 > > URL: http://svn.reactos.org/svn/reactos?rev=50243&view=rev > Log: > [CMAKE] > Add generation of a depencency graph for shared libraries. > The output is a graphml file. Can be enabled with GENERATE_DEPENDENCY_GRAPH > switch. > >

14 years, 8 months

3
3
0 0

Is Testman and DBG-Server on strike or on Christmas holidays?

by victor martinez

I have asked several times in #reactos and in #reactos-dev channels, so now time to ask again here: What happens with the server? We are commiting a lot ( more than 25 commits/days last days) and we dont know if: 1)One of those commits (hopefully not) has broken building.. 2)One of those commits (hopefully not) has broken booting.. Both of these are pain in the a...if regtesting is needed. So: Can anyone fix this situation asap? Merry Thanks and Many Christmas ;)

14 years, 8 months

6
7
0 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 50217: [CMAKE] LD is stupid and doesn't handle stdcall decoration as proper as dlltool does (after we provided a patch). Passing --kill-at, also kills C++ mangled names and exports with ...

by Colin Finck

tkreuzer(a)svn.reactos.org wrote: > LD is stupid and doesn't handle stdcall decoration as proper as > dlltool does (after we provided a patch) [...] Wouldn't it have been easier to just provide a similar patch for LD then? It was a matter of changing a strchr() call to strrchr()... (http://sourceware.org/bugzilla/show_bug.cgi?id=9766) We can always use a patched binutils version in the next RosBE if the patch is not applied to the upstream source in time. Cheers, Colin

14 years, 8 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [cgutman] 50077: [USBDRIVER] - Fix a bug that resulted in us onl

by Pierre Schweitzer

Hi, > Author: cgutman > Date: Tue Dec 21 04:35:12 2010 > New Revision: 50077 > > URL: http://svn.reactos.org/svn/reactos?rev=50077&view=rev > Log: > [USBDRIVER] > - Fix a bug that resulted in us only copying half of the old keyboard data > - CID 10402 > > Modified: > trunk/reactos/drivers/usb/nt4compat/usbdriver/keyboard.c > > Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/keyboard.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbd… > ============================================================================== > --- trunk/reactos/drivers/usb/nt4compat/usbdriver/keyboard.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/usb/nt4compat/usbdriver/keyboard.c [iso-8859-1] Tue Dec 21 04:35:12 2010 > @@ -277,7 +277,7 @@ > } > > // Save old keyboard data > - RtlCopyMemory(pdev_ext->kbd_old, data, sizeof(data)); > + RtlCopyMemory(pdev_ext->kbd_old, data, 8); > > // resubmit the urb > status = usb_submit_urb(pdev_ext->dev_mgr, purb); This change is really dangerous and should be changed to a correct fix. Using magic values on memory copying is a bad idea. Using magic values (in general) is a bad idea. Please provide a better fix without magic value. Regards, P. Schweitzer

14 years, 8 months

1
0
0 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 50117: Marco Radossevich <fwdprojects=at=email=dot=it>, a.k.a. forart: "Just two important examples that involved my contributions: UniATA & FullFAT." No code changes. See thread <http...

by Ged Murphy

hahaha -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: 24 December 2010 01:59 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 50117: Marco Radossevich <fwdprojects=at=email=dot=it>, a.k.a. forart: "Just two important examples that involved my contributions: UniATA & FullFAT." No code changes. See thread <http... Author: dgorbachev Date: Fri Dec 24 01:59:13 2010 New Revision: 50117 URL: http://svn.reactos.org/svn/reactos?rev=50117&view=rev Log: Marco Radossevich <fwdprojects=at=email=dot=it>, a.k.a. forart: "Just two important examples that involved my contributions: UniATA & FullFAT." No code changes. See thread <http://www.reactos.org/forum/viewtopic.php?f=14&t=8809> for more details. Modified: trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h trunk/reactos/drivers/filesystems/fastfat_new/rw.c trunk/reactos/drivers/storage/ide/uniata/inc/PostDbgMesg.h Modified: trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h [iso-8859-1] Fri Dec 24 01:59:13 2010 @@ -80,7 +80,7 @@ CcUnpinData((xContext)->Bcb); \ (xContext)->Bcb = NULL; \ } \ - + #define FatPinEndOfPage(xContext, xType) \ Add2Ptr((xContext)->Buffer, (xContext)->ValidLength, xType) Modified: trunk/reactos/drivers/filesystems/fastfat_new/rw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/rw.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/rw.c [iso-8859-1] Fri Dec 24 01:59:13 2010 @@ -36,7 +36,7 @@ FatCompleteRequest(IrpContext, IrpContext->Irp, STATUS_SUCCESS); return STATUS_SUCCESS; } - + OpenType = FatDecodeFileObject(FileObject, &Vcb, &Fcb, &Ccb); DPRINT("FatiRead() Fcb %p, Name %wZ, Offset %d, Length %d, Handle %p\n", Modified: trunk/reactos/drivers/storage/ide/uniata/inc/PostDbgMesg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… ============================================================================== --- trunk/reactos/drivers/storage/ide/uniata/inc/PostDbgMesg.h [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/uniata/inc/PostDbgMesg.h [iso-8859-1] Fri Dec 24 01:59:13 2010 @@ -43,4 +43,4 @@ }; #endif //__cplusplus -#endif //__DBG_DUMP_TOOLS__H__ +#endif //__DBG_DUMP_TOOLS__H__

14 years, 8 months

5
5
0 0

[ros-diffs] [fireball] 50108: [NTOS] - Fix memory region size calculation in MemoryBasicInformation in certain cases

by victor martinez

I have a doubt: ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Wed Dec 22 21:59:27 2010 @@ -2446,6 +2446,9 @@ /* Check if this VAD is too high */ if (BaseVpn < Vad->StartingVpn) { + /* Stop if there is no left child */ + if (!Vad->LeftChild) break; + /* Search on the left next */ Vad = Vad->LeftChild; } @@ -2453,6 +2456,11 @@ { /* Then this VAD is too low, keep searching on the right */ ASSERT(BaseVpn > Vad->EndingVpn); + + /* Stop if there is no right child */ + if (!Vad->LeftChild) break; + + /* Search on the right next */ Vad = Vad->RightChild; } }======================================================== Look these lines: + /* Stop if there is no left child */ + if (!Vad->LeftChild) break; + /* Stop if there is no right child */ + if (!Vad->LeftChild) break; 1) Is there a typo in the copy-pasta condition? 2) Is the comment wrong or misleading? 3) Am I a complete noob? I think the order is 3), 1), 2) One of the latest changes has made ReactOS totally uninstallable(12 tries /12 fails) using less than 192MB Ram.It halts in first stage during copying files. Merry Christmas!!

14 years, 8 months

2
1
0 0

[ros-diffs] [pschweitzer] 50090: [FASTFAT] Fix for a buffer overflow and then a buffer overrun (if ever it fixes something) The way filenames are handled for FAT entries should be REALLY simplified. This would...

by James Tabor

Hi! I guess once long tyme ago, there was a little file called dos.h! Need this #define _A_VOLID 0x08 /* Volume ID file */ VolumeLabelDirEntry.Fat.Attrib = 0x08; }

14 years, 9 months

2
1
0 0

Unable to get wubble launch working with ua-ros-pkg

by GANESH KUMAR

I'm not able to get the wubble simulation working for the ua-ros-pkg at: http://code.google.com/p/ua-ros-pkg [Note: I'm a new comer to ROS] Summary of Issue: I am using the Q&A Format provided by the site above. a. What steps will reproduce the problem? 1. Follow http://code.google.com/p/ua-ros-pkg/wiki/DeveloperInstall to install uav-ros-pkg packages 2. Run roslaunch wubble_mapping simulation.launch b. What is the expected output? What do you see instead? Expected output: Runs as given in http://code.google.com/p/ua-ros-pkg/wiki/ClassInstructions. Observed output: -------------- while processing /opt/ros/cturtle/stacks/ua-ros-pkg-read-only/arrg/wubble_world/wubble_environments/launch/empty_blocks_world.launch: while processing /opt/ros/cturtle/stacks/ua-ros-pkg-read-only/arrg/wubble_world/wubble_environments/launch/world_common.launch: Invalid roslaunch XML syntax: [Errno 2] No such file or directory: u'/opt/ros/cturtle/stacks/ua-ros-pkg-read-only/arrg/wubble_world/wubble_environments/launch/world_common.launch' ------------ c. What version of the product are you using? On what operating system? Latest trunk, on Ubuntu 10.04 /Lucid. d. Additional Notes? world_common isn't there in the given files, and neither does it get generated during the build. Also, while running make-all.sh I get 'Built 46 packages with 1 failure'. My gearbox has the following issue during the build: ========================== mkdir -p build/gearbox-svn/build cd `rospack find gearbox` && patch -d build/gearbox-svn/src/hokuyo_aist/python --verbose < `rospack find gearbox`/aist_python_mt.patch Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- CMakeLists.txt 2010-11-05 17:13:52.719057243 -0700 |+++ CMakeLists.txt.ros 2010-11-05 17:12:30.921672551 -0700 -------------------------- Patching file CMakeLists.txt using Plan A... Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. Hunk #1 ignored at 41. 1 out of 1 hunk ignored -- saving rejects to file CMakeLists.txt.rej done =========================== I wonder whether this is causing the problem, and am not totally clear as to how to correct this. Thanks! -- Ganesh $ g++ file.c -fblocks -Wall /usr/lib/bundle1.o -arch x86_64 -o file.out

14 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [rmessiant] 50076: [CLASSPNP] - Use correct type in sizeof expression (CID 1646 and 10401). - Simplify signature define (CID 3653 and 3654). - Remove funky 0xFF characters.

by Timo Kreuzer

Am 21.12.2010 01:41, schrieb rmessiant(a)svn.reactos.org: > Author: rmessiant > Date: Tue Dec 21 00:41:52 2010 > New Revision: 50076 > > ... > > -#define DICTIONARY_SIGNATURE (((ULONG)'dict'<< 32) + 'sig ') > - > -struct _DICTIONARY_HEADER { > +#define DICTIONARY_SIGNATURE 'dsig' > + I think it was supposed to be something like (ULONGLONG)'dictsig '

14 years, 9 months

2
1
0 0

Heap Issues

by James Tabor

I've tested my patches with 49720 so far the wine user Dialog works. Upping to 50046 and repeating the test since 50000, this happens, (subsystems/win32/win32k/ntuser/window.c:2067) co_UserCreateWindowEx(): NCCREATE message failed (subsystems/win32/win32k/ntuser/window.c:2339) co_UserCreateWindowEx failed! kdb:> bt Eip: <ntdll.dll:92b1> lib/rtl/heap.c:358 (RtlpRemoveFreeBlock@16) Frames: <ntdll.dll:b189> lib/rtl/heap.c:2193 (RtlAllocateHeap@12) <user32.dll:32610> dialog.c:157 (DIALOG_get_info) <user32.dll:3369c> dialog.c:1577 (DefDlgProcA@16) <user32.dll:495dc> message.c:1091 (@IntCallWindowProcW@28) <user32.dll:49ead> message.c:2449 (User32CallWindowProcFromKernel@8) <ntdll.dll:7a84> <user32.dll:542c5> window.c:409 (CreateWindowExA@48) <user32.dll:343bf> dialog.c:925 (DIALOG_CreateIndirect) <user32.dll:352c0> dialog.c:1764 (DialogBoxParamA@20) <user32_winetest.exe:2055c> <user32_winetest.exe:22065> <user32_winetest.exe:a36e6> <user32_winetest.exe:a38fb> <user32_winetest.exe:a3d95> <user32_winetest.exe:a3dde> it faults at 0x00000004,,,....

14 years, 9 months

2
1
0 0

Re: [ros-dev] [ros-diffs] [pschweitzer] 50021: [NTOSKRNL] Rewritten FsRtlIsDbcsInExpression() using FsRtlIsNameInExpression() pattern. This fixes all failing tests from kmtest.sys and make this function definitely tastier t...

by Ged Murphy

pschweitzer(a)svn.reactos.org wrote: > > ASSERT(Name->Length); > ASSERT(Expression->Length); > ASSERT(!FsRtlDoesDbcsContainWildCards(Name)); It'd be preferable to wrap that last ASSERT so it isn't compiled into release builds. Adding functions into asserts adds overhead on release builds as they're called for no reason. Ged.

14 years, 9 months

2
2
0 0

Moving /trunk/tools into an own repository

by Colin Finck

Hello all, I'm currently developing two project tools which are going to be used by the German ReactOS foundation (custom IRC Server and plugin for Jameica - http://www.willuhn.de/products/jameica/). They shall be committed into a public ReactOS SVN repository. Since I believe that these tools are hardly useful for the average ReactOS developer, I don't want to commit them to our current /trunk/tools directory in the "reactos" repository. Among other disadvantages, every commit to them would trigger a useless BuildBot build, source checkouts would include unnecessary stuff, etc. As this is generally the case with most of the stuff in /trunk/tools, I'd like to move everything below this directory and the /irc directory into a new repository called "project-tools". We have already done a similar step in the past for the former "web" directory. Additionally, the "press-media" directory would be a similar candidate for an own "press-media" repository. After these steps, our "reactos" repository would finally contain only OS development related stuff. For comparison, Wine already keeps its main repository free from unrelated stuff and has several similar repositories (see http://source.winehq.org/git/). If there are no objections to my idea within the next two weeks, I will proceed and set up "project-tools" and "press-media" repositories (preserving as much SVN history as possible). Cheers, Colin

14 years, 9 months

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev