Ros-dev

ros-dev@reactos.org

5788 discussions

Status Meeting (December 2018)

by Colin Finck

Hi all! With Christmas fast approaching and many people traditionally being unavailable over the holidays (myself included), let me prepone our monthly meeting to tomorrow, Thursday, December 20, 2018, 19:00 UTC. Invited members will again receive their IRC Server credentials shortly before the meeting. Note that due to the recent infra changes, your IRC username will now be based on the Display Name you set in https://reactos.org/roslogin/?p=selfservice (spaces replaced by underscores). Please check that before the meeting. However, as our self-hosted Mattermost server is being set up right now, this may as well be our last meeting on IRC :) I wouldn't mind if it's just about the Status Updates from everybody this time, given that the November meeting was really long and a lot of things should be in progress. Let's also not forget about our preparations for Google Summer of Code! Cheers, Colin

5 years, 9 months

Re: [ros-dev] CORE-15467 - 1st stage setup freezes when the expected file is missing

by hermes.belusca＠sfr.fr

‌Hi, There is in principle (almost) all the infrastructure to implement the Retry/Skip/Abort dialog in usetup. The freezing you encounter is however a bug I should investigate. Cheers, Hermes <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Javier Agustìn Fernàndez Arroyo" A : "ReactOS Development List" Envoyé: mercredi 19 décembre 2018 20:17 Objet : [ros-dev] CORE-15467 - 1st stage setup freezes when the expected file is missing   <div class="gl_quoted"> <div dir="ltr">An idea, <div> </div> <div>I don´t think its a good idea to "skip" a file during 1st stage, specially core files (in 2nd stage it might be acceptable for some device drivers, for example)</div> <div> </div> <div>So, if "cloning" the Win2k3 behavior, i would set only 2 options: retry or abort installation and reboot.</div> <div> </div> <div>what do you guys think?</div> </div>  _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://reactos.org/mailman/listinfo/ros-dev</div> <div class="gl_quoted"> </div> </div>

5 years, 9 months

CORE-15467 - 1st stage setup freezes when the expected file is missing

by Javier Agustìn Fernàndez Arroyo

An idea, I don´t think its a good idea to "skip" a file during 1st stage, specially core files (in 2nd stage it might be acceptable for some device drivers, for example) So, if "cloning" the Win2k3 behavior, i would set only 2 options: retry or abort installation and reboot. what do you guys think?

5 years, 9 months

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412

by Pierre Schweitzer

Hi, I definitely don't like that commit, nor appreciate the way it was done. If we read CORE-15412 carefully, we have three developers (namely: Thomas, Mark, Giannis) expressing that they are again this revert, and thus this commit. Then, why was it pushed to HEAD? Cheers, Pierre Le 17/12/2018 à 22:02, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6f8cb05cad142a8679872… > > commit 6f8cb05cad142a8679872e695f317dc1f9728d55 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Mon Dec 17 22:01:49 2018 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Mon Dec 17 22:01:49 2018 +0100 > > [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412 > > addendum to 0.4.10-dev-502-g > d559ca9c982f9766acc5db3ea887ef2bc27acdff > > That copy-paste was done once intentionally to keep our imports similar to 2003. > It's worth reading the conversation in PR #748: Getequ seems to be ok with this. > > The ideal solution most likely would be to instead *statically* > link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502. > For now the stuff runs again at least. > I left the func existing in advapi32_vista.dll. > --- > dll/cpl/desk/CMakeLists.txt | 6 +- > dll/cpl/desk/desk.h | 9 ++ > dll/cpl/desk/muireg.c | 144 ++++++++++++++++++++++++++ > dll/win32/shell32/CMakeLists.txt | 3 +- > dll/win32/shell32/vista.c | 218 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 375 insertions(+), 5 deletions(-) > > diff --git a/dll/cpl/desk/CMakeLists.txt b/dll/cpl/desk/CMakeLists.txt > index 24d9bb1e60..ae7fb83825 100644 > --- a/dll/cpl/desk/CMakeLists.txt > +++ b/dll/cpl/desk/CMakeLists.txt > @@ -2,9 +2,6 @@ > add_definitions(-D_WIN32) > spec2def(desk.cpl desk.spec) > > -remove_definitions(-D_WIN32_WINNT=0x502) > -add_definitions(-D_WIN32_WINNT=0x600) > - > list(APPEND SOURCE > advmon.c > appearance.c > @@ -23,6 +20,7 @@ list(APPEND SOURCE > general.c > draw.c > theme.c > + muireg.c > desk.h) > > file(GLOB desk_rc_deps resources/*.*) > @@ -36,6 +34,6 @@ add_library(desk SHARED > > set_module_type(desk cpl UNICODE) > target_link_libraries(desk uuid) > -add_importlibs(desk user32 advapi32 advapi32_vista gdi32 comctl32 comdlg32 ole32 setupapi shell32 shlwapi uxtheme gdiplus msvcrt kernel32 ntdll) > +add_importlibs(desk user32 advapi32 gdi32 comctl32 comdlg32 ole32 setupapi shell32 shlwapi uxtheme gdiplus msvcrt kernel32 ntdll) > add_pch(desk desk.h SOURCE) > add_cd_file(TARGET desk DESTINATION reactos/system32 FOR all) > diff --git a/dll/cpl/desk/desk.h b/dll/cpl/desk/desk.h > index 3bb02f3a74..3c479251cf 100644 > --- a/dll/cpl/desk/desk.h > +++ b/dll/cpl/desk/desk.h > @@ -122,4 +122,13 @@ HPSXA WINAPI SHCreatePropSheetExtArrayEx(HKEY,LPCWSTR,UINT,IDataObject*); > INT_PTR CALLBACK > AdvGeneralPageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam); > > +LONG > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL); > + > #endif /* _DESK_H */ > diff --git a/dll/cpl/desk/muireg.c b/dll/cpl/desk/muireg.c > new file mode 100644 > index 0000000000..8754b43655 > --- /dev/null > +++ b/dll/cpl/desk/muireg.c > @@ -0,0 +1,144 @@ > +#include "desk.h" > + > +/****************************************************************************** > + * load_string [Internal] > + * > + * This is basically a copy of user32/resource.c's LoadStringW. Necessary to > + * avoid importing user32, which is higher level than advapi32. Helper for > + * RegLoadMUIString. > + */ > +static int load_string(HINSTANCE hModule, UINT resId, LPWSTR pwszBuffer, INT cMaxChars) > +{ > + HGLOBAL hMemory; > + HRSRC hResource; > + WCHAR *pString; > + int idxString; > + > + /* Negative values have to be inverted. */ > + if (HIWORD(resId) == 0xffff) > + resId = (UINT)(-((INT)resId)); > + > + /* Load the resource into memory and get a pointer to it. */ > + hResource = FindResourceW(hModule, MAKEINTRESOURCEW(LOWORD(resId >> 4) + 1), (LPWSTR)RT_STRING); > + if (!hResource) return 0; > + hMemory = LoadResource(hModule, hResource); > + if (!hMemory) return 0; > + pString = LockResource(hMemory); > + > + /* Strings are length-prefixed. Lowest nibble of resId is an index. */ > + idxString = resId & 0xf; > + while (idxString--) pString += *pString + 1; > + > + /* If no buffer is given, return length of the string. */ > + if (!pwszBuffer) return *pString; > + > + /* Else copy over the string, respecting the buffer size. */ > + cMaxChars = (*pString < cMaxChars) ? *pString : (cMaxChars - 1); > + if (cMaxChars >= 0) > + { > + memcpy(pwszBuffer, pString+1, cMaxChars * sizeof(WCHAR)); > + pwszBuffer[cMaxChars] = L'\0'; > + } > + > + return cMaxChars; > +} > + > + > +/************************************************************************ > + * RegLoadMUIStringW > + * > + * @implemented > + */ > +LONG > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL) > +{ > + DWORD dwValueType, cbData; > + LPWSTR pwszTempBuffer = NULL, pwszExpandedBuffer = NULL; > + LONG result; > + > + /* Parameter sanity checks. */ > + if (!hKey || !pszOutBuf) > + return ERROR_INVALID_PARAMETER; > + > + if (pszDirectory && *pszDirectory) > + { > + //FIXME("BaseDir parameter not yet supported!\n"); > + return ERROR_INVALID_PARAMETER; > + } > + > + /* Check for value existence and correctness of it's type, allocate a buffer and load it. */ > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, NULL, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + if (!(dwValueType == REG_SZ || dwValueType == REG_EXPAND_SZ) || !cbData) > + { > + result = ERROR_FILE_NOT_FOUND; > + goto cleanup; > + } > + pwszTempBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszTempBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, (LPBYTE)pwszTempBuffer, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + > + /* Expand environment variables, if appropriate, or copy the original string over. */ > + if (dwValueType == REG_EXPAND_SZ) > + { > + cbData = ExpandEnvironmentStringsW(pwszTempBuffer, NULL, 0) * sizeof(WCHAR); > + if (!cbData) goto cleanup; > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszExpandedBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + ExpandEnvironmentStringsW(pwszTempBuffer, pwszExpandedBuffer, cbData); > + } > + else > + { > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + memcpy(pwszExpandedBuffer, pwszTempBuffer, cbData); > + } > + > + /* If the value references a resource based string, parse the value and load the string. > + * Else just copy over the original value. */ > + result = ERROR_SUCCESS; > + if (*pwszExpandedBuffer != L'@') /* '@' is the prefix for resource based string entries. */ > + { > + lstrcpynW(pszOutBuf, pwszExpandedBuffer, cbOutBuf / sizeof(WCHAR)); > + } > + else > + { > + WCHAR *pComma = wcsrchr(pwszExpandedBuffer, L','); > + UINT uiStringId; > + HMODULE hModule; > + > + /* Format of the expanded value is 'path_to_dll,-resId' */ > + if (!pComma || pComma[1] != L'-') > + { > + result = ERROR_BADKEY; > + goto cleanup; > + } > + > + uiStringId = _wtoi(pComma+2); > + *pComma = L'\0'; > + > + hModule = LoadLibraryExW(pwszExpandedBuffer + 1, NULL, LOAD_LIBRARY_AS_DATAFILE); > + if (!hModule || !load_string(hModule, uiStringId, pszOutBuf, cbOutBuf / sizeof(WCHAR))) > + result = ERROR_BADKEY; > + FreeLibrary(hModule); > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszTempBuffer); > + HeapFree(GetProcessHeap(), 0, pwszExpandedBuffer); > + return result; > +} > diff --git a/dll/win32/shell32/CMakeLists.txt b/dll/win32/shell32/CMakeLists.txt > index 08933dda35..78ee1af531 100644 > --- a/dll/win32/shell32/CMakeLists.txt > +++ b/dll/win32/shell32/CMakeLists.txt > @@ -102,6 +102,7 @@ add_library(shell32 SHARED > wine/shellstring.c > wine/shlmenu.c > wine/shpolicy.c > + vista.c > shell32.rc > ${CMAKE_CURRENT_BINARY_DIR}/shell32_stubs.c > ${CMAKE_CURRENT_BINARY_DIR}/shell32.def) > @@ -113,7 +114,7 @@ set_source_files_properties(shell32.rc PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT > set_module_type(shell32 win32dll UNICODE) > target_link_libraries(shell32 shellmenu shelldesktop atlnew wine uuid recyclebin) > add_delay_importlibs(shell32 powrprof shdocvw devmgr winspool.drv winmm mpr uxtheme ole32 oleaut32 userenv browseui version fmifs) > -add_importlibs(shell32 advapi32 advapi32_vista gdi32 user32 comctl32 comdlg32 shlwapi msvcrt kernel32 ntdll) > +add_importlibs(shell32 advapi32 gdi32 user32 comctl32 comdlg32 shlwapi msvcrt kernel32 ntdll) > add_dependencies(shell32 stdole2) # shell32_shldisp.tlb needs stdole2.tlb > add_pch(shell32 precomp.h SOURCE) > add_cd_file(TARGET shell32 DESTINATION reactos/system32 FOR all) > diff --git a/dll/win32/shell32/vista.c b/dll/win32/shell32/vista.c > new file mode 100644 > index 0000000000..9f1a8335a3 > --- /dev/null > +++ b/dll/win32/shell32/vista.c > @@ -0,0 +1,218 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS system libraries > + * FILE: Copied from advapi32/reg/reg.c > + * PURPOSE: Registry functions > + * PROGRAMMER: Ariadne ( ariadne(a)xs4all.nl) > + * Thomas Weidenmueller <w3seek(a)reactos.com> > + * UPDATE HISTORY: > + * Created 01/11/98 > + * 19990309 EA Stubs > + * 20050502 Fireball imported some stuff from WINE > + */ > + > +#include <stdarg.h> > + > +#define WIN32_NO_STATUS > +#define _INC_WINDOWS > +#define COM_NO_WINDOWS_H > + > +#include <windef.h> > +#include <winbase.h> > +#include <winreg.h> > +#include <winuser.h> > +#define NTOS_MODE_USER > +#include <ndk/rtlfuncs.h> > + > +#include <wine/debug.h> > +#include <wine/unicode.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(shell); > + > +/****************************************************************************** > + * load_string [Internal] > + * > + * This is basically a copy of user32/resource.c's LoadStringW. Necessary to > + * avoid importing user32, which is higher level than advapi32. Helper for > + * RegLoadMUIString. > + */ > +static int load_string(HINSTANCE hModule, UINT resId, LPWSTR pwszBuffer, INT cMaxChars) > +{ > + HGLOBAL hMemory; > + HRSRC hResource; > + WCHAR *pString; > + int idxString; > + > + /* Negative values have to be inverted. */ > + if (HIWORD(resId) == 0xffff) > + resId = (UINT)(-((INT)resId)); > + > + /* Load the resource into memory and get a pointer to it. */ > + hResource = FindResourceW(hModule, MAKEINTRESOURCEW(LOWORD(resId >> 4) + 1), (LPWSTR)RT_STRING); > + if (!hResource) return 0; > + hMemory = LoadResource(hModule, hResource); > + if (!hMemory) return 0; > + pString = LockResource(hMemory); > + > + /* Strings are length-prefixed. Lowest nibble of resId is an index. */ > + idxString = resId & 0xf; > + while (idxString--) pString += *pString + 1; > + > + /* If no buffer is given, return length of the string. */ > + if (!pwszBuffer) return *pString; > + > + /* Else copy over the string, respecting the buffer size. */ > + cMaxChars = (*pString < cMaxChars) ? *pString : (cMaxChars - 1); > + if (cMaxChars >= 0) > + { > + memcpy(pwszBuffer, pString+1, cMaxChars * sizeof(WCHAR)); > + pwszBuffer[cMaxChars] = L'\0'; > + } > + > + return cMaxChars; > +} > + > +/************************************************************************ > + * RegLoadMUIStringW > + * > + * @implemented > + */ > +LONG WINAPI > +RegLoadMUIStringW(IN HKEY hKey, > + IN LPCWSTR pszValue OPTIONAL, > + OUT LPWSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCWSTR pszDirectory OPTIONAL) > +{ > + DWORD dwValueType, cbData; > + LPWSTR pwszTempBuffer = NULL, pwszExpandedBuffer = NULL; > + LONG result; > + > + /* Parameter sanity checks. */ > + if (!hKey || !pszOutBuf) > + return ERROR_INVALID_PARAMETER; > + > + if (pszDirectory && *pszDirectory) > + { > + FIXME("BaseDir parameter not yet supported!\n"); > + return ERROR_INVALID_PARAMETER; > + } > + > + /* Check for value existence and correctness of it's type, allocate a buffer and load it. */ > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, NULL, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + if (!(dwValueType == REG_SZ || dwValueType == REG_EXPAND_SZ) || !cbData) > + { > + result = ERROR_FILE_NOT_FOUND; > + goto cleanup; > + } > + pwszTempBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszTempBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + result = RegQueryValueExW(hKey, pszValue, NULL, &dwValueType, (LPBYTE)pwszTempBuffer, &cbData); > + if (result != ERROR_SUCCESS) goto cleanup; > + > + /* Expand environment variables, if appropriate, or copy the original string over. */ > + if (dwValueType == REG_EXPAND_SZ) > + { > + cbData = ExpandEnvironmentStringsW(pwszTempBuffer, NULL, 0) * sizeof(WCHAR); > + if (!cbData) goto cleanup; > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + if (!pwszExpandedBuffer) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + ExpandEnvironmentStringsW(pwszTempBuffer, pwszExpandedBuffer, cbData); > + } > + else > + { > + pwszExpandedBuffer = HeapAlloc(GetProcessHeap(), 0, cbData); > + memcpy(pwszExpandedBuffer, pwszTempBuffer, cbData); > + } > + > + /* If the value references a resource based string, parse the value and load the string. > + * Else just copy over the original value. */ > + result = ERROR_SUCCESS; > + if (*pwszExpandedBuffer != L'@') /* '@' is the prefix for resource based string entries. */ > + { > + lstrcpynW(pszOutBuf, pwszExpandedBuffer, cbOutBuf / sizeof(WCHAR)); > + } > + else > + { > + WCHAR *pComma = wcsrchr(pwszExpandedBuffer, L','); > + UINT uiStringId; > + HMODULE hModule; > + > + /* Format of the expanded value is 'path_to_dll,-resId' */ > + if (!pComma || pComma[1] != L'-') > + { > + result = ERROR_BADKEY; > + goto cleanup; > + } > + > + uiStringId = _wtoi(pComma+2); > + *pComma = L'\0'; > + > + hModule = LoadLibraryExW(pwszExpandedBuffer + 1, NULL, LOAD_LIBRARY_AS_DATAFILE); > + if (!hModule || !load_string(hModule, uiStringId, pszOutBuf, cbOutBuf / sizeof(WCHAR))) > + result = ERROR_BADKEY; > + FreeLibrary(hModule); > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszTempBuffer); > + HeapFree(GetProcessHeap(), 0, pwszExpandedBuffer); > + return result; > +} > + > +/************************************************************************ > + * RegLoadMUIStringA > + * > + * @implemented > + */ > +LONG WINAPI > +RegLoadMUIStringA(IN HKEY hKey, > + IN LPCSTR pszValue OPTIONAL, > + OUT LPSTR pszOutBuf, > + IN DWORD cbOutBuf, > + OUT LPDWORD pcbData OPTIONAL, > + IN DWORD Flags, > + IN LPCSTR pszDirectory OPTIONAL) > +{ > + UNICODE_STRING valueW, baseDirW; > + WCHAR *pwszBuffer; > + DWORD cbData = cbOutBuf * sizeof(WCHAR); > + LONG result; > + > + valueW.Buffer = baseDirW.Buffer = pwszBuffer = NULL; > + if (!RtlCreateUnicodeStringFromAsciiz(&valueW, pszValue) || > + !RtlCreateUnicodeStringFromAsciiz(&baseDirW, pszDirectory) || > + !(pwszBuffer = HeapAlloc(GetProcessHeap(), 0, cbData))) > + { > + result = ERROR_NOT_ENOUGH_MEMORY; > + goto cleanup; > + } > + > + result = RegLoadMUIStringW(hKey, valueW.Buffer, pwszBuffer, cbData, NULL, Flags, > + baseDirW.Buffer); > + > + if (result == ERROR_SUCCESS) > + { > + cbData = WideCharToMultiByte(CP_ACP, 0, pwszBuffer, -1, pszOutBuf, cbOutBuf, NULL, NULL); > + if (pcbData) > + *pcbData = cbData; > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, pwszBuffer); > + RtlFreeUnicodeString(&baseDirW); > + RtlFreeUnicodeString(&valueW); > + > + return result; > +} > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

5 years, 9 months

BuildBot and irc.reactos.org now using ReactOS.org accounts

by Colin Finck

Hi all! Another important change has just been applied to ReactOS infrastructure: https://build.reactos.org and https://irc.reactos.org now use ReactOS.org accounts. Finally, we have a real global login system where you can access all ReactOS services with the same account! Please let me know if or if not things work for you, as I may have forgotten to add some accounts to the BuildBot group. If everything works well, we are technically ready to launch a Mattermost instance using the same accounts as the next step :) Cheers, Colin

5 years, 9 months

iso.reactos.org migrated to new server

by Colin Finck

Hi all! iso.reactos.org, the file server used by our build machines and the source for https://reactos.org/getbuilds, has been migrated to new hardware at a different location today. You should experience better transfer rates due to the increased bandwidth, and a higher availability. The new hardware also offers more disk space and redundancy to keep our precious ISOs absolutely safe :) Unfortunately, the new iso.reactos.org is no longer right next to the build machines. This has several consequences: If I had left the build scripts as-is, the build machines would have uploaded the bootcdregtest ISOs to iso.reactos.org, just to download them multiple times for each Testbot a minute later. This would be an excessive waste of ISP bandwidth and would have delayed the entire testing process. Therefore, I changed the build scripts to keep the bootcdregtest ISOs within the local build machine network. However, the downside is that bootcdregtest ISOs are no longer available via iso.reactos.org. Please let me know if this is a problem for you and needs a solution. In the past, bootcdregtest ISOs were only available for a week and not accessible via GetBuilds either, so I have no idea how popular they are. Cheers, Colin

5 years, 9 months

Re: [ros-dev] [ros-diffs] 07/18: [WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header. CORE-11933 and PR #621.

by hermes.belusca＠sfr.fr

Hello Timo, Let's make a deal: while I fix this in win32k, you may try to find a way to fix that one too in the SAC driver line 1192: https://git.reactos.org/?p=reactos.git;a=blob;f=drivers/sac/driver/util.c;h… I used the object macros because I didn't want to have the (huge) overhead of calling ObQueryNameString() together with allocating memory buffers just to retrieve the necessary names that already exist somewhere. (Also we note that WinStation objects, by their nature, really wrap closely around the NT objects and that's why I didn't see any inconvenience in using the helper macros for retrieving said information). Best, Hermes‌ <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">De : "Timo Kreuzer" A : ros-dev(a)reactos.org,"Hermès Bélusca-Maïto" Envoyé: lundi 10 décembre 2018 01:44 Objet : Re: [ros-diffs] 07/18: [WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header. CORE-11933 and PR #621.   <div class="gl_quoted"> Why did you remove an abstraction and create additional dependencies on internal implementation details? Win32k is not supposed to directly access internal kernel structures! The headers and macros shouldn't even be in NDK. Please revert or fix this. And while you are at it, put an "#ifdef _NTOSKRNL_" around the stuff in NDK to prevent people from using it. Thanks, Timo Am 19.08.2018 um 22:16 schrieb Hermès Bélusca-Maïto: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=43e2ab208a2d3d50b12b4… > > commit 43e2ab208a2d3d50b12b4689347f57ca83568dd9 > Author: Hermès Bélusca-Maïto > AuthorDate: Sun Jun 17 19:40:32 2018 +0200 > Commit: Hermès Bélusca-Maïto > CommitDate: Sun Aug 19 22:18:32 2018 +0200 > > [WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header. > CORE-11933 and PR #621. > > - Remove the related hack-FIXMEs; > - Adjust NtUserGetObjectInformation() in accordance. > - Retrieve the window-station/desktop object type string in NtUserGetObjectInformation() > also from the NT Object's header. > > Also simplify the UOI_FLAGS case of NtUserGetObjectInformation() by reading > the handle inheritance information directly from the OBJECT_HANDLE_INFORMATION > structure returned by ObReferenceObjectByHandle(). > --- > win32ss/user/ntuser/sysparams.c | 3 +- > win32ss/user/ntuser/winsta.c | 106 +++++++++++++++++++--------------------- > win32ss/user/ntuser/winsta.h | 1 - > 3 files changed, 51 insertions(+), 59 deletions(-) > > diff --git a/win32ss/user/ntuser/sysparams.c b/win32ss/user/ntuser/sysparams.c > index 7eedc028de..d0badba00e 100644 > --- a/win32ss/user/ntuser/sysparams.c > +++ b/win32ss/user/ntuser/sysparams.c > @@ -33,7 +33,8 @@ BOOL g_PaintDesktopVersion = FALSE; > } \ > else \ > { \ > - ERR("NtUserSystemParametersInfo requires interactive window station (current is %wZ)\n", &GetW32ProcessInfo()->prpwinsta->Name); \ > + ERR("NtUserSystemParametersInfo requires interactive window station (current is %wZ)\n", \ > + &(OBJECT_HEADER_TO_NAME_INFO(OBJECT_TO_OBJECT_HEADER(GetW32ProcessInfo()->prpwinsta))->Name)); \ > } \ > EngSetLastError(err); \ > return 0; \ > diff --git a/win32ss/user/ntuser/winsta.c b/win32ss/user/ntuser/winsta.c > index f373b1cedf..ba1b1eb57d 100644 > --- a/win32ss/user/ntuser/winsta.c > +++ b/win32ss/user/ntuser/winsta.c > @@ -114,8 +114,6 @@ IntWinStaObjectDelete( > > RtlDestroyAtomTable(WinSta->AtomTable); > > - RtlFreeUnicodeString(&WinSta->Name); > - > return STATUS_SUCCESS; > } > > @@ -449,8 +447,6 @@ IntCreateWindowStation( > RtlZeroMemory(WindowStationObject, sizeof(WINSTATION_OBJECT)); > > InitializeListHead(&WindowStationObject->DesktopListHead); > - WindowStationObject->Name = *ObjectAttributes->ObjectName; > - ObjectAttributes->ObjectName = NULL; // FIXME! (see NtUserCreateWindowStation()) > WindowStationObject->dwSessionId = NtCurrentPeb()->SessionId; > Status = RtlCreateAtomTable(37, &WindowStationObject->AtomTable); > if (!NT_SUCCESS(Status)) > @@ -491,7 +487,7 @@ IntCreateWindowStation( > } > > TRACE("IntCreateWindowStation created object 0x%p with name %wZ handle 0x%p\n", > - WindowStationObject, &WindowStationObject->Name, WindowStation); > + WindowStationObject, ObjectAttributes->ObjectName, WindowStation); > > *phWinSta = WindowStation; > return STATUS_SUCCESS; > @@ -582,23 +578,7 @@ NtUserCreateWindowStation( > return NULL; > } > > - WindowStationName.Length = wcslen(ServiceWinStaName) * sizeof(WCHAR); > - WindowStationName.MaximumLength = > - WindowStationName.Length + sizeof(UNICODE_NULL); > - WindowStationName.Buffer = > - ExAllocatePoolWithTag(PagedPool, > - WindowStationName.MaximumLength, > - TAG_STRING); > - if (!WindowStationName.Buffer) > - { > - Status = STATUS_NO_MEMORY; > - ERR("Impossible to build a valid window station name, Status 0x%08lx\n", Status); > - SetLastNtError(Status); > - return NULL; > - } > - RtlStringCbCopyW(WindowStationName.Buffer, > - WindowStationName.MaximumLength, > - ServiceWinStaName); > + RtlInitUnicodeString(&WindowStationName, ServiceWinStaName); > LocalObjectAttributes.ObjectName = &WindowStationName; > AccessMode = KernelMode; > } > @@ -615,12 +595,7 @@ NtUserCreateWindowStation( > Unknown5, > Unknown6); > > - // FIXME! Because in some situations we store the allocated window station name > - // inside the window station, we must not free it now! We know this fact when > - // IntCreateWindowStation() sets LocalObjectAttributes.ObjectName to NULL. > - // This hack must be removed once we just use the stored Ob name instead > - // (in which case we will always free the allocated name here). > - if (LocalObjectAttributes.ObjectName) > + if ((AccessMode == UserMode) && LocalObjectAttributes.ObjectName) > ExFreePoolWithTag(LocalObjectAttributes.ObjectName->Buffer, TAG_STRING); > > if (NT_SUCCESS(Status)) > @@ -802,7 +777,11 @@ NtUserGetObjectInformation( > NTSTATUS Status; > PWINSTATION_OBJECT WinStaObject = NULL; > PDESKTOP DesktopObject = NULL; > + POBJECT_HEADER ObjectHeader; > + POBJECT_HEADER_NAME_INFO NameInfo; > + OBJECT_HANDLE_INFORMATION HandleInfo; > USEROBJECTFLAGS ObjectFlags; > + PUNICODE_STRING pStrNameU = NULL; > PVOID pvData = NULL; > SIZE_T nDataSize = 0; > > @@ -820,13 +799,13 @@ NtUserGetObjectInformation( > _SEH2_END; > > /* Try window station */ > - TRACE("Trying to open window station %p\n", hObject); > + TRACE("Trying to open window station 0x%p\n", hObject); > Status = ObReferenceObjectByHandle(hObject, > 0, > ExWindowStationObjectType, > UserMode, > (PVOID*)&WinStaObject, > - NULL); > + &HandleInfo); > > if (Status == STATUS_OBJECT_TYPE_MISMATCH) > { > @@ -852,23 +831,8 @@ NtUserGetObjectInformation( > { > case UOI_FLAGS: > { > - OBJECT_HANDLE_ATTRIBUTE_INFORMATION HandleInfo; > - ULONG BytesWritten; > - > ObjectFlags.fReserved = FALSE; > - > - /* Check whether this handle is inheritable */ > - Status = ZwQueryObject(hObject, > - ObjectHandleFlagInformation, > - &HandleInfo, > - sizeof(OBJECT_HANDLE_ATTRIBUTE_INFORMATION), > - &BytesWritten); > - if (!NT_SUCCESS(Status)) > - { > - ERR("ZwQueryObject failed, Status 0x%08lx\n", Status); > - break; > - } > - ObjectFlags.fInherit = HandleInfo.Inherit; > + ObjectFlags.fInherit = !!(HandleInfo.HandleAttributes & OBJ_INHERIT); > > ObjectFlags.dwFlags = 0; > if (WinStaObject != NULL) > @@ -893,11 +857,24 @@ NtUserGetObjectInformation( > > case UOI_NAME: > { > - // FIXME: Use either ObQueryNameString() or read directly that name inside the Object section! > if (WinStaObject != NULL) > { > - pvData = WinStaObject->Name.Buffer; > - nDataSize = WinStaObject->Name.Length + sizeof(WCHAR); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(WinStaObject); > + NameInfo = OBJECT_HEADER_TO_NAME_INFO(ObjectHeader); > + > + if (NameInfo && (NameInfo->Name.Length > 0)) > + { > + /* Named window station */ > + pStrNameU = &NameInfo->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > + } > + else > + { > + /* Unnamed window station (should never happen!) */ > + ASSERT(FALSE); > + pStrNameU = NULL; > + nDataSize = sizeof(UNICODE_NULL); > + } > Status = STATUS_SUCCESS; > } > else if (DesktopObject != NULL) > @@ -917,14 +894,16 @@ NtUserGetObjectInformation( > { > if (WinStaObject != NULL) > { > - pvData = L"WindowStation"; > - nDataSize = sizeof(L"WindowStation"); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(WinStaObject); > + pStrNameU = &ObjectHeader->Type->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > Status = STATUS_SUCCESS; > } > else if (DesktopObject != NULL) > { > - pvData = L"Desktop"; > - nDataSize = sizeof(L"Desktop"); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(DesktopObject); > + pStrNameU = &ObjectHeader->Type->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > Status = STATUS_SUCCESS; > } > else > @@ -954,10 +933,25 @@ Exit: > *nLengthNeeded = nDataSize; > > /* Try to copy data to caller */ > - if (Status == STATUS_SUCCESS) > + if (Status == STATUS_SUCCESS && (nDataSize > 0)) > { > TRACE("Trying to copy data to caller (len = %lu, len needed = %lu)\n", nLength, nDataSize); > - RtlCopyMemory(pvInformation, pvData, nDataSize); > + if (pvData) > + { > + /* Copy the data */ > + RtlCopyMemory(pvInformation, pvData, nDataSize); > + } > + else if (pStrNameU) > + { > + /* Copy and NULL-terminate the string */ > + RtlCopyMemory(pvInformation, pStrNameU->Buffer, pStrNameU->Length); > + ((PWCHAR)pvInformation)[pStrNameU->Length / sizeof(WCHAR)] = UNICODE_NULL; > + } > + else > + { > + /* Zero the memory */ > + RtlZeroMemory(pvInformation, nDataSize); > + } > } > } > _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > @@ -1026,8 +1020,6 @@ NtUserSetObjectInformation( > } > > > - > - > HWINSTA FASTCALL > UserGetProcessWindowStation(VOID) > { > diff --git a/win32ss/user/ntuser/winsta.h b/win32ss/user/ntuser/winsta.h > index 085f3bcb26..19b1479ec0 100644 > --- a/win32ss/user/ntuser/winsta.h > +++ b/win32ss/user/ntuser/winsta.h > @@ -15,7 +15,6 @@ typedef struct _WINSTATION_OBJECT > { > DWORD dwSessionId; > > - UNICODE_STRING Name; > LIST_ENTRY DesktopListHead; > PRTL_ATOM_TABLE AtomTable; > HANDLE ShellWindow; > >  </div> <div class="gl_quoted"> </div> </div>

5 years, 9 months

Test_KVM_AHK is offline

by Sylvain Petreolle

Hi all, The Test_KVM_AHK machine has encountered a power shortage in my area and is currently shut off. I will bring it back on today evening. Kind regards, Sylvain Petreolle

5 years, 9 months

Re: [ros-dev] [ros-diffs] 07/18: [WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header. CORE-11933 and PR #621.

by Timo Kreuzer

Why did you remove an abstraction and create additional dependencies on internal implementation details? Win32k is not supposed to directly access internal kernel structures! The headers and macros shouldn't even be in NDK. Please revert or fix this. And while you are at it, put an "#ifdef _NTOSKRNL_" around the stuff in NDK to prevent people from using it. Thanks, Timo Am 19.08.2018 um 22:16 schrieb Hermès Bélusca-Maïto: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=43e2ab208a2d3d50b12b4… > > commit 43e2ab208a2d3d50b12b4689347f57ca83568dd9 > Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > AuthorDate: Sun Jun 17 19:40:32 2018 +0200 > Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> > CommitDate: Sun Aug 19 22:18:32 2018 +0200 > > [WIN32K:NTUSER] Get rid of the cached window station Name member, and instead just use the name stored in the NT Object's header. > CORE-11933 and PR #621. > > - Remove the related hack-FIXMEs; > - Adjust NtUserGetObjectInformation() in accordance. > - Retrieve the window-station/desktop object type string in NtUserGetObjectInformation() > also from the NT Object's header. > > Also simplify the UOI_FLAGS case of NtUserGetObjectInformation() by reading > the handle inheritance information directly from the OBJECT_HANDLE_INFORMATION > structure returned by ObReferenceObjectByHandle(). > --- > win32ss/user/ntuser/sysparams.c | 3 +- > win32ss/user/ntuser/winsta.c | 106 +++++++++++++++++++--------------------- > win32ss/user/ntuser/winsta.h | 1 - > 3 files changed, 51 insertions(+), 59 deletions(-) > > diff --git a/win32ss/user/ntuser/sysparams.c b/win32ss/user/ntuser/sysparams.c > index 7eedc028de..d0badba00e 100644 > --- a/win32ss/user/ntuser/sysparams.c > +++ b/win32ss/user/ntuser/sysparams.c > @@ -33,7 +33,8 @@ BOOL g_PaintDesktopVersion = FALSE; > } \ > else \ > { \ > - ERR("NtUserSystemParametersInfo requires interactive window station (current is %wZ)\n", &GetW32ProcessInfo()->prpwinsta->Name); \ > + ERR("NtUserSystemParametersInfo requires interactive window station (current is %wZ)\n", \ > + &(OBJECT_HEADER_TO_NAME_INFO(OBJECT_TO_OBJECT_HEADER(GetW32ProcessInfo()->prpwinsta))->Name)); \ > } \ > EngSetLastError(err); \ > return 0; \ > diff --git a/win32ss/user/ntuser/winsta.c b/win32ss/user/ntuser/winsta.c > index f373b1cedf..ba1b1eb57d 100644 > --- a/win32ss/user/ntuser/winsta.c > +++ b/win32ss/user/ntuser/winsta.c > @@ -114,8 +114,6 @@ IntWinStaObjectDelete( > > RtlDestroyAtomTable(WinSta->AtomTable); > > - RtlFreeUnicodeString(&WinSta->Name); > - > return STATUS_SUCCESS; > } > > @@ -449,8 +447,6 @@ IntCreateWindowStation( > RtlZeroMemory(WindowStationObject, sizeof(WINSTATION_OBJECT)); > > InitializeListHead(&WindowStationObject->DesktopListHead); > - WindowStationObject->Name = *ObjectAttributes->ObjectName; > - ObjectAttributes->ObjectName = NULL; // FIXME! (see NtUserCreateWindowStation()) > WindowStationObject->dwSessionId = NtCurrentPeb()->SessionId; > Status = RtlCreateAtomTable(37, &WindowStationObject->AtomTable); > if (!NT_SUCCESS(Status)) > @@ -491,7 +487,7 @@ IntCreateWindowStation( > } > > TRACE("IntCreateWindowStation created object 0x%p with name %wZ handle 0x%p\n", > - WindowStationObject, &WindowStationObject->Name, WindowStation); > + WindowStationObject, ObjectAttributes->ObjectName, WindowStation); > > *phWinSta = WindowStation; > return STATUS_SUCCESS; > @@ -582,23 +578,7 @@ NtUserCreateWindowStation( > return NULL; > } > > - WindowStationName.Length = wcslen(ServiceWinStaName) * sizeof(WCHAR); > - WindowStationName.MaximumLength = > - WindowStationName.Length + sizeof(UNICODE_NULL); > - WindowStationName.Buffer = > - ExAllocatePoolWithTag(PagedPool, > - WindowStationName.MaximumLength, > - TAG_STRING); > - if (!WindowStationName.Buffer) > - { > - Status = STATUS_NO_MEMORY; > - ERR("Impossible to build a valid window station name, Status 0x%08lx\n", Status); > - SetLastNtError(Status); > - return NULL; > - } > - RtlStringCbCopyW(WindowStationName.Buffer, > - WindowStationName.MaximumLength, > - ServiceWinStaName); > + RtlInitUnicodeString(&WindowStationName, ServiceWinStaName); > LocalObjectAttributes.ObjectName = &WindowStationName; > AccessMode = KernelMode; > } > @@ -615,12 +595,7 @@ NtUserCreateWindowStation( > Unknown5, > Unknown6); > > - // FIXME! Because in some situations we store the allocated window station name > - // inside the window station, we must not free it now! We know this fact when > - // IntCreateWindowStation() sets LocalObjectAttributes.ObjectName to NULL. > - // This hack must be removed once we just use the stored Ob name instead > - // (in which case we will always free the allocated name here). > - if (LocalObjectAttributes.ObjectName) > + if ((AccessMode == UserMode) && LocalObjectAttributes.ObjectName) > ExFreePoolWithTag(LocalObjectAttributes.ObjectName->Buffer, TAG_STRING); > > if (NT_SUCCESS(Status)) > @@ -802,7 +777,11 @@ NtUserGetObjectInformation( > NTSTATUS Status; > PWINSTATION_OBJECT WinStaObject = NULL; > PDESKTOP DesktopObject = NULL; > + POBJECT_HEADER ObjectHeader; > + POBJECT_HEADER_NAME_INFO NameInfo; > + OBJECT_HANDLE_INFORMATION HandleInfo; > USEROBJECTFLAGS ObjectFlags; > + PUNICODE_STRING pStrNameU = NULL; > PVOID pvData = NULL; > SIZE_T nDataSize = 0; > > @@ -820,13 +799,13 @@ NtUserGetObjectInformation( > _SEH2_END; > > /* Try window station */ > - TRACE("Trying to open window station %p\n", hObject); > + TRACE("Trying to open window station 0x%p\n", hObject); > Status = ObReferenceObjectByHandle(hObject, > 0, > ExWindowStationObjectType, > UserMode, > (PVOID*)&WinStaObject, > - NULL); > + &HandleInfo); > > if (Status == STATUS_OBJECT_TYPE_MISMATCH) > { > @@ -852,23 +831,8 @@ NtUserGetObjectInformation( > { > case UOI_FLAGS: > { > - OBJECT_HANDLE_ATTRIBUTE_INFORMATION HandleInfo; > - ULONG BytesWritten; > - > ObjectFlags.fReserved = FALSE; > - > - /* Check whether this handle is inheritable */ > - Status = ZwQueryObject(hObject, > - ObjectHandleFlagInformation, > - &HandleInfo, > - sizeof(OBJECT_HANDLE_ATTRIBUTE_INFORMATION), > - &BytesWritten); > - if (!NT_SUCCESS(Status)) > - { > - ERR("ZwQueryObject failed, Status 0x%08lx\n", Status); > - break; > - } > - ObjectFlags.fInherit = HandleInfo.Inherit; > + ObjectFlags.fInherit = !!(HandleInfo.HandleAttributes & OBJ_INHERIT); > > ObjectFlags.dwFlags = 0; > if (WinStaObject != NULL) > @@ -893,11 +857,24 @@ NtUserGetObjectInformation( > > case UOI_NAME: > { > - // FIXME: Use either ObQueryNameString() or read directly that name inside the Object section! > if (WinStaObject != NULL) > { > - pvData = WinStaObject->Name.Buffer; > - nDataSize = WinStaObject->Name.Length + sizeof(WCHAR); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(WinStaObject); > + NameInfo = OBJECT_HEADER_TO_NAME_INFO(ObjectHeader); > + > + if (NameInfo && (NameInfo->Name.Length > 0)) > + { > + /* Named window station */ > + pStrNameU = &NameInfo->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > + } > + else > + { > + /* Unnamed window station (should never happen!) */ > + ASSERT(FALSE); > + pStrNameU = NULL; > + nDataSize = sizeof(UNICODE_NULL); > + } > Status = STATUS_SUCCESS; > } > else if (DesktopObject != NULL) > @@ -917,14 +894,16 @@ NtUserGetObjectInformation( > { > if (WinStaObject != NULL) > { > - pvData = L"WindowStation"; > - nDataSize = sizeof(L"WindowStation"); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(WinStaObject); > + pStrNameU = &ObjectHeader->Type->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > Status = STATUS_SUCCESS; > } > else if (DesktopObject != NULL) > { > - pvData = L"Desktop"; > - nDataSize = sizeof(L"Desktop"); > + ObjectHeader = OBJECT_TO_OBJECT_HEADER(DesktopObject); > + pStrNameU = &ObjectHeader->Type->Name; > + nDataSize = pStrNameU->Length + sizeof(UNICODE_NULL); > Status = STATUS_SUCCESS; > } > else > @@ -954,10 +933,25 @@ Exit: > *nLengthNeeded = nDataSize; > > /* Try to copy data to caller */ > - if (Status == STATUS_SUCCESS) > + if (Status == STATUS_SUCCESS && (nDataSize > 0)) > { > TRACE("Trying to copy data to caller (len = %lu, len needed = %lu)\n", nLength, nDataSize); > - RtlCopyMemory(pvInformation, pvData, nDataSize); > + if (pvData) > + { > + /* Copy the data */ > + RtlCopyMemory(pvInformation, pvData, nDataSize); > + } > + else if (pStrNameU) > + { > + /* Copy and NULL-terminate the string */ > + RtlCopyMemory(pvInformation, pStrNameU->Buffer, pStrNameU->Length); > + ((PWCHAR)pvInformation)[pStrNameU->Length / sizeof(WCHAR)] = UNICODE_NULL; > + } > + else > + { > + /* Zero the memory */ > + RtlZeroMemory(pvInformation, nDataSize); > + } > } > } > _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > @@ -1026,8 +1020,6 @@ NtUserSetObjectInformation( > } > > > - > - > HWINSTA FASTCALL > UserGetProcessWindowStation(VOID) > { > diff --git a/win32ss/user/ntuser/winsta.h b/win32ss/user/ntuser/winsta.h > index 085f3bcb26..19b1479ec0 100644 > --- a/win32ss/user/ntuser/winsta.h > +++ b/win32ss/user/ntuser/winsta.h > @@ -15,7 +15,6 @@ typedef struct _WINSTATION_OBJECT > { > DWORD dwSessionId; > > - UNICODE_STRING Name; > LIST_ENTRY DesktopListHead; > PRTL_ATOM_TABLE AtomTable; > HANDLE ShellWindow; > >

5 years, 9 months

USB meta bug

by Javier Agustìn Fernàndez Arroyo

hello all, There are lots of USB related reports, and i´m about creating a master one, which blocks all of those... what do you think?

5 years, 9 months

← Newer
1
...
9
10
11
12
13
14
15
...
579
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev