Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Microsoft open-sources its console / terminal code! (MIT-licensed)
by Hermès BÉLUSCA-MAÏTO 07 May '19

07 May '19

Dear All, Yes you've read correctly! Microsoft released the code of its terminal + the Windows console host (conhost.exe) under MIT license at: https://github.com/microsoft/Terminal I think this is a really great move!! This can definitively help us for: * first, allowing us to improve our existing console code, * and in the future, getting our console architecture Win10-compatible (...) This also means that anybody can contribute back to their code via pull-requests, or at least creating issues. For those using Windows 10, they plan releasing official builds starting June 2019 according to their posts: https://devblogs.microsoft.com/commandline/introducing-windows-terminal/ https://www.hanselman.com/blog/ANewConsoleForWindowsItsTheOpenSourceWindowsT erminal.aspx Best, Hermès

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [POWERCFG] Fix an exception that occurs when the control panel is closed.
by Thomas Faber 04 May '19

04 May '19

This fix seems odd. I thought HeapFree(NULL) was well-defined and did nothing (despite what MSDN says). Pretty sure Wine uses it everywhere. Am I missing something? On 2019-04-27 19:02, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce218f70ec8a758ec6d40… > > commit ce218f70ec8a758ec6d4039690bae29c23289b9d > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Sat Apr 27 19:00:33 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Sat Apr 27 19:01:35 2019 +0200 > > [POWERCFG] Fix an exception that occurs when the control panel is closed. > --- > dll/cpl/powercfg/powershemes.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dll/cpl/powercfg/powershemes.c b/dll/cpl/powercfg/powershemes.c > index 4fff28a279..7d1441a043 100644 > --- a/dll/cpl/powercfg/powershemes.c > +++ b/dll/cpl/powercfg/powershemes.c > @@ -78,8 +78,12 @@ AddPowerScheme( > dwDescription + sizeof(TCHAR)); > if (pScheme->pszName == NULL || pScheme->pszDescription == NULL) > { > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > return NULL; > } > @@ -103,8 +107,12 @@ DeletePowerScheme( > { > RemoveEntryList(&pScheme->ListEntry); > > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > } > >

1 0

Proposal for Web App development
by Jatin Kumar 09 Apr '19

09 Apr '19

Hi there, Just got my proposal ready, It would be very kind of you if you can go through my proposal once and tell me of any improvements i should make to it. https://docs.google.com/document/d/1Kmwk2B6PYGypMvEqLR0V-OpZbde_d_tfDBz6Vdw…

1 0

Help required regarding GSOC Application
by Jatin Kumar 09 Apr '19

09 Apr '19

Hey there ! I am really interested to work with your organization.I have been doing web development projects using MERN stack for a while now,And I went through your reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API(https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer… I am Looking forward to work on the same for GSOC this year under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using React and Node.js, till now I have created robust user ineterface with React and am looking forward to add some logics to it in coming hours. Webapp link: https://reactos-web.herokuapp.com/ GitHub repo: https://github.com/AwesomeChap/ReactOS_Web_Interface (Theme I chose in webApp mentioned above is completely customizable : You may think of present theme as Night Mode) kindly review the links. Any suggestion would be appreciated Thanks Jatin Kumar Btech CSE 2nd Year USICT, GGSIPU India

2 2

ReactOS Hackfest 2019 will take place from 15th to 20th August in Berlin
by Colin Finck 09 Apr '19

09 Apr '19

Hi all! The ReactOS Hackfest goes into its fourth round! Join us from Thursday, 15th August to Tuesday, 20th August 2019, just at the same location in Berlin as last year. As every year, check out the https://reactos.org/wiki/ReactOS_Hackfest_2019 and https://reactos.org/wiki/ReactOS_Hackfest_2019/Lists pages on our Wiki and add yourself if you can make it. Hope to see you all in August! Colin

1 0

Code Review and guidence for further application
by Jatin Kumar 09 Apr '19

09 Apr '19

Hey there ! I am really interested to work with your organization.I have been doing web development projects using MERN stack for a while now,And I went through your reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API(https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer… I am Looking forward to work on the same for GSOC this year under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using React and Node.js, till now I have created robust user ineterface with React and am looking forward to add some logics to it in coming hours. Webapp link: https://reactos-web.herokuapp.com/ GitHub repo: https://github.com/AwesomeChap/ReactOS_Web_Interface kindly review the links. Any suggestion would be appreciated Thanks Jatin Kumar Btech CSE 2nd Year USICT, GGSIPU India

2 1

GSOC 2019 - Costin Visan
by costin visan 08 Apr '19

08 Apr '19

Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's project. I'm in my second year at University Politehnica of Bucharest at the Faculty of Automatic Control and Computers and I study for a degree in Computer Science and Information Technology. I wanna start early this year contributing to the project as I wish to show you that I will be a great addition to your team. If I have caught your attention and you want to communicate me anything, I can be contacted on this mail. - Many thanks, Costin Visan <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

3 2

Re: [ros-dev] [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it
by Pierre Schweitzer 01 Apr '19

01 Apr '19

This is 3rd party code. Can you surround it with #ifdef __REACTOS__? Le 01/04/2019 à 17:08, Hervé Poussineau a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76910c358f7197a6b8e28… > > commit 76910c358f7197a6b8e283ea267faf7b5c1812ff > Author: Hervé Poussineau <hpoussin(a)reactos.org> > AuthorDate: Sat Mar 30 23:06:27 2019 +0100 > Commit: Hervé Poussineau <hpoussin(a)reactos.org> > CommitDate: Mon Apr 1 11:38:32 2019 +0200 > > [EXT2] Correctly zero memory before using it > --- > drivers/filesystems/ext2/src/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/filesystems/ext2/src/memory.c b/drivers/filesystems/ext2/src/memory.c > index 8915dfeccb..cf569f40cd 100644 > --- a/drivers/filesystems/ext2/src/memory.c > +++ b/drivers/filesystems/ext2/src/memory.c > @@ -2072,9 +2072,9 @@ Ext2ParseRegistryVolumeParams( > > USHORT i, j, k; > > - RtlZeroMemory(Codepage, CODEPAGE_MAXLEN); > - RtlZeroMemory(Prefix, HIDINGPAT_LEN); > - RtlZeroMemory(Suffix, HIDINGPAT_LEN); > + RtlZeroMemory(Codepage, sizeof(WCHAR) * CODEPAGE_MAXLEN); > + RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN); > + RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN); > RtlZeroMemory(MountPoint, sizeof(USHORT) * 4); > RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4); > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Tibor Popper (Sumi), Google GSoC 2019
by Tibor Popper 24 Mar '19

24 Mar '19

Hello Everyone!! Im Tibor Popper from Hungary, somewhere at middle of Europe :). I want to apply in Google GSoC at this year, also I wanna be co-developer of ReactOS project. I'm really exited about Operating System programming right now, atleast for training myself? I dont really know, but more prefer to make some new functions or fixes for ReactOS to really make this project better, and really useful. Like.: UEFI boot, Kernel expansion, Graphics. Im especially advanced in grafical programming with DirectX 11 / 12, but maybe more with OpenGL 4+. I was developer of video games in some little company, mainly for Windows, with Unreal Engine, Unity, I cant tell about more. I didnt finished University of Pécs, with Engineering IT (BSc), but I have Software Developer occupation. My main programming language is C++, but not limited to others. I have started to look half year before how UEFI works in general to start write EFI programs, but I abandoned this studying, + some OS from sctratch tutorials :) … I really love to make things work! I love optimal and nice looking code, performance, software design, functionality. I love to understand HOW things work, I can take really much time discover these things, like in Physics, also love that too. Greetings, regards, Sumi!

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [MSI] Allow to pass product key validation check
by Thomas Faber 20 Mar '19

20 Mar '19

This causes a test failure... https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=1&strip… On 2019-03-19 23:06, Stanislav Motylkov wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d54… > > commit 8e05f5509c4baa4df9d543620d5da9552c18f25f > Author: Stanislav Motylkov <x86corez(a)gmail.com> > AuthorDate: Mon Mar 18 01:14:46 2019 +0300 > Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> > CommitDate: Tue Mar 19 23:05:57 2019 +0100 > > [MSI] Allow to pass product key validation check > > CORE-14710 CORE-15864 > --- > dll/win32/msi/action.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dll/win32/msi/action.c b/dll/win32/msi/action.c > index 3909246869..0eef96a89c 100644 > --- a/dll/win32/msi/action.c > +++ b/dll/win32/msi/action.c > @@ -7448,7 +7448,11 @@ UINT msi_validate_product_id( MSIPACKAGE *package ) > if (key && template) > { > FIXME( "partial stub: template %s key %s\n", debugstr_w(template), debugstr_w(key) ); > +#ifdef __REACTOS__ > + WARN("Product key validation HACK, see CORE-14710\n"); > +#else > r = msi_set_property( package->db, szProductID, key, -1 ); > +#endif > } > msi_free( template ); > msi_free( key ); >

2 1

← Newer
1
...
6
7
8
9
10
11
12
...
580
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev