Ros-dev

ros-dev@reactos.org

5788 discussions

Code Review and guidence for further application

by Jatin Kumar

Hey there ! I am really interested to work with your organization.I have been doing web development projects using MERN stack for a while now,And I went through your reactOS GSOC’19 page. I am interested in making the web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API(https://www.reactos.org/wiki/Google_Summer_of_Code_2019_Ideas#Developer… I am Looking forward to work on the same for GSOC this year under your mentorship. Currently I am reading the api documentation and trying to implement some basic stuffs using React and Node.js, till now I have created robust user ineterface with React and am looking forward to add some logics to it in coming hours. Webapp link: https://reactos-web.herokuapp.com/ GitHub repo: https://github.com/AwesomeChap/ReactOS_Web_Interface kindly review the links. Any suggestion would be appreciated Thanks Jatin Kumar Btech CSE 2nd Year USICT, GGSIPU India

5 years, 5 months

GSOC 2019 - Costin Visan

by costin visan

Hello! I'm really interested in participating this year at gsoc as part of your team. I'm writting you this email to get your attention and maybe to get a hint for this year's project. I'm in my second year at University Politehnica of Bucharest at the Faculty of Automatic Control and Computers and I study for a degree in Computer Science and Information Technology. I wanna start early this year contributing to the project as I wish to show you that I will be a great addition to your team. If I have caught your attention and you want to communicate me anything, I can be contacted on this mail. - Many thanks, Costin Visan <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campai…> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

5 years, 5 months

Re: [ros-dev] [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it

by Pierre Schweitzer

This is 3rd party code. Can you surround it with #ifdef __REACTOS__? Le 01/04/2019 à 17:08, Hervé Poussineau a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76910c358f7197a6b8e28… > > commit 76910c358f7197a6b8e283ea267faf7b5c1812ff > Author: Hervé Poussineau <hpoussin(a)reactos.org> > AuthorDate: Sat Mar 30 23:06:27 2019 +0100 > Commit: Hervé Poussineau <hpoussin(a)reactos.org> > CommitDate: Mon Apr 1 11:38:32 2019 +0200 > > [EXT2] Correctly zero memory before using it > --- > drivers/filesystems/ext2/src/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/filesystems/ext2/src/memory.c b/drivers/filesystems/ext2/src/memory.c > index 8915dfeccb..cf569f40cd 100644 > --- a/drivers/filesystems/ext2/src/memory.c > +++ b/drivers/filesystems/ext2/src/memory.c > @@ -2072,9 +2072,9 @@ Ext2ParseRegistryVolumeParams( > > USHORT i, j, k; > > - RtlZeroMemory(Codepage, CODEPAGE_MAXLEN); > - RtlZeroMemory(Prefix, HIDINGPAT_LEN); > - RtlZeroMemory(Suffix, HIDINGPAT_LEN); > + RtlZeroMemory(Codepage, sizeof(WCHAR) * CODEPAGE_MAXLEN); > + RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN); > + RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN); > RtlZeroMemory(MountPoint, sizeof(USHORT) * 4); > RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4); > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

5 years, 5 months

Tibor Popper (Sumi), Google GSoC 2019

by Tibor Popper

Hello Everyone!! Im Tibor Popper from Hungary, somewhere at middle of Europe :). I want to apply in Google GSoC at this year, also I wanna be co-developer of ReactOS project. I'm really exited about Operating System programming right now, atleast for training myself? I dont really know, but more prefer to make some new functions or fixes for ReactOS to really make this project better, and really useful. Like.: UEFI boot, Kernel expansion, Graphics. Im especially advanced in grafical programming with DirectX 11 / 12, but maybe more with OpenGL 4+. I was developer of video games in some little company, mainly for Windows, with Unreal Engine, Unity, I cant tell about more. I didnt finished University of Pécs, with Engineering IT (BSc), but I have Software Developer occupation. My main programming language is C++, but not limited to others. I have started to look half year before how UEFI works in general to start write EFI programs, but I abandoned this studying, + some OS from sctratch tutorials :) … I really love to make things work! I love optimal and nice looking code, performance, software design, functionality. I love to understand HOW things work, I can take really much time discover these things, like in Physics, also love that too. Greetings, regards, Sumi!

5 years, 5 months

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [MSI] Allow to pass product key validation check

by Thomas Faber

This causes a test failure... https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=1&strip… On 2019-03-19 23:06, Stanislav Motylkov wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d54… > > commit 8e05f5509c4baa4df9d543620d5da9552c18f25f > Author: Stanislav Motylkov <x86corez(a)gmail.com> > AuthorDate: Mon Mar 18 01:14:46 2019 +0300 > Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> > CommitDate: Tue Mar 19 23:05:57 2019 +0100 > > [MSI] Allow to pass product key validation check > > CORE-14710 CORE-15864 > --- > dll/win32/msi/action.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dll/win32/msi/action.c b/dll/win32/msi/action.c > index 3909246869..0eef96a89c 100644 > --- a/dll/win32/msi/action.c > +++ b/dll/win32/msi/action.c > @@ -7448,7 +7448,11 @@ UINT msi_validate_product_id( MSIPACKAGE *package ) > if (key && template) > { > FIXME( "partial stub: template %s key %s\n", debugstr_w(template), debugstr_w(key) ); > +#ifdef __REACTOS__ > + WARN("Product key validation HACK, see CORE-14710\n"); > +#else > r = msi_set_property( package->db, szProductID, key, -1 ); > +#endif > } > msi_free( template ); > msi_free( key ); >

5 years, 6 months

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [FREETYPE] Fix 3 regressions in one patch

by Pierre Schweitzer

Hi, This commit broke HEAD; both VBox & KVM regtesters are red. Either fix this commit or revert it. In the meantime, please refrain from pushing to HEAD. Cheers, Pierre Le 11/03/2019 à 20:11, Joachim Henze a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=98b7ecd280c0f641d4593… > > commit 98b7ecd280c0f641d4593c8ba792b463a5117550 > Author: Joachim Henze <Joachim.Henze(a)reactos.org> > AuthorDate: Mon Mar 11 20:10:14 2019 +0100 > Commit: Joachim Henze <Joachim.Henze(a)reactos.org> > CommitDate: Mon Mar 11 20:10:14 2019 +0100 > > [FREETYPE] Fix 3 regressions in one patch > > Fixes regression CORE-15785 (Zim Desktop Wiki 0.67 crashed) and > Fixes regression CORE-15755 (NLite 1.4.9.3 used wrong font) > > without reintroducing regression CORE-15558 (AbiWord 2.6.8 font enumeration) > > This is achieved by partial revert of > 0.4.12-dev-320-g > 6e4e5a004c9da6276695d90187fb577812e8892f > and got ack of Katayama Hirofumi MZ. > > Thanks to patches author Doug Lyons. > Test-results: https://reactos.org/testman/compare.php?ids=66264,66267 > --- > win32ss/gdi/ntgdi/freetype.c | 196 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 152 insertions(+), 44 deletions(-) > > diff --git a/win32ss/gdi/ntgdi/freetype.c b/win32ss/gdi/ntgdi/freetype.c > index 7005057a077..4f58f030f27 100644 > --- a/win32ss/gdi/ntgdi/freetype.c > +++ b/win32ss/gdi/ntgdi/freetype.c > @@ -2244,6 +2244,73 @@ IntGetOutlineTextMetrics(PFONTGDI FontGDI, > return Cache->OutlineRequiredSize; > } > > +static PFONTGDI FASTCALL > +FindFaceNameInList(PUNICODE_STRING FaceName, PLIST_ENTRY Head) > +{ > + PLIST_ENTRY Entry; > + PFONT_ENTRY CurrentEntry; > + ANSI_STRING EntryFaceNameA; > + UNICODE_STRING EntryFaceNameW; > + FONTGDI *FontGDI; > + NTSTATUS status; > + > + for (Entry = Head->Flink; Entry != Head; Entry = Entry->Flink) > + { > + CurrentEntry = CONTAINING_RECORD(Entry, FONT_ENTRY, ListEntry); > + > + FontGDI = CurrentEntry->Font; > + ASSERT(FontGDI); > + > + RtlInitAnsiString(&EntryFaceNameA, FontGDI->SharedFace->Face->family_name); > + status = RtlAnsiStringToUnicodeString(&EntryFaceNameW, &EntryFaceNameA, TRUE); > + if (!NT_SUCCESS(status)) > + { > + break; > + } > + > + if ((LF_FACESIZE - 1) * sizeof(WCHAR) < EntryFaceNameW.Length) > + { > + EntryFaceNameW.Length = (LF_FACESIZE - 1) * sizeof(WCHAR); > + EntryFaceNameW.Buffer[LF_FACESIZE - 1] = L'\0'; > + } > + > + if (RtlEqualUnicodeString(FaceName, &EntryFaceNameW, TRUE)) > + { > + RtlFreeUnicodeString(&EntryFaceNameW); > + return FontGDI; > + } > + > + RtlFreeUnicodeString(&EntryFaceNameW); > + } > + > + return NULL; > +} > + > +static PFONTGDI FASTCALL > +FindFaceNameInLists(PUNICODE_STRING FaceName) > +{ > + PPROCESSINFO Win32Process; > + PFONTGDI Font; > + > + /* Search the process local list. > + We do not have to search the 'Mem' list, since those fonts are linked in the PrivateFontListHead */ > + Win32Process = PsGetCurrentProcessWin32Process(); > + IntLockProcessPrivateFonts(Win32Process); > + Font = FindFaceNameInList(FaceName, &Win32Process->PrivateFontListHead); > + IntUnLockProcessPrivateFonts(Win32Process); > + if (NULL != Font) > + { > + return Font; > + } > + > + /* Search the global list */ > + IntLockGlobalFonts(); > + Font = FindFaceNameInList(FaceName, &g_FontListHead); > + IntUnLockGlobalFonts(); > + > + return Font; > +} > + > /* See https://msdn.microsoft.com/en-us/library/bb165625(v=vs.90).aspx */ > static BYTE > CharSetFromLangID(LANGID LangID) > @@ -2670,10 +2737,67 @@ FontFamilyFillInfo(PFONTFAMILYINFO Info, LPCWSTR FaceName, > Info->NewTextMetricEx.ntmFontSig = fs; > } > > +static int FASTCALL > +FindFaceNameInInfo(PUNICODE_STRING FaceName, PFONTFAMILYINFO Info, DWORD InfoEntries) > +{ > + DWORD i; > + UNICODE_STRING InfoFaceName; > + > + for (i = 0; i < InfoEntries; i++) > + { > + RtlInitUnicodeString(&InfoFaceName, Info[i].EnumLogFontEx.elfLogFont.lfFaceName); > + if (RtlEqualUnicodeString(&InfoFaceName, FaceName, TRUE)) > + { > + return i; > + } > + } > + > + return -1; > +} > + > +static BOOLEAN FASTCALL > +FontFamilyInclude(LPLOGFONTW LogFont, PUNICODE_STRING FaceName, > + PFONTFAMILYINFO Info, DWORD InfoEntries) > +{ > + UNICODE_STRING LogFontFaceName; > + > + RtlInitUnicodeString(&LogFontFaceName, LogFont->lfFaceName); > + if (0 != LogFontFaceName.Length && > + !RtlEqualUnicodeString(&LogFontFaceName, FaceName, TRUE)) > + { > + return FALSE; > + } > + > + return FindFaceNameInInfo(FaceName, Info, InfoEntries) < 0; > +} > + > +static BOOL FASTCALL > +FontFamilyFound(PFONTFAMILYINFO InfoEntry, > + PFONTFAMILYINFO Info, DWORD InfoCount) > +{ > + LPLOGFONTW plf1 = &InfoEntry->EnumLogFontEx.elfLogFont; > + LPWSTR pFullName1 = InfoEntry->EnumLogFontEx.elfFullName; > + LPWSTR pFullName2; > + DWORD i; > + > + for (i = 0; i < InfoCount; ++i) > + { > + LPLOGFONTW plf2 = &Info[i].EnumLogFontEx.elfLogFont; > + if (plf1->lfCharSet != plf2->lfCharSet) > + continue; > + > + pFullName2 = Info[i].EnumLogFontEx.elfFullName; > + if (_wcsicmp(pFullName1, pFullName2) != 0) > + continue; > + > + return TRUE; > + } > + return FALSE; > +} > + > static BOOLEAN FASTCALL > GetFontFamilyInfoForList(LPLOGFONTW LogFont, > PFONTFAMILYINFO Info, > - LPCWSTR NominalName, > DWORD *pCount, > DWORD MaxCount, > PLIST_ENTRY Head) > @@ -2700,38 +2824,28 @@ GetFontFamilyInfoForList(LPLOGFONTW LogFont, > { > if (Count < MaxCount) > { > - FontFamilyFillInfo(&Info[Count], NominalName, NULL, FontGDI); > + FontFamilyFillInfo(&Info[Count], NULL, NULL, FontGDI); > } > Count++; > continue; > } > > - FontFamilyFillInfo(&InfoEntry, NominalName, NULL, FontGDI); > + FontFamilyFillInfo(&InfoEntry, NULL, NULL, FontGDI); > > - if (NominalName) > + if (_wcsnicmp(LogFont->lfFaceName, InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, RTL_NUMBER_OF(LogFont->lfFaceName)-1) != 0 && > + _wcsnicmp(LogFont->lfFaceName, InfoEntry.EnumLogFontEx.elfFullName, RTL_NUMBER_OF(LogFont->lfFaceName)-1) != 0) > { > - RtlStringCchCopyW(InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, > - RTL_NUMBER_OF(InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName), > - NominalName); > + continue; > } > - else > + > + if (!FontFamilyFound(&InfoEntry, Info, min(Count, MaxCount))) > { > - if (_wcsnicmp(LogFont->lfFaceName, > - InfoEntry.EnumLogFontEx.elfLogFont.lfFaceName, > - RTL_NUMBER_OF(LogFont->lfFaceName) - 1) != 0 && > - _wcsnicmp(LogFont->lfFaceName, > - InfoEntry.EnumLogFontEx.elfFullName, > - RTL_NUMBER_OF(LogFont->lfFaceName) - 1) != 0) > + if (Count < MaxCount) > { > - continue; > + RtlCopyMemory(&Info[Count], &InfoEntry, sizeof(InfoEntry)); > } > + Count++; > } > - > - if (Count < MaxCount) > - { > - RtlCopyMemory(&Info[Count], &InfoEntry, sizeof(InfoEntry)); > - } > - Count++; > } > > *pCount = Count; > @@ -2747,9 +2861,10 @@ GetFontFamilyInfoForSubstitutes(LPLOGFONTW LogFont, > { > PLIST_ENTRY pEntry, pHead = &g_FontSubstListHead; > PFONTSUBST_ENTRY pCurrentEntry; > - PUNICODE_STRING pFromW, pToW; > + PUNICODE_STRING pFromW; > + FONTGDI *FontGDI; > LOGFONTW lf = *LogFont; > - PPROCESSINFO Win32Process = PsGetCurrentProcessWin32Process(); > + UNICODE_STRING NameW; > > for (pEntry = pHead->Flink; pEntry != pHead; pEntry = pEntry->Flink) > { > @@ -2758,32 +2873,25 @@ GetFontFamilyInfoForSubstitutes(LPLOGFONTW LogFont, > pFromW = &pCurrentEntry->FontNames[FONTSUBST_FROM]; > if (LogFont->lfFaceName[0] != UNICODE_NULL) > { > - if (_wcsicmp(LogFont->lfFaceName, pFromW->Buffer) != 0) > + if (!FontFamilyInclude(LogFont, pFromW, Info, min(*pCount, MaxCount))) > continue; /* mismatch */ > } > > - pToW = &pCurrentEntry->FontNames[FONTSUBST_TO]; > - if (RtlEqualUnicodeString(pFromW, pToW, TRUE) && > - pCurrentEntry->CharSets[FONTSUBST_FROM] == > - pCurrentEntry->CharSets[FONTSUBST_TO]) > - { > - continue; > - } > - > IntUnicodeStringToBuffer(lf.lfFaceName, sizeof(lf.lfFaceName), pFromW); > SubstituteFontRecurse(&lf); > - if (LogFont->lfCharSet != DEFAULT_CHARSET && LogFont->lfCharSet != lf.lfCharSet) > - continue; > > - IntLockGlobalFonts(); > - GetFontFamilyInfoForList(&lf, Info, pFromW->Buffer, pCount, MaxCount, &g_FontListHead); > - IntUnLockGlobalFonts(); > + RtlInitUnicodeString(&NameW, lf.lfFaceName); > + FontGDI = FindFaceNameInLists(&NameW); > + if (FontGDI == NULL) > + { > + continue; /* no real font */ > + } > > - IntLockProcessPrivateFonts(Win32Process); > - GetFontFamilyInfoForList(&lf, Info, pFromW->Buffer, pCount, MaxCount, > - &Win32Process->PrivateFontListHead); > - IntUnLockProcessPrivateFonts(Win32Process); > - break; > + if (*pCount < MaxCount) > + { > + FontFamilyFillInfo(&Info[*pCount], pFromW->Buffer, NULL, FontGDI); > + } > + (*pCount)++; > } > > return TRUE; > @@ -5426,7 +5534,7 @@ NtGdiGetFontFamilyInfo(HDC Dc, > /* Enumerate font families in the global list */ > IntLockGlobalFonts(); > Count = 0; > - if (! GetFontFamilyInfoForList(&LogFont, Info, NULL, &Count, Size, &g_FontListHead) ) > + if (! GetFontFamilyInfoForList(&LogFont, Info, &Count, Size, &g_FontListHead) ) > { > IntUnLockGlobalFonts(); > ExFreePoolWithTag(Info, GDITAG_TEXT); > @@ -5437,7 +5545,7 @@ NtGdiGetFontFamilyInfo(HDC Dc, > /* Enumerate font families in the process local list */ > Win32Process = PsGetCurrentProcessWin32Process(); > IntLockProcessPrivateFonts(Win32Process); > - if (! GetFontFamilyInfoForList(&LogFont, Info, NULL, &Count, Size, > + if (! GetFontFamilyInfoForList(&LogFont, Info, &Count, Size, > &Win32Process->PrivateFontListHead)) > { > IntUnLockProcessPrivateFonts(Win32Process); > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

5 years, 6 months

Proposal for GSOC

by Akshay Patil

Hello everyone, I am Akshay Patil, a 3rd year undergraduate student studying Computer Science in VIIT, Pune, India. I have been trying React OS for a while now and found it really interesting. I love open source. I want to contribute for the project "*Applications Manager Rapps*" through Google summer of Code 2019. I have been using C++ launguage for 5 years and also made some applications like user control app. I am sure tthat the experience I ganied from last few years will certainly help me in understanding the Rapps Code easily. We will figure out the concrete goals of the project and the decided the plan for the project with the mentor. It'll be great if somebody, could mentor me for this project. Thanks, Akshay Patil

5 years, 6 months

ReactOS 0.4.11 to be released tomorrow, March 4, 2019 - Press Kit is online!

by Colin Finck

Hi all! ReactOS 0.4.11 is going to be released tomorrow, Monday, March 4, 2019. The download will be officially available around noon (CEST). A Press Kit for the ReactOS 0.4.11 release is already available: https://download.reactos.org/reactos/ReactOS/0.4.11/ReactOS-0.4.11-PressKit… Feel free to send it to interested parties to let them know about the upcoming release in advance. Best regards, Colin Finck

5 years, 6 months

Fwd: [ReactOS Chat] Notification in ReactOS on March 1, 2019

by Javier Agustìn Fernàndez Arroyo

They do! ---------- Forwarded message --------- From: <chat(a)reactos.org> Date: vie., 1 mar. 2019 18:30 Subject: [ReactOS Chat] Notification in ReactOS on March 1, 2019 To: <elhoir(a)gmail.com> You have a new notification. Channel: Town Square @Colin Finck - 17:30 UTC, March 1 @all Mattermost E-Mail notifications should finally work now :) Go To Post <https://chat.reactos.org/reactos/pl/54gbdt6h63rz8j5tqbmtg3wkpc> Any questions at all, mail us any time: feedback(a)mattermost.com Best wishes, The ReactOS Chat Team To change your notification preferences, log in to your team site and go to Account Settings > Notifications.

5 years, 6 months

Status Meeting (February 2019)

by Colin Finck

Hi all! Let me invite you to the February 2019 meeting, taking place this Thursday, February 28, 19:00 UTC. It will again happen in the private "Meeting" channel on our Mattermost server at https://chat.reactos.org. The current agenda is as follows: * Status Updates ============== As always, please have your status report ready before the meeting, so that we can get this done quickly. * Google Summer of Code 2019 ========================== Google is about to announce the list of participating organizations today, so we should prepare to spread the word and soon answer lots of questions from interested students. * 0.4.11 ====== Let's quickly update everyone on the state of the 0.4.11 release and the changelog in order to get it out soon. As always, please let me know if you want anything to be added to the agenda. Cheers, Colin

5 years, 6 months

← Newer
1
...
6
7
8
9
10
11
12
...
579
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev