Ros-dev

ros-dev@reactos.org

5791 discussions

Hackfest 2019 - Deadline for Merchandising and Financial Assistance
by Colin Finck 04 Jul '19

04 Jul '19

Hi all! The ReactOS Hackfest will take place in about a month and a week. Please revisit https://reactos.org/wiki/ReactOS_Hackfest_2019/Lists and put yourself in all relevant lists if you are going to attend. I've just updated the Shirts/Hoodies section with the final design. Please check that out and add whether you want a shirt or a hoodie. You may also want to check the links regarding the exact sizes again. Deadline for this is THURSDAY, JULY 11 After that, I will move on and buy the merchandising products. If your attendance at the Hackfest needs financial assistance from ReactOS Deutschland e.V., please also get in touch with me before that deadline. You know, flights and accommodation get more expensive the closer we are to the event date ;) Cheers, Colin

1 0

BuildBot Upgrade on Tuesday
by Colin Finck 23 Jun '19

23 Jun '19

Hi all! Our BuildBot at https://build.reactos.org is finally going to be upgraded from the ancient version 0.8.14 to the latest 2.3.1 release this Tuesday evening (CEST). We have postponed this for a very long time due to the fundamental UI changes in newer versions. The UI has been rewritten from scratch and its Waterfall View has been simplified. I used to be a strong opponent of this change. However, in one of the last meetings, it turned out that the current Waterfall View isn't that popular among our developers anyway. You can expect the new BuildBot to look like this: https://lidell.nu/xemacs-buildbot/ BuildBot also doesn't provide a direct migration path from the old to the new version. This means that previous build and log information will be gone after the upgrade. I used to consider this a blocker as well, but current BuildBot already purges old build/log information after some time and apparently it hasn't been missed. We still have all important information in Testman. I will make sure however that build numbers in the new version continue where they ended in the old version. On the plus side, this upgrade brings integrations with GitHub and Mattermost as well as proper Unicode support. Using an up-to-date BuildBot version also allows us to actually enhance it. In fact, this upgrade is a prerequisite for the Developer Web Interface our GSoC student Ayush Sinha is currently working on. Regarding Buildslaves (now called "workers"), the new BuildBot is still compatible with 0.8.x clients, so these don't need an upgrade right away. We just need a small change on workers submitting test results. Kudos go to Victor Perevertkin, who has already begun evaluating the new BuildBot version a long time ago and provided me with an updated master.cfg file, along with other help! I'm glad that the number of people maintaining our BuildBot setup is growing! :) Cheers, Colin

1 0

Coding style fixes/improvements
by Victor Perevertkin 07 Jun '19

07 Jun '19

Hi! Recently I've looked into Doxygen manual for writing documentation and noticed that an example on our Coding style <https://reactos.org/wiki/index.php?title=Coding_Style> page on wiki uses some statements in a wrong way. Namely, @name statement is for defining sections, groups and definitely not for functions/structs/classes etc. Another thing is a function description. Doxygen has two types of them: brief and detailed one. Brief description must be defined by @brief statement, but for detailed one @details can be omitted (which in fact was done in our example). Obviously, brief description should be used in first place (and that would be likely the only one) I've made some changes, to the page (see the latest change in page history) Btw, I think it can be extended to something like this ( http://micro-os-plus.github.io/develop/doxygen-style-guide/) sometime If you have any objections or suggestions, feel free to add them or discuss here. Cheers, Victor

1 0

Re: [ros-dev] [ros-diffs] [reactos] 02/02: [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List.
by Thomas Faber 07 Jun '19

07 Jun '19

This does not seem right. On 2019-06-06 19:14, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c47ad98ff79ad98042ff2… > > commit c47ad98ff79ad98042ff2043d739be58770c2fbc > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Thu Jun 6 19:12:44 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Thu Jun 6 19:12:44 2019 +0200 > > [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. > --- > dll/win32/setupapi/cfgmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dll/win32/setupapi/cfgmgr.c b/dll/win32/setupapi/cfgmgr.c > index 8215d47ac63..d33a6497172 100644 > --- a/dll/win32/setupapi/cfgmgr.c > +++ b/dll/win32/setupapi/cfgmgr.c > @@ -6761,7 +6761,7 @@ CM_Query_Resource_Conflict_List( > if (lpDevInst == NULL) > return CR_INVALID_DEVNODE; > > - pConflictData = MyMalloc(sizeof(CONFLICT_DATA)); > + pConflictData = MyMalloc(sizeof(PCONFLICT_DATA)); > if (pConflictData == NULL) > { > ret = CR_OUT_OF_MEMORY; >

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
by gedmurphy.maillists＠gmail.com 29 May '19

29 May '19

+ /* Now we need to set the Hostname */ + lError = RegOpenKeyExW(HKEY_LOCAL_MACHINE, + L"SYSTEM\\CurrentControlSet\\Services\\Tcpip\\Parameters", + 0, + KEY_SET_VALUE, + &hKey); + if (lError != ERROR_SUCCESS) + { + DPRINT1("RegOpenKeyExW for Tcpip\\Parameters failed (%08lX)\n", lError); + return TRUE; Typo?

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory
by gedmurphy.maillists＠gmail.com 08 May '19

08 May '19

Hadn't we decided to default to strsafe apis for all new code? StringCchPrintfW StringCchCopyW -----Original Message----- From: Ros-diffs <ros-diffs-bounces(a)reactos.org> On Behalf Of Pierre Schweitzer Sent: 08 May 2019 19:42 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [reactos] 01/02: [BASESVR] Take SessionId into account while creating BNO directory https://git.reactos.org/?p=reactos.git;a=commitdiff;h=20f57973866eb54d3c282… commit 20f57973866eb54d3c2822a3b62a309a9983c196 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Wed May 8 20:35:31 2019 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed May 8 20:35:31 2019 +0200 [BASESVR] Take SessionId into account while creating BNO directory --- subsystems/win/basesrv/init.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/subsystems/win/basesrv/init.c b/subsystems/win/basesrv/init.c index ebfe937068..84b24f38db 100644 --- a/subsystems/win/basesrv/init.c +++ b/subsystems/win/basesrv/init.c @@ -353,8 +353,14 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) SystemRootString.Buffer); ASSERT(Success); - /* FIXME: Check Session ID */ - wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + if (SessionId != 0) + { + swprintf(BnoBuffer, L"\\Sessions\\%ld\\BaseNamedObjects", SessionId); + } + else + { + wcscpy(BnoBuffer, L"\\BaseNamedObjects"); + } RtlInitUnicodeString(&BnoString, BnoBuffer); /* Allocate the server data */ @@ -531,7 +537,7 @@ BaseInitializeStaticServerData(IN PCSR_SERVER_DLL LoadedServerDll) Status = NtCreateSymbolicLinkObject(&SymHandle, SYMBOLIC_LINK_ALL_ACCESS, &ObjectAttributes, - &SymlinkName); + &BnoString); if ((NT_SUCCESS(Status)) && SessionId == 0) NtClose(SymHandle); /* Make Session point back to BNOLINKS */

1 0

MS Console/Terminal stuff (was: "RE: Ros-dev Digest, Vol 177, Issue 2")
by Hermès BÉLUSCA-MAÏTO 08 May '19

08 May '19

Hi, I’m trying to answer point by point. 1. Their license is MIT. At least it allows us to borrow ideas from their code for how to implement stuff in ReactOS’ console/terminal. (I suppose that if one wants to copy entire chunks of code, that I wouldn’t do it, I’m not sure how the licensing of the original ReactOS console GPL code would have to change. But “I’m not a lawyer”. Anyway, copy-pasting stuff is never a good idea.) 2. Yes but again you don’t need to care. It allows us to remain “original” in our way of implementing the things. What’s now “documented” however, is the interface between condrv and conhost (and to kernel32 if my quick reading of the shared headers is correct). This is sufficient. Then the internal implementation one can write for ReactOS is left free, this allows one to have original code and note a dull copy-paste. 3. ReactOS doesn’t use C++ in the console, and won’t use ”WinRT” any time soon in its entire code-base. So forget about any direct import of the MS console code into ROS. Regards, Hermès De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Biswapriyo Nath Envoyé : mardi 7 mai 2019 20:42 À : ros-dev(a)reactos.org Objet : Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2 Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

3 2

Re: [ros-dev] Ros-dev Digest, Vol 177, Issue 2
by Biswapriyo Nath 07 May '19

07 May '19

Some queries though: 1. There are many restrictions on how the code can be used. Are developers allowed to import the idea to ReactOS? Also with a different license. 2. The half of the codebase of console subsystem implemented in KernelBase and Kernel32. Those are not open source. Also the main magic happens in ConDrv driver. 3. The project has C++/WinRT code. Does ReactOS have that section? Thank you <3

1 0

Microsoft open-sources its console / terminal code! (MIT-licensed)
by Hermès BÉLUSCA-MAÏTO 07 May '19

07 May '19

Dear All, Yes you've read correctly! Microsoft released the code of its terminal + the Windows console host (conhost.exe) under MIT license at: https://github.com/microsoft/Terminal I think this is a really great move!! This can definitively help us for: * first, allowing us to improve our existing console code, * and in the future, getting our console architecture Win10-compatible (...) This also means that anybody can contribute back to their code via pull-requests, or at least creating issues. For those using Windows 10, they plan releasing official builds starting June 2019 according to their posts: https://devblogs.microsoft.com/commandline/introducing-windows-terminal/ https://www.hanselman.com/blog/ANewConsoleForWindowsItsTheOpenSourceWindowsT erminal.aspx Best, Hermès

1 0

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [POWERCFG] Fix an exception that occurs when the control panel is closed.
by Thomas Faber 04 May '19

04 May '19

This fix seems odd. I thought HeapFree(NULL) was well-defined and did nothing (despite what MSDN says). Pretty sure Wine uses it everywhere. Am I missing something? On 2019-04-27 19:02, Eric Kohl wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce218f70ec8a758ec6d40… > > commit ce218f70ec8a758ec6d4039690bae29c23289b9d > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Sat Apr 27 19:00:33 2019 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Sat Apr 27 19:01:35 2019 +0200 > > [POWERCFG] Fix an exception that occurs when the control panel is closed. > --- > dll/cpl/powercfg/powershemes.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dll/cpl/powercfg/powershemes.c b/dll/cpl/powercfg/powershemes.c > index 4fff28a279..7d1441a043 100644 > --- a/dll/cpl/powercfg/powershemes.c > +++ b/dll/cpl/powercfg/powershemes.c > @@ -78,8 +78,12 @@ AddPowerScheme( > dwDescription + sizeof(TCHAR)); > if (pScheme->pszName == NULL || pScheme->pszDescription == NULL) > { > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > return NULL; > } > @@ -103,8 +107,12 @@ DeletePowerScheme( > { > RemoveEntryList(&pScheme->ListEntry); > > - HeapFree(GetProcessHeap(), 0, pScheme->pszName); > - HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + if (pScheme->pszName) > + HeapFree(GetProcessHeap(), 0, pScheme->pszName); > + > + if (pScheme->pszDescription) > + HeapFree(GetProcessHeap(), 0, pScheme->pszDescription); > + > HeapFree(GetProcessHeap(), 0, pScheme); > } > >

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
580
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev