Ros-dev

ros-dev@reactos.org

5788 discussions

by caemyr＠myopera.com

Is the new geometry backward-compatible? If i recreate the partitions, will they be visible when i regress test revisions before 54511? -- With best regards Caemyr

13 years, 1 month

Rbuild debug & KVM tester offline

by Pierre Schweitzer

Hi, due to connectivity issues with our servers in Sweden, I've taken our rbuild debug buildslave & our KVM testbot offline. This doesn't affect ISOs storage for the moment. Regards, Pierre

13 years, 1 month

Sending pointers with non pointer functions!

by James Tabor

I see this and I LMFAO! co_IntSendMessageNoWait(Window->head.h, WM_WINDOWPOSCHANGING, 0, (LPARAM) WinPos); co_IntSendMessageNoWait(WinPos.hwnd, WM_WINDOWPOSCHANGED, 0, (LPARAM) &WinPos); There is more too! Amazing! Please tell me this is not wrong!!!! James

13 years, 1 month

Re: [ros-dev] New harddisk geometry

by Love Nystrom

Hi People, I'm back after my ordeal in Europe and finally got an inet line.. But now I've over 300 mails from the list to wade through.. Ugh. It's gonna take some time to get up to speed. Hi Eric, That's all fine, it's just an educated choice of disk parameters as I see it. But anyway, all disk handling software (drivers etc) should honor whatever disk parameters you write in the boot record when you format the partition, and whatever geometry you write in the MBR when the disk gets partitioned, whether it's this or that. Just in case someone forgot ;) Best Regards Love > From: Eric Kohl <eric.kohl(a)t-online.de> > To: ReactOS Development List <ros-dev(a)reactos.org> > Date: Mon, 21 Nov 2011 23:17:40 +0100 > Subject: [ros-dev] Announcement: New harddisk geometry next weekend > Hi! > > I plan to change the standard harddisk geometry from the old 32 sectors and 64 heads geometry to the > new 63 sectors and 255 heads geometry next weekend. The old disk geometry was used up to > Windows NT4 and the new geometry is used since Windows 2000. So I guess it is time for ReactOS to > make this change too. ;-) > > This should improve the compatiibility with other OSs because every modern OS uses the new disk > geometry. > > Please note that you must delete and re-create all partitions on your virtual harddisk in order to get > a clean partition table when the new disk geomerty is in use. > > Regards, > Eric

13 years, 1 month

Re: [ros-dev] [ros-diffs] [cgutman] 54484: [SCSIPORT] - Implement ScsiPortGetLogicalUnit

by Timo Kreuzer

Am 24.11.2011 01:07, schrieb cgutman(a)svn.reactos.org: > Author: cgutman > Date: Thu Nov 24 00:07:15 2011 > New Revision: 54484 > > URL: http://svn.reactos.org/svn/reactos?rev=54484&view=rev > Log: > [SCSIPORT] > - Implement ScsiPortGetLogicalUnit > > Modified: > trunk/reactos/drivers/storage/scsiport/scsiport.c > > ... > + > + /* Return the logical unit miniport extension */ > + return (LunExtension + 1); > } This looks broken to me. The old code was "&LunExtension->MiniportLunExtension", which seems to make more sense.

13 years, 1 month

Re: [ros-dev] [ros-diffs] [jgardou] 54462: [RTL] - explicitly truncate some values, so it doesn't count as an error for compiler/MSVC runtime checker

by Timo Kreuzer

That doesn't make much sense. Whats the point of the LOWORD() macro, if not truncating it ? Fix the macro if its broken. Am 20.11.2011 20:45, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Sun Nov 20 19:45:06 2011 > New Revision: 54462 > > URL: http://svn.reactos.org/svn/reactos?rev=54462&view=rev > Log: > [RTL] > - explicitly truncate some values, so it doesn't count as an error for compiler/MSVC runtime checker > > Modified: > trunk/reactos/lib/rtl/image.c > > Modified: trunk/reactos/lib/rtl/image.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/image.c?rev=54462&… > ============================================================================== > --- trunk/reactos/lib/rtl/image.c [iso-8859-1] (original) > +++ trunk/reactos/lib/rtl/image.c [iso-8859-1] Sun Nov 20 19:45:06 2011 > @@ -369,7 +369,7 @@ > { > SHORT Offset; > USHORT Type; > - USHORT i; > + ULONG i; > PUSHORT ShortPtr; > PULONG LongPtr; > PULONGLONG LongLongPtr; > @@ -379,7 +379,6 @@ > Offset = SWAPW(*TypeOffset)& 0xFFF; > Type = SWAPW(*TypeOffset)>> 12; > ShortPtr = (PUSHORT)(RVA(Address, Offset)); > - > /* > * Don't relocate within the relocation section itself. > * GCC/LD generates sometimes relocation records for the relocation section. > @@ -398,16 +397,16 @@ > break; > > case IMAGE_REL_BASED_HIGH: > - *ShortPtr = HIWORD(MAKELONG(0, *ShortPtr) + (LONG)Delta); > + *ShortPtr = HIWORD(MAKELONG(0, *ShortPtr) + (Delta& 0xFFFFFFFF)); > break; > > case IMAGE_REL_BASED_LOW: > - *ShortPtr = SWAPW(*ShortPtr) + LOWORD(Delta); > + *ShortPtr = SWAPW(*ShortPtr) + LOWORD(Delta& 0xFFFF); > break; > > case IMAGE_REL_BASED_HIGHLOW: > LongPtr = (PULONG)RVA(Address, Offset); > - *LongPtr = SWAPD(*LongPtr) + (ULONG)Delta; > + *LongPtr = SWAPD(*LongPtr) + (Delta& 0xFFFFFFFF); > break; > > case IMAGE_REL_BASED_DIR64: > > >

13 years, 1 month

Meeting with Stephen Gary Wozniak (Apple 'father')

by Александр

13 years, 1 month

Announcement: New harddisk geometry next weekend

by Eric Kohl

Hi! I plan to change the standard harddisk geometry from the old 32 sectors and 64 heads geometry to the new 63 sectors and 255 heads geometry next weekend. The old disk geometry was used up to Windows NT4 and the new geometry is used since Windows 2000. So I guess it is time for ReactOS to make this change too. ;-) This should improve the compatiibility with other OSs because every modern OS uses the new disk geometry. Please note that you must delete and re-create all partitions on your virtual harddisk in order to get a clean partition table when the new disk geomerty is in use. Regards, Eric

13 years, 1 month

Re: [ros-dev] [ros-diffs] [cgutman] 54418: [HALX86] - Do not allow software interrupts to preempt code running with interrupts disabled during KfLowerIrql

by Aleksey Bragin

I would like to ask our kernel gurus if this one is correct. WBR, Aleksey Bragin. On 18.11.2011 22:53, cgutman(a)svn.reactos.org wrote: > Author: cgutman > Date: Fri Nov 18 18:53:41 2011 > New Revision: 54418 > > URL: http://svn.reactos.org/svn/reactos?rev=54418&view=rev > Log: > [HALX86] > - Do not allow software interrupts to preempt code running with interrupts disabled during KfLowerIrql > > Modified: > trunk/reactos/hal/halx86/up/pic.c > > Modified: trunk/reactos/hal/halx86/up/pic.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.c?rev=54… > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] Fri Nov 18 18:53:41 2011 > @@ -665,26 +665,30 @@ > > /* Set old IRQL */ > Pcr->Irql = OldIrql; > - > - /* Check for pending software interrupts and compare with current IRQL */ > - PendingIrqlMask = Pcr->IRR& FindHigherIrqlMask[OldIrql]; > - if (PendingIrqlMask) > - { > - /* Check if pending IRQL affects hardware state */ > - BitScanReverse(&PendingIrql, PendingIrqlMask); > - if (PendingIrql> DISPATCH_LEVEL) > + > + /* Make sure interrupts were enabled */ > + if (EFlags& EFLAGS_INTERRUPT_MASK) > + { > + /* Check for pending software interrupts and compare with current IRQL */ > + PendingIrqlMask = Pcr->IRR& FindHigherIrqlMask[OldIrql]; > + if (PendingIrqlMask) > { > - /* Set new PIC mask */ > - Mask.Both = Pcr->IDR; > - __outbyte(PIC1_DATA_PORT, Mask.Master); > - __outbyte(PIC2_DATA_PORT, Mask.Slave); > - > - /* Clear IRR bit */ > - Pcr->IRR ^= (1<< PendingIrql); > + /* Check if pending IRQL affects hardware state */ > + BitScanReverse(&PendingIrql, PendingIrqlMask); > + if (PendingIrql> DISPATCH_LEVEL) > + { > + /* Set new PIC mask */ > + Mask.Both = Pcr->IDR; > + __outbyte(PIC1_DATA_PORT, Mask.Master); > + __outbyte(PIC2_DATA_PORT, Mask.Slave); > + > + /* Clear IRR bit */ > + Pcr->IRR ^= (1<< PendingIrql); > + } > + > + /* Now handle pending interrupt */ > + SWInterruptHandlerTable[PendingIrql](); > } > - > - /* Now handle pending interrupt */ > - SWInterruptHandlerTable[PendingIrql](); > } > > /* Restore interrupt state */ > >

13 years, 1 month

Re: [ros-dev] [ros-diffs] [cgutman] 54415: [I8042PRT] - Implement support for hot plugging PS/2 mice if one was present at boot (same requirement as Windows) - Fixes bug 1395

by Johannnes Anderwald

Am 18.11.2011 00:41, schrieb cgutman(a)svn.reactos.org: > Author: cgutman > Date: Thu Nov 17 23:41:18 2011 > New Revision: 54415 > > URL: http://svn.reactos.org/svn/reactos?rev=54415&view=rev > Log: > [I8042PRT] > - Implement support for hot plugging PS/2 mice if one was present at boot (same requirement as Windows) > - Fixes bug 1395 > > Exellent! -- Johannes Anderwald

13 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev