Ros-dev

ros-dev@reactos.org

5788 discussions

by Aleksey Bragin

Hello, Let me invite you to the monthly status meeting taking place last thursday of this month (hint: today), 27th of October, 19:00 UTC. The meeting will be atirc://fezile.reactos.org (Port 6667, no SSL) in the channel #meeting. Note that the IRC service will only be started shortly before the meeting. Everyone is invited to listen, and active community members have their passwords so that they can participate in the discussion. If someone still is not getting passwords sent before a meeting - please email Colin or Pierre before the meeting started to get one. Proposed agenda for the meeting: 1. Release status 2. CMake adoption status 3. Website revamp status More suggestions are welcome. With the best regards, Aleksey Bragin.

13 years, 2 months

Regressions / release status

by Aleksey Bragin

Hello! Time flies fast, and soon we are going to face the deadline (next status meeting) by which we decided to create a RC of the upcoming release. And, there are some problems. I will start from good stuff. Since the last meeting took place, quite a few regressions were fixed, and interesting bugs have also been closed. This is very good and I appreciate your efforts. However some problems remains, and here is where your help is urgently needed! For the current milestone (0.3.14), there are 3 blocker regressions and 2 big buckets of issues - ldr rewrite regressions and shell32 rewrite regressions. From blocker stuff, the most important is the heap-related one. Mephisto provided a good explanation here (http://www.reactos.org/bugzilla/show_bug.cgi?id=5857), and we need someone with a fresh eye to look into this problem. N.B. Please don't go into "let's fix some unrelated stuff in the heap code just to make it better". Look strictly into the specified bug and try to spot the place where the heap lists are getting corrupted. Anyone volunteers to have a look? LDR regressions: there are relatively many of them, but all are more-or-less nicely fixable because of the new, good LDR code. Alex - maybe you could please devote a bit of your time to check the code and see if that fixes some of the regressions? shell32 regressions: I already see some improvements being committed, please continue this way. We can make a good 0.3.14 release only if we act as a team now. It's not someone, it's YOUR help which matters. Testers are already doing as much as they can, retesting issues, providing newer debug logs, and other other things. Now it's time to act and fix regressions before moving further. It's just stupid to move further, if a rewrite introduces new bugs instead of fixing existing. I know how hard it is, but let's finish smaller steps and hence move forward. There is no way forward at all if old bugs are stacked and new regressions are introduced all the time. We can't bring in new good changes (wine syncs, 3rd party code syncs, arwinss, whatever else) until 0.3.14 is ready, and 0.3.14 is not ready until blocking regressions are fixed. As simple as it is. Thanks for reading and I hope you understand. With the best regards, Aleksey Bragin.

13 years, 2 months

Two petitions

by caemyr＠myopera.com

Hiya Its still at least two weeks until next meeting, hence i suppose ros-dev could be used in decision making even before that. I have two things i would like to push, things that i discussed a bit with varioius team memebers on IRC and got positive feedback. I would like you guys to comment on those and if you feel that one of both of them are wrong/unnecessary/not needed, please voice it out here. If there is no opposition for them, i`ll consider those two accepted and push for them to be finialised. Here we go: 1. Adding a default theme to ReactOS. We need at least one to test Themes service in trunk ootb and avoid copying it to ros install each time, which is really important in regression testing. Also, a theme is a must for our upcoming release. Since its not a big file usually, it should be present in trunk, not only in release ISO. 2. Moving Starfield screensaver from rosapps to trunk. Rosapps, no matter how much cheered, is a wasteland, a museum, a forgotten place. It will not be even buildable when we move away from rbuild. Old and unneeded code should land there, but not a new creation Carlo has been working on. Apart from that, Starfield is using OpenGL, which is also a handy ootb test tool for 3d acceleration, also important in regression testing. If you think that two screensavers are the top amount you can accept, then lets replace one of the trunk screensavers with Starfield. -- With best regards Caemyr

13 years, 2 months

Would you donate just 3 minutes to the project?

by The ReactOS Team

Dear ReactOS Community Member, We contact you today, because you have signed up for a myReactOS account some time ago. And we need your help! A German bank is currently running a sponsoring campaign for all kinds of foundations. The 1000 foundations with the most votes receive 1000 EUR each by the 15th November. You can easily increase our chances by voting on the following website: https://verein.ing-diba.de/sonstiges/33378/reactos-deutschland-ev Here is the complete voting procedure: * Open the link above * Click on the orange button "Stimme abgeben" (= Vote) * Enter your E-Mail address and solve the captcha, then hit the button "Absenden" (= Send) * You will receive a confirmation E-Mail where you have to click the first link. Finally click on "Stimme abgeben" again and you're done. Note that you can vote UP TO 3 TIMES with a single E-Mail address, and you can even cast all votes to the same foundation. You may also share this, so that we can get as many people as possible to vote for us. Let's get ReactOS among the top 1000! Cheers and thanks for your support, Aleksey Bragin and Colin Finck in the name of the ReactOS Team and ReactOS Deutschland e.V.

13 years, 2 months

Livecd video regression

by Timo Kreuzer

Hi, Since one of my recent video driver loading changes, livecd video is vga mode. The reson is: When installing bootcd, there will be only 1 video driver installed: based on 1st stage selection, either vbe or vga will be installed the other one is deactivated (start mode = manual). When installing a 3rd party driver, that one used to be installed and loaded prior to VBE and thus became Device/Video0, which win32k happily used as primary adapter. This behaviour changed with ACPI hal and VBE is loaded first, resulting is non functional VBox driver. I fixed this, by having win32k decide which driver to use, by looking if its a vga compatible driver and use that one only as fallback, if no other is present. additionally the VBE was marked as VgaCompatible. Now livecd behaves differently and simply installs both VGA and VBE. and since both are now marked as VgaCompatible, win32k doesn't know which one to use and currently uses VGA. Now how does this work in Windows? Windows has only one Adapter installed for VGA and VBE (vga.sys + vga.dll/vga256.dll/vga64k.dll/framebuf.dll) This service is always loaded and marked as "VgaCompatible". It is also used when a 3rd party driver is installed, when you switch to fullscreen console mode. This adapter is only replaced by a 3rd party adapter if that one is also vga compatible. This way its easy for win32k to decide which one to use: based on whether /BASEVIDEO is passed, either the vga compatible one or the other one can be selected. Possible solutions: 1) Add another workaround to win32k, checking if 2 VGA adapters are installed and then using the first one, instead of the second one as currently (because 1st is VGA, simply the second is used), but thats not a real solution. 2) Fix whatever is neccessary to have VBE be replaced by a 3rd party driver that is installed. (Cameron said it was related to VBE not being PNP ready.) This way we can stop marking it as VgaCompatible. 3) Combine VGA and VBE miniport into one vga compatible driver, like it's in windows. Alex mentioned that eVb has more or less finished that. Question is: whats missing to have the code comitted? Comments and feedback appreciated, Timo

13 years, 2 months

Re: [ros-dev] [ros-diffs] [jgardou] 54179: [WinMM] - avoid buffer overrun. - do not try to unload uninitialized driver. See issue #6343 for more details.

by Timo Kreuzer

I think that will not unload the last driver. Looking at MMDRV_Install, MMDrvsHi is the index of the first free array field and its incremented each time MMDRV_Install is called. The assert in line 465 is wrong. It should be "<". The for () loop in line 432 is also wrong Your change starts with MMDrvsHi - 1, the last used index, then decrements i by one before doing anything else. Am 17.10.2011 18:35, schrieb jgardou(a)svn.reactos.org: > Author: jgardou > Date: Mon Oct 17 16:35:10 2011 > New Revision: 54179 > > URL: http://svn.reactos.org/svn/reactos?rev=54179&view=rev > Log: > [WinMM] > - avoid buffer overrun. > - do not try to unload uninitialized driver. > See issue #6343 for more details. > > Modified: > trunk/reactos/dll/win32/winmm/lolvldrv.c > > Modified: trunk/reactos/dll/win32/winmm/lolvldrv.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winmm/lolvldrv.c… > ============================================================================== > --- trunk/reactos/dll/win32/winmm/lolvldrv.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/winmm/lolvldrv.c [iso-8859-1] Mon Oct 17 16:35:10 2011 > @@ -634,7 +634,7 @@ > } > > /* unload driver, in reverse order of loading */ > - i = sizeof(MMDrvs) / sizeof(MMDrvs[0]); > + i = MMDrvsHi - 1; > while (i--> 0) > { > MMDRV_ExitPerType(&MMDrvs[i], MMDRV_AUX); > > >

13 years, 2 months

CMake migration of Trunk_x86_GCCLin Debug Buildslave

by Colin Finck

Hello all, The "Trunk_x86_GCCLin Debug" Buildslave has been migrated to RosBE-Unix 2.0-RC1. All builds starting with r53983 are now created using a CMake environment. Unfortunately, the CMake builds don't boot under KVM on the same machine, but apparently for everybody else. To give you an idea what I mean by "don't boot": http://img830.imageshack.us/img830/5145/image1iz.png If nobody has an idea how to debug or fix this, I'm afraid I have to revert everything back to the rbuild scripts until a proper solution is found. - Colin

13 years, 3 months

Problems linking msxml3.dll

by Alex Ionescu

This is the original command-line: mingw32-ld --entry=_DllMain@12 --image-base=0x74ae0000 @obj-i386/dll/win32/msxml3/msxml3_objs.rsp --start-group "/usr/local/new/RosBE/i386/lib/gcc/mingw32/4.4.3/libgcc.a" obj-i386/lib/3rdparty/libxml2/libxml2.a output-i386/dll/3rdparty/libxslt/libxslt.dll obj-i386/lib/3rdparty/libwine/wine.a obj-i386/lib/3rdparty/libwine/wineldr.a obj-i386/dll/win32/urlmon/liburlmon.a obj-i386/dll/win32/wininet/libwininet.a obj-i386/dll/win32/ws2_32/libws2_32.a obj-i386/dll/win32/comctl32/libcomctl32.a obj-i386/dll/win32/shell32/libshell32.a obj-i386/dll/win32/shlwapi/libshlwapi.a obj-i386/dll/win32/cabinet/libcabinet.a obj-i386/dll/win32/oleaut32/liboleaut32.a obj-i386/dll/win32/ole32/libole32.a obj-i386/dll/win32/version/libversion.a obj-i386/dll/win32/user32/libuser32.a obj-i386/dll/win32/gdi32/libgdi32.a obj-i386/dll/win32/advapi32/libadvapi32.a obj-i386/lib/sdk/uuid/uuid.a obj-i386/dll/ntdll/libntdll.a obj-i386/lib/3rdparty/mingw/mingw_common.a obj-i386/lib/3rdparty/mingw/oldnames.a obj-i386/dll/ntdll/libntdll.a obj-i386/dll/win32/kernel32/libkernel32.a obj-i386/dll/win32/msvcrt/libmsvcrt.a obj-i386/lib/debugsup/debugsup_ntdll.a --end-group -disable-stdcall-fixup -file-alignment=0x1000 -section-alignment=0x1000 --shared --exclude-all-symbols -o output-i386/dll/win32/msxml3/msxml3.dll This is on RosBE 2.0 with RBUILD. Note that it's trying to link with libxslt.dll, which obviously won-t work on a non-Windows host. Removing that broken linkage makes the link work fine if I do it by hand. Can anyone fix? -- Best regards, Alex Ionescu

13 years, 3 months

Re: [ros-dev] [ros-diffs] [akhaldi] 54136: [CMD] * Reduce the scope of some variables.

by Alex Ionescu

Why? It doesn't change anything...and... This is not our coding standard. Best regards, Alex Ionescu On Fri, Oct 14, 2011 at 1:50 PM, <akhaldi(a)svn.reactos.org> wrote: > Author: akhaldi > Date: Fri Oct 14 17:50:16 2011 > New Revision: 54136 > > URL: http://svn.reactos.org/svn/reactos?rev=54136&view=rev > Log: > [CMD] > * Reduce the scope of some variables. > > Modified: > trunk/reactos/base/shell/cmd/assoc.c > trunk/reactos/base/shell/cmd/dir.c > trunk/reactos/base/shell/cmd/filecomp.c > trunk/reactos/base/shell/cmd/start.c > trunk/reactos/base/shell/cmd/ver.c > > Modified: trunk/reactos/base/shell/cmd/assoc.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/assoc.c?rev… > > ============================================================================== > --- trunk/reactos/base/shell/cmd/assoc.c [iso-8859-1] (original) > +++ trunk/reactos/base/shell/cmd/assoc.c [iso-8859-1] Fri Oct 14 17:50:16 > 2011 > @@ -206,8 +206,6 @@ > INT CommandAssoc (LPTSTR param) > { > > - LPTSTR lpEqualSign = NULL; > - > /* print help */ > if (!_tcsncmp (param, _T("/?"), 2)) > { > @@ -221,7 +219,7 @@ > PrintAllAssociations(); > else > { > - lpEqualSign = _tcschr(param, _T('=')); > + LPTSTR lpEqualSign = _tcschr(param, _T('=')); > if(lpEqualSign != NULL) > { > LPTSTR fileType = lpEqualSign + 1; > > Modified: trunk/reactos/base/shell/cmd/dir.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/dir.c?rev=5… > > ============================================================================== > --- trunk/reactos/base/shell/cmd/dir.c [iso-8859-1] (original) > +++ trunk/reactos/base/shell/cmd/dir.c [iso-8859-1] Fri Oct 14 17:50:16 > 2011 > @@ -1260,13 +1260,11 @@ > LPDIRSWITCHFLAGS lpFlags) /* [IN] The flags that > we will use to sort */ > { > LPWIN32_FIND_DATA lpTemp; /* A temporary pointer */ > - int First, Last, Temp; > BOOL Way; > > if (i < j) > { > - First = i; > - Last = j; > + int First = i, Last = j, Temp; > Way = TRUE; > while (i != j) > { > > Modified: trunk/reactos/base/shell/cmd/filecomp.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/filecomp.c?… > > ============================================================================== > --- trunk/reactos/base/shell/cmd/filecomp.c [iso-8859-1] (original) > +++ trunk/reactos/base/shell/cmd/filecomp.c [iso-8859-1] Fri Oct 14 > 17:50:16 2011 > @@ -209,7 +209,6 @@ > TCHAR path[MAX_PATH]; > TCHAR fname[MAX_PATH]; > TCHAR directory[MAX_PATH]; > - UINT longestfname = 0; > SHORT screenwidth; > > /* expand current file name */ > @@ -277,6 +276,7 @@ > hFile = FindFirstFile (path, &file); > if (hFile != INVALID_HANDLE_VALUE) > { > + UINT longestfname = 0; > /* Get the size of longest filename first. */ > do > { > > Modified: trunk/reactos/base/shell/cmd/start.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/start.c?rev… > > ============================================================================== > --- trunk/reactos/base/shell/cmd/start.c [iso-8859-1] (original) > +++ trunk/reactos/base/shell/cmd/start.c [iso-8859-1] Fri Oct 14 17:50:16 > 2011 > @@ -48,7 +48,6 @@ > TCHAR szFullCmdLine [CMDLINE_LENGTH]; > PROCESS_INFORMATION prci; > STARTUPINFO stui; > - INT i = 0; > #ifdef UNICODE > DWORD dwCreationFlags = CREATE_NEW_CONSOLE | > CREATE_UNICODE_ENVIRONMENT; > #else > @@ -213,7 +212,7 @@ > /* Parsing the command that gets called by start, and it's > parameters */ > { > BOOL bInside = FALSE; > - > + INT i; > /* find the end of the command and put the arguments in > param */ > for (i = 0; Rest[i]; i++) > { > > Modified: trunk/reactos/base/shell/cmd/ver.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/ver.c?rev=5… > > ============================================================================== > --- trunk/reactos/base/shell/cmd/ver.c [iso-8859-1] (original) > +++ trunk/reactos/base/shell/cmd/ver.c [iso-8859-1] Fri Oct 14 17:50:16 > 2011 > @@ -28,8 +28,6 @@ > VOID ShortVersion (VOID) > { > OSVERSIONINFO VersionInfo; > - unsigned RosVersionLen; > - LPTSTR RosVersion; > > ConOutResPrintf(STRING_CMD_SHELLINFO, _T(KERNEL_RELEASE_STR), > _T(KERNEL_VERSION_BUILD_STR)); > VersionInfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFO); > @@ -37,6 +35,9 @@ > memset(VersionInfo.szCSDVersion, 0, > sizeof(VersionInfo.szCSDVersion)); > if (GetVersionEx(&VersionInfo)) > { > + LPTSTR RosVersion; > + unsigned RosVersionLen; > + > RosVersion = VersionInfo.szCSDVersion + > _tcslen(VersionInfo.szCSDVersion) + 1; > RosVersionLen = sizeof(VersionInfo.szCSDVersion) / > sizeof(VersionInfo.szCSDVersion[0]) - > (RosVersion - VersionInfo.szCSDVersion); > > >

13 years, 3 months

RosBE-Unix 2.0-RC1

by Colin Finck

Hi all, A first release candidate of RosBE-Unix 2.0 is now available on http://svn.reactos.org/RosBE-Temp/. Compared to 1.5, it finally includes CMake 2.8.5 (with Jerome's patches), an updated GNU Make and new GMP and MPFR libraries. For the latter ones, I've added a patch to fix building under Mac OS X 10.7. Please try it out and tell me about your results. If there's anything that needs to be fixed before the release, please tell me in a reply to this mail. For the reference, the current CMake building commands in a ReactOS checkout are as follows: - ./configure.sh - cd output-i386-MinGW/host-tools - makex - cd ../reactos - makex bootcd I'll also set up this Build Environment on the Debug Buildslave as soon as possible. Happy building, Colin

13 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev