Ros-dev

ros-dev@reactos.org

1 participants
5790 discussions

by Aleksey Bragin

FYI: This is Linus' interview. http://h30565.www3.hp.com/t5/Feature- Articles/Linus-Torvalds-s-Lessons-on-Software-Development-Management/ ba-p/440 He very correctly outlines many things. One of the most important: "The other thing—and it's kind of related—that people seem to get wrong is to think that the code they write is what matters. No, even if you wrote 100% of the code, and even if you are the best programmer in the world and will never need any help with the project at all, the thing that really matters is the users of the code. The code itself is unimportant; the project is only as useful as people actually find it.” And this: "Way too many projects seem to think that the code is more important than the user, and they break things left and right, and they don't apologize for it, because they feel that they are ‘fixing’ the code and doing the right thing.” WBR, Aleksey Bragin.

13 years, 11 months

ACPI enabled on Linux Testslave

by Colin Finck

Hi all, Just for your information, I have enabled ACPI for the KVM machine used by the Linux Testslave today. For reference, the full VM configuration is like this: * QEMU/KVM-based i686 ACPI machine * 256MB of RAM * 512MB HDD on IDE Primary Master * ReactOS ISO on IDE Secondary Master * AMD PCNet-compatible Network Adapter * COM1 port redirected to a virtual Linux terminal device * PS/2 mouse * Tablet pointing device on USB Usually useful if any KVM machine is controlled over VNC, but probably not relevant for ReactOS yet. As you see, there is no virtual sound card (disabled as of 2011-06-07 due to r52098 according to my notes). Is this still correct? - Colin

13 years, 11 months

Usual build breakage rant again...

by caemyr＠myopera.com

Wont be that usual. Happened twice today, still broken atm. I`m not a dev, hence i have no idea how the devs commit stuff works and all the problems you guys have to overcome... I suppose it is too difficult for you simply to visit http://build.reactos.org/waterfall and just check if its all green (yes, no need to check stdio, just noticing the color). Your time is probably too precious to wait up to 5 bloody minutes, to see if previous build was ok... I`m not even talking about runtime regressions. Its understandable, that 45 minutes is often too much to wait, but 5?? I`m not even talking about patchbot, why should I? Already did, already tried, to no effect. If you really care about ROS, then by commiting on a broken trunk, you are practically shooting yourself in your foot. Trunk will be most likely not fixed until several other commits, sometimes a day or so. ISO will not be build. Commits will not be tested, neither by automation, nor by community, bugs will not be reported and regressions will only be found in more distant future. Then, you will ask for regtesting. You should better start doing it yourself, because you guys too often are not doing even the simplest things to keep trunk clean and working, making development harder for everyone around! -- With best regards Caemyr

13 years, 11 months

Compiler warnings

by Dmitry Gorbachev

Hi, Are there any bugs: /reactos/dll/directx/ksproxy/allocator.cpp: In member function 'void CKsAllocator::FreeMediaSamples()': /reactos/dll/directx/ksproxy/allocator.cpp:586:16: warning: deleting object of abstract class type 'IMediaSample' which has non-virtual destructor will cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/dll/directx/ksproxy/proxy.cpp: In function 'HRESULT CKsProxy_Constructor(IUnknown*, const IID&, void**)': /reactos/dll/directx/ksproxy/proxy.cpp:3188:16: warning: deleting object of polymorphic class type 'CKsProxy' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] In file included from /reactos/dll/win32/browseui/precomp.h:8:0, from /reactos/dll/win32/browseui/browseui.cpp:21: /reactos/lib/atl/atlcom.h: In instantiation of 'static HRESULT ATL::CComCreator<T1>::CreateInstance(void*, const IID&, void**) [with T1 = ATL::CComObjectCached<ATL::CComClassFactory>, HRESULT = int, IID = _GUID, LPVOID = void*]': /reactos/dll/win32/browseui/browseui.cpp:32:1: required from here /reactos/lib/atl/atlcom.h:253:5: warning: deleting object of polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/lib/atl/atlcom.h: In instantiation of 'ULONG ATL::CComObjectCached<Base>::Release() [with Base = ATL::CComClassFactory, ULONG = unsigned int]': /reactos/dll/win32/browseui/browseui.cpp:121:1: required from here /reactos/lib/atl/atlcom.h:304:4: warning: deleting object of polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] In file included from /reactos/dll/win32/shell32/precomp.h:50:0, from /reactos/dll/win32/shell32/shell32_main.cpp:22: /reactos/lib/atl/atlcom.h: In instantiation of 'static HRESULT ATL::CComCreator<T1>::CreateInstance(void*, const IID&, void**) [with T1 = ATL::CComObjectCached<ATL::CComClassFactory>, HRESULT = long int, IID = _GUID, LPVOID = void*]': /reactos/dll/win32/shell32/shell32_main.cpp:1273:1: required from here /reactos/lib/atl/atlcom.h:253:5: warning: deleting object of polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/lib/atl/atlcom.h: In instantiation of 'ULONG ATL::CComObjectCached<Base>::Release() [with Base = ATL::CComClassFactory, ULONG = long unsigned int]': /reactos/dll/win32/shell32/shell32_main.cpp:1478:1: required from here /reactos/lib/atl/atlcom.h:304:4: warning: deleting object of polymorphic class type 'ATL::CComObjectCached<ATL::CComClassFactory>' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In member function 'virtual ULONG CMiniportDMusUART::Release()': /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:114:20: warning: deleting object of polymorphic class type 'CMiniportDMusUART' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In member function 'virtual ULONG CMiniportDMusUARTStream::Release()': /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:239:20: warning: deleting object of polymorphic class type 'CMiniportDMusUARTStream' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp: In function 'NTSTATUS NewMiniportDMusUART(IMiniport**, const CLSID&)': /reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp:1274:16: warning: deleting object of polymorphic class type 'CMiniportDMusUART' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

13 years, 11 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 53823: [KERNEL32] Simplify overcomplicated function CreateHardlinkW(), and SEHify it.

by Alex Ionescu

Why are you putting SEH everywhere??? Just to avoid goto? This is infinitely retarded. Exceptions should not be used as a mechanism for flow control. Best regards, Alex Ionescu On Sat, Sep 24, 2011 at 3:51 AM, <pschweitzer(a)svn.reactos.org> wrote: > Author: pschweitzer > Date: Sat Sep 24 07:51:21 2011 > New Revision: 53823 > > URL: http://svn.reactos.org/svn/reactos?rev=53823&view=rev > Log: > [KERNEL32] > Simplify overcomplicated function CreateHardlinkW(), and SEHify it. > > Modified: > trunk/reactos/dll/win32/kernel32/client/file/hardlink.c > > Modified: trunk/reactos/dll/win32/kernel32/client/file/hardlink.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… > > ============================================================================== > --- trunk/reactos/dll/win32/kernel32/client/file/hardlink.c [iso-8859-1] > (original) > +++ trunk/reactos/dll/win32/kernel32/client/file/hardlink.c [iso-8859-1] > Sat Sep 24 07:51:21 2011 > @@ -2,11 +2,10 @@ > * > * COPYRIGHT: See COPYING in the top level directory > * PROJECT: ReactOS system libraries > - * FILE: lib/kernel32/file/hardlink.c > + * FILE: dll/win32/kernel32/client/file/hardlink.c > * PURPOSE: Hardlink functions > * PROGRAMMER: Thomas Weidenmueller (w3seek(a)users.sourceforge.net) > - * UPDATE HISTORY: > - * Created 13/03/2004 > + * Pierre Schweitzer (pierre.schweitzer(a)reactos.org) > */ > > /* INCLUDES > *****************************************************************/ > @@ -27,169 +26,110 @@ > LPCWSTR lpExistingFileName, > LPSECURITY_ATTRIBUTES lpSecurityAttributes) > { > - UNICODE_STRING LinkTarget, LinkName; > - LPVOID lpSecurityDescriptor; > - PFILE_LINK_INFORMATION LinkInformation; > - IO_STATUS_BLOCK IoStatus; > - NTSTATUS Status; > - BOOL Ret = FALSE; > + NTSTATUS Status; > + BOOL Ret = FALSE; > + ULONG NeededSize; > + IO_STATUS_BLOCK IoStatusBlock; > + OBJECT_ATTRIBUTES ObjectAttributes; > + HANDLE hTarget = INVALID_HANDLE_VALUE; > + PFILE_LINK_INFORMATION LinkInformation = NULL; > + UNICODE_STRING LinkTarget = {0, 0, NULL}, LinkName = {0, 0, NULL}; > > - if(!lpFileName || !lpExistingFileName) > - { > - SetLastError(ERROR_INVALID_PARAMETER); > - return FALSE; > - } > + TRACE("CreateHardLinkW: %S, %S, %p\n", lpFileName, lpExistingFileName, > lpSecurityAttributes); > > - lpSecurityDescriptor = (lpSecurityAttributes ? > lpSecurityAttributes->lpSecurityDescriptor : NULL); > + /* Validate parameters */ > + if(!lpFileName || !lpExistingFileName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > > - if(RtlDetermineDosPathNameType_U((LPWSTR)lpFileName) == 1 || > - RtlDetermineDosPathNameType_U((LPWSTR)lpExistingFileName) == 1) > - { > - WARN("CreateHardLinkW() cannot handle UNC Paths!\n"); > - SetLastError(ERROR_INVALID_NAME); > - return FALSE; > - } > + _SEH2_TRY > + { > + /* Get target UNC path */ > + if (!RtlDosPathNameToNtPathName_U(lpExistingFileName, &LinkTarget, > NULL, NULL)) > + { > + SetLastError(ERROR_PATH_NOT_FOUND); > + _SEH2_LEAVE; > + } > > - if(RtlDosPathNameToNtPathName_U(lpExistingFileName, &LinkTarget, NULL, > NULL)) > - { > - ULONG NeededSize = RtlGetFullPathName_U((LPWSTR)lpExistingFileName, 0, > NULL, NULL); > - if(NeededSize > 0) > + /* Open target */ > + InitializeObjectAttributes(&ObjectAttributes, > + &LinkTarget, > + OBJ_CASE_INSENSITIVE, > + NULL, > + (lpSecurityAttributes ? > lpSecurityAttributes->lpSecurityDescriptor : NULL)); > + > + Status = NtOpenFile(&hTarget, > + SYNCHRONIZE | FILE_WRITE_ATTRIBUTES, > + &ObjectAttributes, > + &IoStatusBlock, > + FILE_SHARE_READ | FILE_SHARE_WRITE | > FILE_SHARE_DELETE, > + FILE_SYNCHRONOUS_IO_NONALERT | > FILE_OPEN_REPARSE_POINT); > + if (!NT_SUCCESS(Status)) > + { > + BaseSetLastNTError(Status); > + _SEH2_LEAVE; > + } > + > + /* Get UNC path name for link */ > + if (!RtlDosPathNameToNtPathName_U(lpFileName, &LinkName, NULL, > NULL)) > + { > + SetLastError(ERROR_PATH_NOT_FOUND); > + _SEH2_LEAVE; > + } > + > + /* Prepare data for link */ > + NeededSize = sizeof(FILE_LINK_INFORMATION) + LinkName.Length; > + LinkInformation = RtlAllocateHeap(RtlGetProcessHeap(), 0, > NeededSize); > + if (!LinkInformation) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + _SEH2_LEAVE; > + } > + > + RtlMoveMemory(LinkInformation->FileName, LinkName.Buffer, > LinkName.Length); > + LinkInformation->ReplaceIfExists = FALSE; > + LinkInformation->RootDirectory = 0; > + LinkInformation->FileNameLength = LinkName.Length; > + > + /* Create hard link */ > + Status = NtSetInformationFile(hTarget, > + &IoStatusBlock, > + LinkInformation, > + NeededSize, > + FileLinkInformation); > + if (NT_SUCCESS(Status)) > + { > + Ret = TRUE; > + } > + } > + _SEH2_FINALLY > { > - LPWSTR lpNtLinkTarget = RtlAllocateHeap(RtlGetProcessHeap(), > HEAP_ZERO_MEMORY, NeededSize * sizeof(WCHAR)); > - if(lpNtLinkTarget != NULL) > - { > - LPWSTR lpFilePart; > + if (LinkTarget.Buffer) > + { > + RtlFreeHeap(RtlGetProcessHeap(), 0, LinkTarget.Buffer); > + } > > - if(RtlGetFullPathName_U((LPWSTR)lpExistingFileName, NeededSize, > lpNtLinkTarget, &lpFilePart) && > - (*lpNtLinkTarget) != L'\0') > + if (hTarget != INVALID_HANDLE_VALUE) > { > - UNICODE_STRING CheckDrive, LinkDrive; > - WCHAR wCheckDrive[10]; > + NtClose(hTarget); > + } > > - swprintf(wCheckDrive, L"\\??\\%c:", (WCHAR)(*lpNtLinkTarget)); > - RtlInitUnicodeString(&CheckDrive, wCheckDrive); > + if (LinkName.Buffer) > + { > + RtlFreeHeap(RtlGetProcessHeap(), 0, LinkName.Buffer); > + } > > - RtlZeroMemory(&LinkDrive, sizeof(UNICODE_STRING)); > + if (LinkInformation) > + { > + RtlFreeHeap(RtlGetProcessHeap(), 0, LinkInformation); > + } > + } > + _SEH2_END; > > - LinkDrive.Buffer = RtlAllocateHeap(RtlGetProcessHeap(), > HEAP_ZERO_MEMORY, (MAX_PATH + 1) * sizeof(WCHAR)); > - if(LinkDrive.Buffer != NULL) > - { > - HANDLE hFile, hTarget; > - OBJECT_ATTRIBUTES ObjectAttributes; > - > - InitializeObjectAttributes(&ObjectAttributes, > - &CheckDrive, > - OBJ_CASE_INSENSITIVE, > - NULL, > - NULL); > - > - Status = NtOpenSymbolicLinkObject(&hFile, 1, > &ObjectAttributes); > - if(NT_SUCCESS(Status)) > - { > - UNICODE_STRING LanManager; > - > - RtlInitUnicodeString(&LanManager, > L"\\Device\\LanmanRedirector\\"); > - > - NtQuerySymbolicLinkObject(hFile, &LinkDrive, NULL); > - > - if(!RtlPrefixUnicodeString(&LanManager, &LinkDrive, TRUE)) > - { > - InitializeObjectAttributes(&ObjectAttributes, > - &LinkTarget, > - OBJ_CASE_INSENSITIVE, > - NULL, > - lpSecurityDescriptor); > - Status = NtOpenFile(&hTarget, > - SYNCHRONIZE | DELETE, > - &ObjectAttributes, > - &IoStatus, > - FILE_SHARE_READ | FILE_SHARE_WRITE | > FILE_SHARE_DELETE, > - FILE_SYNCHRONOUS_IO_NONALERT | > FILE_OPEN_FOR_BACKUP_INTENT | FILE_OPEN_REPARSE_POINT); > - if(NT_SUCCESS(Status)) > - { > - if(RtlDosPathNameToNtPathName_U(lpFileName, &LinkName, > NULL, NULL)) > - { > - NeededSize = sizeof(FILE_LINK_INFORMATION) + > LinkName.Length + sizeof(WCHAR); > - LinkInformation = RtlAllocateHeap(RtlGetProcessHeap(), > HEAP_ZERO_MEMORY, NeededSize); > - if(LinkInformation != NULL) > - { > - LinkInformation->ReplaceIfExists = FALSE; > - LinkInformation->RootDirectory = 0; > - LinkInformation->FileNameLength = LinkName.Length; > - RtlCopyMemory(LinkInformation->FileName, > LinkName.Buffer, LinkName.Length); > - > - Status = NtSetInformationFile(hTarget, &IoStatus, > LinkInformation, NeededSize, FileLinkInformation); > - if(NT_SUCCESS(Status)) > - { > - Ret = TRUE; > - } > - else > - { > - BaseSetLastNTError(Status); > - } > - > - RtlFreeHeap(RtlGetProcessHeap(), 0, > LinkInformation); > - } > - else > - { > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - } > - else > - { > - SetLastError(ERROR_PATH_NOT_FOUND); > - } > - NtClose(hTarget); > - } > - else > - { > - WARN("Unable to open link destination \"%wZ\"!\n", > &LinkTarget); > - BaseSetLastNTError(Status); > - } > - } > - else > - { > - WARN("Path \"%wZ\" must not be a mapped drive!\n", > &LinkDrive); > - SetLastError(ERROR_INVALID_NAME); > - } > - > - NtClose(hFile); > - } > - else > - { > - BaseSetLastNTError(Status); > - } > - } > - else > - { > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - } > - else > - { > - SetLastError(ERROR_INVALID_NAME); > - } > - RtlFreeHeap(RtlGetProcessHeap(), 0, lpNtLinkTarget); > - } > - else > - { > - SetLastError(ERROR_NOT_ENOUGH_MEMORY); > - } > - } > - else > - { > - SetLastError(ERROR_INVALID_NAME); > - } > - RtlFreeHeap(RtlGetProcessHeap(), 0, LinkTarget.Buffer); > - } > - else > - { > - SetLastError(ERROR_PATH_NOT_FOUND); > - } > - > - return Ret; > + return Ret; > } > - > > /* > * @implemented > @@ -199,26 +139,32 @@ > LPCSTR lpExistingFileName, > LPSECURITY_ATTRIBUTES lpSecurityAttributes) > { > - PWCHAR FileNameW, ExistingFileNameW; > - BOOL Ret; > + BOOL Ret; > + PUNICODE_STRING lpFileNameW; > + UNICODE_STRING ExistingFileNameW; > > - if(!lpFileName || !lpExistingFileName) > - { > - SetLastError(ERROR_INVALID_PARAMETER); > - return FALSE; > - } > + lpFileNameW = Basep8BitStringToStaticUnicodeString(lpFileName); > + if (!lpFileNameW) > + { > + return FALSE; > + } > > - if (!(FileNameW = FilenameA2W(lpFileName, FALSE))) > - return FALSE; > + if (!lpExistingFileName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > > - if (!(ExistingFileNameW = FilenameA2W(lpExistingFileName, TRUE))) > - return FALSE; > + if (!Basep8BitStringToDynamicUnicodeString(&ExistingFileNameW, > lpExistingFileName)) > + { > + return FALSE; > + } > > - Ret = CreateHardLinkW(FileNameW , ExistingFileNameW , > lpSecurityAttributes); > + Ret = CreateHardLinkW(lpFileNameW->Buffer, ExistingFileNameW.Buffer, > lpSecurityAttributes); > > - RtlFreeHeap(RtlGetProcessHeap(), 0, ExistingFileNameW); > + RtlFreeHeap(RtlGetProcessHeap(), 0, ExistingFileNameW.Buffer); > > - return Ret; > + return Ret; > } > > /* EOF */ > > >

13 years, 11 months

Problem with new BE release candidate

by caemyr＠myopera.com

Windows cmake builder is running new BE since yesterday. First thing that i noticed, is the increase of buildtime. Previous version was consistent around 5 minutes, the new candidate - more than 7. I doublechecked it by swapping BE's back and forth. This might look not serious, but if this problem scales up, we are talking about 35 minutes of buildtime for someone who needed 25 minutes previously. -- With best regards Caemyr

13 years, 11 months

[ros-diffs] [gadamopoulos] 52716: [win32k] - Fix TrackMouseEvent. Now hot tracking really works

by James Tabor

If it passes all the wine tests w/o the intermittent hits and misses! SYNC it to HEAD!

13 years, 11 months

Re: [ros-dev] [ros-diffs] [dgorbachev] 53730: [CMAKE] Allow to specify prefix/suffix for GCC and Binutils.

by Jérôme Gardou

Hello. May I ask why you removed the -nodefaultlibs flag? Regards. Jérôme. Le 18/09/2011 02:57, dgorbachev(a)svn.reactos.org a écrit : > Author: dgorbachev > Date: Sun Sep 18 00:57:17 2011 > New Revision: 53730 > > URL: http://svn.reactos.org/svn/reactos?rev=53730&view=rev > Log: > [CMAKE] > Allow to specify prefix/suffix for GCC and Binutils. > > Modified: > trunk/reactos/cmake/gcc.cmake > trunk/reactos/lib/3rdparty/mingw/CMakeLists.txt > trunk/reactos/lib/sdk/crt/oldnames.cmake > trunk/reactos/toolchain-gcc.cmake > > Modified: trunk/reactos/cmake/gcc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=53730&… > ============================================================================== > --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) > +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Sep 18 00:57:17 2011 > @@ -86,7 +86,7 @@ > > set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o<TARGET> <LINK_LIBRARIES>") > > -set(CMAKE_EXE_LINKER_FLAGS "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--disable-auto-import -Wl,--disable-stdcall-fixup") > +set(CMAKE_EXE_LINKER_FLAGS "-nostdlib -Wl,--enable-auto-image-base,--disable-auto-import,--disable-stdcall-fixup") > > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS_INIT} -Wl,--disable-stdcall-fixup") > > @@ -134,7 +134,7 @@ > endif() > > if(${TYPE} STREQUAL kernelmodedriver) > - add_target_link_flags(${MODULE} "-Wl,--exclude-all-symbols -Wl,-file-alignment=0x1000 -Wl,-section-alignment=0x1000") > + add_target_link_flags(${MODULE} "-Wl,--exclude-all-symbols,-file-alignment=0x1000,-section-alignment=0x1000") > endif() > endfunction() > > @@ -190,25 +190,25 @@ > add_custom_command( > OUTPUT ${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > COMMAND native-spec2def -n=${_name}${_suffix} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_name}_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_BINARY_DIR}/${_name}_implib.def --kill-at --output-lib=${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_BINARY_DIR}/${_name}_implib.def --kill-at --output-lib=${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} native-spec2def) > > # Delayed importlib creation > add_custom_command( > OUTPUT ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > COMMAND native-spec2def -n=${_name}${_suffix} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_name}_delayed_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_BINARY_DIR}/${_name}_delayed_implib.def --kill-at --output-delaylib ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_BINARY_DIR}/${_name}_delayed_implib.def --kill-at --output-delaylib ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} native-spec2def) > > elseif(${_extension} STREQUAL ".def") > message("Use of def files for import libs is deprecated: ${_exports_file}") > add_custom_command( > OUTPUT ${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} --kill-at --output-lib=${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} --kill-at --output-lib=${CMAKE_BINARY_DIR}/importlibs/lib${_name}.a > DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file}) > add_custom_command( > OUTPUT ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} --kill-at --output-delaylib ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file} --kill-at --output-delaylib ${CMAKE_BINARY_DIR}/importlibs/lib${_name}_delayed.a > DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_exports_file}) > else() > message(FATAL_ERROR "Unsupported exports file extension: ${_extension}") > @@ -243,7 +243,7 @@ > endfunction() > > macro(macro_mc FILE) > - set(COMMAND_MC ${MINGW_PREFIX}windmc -A -b ${CMAKE_CURRENT_SOURCE_DIR}/${FILE}.mc -r ${REACTOS_BINARY_DIR}/include/reactos -h ${REACTOS_BINARY_DIR}/include/reactos) > + set(COMMAND_MC ${CMAKE_MC_COMPILER} -A -b ${CMAKE_CURRENT_SOURCE_DIR}/${FILE}.mc -r ${REACTOS_BINARY_DIR}/include/reactos -h ${REACTOS_BINARY_DIR}/include/reactos) > endmacro() > > #pseh lib, needed with mingw > > Modified: trunk/reactos/lib/3rdparty/mingw/CMakeLists.txt > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/CMakeLi… > ============================================================================== > --- trunk/reactos/lib/3rdparty/mingw/CMakeLists.txt [iso-8859-1] (original) > +++ trunk/reactos/lib/3rdparty/mingw/CMakeLists.txt [iso-8859-1] Sun Sep 18 00:57:17 2011 > @@ -65,8 +65,7 @@ > if(NOT MSVC) > add_custom_command( > OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_SOURCE_DIR}/moldname-msvcrt.def --kill-at --output-lib ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a > - COMMAND ${MINGW_PREFIX}ar -rc ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a) > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_SOURCE_DIR}/moldname-msvcrt.def --kill-at --output-lib ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a) > > set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a PROPERTIES GENERATED TRUE) > > > Modified: trunk/reactos/lib/sdk/crt/oldnames.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/oldnames.cmake… > ============================================================================== > --- trunk/reactos/lib/sdk/crt/oldnames.cmake [iso-8859-1] (original) > +++ trunk/reactos/lib/sdk/crt/oldnames.cmake [iso-8859-1] Sun Sep 18 00:57:17 2011 > @@ -1,8 +1,7 @@ > if(NOT MSVC) > add_custom_command( > OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a > - COMMAND ${MINGW_PREFIX}dlltool --def ${CMAKE_CURRENT_SOURCE_DIR}/moldname-msvcrt.def --kill-at --output-lib ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a > - COMMAND ${MINGW_PREFIX}ar -rc ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a) > + COMMAND ${CMAKE_DLLTOOL} --def ${CMAKE_CURRENT_SOURCE_DIR}/moldname-msvcrt.def --kill-at --output-lib ${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a) > > set_source_files_properties(${CMAKE_CURRENT_BINARY_DIR}/liboldnames.a PROPERTIES GENERATED TRUE) > > > Modified: trunk/reactos/toolchain-gcc.cmake > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/toolchain-gcc.cmake?rev=53… > ============================================================================== > --- trunk/reactos/toolchain-gcc.cmake [iso-8859-1] (original) > +++ trunk/reactos/toolchain-gcc.cmake [iso-8859-1] Sun Sep 18 00:57:17 2011 > @@ -3,19 +3,25 @@ > set(ARCH i386) > endif() > > -# Choose the right MinGW prefix > -if(ARCH MATCHES i386) > +# Choose the right MinGW toolchain prefix > +if (NOT DEFINED MINGW_TOOLCHAIN_PREFIX) > + if(ARCH MATCHES i386) > > - if(CMAKE_HOST_SYSTEM_NAME MATCHES Windows) > - set(MINGW_PREFIX "" CACHE STRING "MinGW Prefix") > - else() > - set(MINGW_PREFIX "mingw32-" CACHE STRING "MinGW Prefix") > - endif(CMAKE_HOST_SYSTEM_NAME MATCHES Windows) > + if(CMAKE_HOST_SYSTEM_NAME MATCHES Windows) > + set(MINGW_TOOLCHAIN_PREFIX "" CACHE STRING "MinGW Toolchain Prefix") > + else() > + set(MINGW_TOOLCHAIN_PREFIX "mingw32-" CACHE STRING "MinGW Toolchain Prefix") > + endif(CMAKE_HOST_SYSTEM_NAME MATCHES Windows) > > -elseif(ARCH MATCHES amd64) > - set(MINGW_PREFIX "x86_64-w64-mingw32-" CACHE STRING "MinGW Prefix") > -elseif(ARCH MATCHES arm) > - set(MINGW_PREFIX "arm-mingw32ce-" CACHE STRING "MinGW Prefix") > + elseif(ARCH MATCHES amd64) > + set(MINGW_TOOLCHAIN_PREFIX "x86_64-w64-mingw32-" CACHE STRING "MinGW Toolchain Prefix") > + elseif(ARCH MATCHES arm) > + set(MINGW_TOOLCHAIN_PREFIX "arm-mingw32ce-" CACHE STRING "MinGW Toolchain Prefix") > + endif() > +endif() > + > +if (NOT DEFINED MINGW_TOOLCHAIN_SUFFIX) > + set(MINGW_TOOLCHAIN_SUFFIX "" CACHE STRING "MinGW Toolchain Suffix") > endif() > > if(ENABLE_CCACHE) > @@ -28,11 +34,13 @@ > set(CMAKE_SYSTEM_NAME Windows) > set(CMAKE_SYSTEM_PROCESSOR i686) > > -# Which compilers to use for C and C++ > -set(CMAKE_C_COMPILER ${CCACHE} ${MINGW_PREFIX}gcc) > -set(CMAKE_CXX_COMPILER ${CCACHE} ${MINGW_PREFIX}g++) > -set(CMAKE_RC_COMPILER ${MINGW_PREFIX}windres) > -set(CMAKE_ASM_COMPILER ${MINGW_PREFIX}gcc) > +# Which tools to use > +set(CMAKE_C_COMPILER ${CCACHE} ${MINGW_TOOLCHAIN_PREFIX}gcc${MINGW_TOOLCHAIN_SUFFIX}) > +set(CMAKE_CXX_COMPILER ${CCACHE} ${MINGW_TOOLCHAIN_PREFIX}g++${MINGW_TOOLCHAIN_SUFFIX}) > +set(CMAKE_ASM_COMPILER ${MINGW_TOOLCHAIN_PREFIX}gcc${MINGW_TOOLCHAIN_SUFFIX}) > +set(CMAKE_MC_COMPILER ${MINGW_TOOLCHAIN_PREFIX}windmc) > +set(CMAKE_RC_COMPILER ${MINGW_TOOLCHAIN_PREFIX}windres) > +set(CMAKE_DLLTOOL ${MINGW_TOOLCHAIN_PREFIX}dlltool) > > if(NOT CMAKE_HOST_SYSTEM_NAME MATCHES Windows) > set(CMAKE_C_CREATE_STATIC_LIBRARY "<CMAKE_AR> crs<TARGET> <LINK_FLAGS> <OBJECTS>") > @@ -46,4 +54,4 @@ > #MARK_AS_ADVANCED(CLEAR CMAKE_CXX_STANDARD_LIBRARIES) > set(CMAKE_CXX_STANDARD_LIBRARIES "" CACHE STRING "Standard C++ Libraries") > > -set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--disable-auto-import") > +set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nostdlib -Wl,--enable-auto-image-base,--disable-auto-import") > >

13 years, 11 months

Re: [ros-dev] [ros-diffs] [rmessiant] 53729: [NTOSKRNL] Disable normal APC delivery while acquiring/releasing a heap lock. Also, BOOLEAN != NTSTATUS.

by Timo Kreuzer

Am 17.09.2011 22:26, schrieb rmessiant(a)svn.reactos.org: > Author: rmessiant > Date: Sat Sep 17 20:26:31 2011 > New Revision: 53729 > > URL: http://svn.reactos.org/svn/reactos?rev=53729&view=rev > Log: > [NTOSKRNL] > Disable normal APC delivery while acquiring/releasing a heap lock. Also, BOOLEAN != NTSTATUS. > > > Modified: > trunk/reactos/ntoskrnl/rtl/libsupp.c > > Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev… > ============================================================================== > --- trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] Sat Sep 17 20:26:31 2011 > @@ -168,7 +168,10 @@ > RtlEnterHeapLock( > PHEAP_LOCK Lock) > { > - return ExAcquireResourceExclusive(&Lock->Resource, TRUE); > + KeEnterCriticalRegion(); > + ExAcquireResourceExclusive(&Lock->Resource, TRUE); > + KeLeaveCriticalRegion(); > + return STATUS_SUCCESS; > } > > NTSTATUS > @@ -185,7 +188,9 @@ > RtlLeaveHeapLock( > PHEAP_LOCK Lock) > { > + KeEnterCriticalRegion(); > ExReleaseResource(&Lock->Resource); > + KeLeaveCriticalRegion(); > return STATUS_SUCCESS; > } > Why enable APC delivery after the resource is acquired? It should stay disabled to prevent deadlocks.

13 years, 11 months

IServ secured access

by Pierre Schweitzer

Hi, small note to inform people who were having issues connecting to secured IServ services due to wrong SSL certificate (issued for the wrong address) that the certificate has been renewed today and the issues are gone. Regards, Pierre

13 years, 11 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev