Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] [tkreuzer] 53600: [HAL] - Use functions instead of macros for irq<->vector<->irql translation, this will be neccessary, once apic support is there - Disable mp hal in rbuild for now, its broken anyway
by Alex Ionescu 05 Sep '11

05 Sep '11

There are already hal private dispatch table functions to deal with this. Please see older HAL commits and the changes in ke/i386/interrupt.c & friends. Best regards, Alex Ionescu On Mon, Sep 5, 2011 at 4:20 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon Sep 5 15:20:07 2011 > New Revision: 53600 > > URL: http://svn.reactos.org/svn/reactos?rev=53600&view=rev > Log: > [HAL] > - Use functions instead of macros for irq<->vector<->irql translation, this > will be neccessary, once apic support is there > - Disable mp hal in rbuild for now, its broken anyway > > Modified: > trunk/reactos/hal/halx86/directory.rbuild > trunk/reactos/hal/halx86/include/hal.h > trunk/reactos/hal/halx86/include/halirq.h > trunk/reactos/hal/halx86/up/pic.c > > Modified: trunk/reactos/hal/halx86/directory.rbuild > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/directory.rbuil… > > ============================================================================== > --- trunk/reactos/hal/halx86/directory.rbuild [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/directory.rbuild [iso-8859-1] Mon Sep 5 > 15:20:07 2011 > @@ -13,9 +13,9 @@ > <xi:include href="hal.rbuild" /> > <xi:include href="halacpi.rbuild" /> > <xi:include href="halxbox.rbuild" /> > - <if property="BUILD_MP" value="1"> > +  > </if> > > <if property="ARCH" value="amd64"> > > Modified: trunk/reactos/hal/halx86/include/hal.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/hal.h?r… > > ============================================================================== > --- trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/include/hal.h [iso-8859-1] Mon Sep 5 15:20:07 > 2011 > @@ -55,13 +55,11 @@ > #define TAG_BUS_HANDLER 'BusH' > > /* Internal HAL Headers */ > -#include "apic.h" > #include "bus.h" > #include "halirq.h" > #include "haldma.h" > #include "halp.h" > #include "mps.h" > -#include "ioapic.h" > #include "halacpi.h" > > /* EOF */ > > Modified: trunk/reactos/hal/halx86/include/halirq.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/halirq.… > > ============================================================================== > --- trunk/reactos/hal/halx86/include/halirq.h [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/include/halirq.h [iso-8859-1] Mon Sep 5 > 15:20:07 2011 > @@ -4,29 +4,19 @@ > > #pragma once > > -#ifdef CONFIG_SMP > +UCHAR > +FASTCALL > +HalpIrqToVector(UCHAR Irq); > > -#define FIRST_DEVICE_VECTOR (0x30) > -#define FIRST_SYSTEM_VECTOR (0xef) > +KIRQL > +FASTCALL > +HalpVectorToIrql(UCHAR Vector); > > -#define IRQ_BASE FIRST_DEVICE_VECTOR > -#define NR_IRQS (FIRST_SYSTEM_VECTOR - > FIRST_DEVICE_VECTOR) > +UCHAR > +FASTCALL > +HalpVectorToIrq(UCHAR Vector); > > -/* > - * FIXME: > - * This does not work if we have more than 24 IRQs (ie. more than one > I/O APIC) > - */ > -#define VECTOR2IRQ(vector) (23 - (vector - IRQ_BASE) / 8) > -#define VECTOR2IRQL(vector) (PROFILE_LEVEL - VECTOR2IRQ(vector)) > -#define IRQ2VECTOR(irq) (((23 - (irq)) * 8) + > FIRST_DEVICE_VECTOR) > +#define VECTOR2IRQ(vector) HalpVectorToIrq(vector) > +#define VECTOR2IRQL(vector) HalpVectorToIrql(vector) > +#define IRQ2VECTOR(irq) HalpIrqToVector(irq) > > -#else > - > -#define IRQ_BASE (0x30) > -#define NR_IRQS (16) > - > -#define VECTOR2IRQ(vector) ((vector) - IRQ_BASE) > -#define VECTOR2IRQL(vector) (PROFILE_LEVEL - VECTOR2IRQ(vector)) > -#define IRQ2VECTOR(irq) ((irq) + IRQ_BASE) > - > -#endif > > Modified: trunk/reactos/hal/halx86/up/pic.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/up/pic.c?rev=53… > > ============================================================================== > --- trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] (original) > +++ trunk/reactos/hal/halx86/up/pic.c [iso-8859-1] Mon Sep 5 15:20:07 2011 > @@ -512,6 +512,27 @@ > __writeeflags(EFlags); > } > > +UCHAR > +FASTCALL > +HalpIrqToVector(UCHAR Irq) > +{ > + return (PRIMARY_VECTOR_BASE + Irq); > +} > + > +UCHAR > +FASTCALL > +HalpVectorToIrq(UCHAR Vector) > +{ > + return (Vector - PRIMARY_VECTOR_BASE); > +} > + > +KIRQL > +FASTCALL > +HalpVectorToIrql(UCHAR Vector) > +{ > + return (PROFILE_LEVEL - (Vector - PRIMARY_VECTOR_BASE)); > +} > + > /* IRQL MANAGEMENT > ************************************************************/ > > /* > > >

1 0

Re: [ros-dev] [ros-diffs] [dchapyshev] 53519: - Fix multiple typos and bugs, found by PVS-Studio
by Alex Ionescu 05 Sep '11

05 Sep '11

A lot of these are in 3rdparty/wine DLLs. Were these bugs reported to the appropriate projects? Best regards, Alex Ionescu On Thu, Sep 1, 2011 at 4:30 PM, <dchapyshev(a)svn.reactos.org> wrote: > Author: dchapyshev > Date: Thu Sep 1 15:30:19 2011 > New Revision: 53519 > > URL: http://svn.reactos.org/svn/reactos?rev=53519&view=rev > Log: > - Fix multiple typos and bugs, found by PVS-Studio > > Modified: > trunk/reactos/base/applications/sndrec32/sndrec32.cpp > trunk/reactos/base/system/smss/client.c > trunk/reactos/dll/cpl/desk/screensaver.c > trunk/reactos/dll/win32/browseui/bandsite.cpp > trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > trunk/reactos/dll/win32/oleaut32/typelib2.c > trunk/reactos/dll/win32/rsaenh/sha2.c > trunk/reactos/dll/win32/shell32/pidl.c > trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp > trunk/reactos/ntoskrnl/config/cmcontrl.c > trunk/reactos/subsystems/win32/win32k/eng/gradient.c > trunk/reactos/subsystems/win32/win32k/objects/bitblt.c > > Modified: trunk/reactos/base/applications/sndrec32/sndrec32.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndrec32… > > ============================================================================== > --- trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] > (original) > +++ trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -766,7 +766,7 @@ > isnew = TRUE; > display_dur = TRUE; > > - ZeroMemory( file_path, MAX_PATH ); > + ZeroMemory( file_path, MAX_PATH * sizeof(TCHAR) ); > > EnableWindow( slider, FALSE ); > > > Modified: trunk/reactos/base/system/smss/client.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/client.c?… > > ============================================================================== > --- trunk/reactos/base/system/smss/client.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/smss/client.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -441,7 +441,7 @@ > */ > RtlCopyMemory > (SmpClientDirectory.CandidateClient->ProgramName, > ProgramName, > - SM_SB_NAME_MAX_LENGTH); > + SM_SB_NAME_MAX_LENGTH * > sizeof(WCHAR)); > } > } else { > DPRINT1("SM: %s: CandidateClient %p pending!\n", > __FUNCTION__, > > Modified: trunk/reactos/dll/cpl/desk/screensaver.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… > > ============================================================================== > --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) > +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -450,7 +450,7 @@ > lpBackSlash = _tcsrchr(szSearchPath, _T('\\')); > if (lpBackSlash != NULL) > { > - lpBackSlash = '\0'; > + *lpBackSlash = '\0'; > SearchScreenSavers(hwndScreenSavers, szSearchPath, pData); > } > } > > Modified: trunk/reactos/dll/win32/browseui/bandsite.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsit… > > ============================================================================== > --- trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -719,7 +719,7 @@ > if (fRebarWindow == NULL) > return E_FAIL; > > - if (IsEqualIID(pguidCmdGroup, IID_IDeskBand)) > + if (IsEqualIID(*pguidCmdGroup, IID_IDeskBand)) > { > switch (nCmdID) > { > > Modified: trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/libnurbs/i… > > ============================================================================== > --- trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc > [iso-8859-1] Thu Sep 1 15:30:19 2011 > @@ -90,7 +90,7 @@ > } > > void > -Mapdesc::identify( REAL dest[MAXCOORDS][MAXCOORDS] ) > +Mapdesc::identify( REAL (&dest)[MAXCOORDS][MAXCOORDS] ) > { > memset( dest, 0, sizeof( dest ) ); > for( int i=0; i != hcoords; i++ ) > > Modified: trunk/reactos/dll/win32/oleaut32/typelib2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/typelib… > > ============================================================================== > --- trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -317,7 +317,7 @@ > while (offset != -1) { > guidentry = (MSFT_GuidEntry > *)&This->typelib_segment_data[MSFT_SEG_GUID][offset]; > > - if (IsEqualGUID(guidentry, guid)) return offset; > + if (IsEqualGUID(*guidentry, guid)) return offset; > > offset = guidentry->next_hash; > } > > Modified: trunk/reactos/dll/win32/rsaenh/sha2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rsaenh/sha2.c?re… > > ============================================================================== > --- trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] Thu Sep 1 15:30:19 > 2011 > @@ -563,7 +563,7 @@ > } > > /* Clean up state data: */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > usedspace = 0; > } > > @@ -584,7 +584,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA256_DIGEST_LENGTH); > return buffer; > @@ -893,7 +893,7 @@ > } > > /* Zero out state data */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > > char *SHA512_End(SHA512_CTX* context, char buffer[]) { > @@ -913,7 +913,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA512_DIGEST_LENGTH); > return buffer; > @@ -968,7 +968,7 @@ > } > > /* Zero out state data */ > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > > char *SHA384_End(SHA384_CTX* context, char buffer[]) { > @@ -988,7 +988,7 @@ > } > *buffer = 0; > } else { > - MEMSET_BZERO(context, sizeof(context)); > + MEMSET_BZERO(context, sizeof(*context)); > } > MEMSET_BZERO(digest, SHA384_DIGEST_LENGTH); > return buffer; > > Modified: trunk/reactos/dll/win32/shell32/pidl.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/pidl.c?r… > > ============================================================================== > --- trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] (original) > +++ trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] Thu Sep 1 15:30:19 > 2011 > @@ -1157,7 +1157,7 @@ > if (len < sizeof(WIN32_FIND_DATAW)) > return E_INVALIDARG; > > - ZeroMemory(pfd, sizeof (WIN32_FIND_DATAA)); > + ZeroMemory(pfd, sizeof (WIN32_FIND_DATAW)); > _ILGetFileDateTime( pidl, &(pfd->ftLastWriteTime)); > pfd->dwFileAttributes = _ILGetFileAttributes(pidl, NULL, 0); > pfd->nFileSizeLow = _ILGetFileSize ( pidl, NULL, 0); > > Modified: trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… > > ============================================================================== > --- trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] > (original) > +++ trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -1607,7 +1607,7 @@ > { 0xc2, 0x82, 0x042, 0x8a, 0x4a, 0x0a } }; > static const UCHAR cmd_wdma_modes[] = { 0x87, 0x32, 0x3f }; > static const UCHAR cmd_pio_modes[] = { 0xa9, 0x57, 0x44, 0x32, > 0x3f }; > - ULONG treg = 0x54 + (dev < 3) ? (dev << 1) : 7; > + ULONG treg = 0x54 + ((dev < 3) ? (dev << 1) : 7); > > udmamode = min(udmamode, 5); > /* enable UDMA mode */ > > Modified: trunk/reactos/ntoskrnl/config/cmcontrl.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmcontrl.c… > > ============================================================================== > --- trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] Thu Sep 1 > 15:30:19 2011 > @@ -118,7 +118,7 @@ > if (!SystemHiveData) return; > > /* Initialize the Hive View List and the security cache */ > - RtlZeroMemory(SystemHive, sizeof(SystemHive)); > + RtlZeroMemory(SystemHive, sizeof(*SystemHive)); > CmpInitHiveViewList((PCMHIVE)SystemHive); > CmpInitSecurityCache((PCMHIVE)SystemHive); > > > Modified: trunk/reactos/subsystems/win32/win32k/eng/gradient.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -298,7 +298,7 @@ > #define SMALLER(a,b) (a->y < b->y) || (a->y == b->y && a->x < b->x) > #define SWAP(a,b,c) c = a;\ > a = b;\ > - a = c > + b = c > #define NLINES 3 > BOOL FASTCALL > IntEngGradientFillTriangle( > > Modified: trunk/reactos/subsystems/win32/win32k/objects/bitblt.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] Thu > Sep 1 15:30:19 2011 > @@ -667,7 +667,7 @@ > MaskPoint.y = YOriginMask; > IntLPtoDP(DCMask, &MaskPoint, 1); > MaskPoint.x += DCMask->ptlDCOrig.x; > - MaskPoint.y += DCMask->ptlDCOrig.x; > + MaskPoint.y += DCMask->ptlDCOrig.y; > } > > /* Perform the bitblt operation */ > > >

4 5

Re: [ros-dev] [ros-diffs] [tkreuzer] 53399: [VMWINST] Fix amd64 build [NTDLL] add missing amd64 specific exports [MSVCRT*] Fix mangled c++ exports for amd64 [OLEAUT32] Add amd64 adm stub for call_method, fix MSVC/amd64 buil...
by Jérôme Gardou 04 Sep '11

04 Sep '11

Le 23/08/2011 10:58, tkreuzer(a)svn.reactos.org a écrit : > Author: tkreuzer > Date: Tue Aug 23 08:58:15 2011 > New Revision: 53399 > > URL: http://svn.reactos.org/svn/reactos?rev=53399&view=rev > Log: > [VMWINST] Fix amd64 build > What about : [VMWINST] Get rid of this useless relic. I mean it's something we have to maintain, it was written for antediluvian vmware versions, and I see no reason to have such a thing. I may as well write an application to install specific ATI card drivers, or intel chipset drivers...

7 12

Re: [ros-dev] [ros-diffs] [jgardou] 53547: [VGA_NEW] - fix some warnings
by Alex Ionescu 04 Sep '11

04 Sep '11

These changes are wrong :( Please use the correct compiler flag instead (-mrtd) Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 5:09 PM, <jgardou(a)svn.reactos.org> wrote: > Author: jgardou > Date: Sat Sep 3 16:09:34 2011 > New Revision: 53547 > > URL: http://svn.reactos.org/svn/reactos?rev=53547&view=rev > Log: > [VGA_NEW] > - fix some warnings > > Modified: > trunk/reactos/drivers/video/miniport/vga_new/vga.c > > Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga… > > ============================================================================== > --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep > 3 16:09:34 2011 > @@ -19,6 +19,7 @@ > // > > VP_STATUS > +NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -28,11 +29,13 @@ > ); > > BOOLEAN > +NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ); > > BOOLEAN > +NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -102,6 +105,7 @@ > ); > > VP_STATUS > +NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > @@ -130,7 +134,6 @@ > #pragma alloc_text(PAGE,VgaSetColorLookup) > #endif > > - > > //--------------------------------------------------------------------------- > ULONG > // eVb: 1.3 [GCC] - Add NTAPI for GCC support > @@ -303,9 +306,10 @@ > return initializationStatus; > > } // end DriverEntry() > - > + > > //--------------------------------------------------------------------------- > VP_STATUS > +NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -383,7 +387,7 @@ > if ((ConfigInfo->AdapterInterfaceType == Internal) && > (VideoPortGetDeviceData(HwDeviceExtension, > VpControllerData, > - &GetDeviceDataCallback, > + GetDeviceDataCallback, > VgaAccessRange) != NO_ERROR)) > { > return ERROR_INVALID_PARAMETER; > @@ -485,9 +489,10 @@ > > > } // VgaFindAdapter() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > +NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ) > @@ -527,9 +532,10 @@ > return TRUE; > > } // VgaInitialize() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > +NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -1440,8 +1446,9 @@ > return ERROR_INVALID_PARAMETER; > > } // end VgaSetColorLookup() > - > + > VP_STATUS > +NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > > >

4 11

Re: [ros-dev] [ros-diffs] [jgardou] 53551: - revert r53547, although setting explicitly something which is default isn't a "wrong change" per se.
by Alex Ionescu 03 Sep '11

03 Sep '11

It is when it breaks the easyness to sync this code with it's original source and do diffs, sorry for not being clear. I believe the whole driver was carefully commented in the locations where it differs from the original source, and this would've added extra burden. Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 5:44 PM, <jgardou(a)svn.reactos.org> wrote: > Author: jgardou > Date: Sat Sep 3 16:44:49 2011 > New Revision: 53551 > > URL: http://svn.reactos.org/svn/reactos?rev=53551&view=rev > Log: > - revert r53547, although setting explicitly something which is default > isn't a "wrong change" per se. > > Modified: > trunk/reactos/drivers/video/miniport/vga_new/vga.c > > Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga… > > ============================================================================== > --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep > 3 16:44:49 2011 > @@ -19,7 +19,6 @@ > // > > VP_STATUS > -NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -29,13 +28,11 @@ > ); > > BOOLEAN > -NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ); > > BOOLEAN > -NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -105,7 +102,6 @@ > ); > > VP_STATUS > -NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > @@ -134,6 +130,7 @@ > #pragma alloc_text(PAGE,VgaSetColorLookup) > #endif > > + > > //--------------------------------------------------------------------------- > ULONG > // eVb: 1.3 [GCC] - Add NTAPI for GCC support > @@ -306,10 +303,9 @@ > return initializationStatus; > > } // end DriverEntry() > - > + > > //--------------------------------------------------------------------------- > VP_STATUS > -NTAPI > VgaFindAdapter( > PVOID HwDeviceExtension, > PVOID HwContext, > @@ -387,7 +383,7 @@ > if ((ConfigInfo->AdapterInterfaceType == Internal) && > (VideoPortGetDeviceData(HwDeviceExtension, > VpControllerData, > - GetDeviceDataCallback, > + &GetDeviceDataCallback, > VgaAccessRange) != NO_ERROR)) > { > return ERROR_INVALID_PARAMETER; > @@ -489,10 +485,9 @@ > > > } // VgaFindAdapter() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > -NTAPI > VgaInitialize( > PVOID HwDeviceExtension > ) > @@ -532,10 +527,9 @@ > return TRUE; > > } // VgaInitialize() > - > + > > //--------------------------------------------------------------------------- > BOOLEAN > -NTAPI > VgaStartIO( > PVOID HwDeviceExtension, > PVIDEO_REQUEST_PACKET RequestPacket > @@ -1446,9 +1440,8 @@ > return ERROR_INVALID_PARAMETER; > > } // end VgaSetColorLookup() > - > + > VP_STATUS > -NTAPI > GetDeviceDataCallback( > PVOID HwDeviceExtension, > PVOID Context, > > >

1 0

Re: [ros-dev] [ros-diffs] [cmihail] 53543: [shell32.dll] - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetest...
by Jérôme Gardou 03 Sep '11

03 Sep '11

Hello Claudiu! I notice some weird tab/spaces modifications here. Regards. Jérôme. Le 03/09/2011 16:20, cmihail(a)svn.reactos.org a écrit : > Author: cmihail > Date: Sat Sep 3 14:20:03 2011 > New Revision: 53543 > > URL: http://svn.reactos.org/svn/reactos?rev=53543&view=rev > Log: > [shell32.dll] > - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetests. > - Fix a bug in ShellLink::SetShowCmd and score one more passed winetest > > Modified: > branches/shell32_new-bringup/dll/win32/shell32/shelllink.cpp > branches/shell32_new-bringup/dll/win32/shell32/shlfileop.cpp > >

2 1

Re: [ros-dev] [ros-diffs] [rharabien] 53542: [FREELDR] - Introduce WINE-like debug macros ERR, FIXME, WARN and TRACE - Always show ERR and FIXME information - WARN and TRACE are enabled by DebugPrintMask in debug.c as befor...
by Alex Ionescu 03 Sep '11

03 Sep '11

And the bug was...? Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 11:56 AM, <rharabien(a)svn.reactos.org> wrote: > Author: rharabien > Date: Sat Sep 3 10:56:36 2011 > New Revision: 53542 > > URL: http://svn.reactos.org/svn/reactos?rev=53542&view=rev > Log: > [FREELDR] > - Introduce WINE-like debug macros ERR, FIXME, WARN and TRACE > - Always show ERR and FIXME information > - WARN and TRACE are enabled by DebugPrintMask in debug.c as before > - Thanks to new macros find bug in CMake livecd creation and fix it > > Modified: > trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/drivemap.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hardware.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwacpi.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwapm.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386disk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/i386vid.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/pcvideo.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxdisk.c > trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxhw.c > trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c > trunk/reactos/boot/freeldr/freeldr/cache/cache.c > trunk/reactos/boot/freeldr/freeldr/debug.c > trunk/reactos/boot/freeldr/freeldr/disk/disk.c > trunk/reactos/boot/freeldr/freeldr/disk/partition.c > trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c > trunk/reactos/boot/freeldr/freeldr/freeldr.c > trunk/reactos/boot/freeldr/freeldr/fs/ext2.c > trunk/reactos/boot/freeldr/freeldr/fs/fat.c > trunk/reactos/boot/freeldr/freeldr/fs/fs.c > trunk/reactos/boot/freeldr/freeldr/fs/iso.c > trunk/reactos/boot/freeldr/freeldr/fs/ntfs.c > trunk/reactos/boot/freeldr/freeldr/fs/pxe.c > trunk/reactos/boot/freeldr/freeldr/include/debug.h > trunk/reactos/boot/freeldr/freeldr/inifile/inifile.c > trunk/reactos/boot/freeldr/freeldr/inifile/parse.c > trunk/reactos/boot/freeldr/freeldr/linuxboot.c > trunk/reactos/boot/freeldr/freeldr/mm/meminit.c > trunk/reactos/boot/freeldr/freeldr/mm/mm.c > trunk/reactos/boot/freeldr/freeldr/reactos/binhive.c > trunk/reactos/boot/freeldr/freeldr/reactos/registry.c > trunk/reactos/boot/freeldr/freeldr/ui/ui.c > trunk/reactos/boot/freeldr/freeldr/windows/conversion.c > trunk/reactos/boot/freeldr/freeldr/windows/peloader.c > trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > trunk/reactos/boot/freeldr/freeldr/windows/wlmemory.c > trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c > > [This mail would be too long, it was shortened to contain the URLs only.] > > Modified: trunk/reactos/boot/freeldr/freeldr/CMakeLists.txt > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/CMake… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/drivemap.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hardware.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwacpi.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwapm.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386disk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/i386vid.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcdisk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcmem.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/pcvideo.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxdisk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxhw.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… > > Modified: trunk/reactos/boot/freeldr/freeldr/cache/blocklist.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache… > > Modified: trunk/reactos/boot/freeldr/freeldr/cache/cache.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/cache… > > Modified: trunk/reactos/boot/freeldr/freeldr/debug.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/debug… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/disk.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/partition.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… > > Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/ext2.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/ex… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/fat.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/fa… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/fs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/fs… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/iso.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/is… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/ntfs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/nt… > > Modified: trunk/reactos/boot/freeldr/freeldr/fs/pxe.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/fs/px… > > Modified: trunk/reactos/boot/freeldr/freeldr/include/debug.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… > > Modified: trunk/reactos/boot/freeldr/freeldr/inifile/inifile.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inifi… > > Modified: trunk/reactos/boot/freeldr/freeldr/inifile/parse.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inifi… > > Modified: trunk/reactos/boot/freeldr/freeldr/linuxboot.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/linux… > > Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… > > Modified: trunk/reactos/boot/freeldr/freeldr/mm/mm.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/mm… > > Modified: trunk/reactos/boot/freeldr/freeldr/reactos/binhive.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… > > Modified: trunk/reactos/boot/freeldr/freeldr/reactos/registry.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… > > Modified: trunk/reactos/boot/freeldr/freeldr/ui/ui.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/ui/ui… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/peloader.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/wlmemory.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > Modified: trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… > > >

2 1

Re: [ros-dev] [ros-diffs] [cmihail] 53541: [shell32.dll] - Don't do some parameter checks, even if MSDN says they're incompatible. Winetests with windows 2003 server as reference tells us msdn lies. (Spotted by Victor Marti...
by Alex Ionescu 03 Sep '11

03 Sep '11

Just because the checks aren't in THIS api doesn't mean MSDN lies. Best regards, Alex Ionescu On Sat, Sep 3, 2011 at 11:55 AM, <cmihail(a)svn.reactos.org> wrote: > Author: cmihail > Date: Sat Sep 3 10:55:51 2011 > New Revision: 53541 > > URL: http://svn.reactos.org/svn/reactos?rev=53541&view=rev > Log: > [shell32.dll] > - Don't do some parameter checks, even if MSDN says they're incompatible. > Winetests with windows 2003 server as reference tells us msdn lies. (Spotted > by Victor Martinez) > > Modified: > branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > > Modified: branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > URL: > http://svn.reactos.org/svn/reactos/branches/shell32_new-bringup/dll/win32/s… > > ============================================================================== > --- branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > [iso-8859-1] (original) > +++ branches/shell32_new-bringup/dll/win32/shell32/shell32_main.cpp > [iso-8859-1] Sat Sep 3 10:55:51 2011 > @@ -330,9 +330,6 @@ > (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path), > dwFileAttributes, > psfi, psfi->dwAttributes, sizeofpsfi, flags); > > - if ( (flags & SHGFI_USEFILEATTRIBUTES) && > - (flags & (SHGFI_ATTRIBUTES|SHGFI_EXETYPE|SHGFI_PIDL))) > - return FALSE; > if (!path) > return FALSE; > > > >

2 1

Re: [ros-dev] [ros-diffs] [cmihail] 53537: [shell32.dll] [FORMATTING] - Format the code to a more acceptable level. This is just for my sanity while sifting through it.
by Timo Kreuzer 03 Sep '11

03 Sep '11

Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org: > Author: cmihail > Date: Sat Sep 3 00:08:11 2011 > New Revision: 53537 > > URL:http://svn.reactos.org/svn/reactos?rev=53537&view=rev > Log: > [shell32.dll] > [FORMATTING] > - Format the code to a more acceptable level. This is just for my sanity while sifting through it. > /* skip the remaining spaces */ > - while (*cs==0x0009 || *cs==0x0020) { > + while (*cs==0x0009 || *cs==0x0020) > + { > cs++; > } > if (*cs==0) > Please don't mix tabs and spaces or we'll end up looking like GNU style ;-) Since the file already uses spaces (as we use almost everywhere), please stick to that here. Regards, Timo

3 2

Re: [ros-dev] [ros-diffs] [akhaldi] 53527: [WIN32K] * Remove some useless asserts considering cLockObj is DWORD.
by Alex Ionescu 02 Sep '11

02 Sep '11

These asserts are not useless. A DWORD can also underflow (due to a bug), hence the point of these ASSERTs -- the only bug is that the ASSERT should cast to LONG. Best regards, Alex Ionescu On Fri, Sep 2, 2011 at 9:23 AM, <akhaldi(a)svn.reactos.org> wrote: > Author: akhaldi > Date: Fri Sep 2 09:23:20 2011 > New Revision: 53527 > > URL: http://svn.reactos.org/svn/reactos?rev=53527&view=rev > Log: > [WIN32K] > * Remove some useless asserts considering cLockObj is DWORD. > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/menu.c > trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c > trunk/reactos/subsystems/win32/win32k/ntuser/window.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/menu.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -74,7 +74,6 @@ > return NULL; > } > > - ASSERT(Menu->head.cLockObj >= 0); > return Menu; > } > > @@ -137,11 +136,8 @@ > { > PMENU_OBJECT Menu = UserGetMenuObject(hMenu); > if (Menu) > - { > - ASSERT(Menu->head.cLockObj >= 0); > - > Menu->head.cLockObj++; > - } > + > return Menu; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -93,8 +93,6 @@ > return NULL; > } > > - ASSERT(Monitor->head.cLockObj >= 0); > - > return Monitor; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] > (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Fri > Sep 2 09:23:20 2011 > @@ -61,11 +61,8 @@ > > Window = UserGetWindowObject(hWnd); > if (Window) > - { > - ASSERT(Window->head.cLockObj >= 0); > - > Window->head.cLockObj++; > - } > + > return Window; > } > > @@ -86,8 +83,6 @@ > EngSetLastError(ERROR_INVALID_WINDOW_HANDLE); > return NULL; > } > - > - ASSERT(Window->head.cLockObj >= 0); > > return Window; > } > > >

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev