Hello Claudiu!
I notice some weird tab/spaces modifications here.
Regards.
Jérôme.
Le 03/09/2011 16:20, cmihail(a)svn.reactos.org a écrit :
> Author: cmihail
> Date: Sat Sep 3 14:20:03 2011
> New Revision: 53543
>
> URL: http://svn.reactos.org/svn/reactos?rev=53543&view=rev
> Log:
> [shell32.dll]
> - Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetests.
> - Fix a bug in ShellLink::SetShowCmd and score one more passed winetest
>
> Modified:
> branches/shell32_new-bringup/dll/win32/shell32/shelllink.cpp
> branches/shell32_new-bringup/dll/win32/shell32/shlfileop.cpp
>
>
Am 03.09.2011 02:08, schrieb cmihail(a)svn.reactos.org:
> Author: cmihail
> Date: Sat Sep 3 00:08:11 2011
> New Revision: 53537
>
> URL:http://svn.reactos.org/svn/reactos?rev=53537&view=rev
> Log:
> [shell32.dll]
> [FORMATTING]
> - Format the code to a more acceptable level. This is just for my sanity while sifting through it.
> /* skip the remaining spaces */
> - while (*cs==0x0009 || *cs==0x0020) {
> + while (*cs==0x0009 || *cs==0x0020)
> + {
> cs++;
> }
> if (*cs==0)
>
Please don't mix tabs and spaces or we'll end up looking like GNU style ;-)
Since the file already uses spaces (as we use almost everywhere), please
stick to that here.
Regards,
Timo
Hey again,
On 2011-09-01 15:18, dchapyshev(a)svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep 1 13:18:22 2011
> @@ -179,7 +179,7 @@
> pContext->Status = 3;
> }
> }
> - else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED)
> + else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED)
> {
> if (pContext->Status != 4)
> {
>
this should more likely be
else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE ||
IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_DISCONNECTED)
Some nice fixes right there by the way. :)
*hopes this might fix some evil bugs that have been lurking* ;)
Thanks,
Tom
Funny how Windows works without these hacks.
Let's hide more bugs :D
Best regards,
Alex Ionescu
On Tue, Aug 30, 2011 at 12:01 PM, <tkreuzer(a)svn.reactos.org> wrote:
> Author: tkreuzer
> Date: Tue Aug 30 12:01:01 2011
> New Revision: 53496
>
> URL: http://svn.reactos.org/svn/reactos?rev=53496&view=rev
> Log:
> [HAL]
> We cannot make any assumptions about the latency whith which the timer
> interrupt fires after a rollover, since VBox (other VMs probably as well)
> doesn't always meet this. Add another check to KeQueryPerformanceCounter
> that gracefully handles missing interrupts. Also raise to DISPATCH_LEVEL,
> since the function is not reentrant.
>
> Modified:
> trunk/reactos/hal/halx86/generic/timer.c
>
> Modified: trunk/reactos/hal/halx86/generic/timer.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/timer.c…
>
> ==============================================================================
> --- trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] (original)
> +++ trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] Tue Aug 30
> 12:01:01 2011
> @@ -253,6 +253,7 @@
> {
> LARGE_INTEGER CurrentPerfCounter;
> ULONG CounterValue, ClockDelta;
> + KIRQL OldIrql;
>
> /* If caller wants performance frequency, return hardcoded value */
> if (PerformanceFrequency) PerformanceFrequency->QuadPart =
> PIT_FREQUENCY;
> @@ -262,6 +263,10 @@
>
> /* Check if interrupts are disabled */
> if(!(__readeflags() & EFLAGS_INTERRUPT_MASK)) return HalpPerfCounter;
> +
> + /* Raise irql to DISPATCH_LEVEL */
> + OldIrql = KeGetCurrentIrql();
> + if (OldIrql < DISPATCH_LEVEL) KfRaiseIrql(DISPATCH_LEVEL);
>
> do
> {
> @@ -287,13 +292,21 @@
> /* Add the clock delta */
> CurrentPerfCounter.QuadPart += ClockDelta;
>
> - /* This must be true unless HalpPerfCounter has changed sign,
> - which takes approximately 245,118 years */
> - ASSERT(CurrentPerfCounter.QuadPart >= HalpLastPerfCounter.QuadPart);
> + /* Check if the value is smaller then before, this means, we somehow
> + missed an interrupt. This is a sign that the timer interrupt
> + is very inaccurate. Probably a virtual machine. */
> + if (CurrentPerfCounter.QuadPart < HalpLastPerfCounter.QuadPart)
> + {
> + /* We missed an interrupt. Assume we will receive it later */
> + CurrentPerfCounter.QuadPart += HalpCurrentRollOver;
> + }
>
> /* Update the last counter value */
> HalpLastPerfCounter = CurrentPerfCounter;
>
> + /* Restore previous irql */
> + if (OldIrql < DISPATCH_LEVEL) KfLowerIrql(OldIrql);
> +
> /* Return the result */
> return CurrentPerfCounter;
> }
>
>
>
Hi,
I am the maintainer of uranos (http://uranos.sf.net) and want to
implement the unattended setup of ReactOS into uranos. I read that you
have implemented a answer file into ReactOS.
Because of uranos does all the parts which is done by the txtinstaller
from ReactOS (partition disk, write mbr, copy files and so on) from a
linux boot environment - I want to know if it is possible to place the
unattended.inf into the filesystem so the ReactOS is read the file in
the first GUI boot.
Thank you! Cheers mario