Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] 02/04: [KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup. This should allow unhandled exceptions in a thread to trigger our crash reporter, instead of killing the process directly.
by Alex Ionescu 28 Oct '18

28 Oct '18

Uhh, this change is not correct. It overrides the proper handling of exception filtering -- please revert. Best regards, Alex Ionescu On Sun, Oct 28, 2018 at 9:03 AM Mark Jansen <mark.jansen(a)reactos.org> wrote: > > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=40549483f60aa00e9fc95… > > commit 40549483f60aa00e9fc952ba831027028f6df107 > Author: Mark Jansen <mark.jansen(a)reactos.org> > AuthorDate: Thu Oct 18 22:07:37 2018 +0200 > Commit: Mark Jansen <mark.jansen(a)reactos.org> > CommitDate: Sun Oct 28 13:01:38 2018 +0100 > > [KERNEL32] Use the default UnhandledExceptionFilter in > BaseThreadStartup. > This should allow unhandled exceptions in a thread to trigger our > crash reporter, > instead of killing the process directly. > --- > dll/win32/kernel32/client/thread.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/dll/win32/kernel32/client/thread.c > b/dll/win32/kernel32/client/thread.c > index 8fc5a7ad61..2ff0102483 100644 > --- a/dll/win32/kernel32/client/thread.c > +++ b/dll/win32/kernel32/client/thread.c > @@ -26,29 +26,6 @@ BasepNotifyCsrOfThread(IN HANDLE ThreadHandle, > > /* FUNCTIONS > ******************************************************************/ > > -static > -LONG BaseThreadExceptionFilter(EXCEPTION_POINTERS * ExceptionInfo) > -{ > - LONG ExceptionDisposition = EXCEPTION_EXECUTE_HANDLER; > - LPTOP_LEVEL_EXCEPTION_FILTER RealFilter; > - > - RealFilter = RtlDecodePointer(GlobalTopLevelExceptionFilter); > - if (RealFilter != NULL) > - { > - _SEH2_TRY > - { > - ExceptionDisposition = RealFilter(ExceptionInfo); > - } > - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) > - { > - ExceptionDisposition = > UnhandledExceptionFilter(ExceptionInfo); > - } > - _SEH2_END; > - } > - > - return ExceptionDisposition; > -} > - > __declspec(noreturn) > VOID > WINAPI > @@ -68,7 +45,7 @@ BaseThreadStartup(IN LPTHREAD_START_ROUTINE > lpStartAddress, > /* Get the exit code from the Thread Start */ > ExitThread((lpStartAddress)((PVOID)lpParameter)); > } > - > _SEH2_EXCEPT(BaseThreadExceptionFilter(_SEH2_GetExceptionInformation())) > + > _SEH2_EXCEPT(UnhandledExceptionFilter(_SEH2_GetExceptionInformation())) > { > /* Get the Exit code from the SEH Handler */ > if (!BaseRunningInServerProcess) > >

1 0

Test_KVM_AHK is temporarily offline
by Sylvain Petreolle 26 Oct '18

26 Oct '18

Hello all. My family is at home and I need to shut down the AHK bot until the end of the week. See you later on Ros ;-) Kind regards, Sylvain Petreolle

1 0

New member
by Никита 13 Oct '18

13 Oct '18

2 1

Upcoming Google Summer of Code Mentor Summit
by Colin Finck 09 Oct '18

09 Oct '18

Hi all, As announced, I'll be travelling to California this Thursday to attend the Google Summer of Code Mentor Summit from Friday to Sunday. I'll be using this opportunity to spread the word about ReactOS, our experiences with GSoC, and learning from other projects' experiences. I'm especially interested to hear how others are acquiring talented students and managing their list of task ideas over the year. Let's hope this will help us to get more than 1 student next year and efficiently collect a list of GSoC ideas continuously instead of preparing it shortly before the deadline ;) Is there anything else you want me to talk about during the summit? Cheers, Colin

2 1

Add InitializeProcThreadAttributeList function
by Biswapriyo Nath 06 Oct '18

06 Oct '18

I found that this function `InitializeProcThreadAttributeList()` is added with GetProcAddress but not with the real function. I can provide the real function from Windows 10. The function hasn't any imported function, just conatins some arithmatic operations. I don't know how to contribute and not familiar with ReactOS repo. So, I can only provide a c file.

1 0

Re: [ros-dev] [ros-diffs] 01/01: [SERVICES] Fix timeout when a service is stopped
by Pierre Schweitzer 05 Oct '18

05 Oct '18

Hey Eric, What's the purpose of that "Sleep(2000);"? Is it a debug leftover? Cheers, Pierre Le 05/10/2018 à 08:43, Eric Kohl a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f6d81f225747e4b1b3716… > > commit f6d81f225747e4b1b3716e9ca8629f77dcc52b1a > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Fri Oct 5 08:41:23 2018 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Fri Oct 5 08:41:23 2018 +0200 > > [SERVICES] Fix timeout when a service is stopped > > RSetServiceStatus: Send the stop command for the dispatcher thread from a separate thread. > > Fixes CORE-15064 > --- > base/system/services/rpcserver.c | 59 ++++++++++++++++++++++++++++++++++------ > 1 file changed, 50 insertions(+), 9 deletions(-) > > diff --git a/base/system/services/rpcserver.c b/base/system/services/rpcserver.c > index 7f251c8760..8e383a5bdc 100644 > --- a/base/system/services/rpcserver.c > +++ b/base/system/services/rpcserver.c > @@ -1671,6 +1671,43 @@ ScmIsValidServiceState(DWORD dwCurrentState) > } > > > +static > +DWORD > +WINAPI > +ScmStopThread( > + _In_ PVOID pParam) > +{ > + PSERVICE pService; > + > + DPRINT("ScmStopThread(%p)\n", pParam); > + > + pService = (PSERVICE)pParam; > + > + if (pService->lpImage->dwImageRunCount != 0) > + return 0; > + > + Sleep(2000); > + > + /* Lock the service database exclusively */ > + ScmLockDatabaseExclusive(); > + > + /* Stop the dispatcher thread */ > + ScmControlService(pService->lpImage->hControlPipe, > + L"", > + (SERVICE_STATUS_HANDLE)pService, > + SERVICE_CONTROL_STOP); > + > + /* Remove the service image */ > + ScmRemoveServiceImage(pService->lpImage); > + > + /* Unlock the service database */ > + ScmUnlockDatabase(); > + > + DPRINT("ScmStopThread done!\n"); > + return 0; > +} > + > + > /* Function 7 */ > DWORD > WINAPI > @@ -1683,6 +1720,8 @@ RSetServiceStatus( > DWORD dwPreviousType; > LPCWSTR lpLogStrings[2]; > WCHAR szLogBuffer[80]; > + HANDLE hStopThread = NULL; > + DWORD dwStopThreadId; > UINT uID; > > DPRINT("RSetServiceStatus() called\n"); > @@ -1762,15 +1801,17 @@ RSetServiceStatus( > /* If we just stopped the last running service... */ > if (lpService->lpImage->dwImageRunCount == 0) > { > - /* Stop the dispatcher thread */ > - ScmControlService(lpService->lpImage->hControlPipe, > - L"", > - (SERVICE_STATUS_HANDLE)lpService, > - SERVICE_CONTROL_STOP); > - > - /* Remove the service image */ > - ScmRemoveServiceImage(lpService->lpImage); > - lpService->lpImage = NULL; > + /* Run the stop thread to stop the service dispatcher */ > + hStopThread = CreateThread(NULL, > + 0, > + (LPTHREAD_START_ROUTINE)ScmStopThread, > + (LPVOID)lpService, > + 0, > + &dwStopThreadId); > + if (hStopThread != NULL) > + { > + CloseHandle(hStopThread); > + } > } > } > > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

WidenPath
by katahiromz 29 Sep '18

29 Sep '18

About NTGDI Should we use PATHOBJ for WidenPath and FlattenPath?

2 1

Unused bandwidth at home
by Javier Agustìn Fernàndez Arroyo 24 Sep '18

24 Sep '18

Hello all, I have just set optical fiber up at my home. The thing is, im completely sure it will be infra-used Is there anything in ROS i might do for help with that?

1 0

Re: [ros-dev] [ros-diffs] 01/01: [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager
by Pierre Schweitzer 18 Sep '18

18 Sep '18

Hi Eric, For security reason, when freeing your password buffers (see below), you shouldn't be using ZeroMemory() before free, but SecureZeroMemory() to zero the buffer. The first one can be optimized (and thus removed) by the compiler. The second cannot. Cheers, Pierre Le 17/09/2018 à 16:36, Eric Kohl a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5e2c4657ca10dea1154cb… > > commit 5e2c4657ca10dea1154cb43f16ee6962999ac7a4 > Author: Eric Kohl <eric.kohl(a)reactos.org> > AuthorDate: Mon Sep 17 16:34:48 2018 +0200 > Commit: Eric Kohl <eric.kohl(a)reactos.org> > CommitDate: Mon Sep 17 16:34:48 2018 +0200 > > [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager > --- > base/system/services/config.c | 24 ++++++++ > base/system/services/rpcserver.c | 49 ++++++++++++++-- > base/system/services/services.h | 7 +++ > dll/win32/advapi32/service/scm.c | 123 ++++++++++++++++++++++++++++++++------- > 4 files changed, 177 insertions(+), 26 deletions(-) > > diff --git a/base/system/services/rpcserver.c b/base/system/services/rpcserver.c > index aa64233350..454181bb66 100644 > --- a/base/system/services/rpcserver.c > +++ b/base/system/services/rpcserver.c > @@ -2216,12 +2232,23 @@ RChangeServiceConfigW( > dwError = ERROR_SUCCESS; > > if (dwError != ERROR_SUCCESS) > + { > + DPRINT1("ScmSetServicePassword failed (Error %lu)\n", dwError); > goto done; > + } > } > } > } > > done: > + if (lpClearTextPassword != NULL) > + { > + /* Wipe and release the password buffer */ > + ZeroMemory(lpClearTextPassword, > + (wcslen(lpClearTextPassword) + 1) * sizeof(WCHAR)); > + HeapFree(GetProcessHeap(), 0, lpClearTextPassword); > + } > + > if (hServiceKey != NULL) > RegCloseKey(hServiceKey); > > @@ -2612,6 +2645,14 @@ done: > if (hServiceKey != NULL) > RegCloseKey(hServiceKey); > > + if (lpClearTextPassword != NULL) > + { > + /* Wipe and release the password buffer */ > + ZeroMemory(lpClearTextPassword, > + (wcslen(lpClearTextPassword) + 1) * sizeof(WCHAR)); > + HeapFree(GetProcessHeap(), 0, lpClearTextPassword); > + } > + > if (dwError == ERROR_SUCCESS) > { > DPRINT("hService %p\n", hServiceHandle); -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

Re: [ros-dev] Win8 theme for ReactOS?
by theUser BL 10 Sep '18

10 Sep '18

> Isn't it fun that ppl simply don't understand a "NO" I give 'em in the > forums?! Thats only a comment of ONE developer. If your medical doctor syas you anything, do you never asks a second doctor again for the same thing, to see if he was right? > I even explained why and that GreenteaOS is not more than > stolen ROS code (*) The only problem you have had is, that he have removed the name "ReactOS" everywhere. But it is still al under the same license like ReactOS. > filled with questionable code sources like the > betaarchive forums. So "NO" means go on the other dev's nerves for a > ugly theme violating our and MS's copyrights? Why is an Win8-theme violating MS-copyright but - changing the color of WineMine to Microsofts WinMine - copying the XP explorer.exe 1:1, only the images on it are different - having a Look And Feel VERY similar to Win2000 - etc is all ok? Greetings theuserbl

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev