Ros-dev

ros-dev@reactos.org

1 participants
5793 discussions

Re: [ros-dev] [ros-diffs] 01/01: [WIN32SS] Fix NtUserGetClipboardData for text paste (#645)
by Pierre Schweitzer 08 Jul '18

08 Jul '18

For the record, that commit seems to have broken ReactOS testing (see testman, which records last successful test run for 2170901, ie, previous commit). Starting with that commit, any regression test run never ends. It seems bug reports have been creating regarding regressions (timeouts) in the tests but got ignored so far. It would be great to fix these before pushing any other commits. Cheers, Pierre Le 30/06/2018 à 17:12, Katayama Hirofumi MZ a écrit : > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6abc9f5b5af6cc7b7c57f… > > commit 6abc9f5b5af6cc7b7c57ff9c6bcc4a919cf85d1e > Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> > AuthorDate: Sun Jul 1 00:12:23 2018 +0900 > Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> > CommitDate: Sat Jun 30 17:12:23 2018 +0200 > > [WIN32SS] Fix NtUserGetClipboardData for text paste (#645) > > Fix the NtUserGetClipboardData function for the synthesized text formats (CF_TEXT, CF_OEMTEXT and CF_UNICODETEXT). > CORE-11471 > --- > win32ss/user/ntuser/clipboard.c | 47 ++++++++++++++++++++++++++--------------- > 1 file changed, 30 insertions(+), 17 deletions(-) > > diff --git a/win32ss/user/ntuser/clipboard.c b/win32ss/user/ntuser/clipboard.c > index 92109953cc..04e5d22291 100644 > --- a/win32ss/user/ntuser/clipboard.c > +++ b/win32ss/user/ntuser/clipboard.c > @@ -294,8 +294,8 @@ IntAddSynthesizedFormats(PWINSTATION_OBJECT pWinStaObj) > bHaveBm = IntIsFormatAvailable(pWinStaObj, CF_BITMAP); > bHaveDib = IntIsFormatAvailable(pWinStaObj, CF_DIB); > > - /* Add CF_LOCALE format if we have CF_TEXT */ > - if (!bHaveLocale && bHaveText) > + /* Add CF_LOCALE format if we have CF_TEXT, CF_OEMTEXT or CF_UNICODETEXT */ > + if (!bHaveLocale && (bHaveText || bHaveOemText || bHaveUniText)) > { > PCLIPBOARDDATA pMemObj; > HANDLE hMem; > @@ -881,6 +881,7 @@ NtUserGetClipboardData(UINT fmt, PGETCLIPBDATA pgcd) > HANDLE hRet = NULL; > PCLIP pElement; > PWINSTATION_OBJECT pWinStaObj; > + UINT uSourceFmt = fmt; > > TRACE("NtUserGetClipboardData(%x, %p)\n", fmt, pgcd); > > @@ -898,18 +899,7 @@ NtUserGetClipboardData(UINT fmt, PGETCLIPBDATA pgcd) > } > > pElement = IntGetFormatElement(pWinStaObj, fmt); > - if (pElement && IS_DATA_DELAYED(pElement) && pWinStaObj->spwndClipOwner) > - { > - /* Send WM_RENDERFORMAT message */ > - pWinStaObj->fInDelayedRendering = TRUE; > - co_IntSendMessage(pWinStaObj->spwndClipOwner->head.h, WM_RENDERFORMAT, (WPARAM)fmt, 0); > - pWinStaObj->fInDelayedRendering = FALSE; > - > - /* Data should be in clipboard now */ > - pElement = IntGetFormatElement(pWinStaObj, fmt); > - } > - > - if (!pElement || IS_DATA_DELAYED(pElement)) > + if (!pElement) > goto cleanup; > > if (IS_DATA_SYNTHESIZED(pElement)) > @@ -921,20 +911,43 @@ NtUserGetClipboardData(UINT fmt, PGETCLIPBDATA pgcd) > case CF_UNICODETEXT: > case CF_TEXT: > case CF_OEMTEXT: > - pElement = IntGetFormatElement(pWinStaObj, CF_UNICODETEXT); > + uSourceFmt = CF_UNICODETEXT; > + pElement = IntGetFormatElement(pWinStaObj, uSourceFmt); > if (IS_DATA_SYNTHESIZED(pElement)) > - pElement = IntGetFormatElement(pWinStaObj, CF_TEXT); > + { > + uSourceFmt = CF_TEXT; > + pElement = IntGetFormatElement(pWinStaObj, uSourceFmt); > + } > if (IS_DATA_SYNTHESIZED(pElement)) > - pElement = IntGetFormatElement(pWinStaObj, CF_OEMTEXT); > + { > + uSourceFmt = CF_OEMTEXT; > + pElement = IntGetFormatElement(pWinStaObj, uSourceFmt); > + } > break; > + > case CF_BITMAP: > IntSynthesizeBitmap(pWinStaObj, pElement); > break; > + > default: > ASSERT(FALSE); > } > } > > + if (pElement && IS_DATA_DELAYED(pElement) && pWinStaObj->spwndClipOwner) > + { > + /* Send WM_RENDERFORMAT message */ > + pWinStaObj->fInDelayedRendering = TRUE; > + co_IntSendMessage(pWinStaObj->spwndClipOwner->head.h, WM_RENDERFORMAT, (WPARAM)uSourceFmt, 0); > + pWinStaObj->fInDelayedRendering = FALSE; > + > + /* Data should be in clipboard now */ > + pElement = IntGetFormatElement(pWinStaObj, uSourceFmt); > + } > + > + if (!pElement || IS_DATA_DELAYED(pElement)) > + goto cleanup; > + > _SEH2_TRY > { > ProbeForWrite(pgcd, sizeof(*pgcd), 1); > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

2 1

Website migrated to a new Login system
by Colin Finck 04 Jul '18

04 Jul '18

Hello all, Our website has been migrated to a new Login system today and all components have been upgraded to their latest versions. In the course of that, the user database has also been moved into an LDAP directory and cleaned from accounts that have never been used. Please check that everything is working alright and report bugs in our JIRA: https://jira.reactos.org You are also advised to change your password in the self-service at https://reactos.org/roslogin/?p=selfservice - even to the same one. Every password change from now on will use a state-of-the-art hashing algorithm (salted SHA-512 with 6000 rounds) to protect your account from credential theft. Unfortunately, there have been several newer accounts, for which the password could not be migrated. If you encounter problems logging in, please reset your account password at https://reactos.org/roslogin/?p=forgot to regain access. Best regards, Colin Finck

3 2

Website Maintenance on Wednesday, July 4
by Colin Finck 01 Jul '18

01 Jul '18

Hi all! The ReactOS Website along with the Forum, Wiki, and JIRA bug tracker will be down for maintenance for several hours during the day (European time) on Wednesday, July 4. In the course of this process, the user database will be migrated to the new RosLogin Single-Sign-On system (https://github.com/reactos/web/tree/master/www/www.reactos.org/roslogin) and the Forum and Wiki software will be upgraded to their latest releases. This is expected to put an end to our login weirdnesses (dead Login buttons, 30 minute propagation delay to JIRA), solve the CAPTCHA problems people were reporting, and increase the maintainability of the website. I will be on the #reactos IRC channel during the migration and give status updates there. Best regards, Colin

1 0

Status Meeting (June 2018)
by Colin Finck 28 Jun '18

28 Jun '18

Hi all! Let me invite you to the June 2018 meeting, taking place this Thursday, June 28, 2018 at 19:00 UTC. Invited members will again receive their credentials shortly before the meeting. The current agenda is: 1. Status Reports 2. ReactOS Hackfest on August 16 - 21 3. 0.4.9 release on July 14 I'm open for additional proposals. Best regards, Colin

4 5

Re: [ros-dev] Microsoft acquires GitHub
by Thomas Mueller 16 Jun '18

16 Jun '18

from Javier Agustìn Fernàndez Arroyo: > May this affect ReactOS? > https://blogs.microsoft.com/blog/2018/06/04/microsoft-github-empowering-dev… I just found this new article on heise online about a new possible alternative to Github: https://www.heise.de/newsticker/meldung/Neue-Entwickler-Plattform-TeaHub-wi… (This is in German language) TeaHub will be nonprofit, URL is https://about.teahub.io/ This website is in English. Tom

1 0

Microsoft acquires GitHub
by Javier Agustìn Fernàndez Arroyo 11 Jun '18

11 Jun '18

May this affect ReactOS? https://blogs.microsoft.com/blog/2018/06/04/microsoft-github-empowering-dev…

8 12

Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.
by Hermès BÉLUSCA-MAÏTO 09 Jun '18

09 Jun '18

This change (on my own code snippet btw, see commit 5a1a35ca5a6) was necessary because otherwise, the StringPrintf call that is done below (which would then use a WindowTitleU.Buffer == NULL) would generate the harderror dialog title: "(null)" (in addition to other strings being appended), instead of just an empty string. And so the bug is that I forgot to adjust the condition that needs to be checked before freeing the window title string (if it has been allocated). Hermès > -----Message d'origine----- > De : Thomas Faber [mailto:thomas.faber@reactos.org] > Envoyé : samedi 9 juin 2018 09:21 > À : ros-dev(a)reactos.org; Hermès Bélusca-Maïto > Objet : Re: [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; > fix few comments; fix the default empty window title string. > > On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote: > > /* Retrieve the window title of the client, if it has one */ > > - RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0); > > + RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0); > > This looks like a bug. Can you explain why you think it's necessary please? > > In particular, it will break this: > > if (WindowTitleU.Buffer) RtlFreeUnicodeString(&WindowTitleU); > > > Thanks, > Thomas

2 1

ReactOS mirror repo detected on GitLab
by Stas'M 09 Jun '18

09 Jun '18

I've found this mirror repo on GitLab, it was created today: https://gitlab.com/reactos/reactos Does it belong to the ReactOS team? If not, we may have problems. ---- Regards, Stas'M

3 2

Re: [ros-dev] [ros-diffs] 01/01: [USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.
by Thomas Faber 09 Jun '18

09 Jun '18

On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote: > /* Retrieve the window title of the client, if it has one */ > - RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0); > + RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0); This looks like a bug. Can you explain why you think it's necessary please? In particular, it will break this: if (WindowTitleU.Buffer) RtlFreeUnicodeString(&WindowTitleU); Thanks, Thomas

1 0

Interested in building developer interface mentioned in your gsoc'18 page.
by Ayush Sinha 08 Jun '18

08 Jun '18

Hey there ! Went through the reactOS GSOC’18 page. I am interested in making web interface for reactos which can show all GitHub reactos repos, commits, etc using the GitHub API. (https://www.reactos.org/wiki/Google_Summer_of_Code_2018_Ideas#Developer_Web…) Looking forward to work on the same idea for GSOC’19 under your mentorship. Need to know more about layout of the web interface. Kindly help! thanks

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev