Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [akhaldi] 50854: [RTL] - Silence this dprint. It's flooding the

by Pierre Schweitzer

Hi, this debug wasn't supposed to be silent as it highlights a quite crappy situation in ReactOS. And that's even what one would call: "a hack". That way, you could also silence IopParseDevice hack debug... At least, you could have asked the author, I'm not that unreachable ;-). Regards, P. Schweitzer

14 years, 9 months

CallOneParam? 0x10? sometimes 0x20

by James Tabor

I noticed this everywhere, (subsystems/win32/win32k/objects/gdiobj.c:249) GDIOBJ_LockObj: Attempted to lock object 0x10064, wrong reuse counter (Handle: 0x0, Entry: 0x8) (subsystems/win32/win32k/objects/dclife.c:726) Could not lock source DC 00010064 (subsystems/win32/win32k/ntuser/simplecall.c:349) Calling invalid routine number 0x10 in NtUserCallOneParam(), Param=0x31 CallOneParam? Looks like a stack issue.

14 years, 9 months

Buidlbot (& trunk?) broken

by Pierre Schweitzer

Hi, it seems that recent changes lead buildbot to brokenness status. It's looping forever on a backtrace. Crash occurs in user32_winetest win. Before the end: win.c:1028: HCBT_DESTROYWND: hwnd 000A04E6 win.c:1058: previous shell window: 00020098 (subsystems/win32/win32k/ntuser/window.c:2500) Destroying the ShellWindow! (subsystems/win32/win32k/ntuser/message.c:1629) SendNotifyMessage: Failed in Broadcast! [7hEntered debugger on last-chance exception (Exception Code: 0xc0000005) (Page Fault) Memory at 0x47534D59 could not be written: Page not present. kdb:> bt Eip: <win32k.sys:7125d (include/ddk/wdm.h:8188 (@MsqCleanupMessageQueue@4))> Frames: <win32k.sys:71438 (subsystems/win32/win32k/ntuser/msgqueue.c:1575 (@MsqDestroyMessageQueue@4))> <win32k.sys:400a2 (subsystems/win32/win32k/main/dllmain.c:346 (Win32kThreadCallback@8))> <ntoskrnl.exe:dfc5d (ntoskrnl/ps/kill.c:693 (PspExitThread@4))> <ntoskrnl.exe:e002c (ntoskrnl/ps/kill.c:890 (PsExitSpecialApc@20))> <ntoskrnl.exe:9004 (ntoskrnl/ke/apc.c:471 (KiDeliverApc@12))> <ntoskrnl.exe:70be (ntoskrnl/include/internal/arch/../i386/ke.h:690 (@KiServiceExit@8))> <win32k.sys:e6a73 (subsystems/win32/win32k/ntuser/menu.c:0 (@IntCreateMenu@8))> <ff8848b8> <b0465eb0> <win32k.sys:e6a73 (subsystems/win32/win32k/ntuser/menu.c:0 (@IntCreateMenu@8))> <win32k.sys:e7153 (/mnt/ramdisk/buildbot/debug/obj/include/psdk/oleidl.h:0 (_SEH2FrameHandler))> <b0467604> <b04675cc> <b04667cc> <b0466794> <b0290874> <b029083c> <b04504ac> <b0450474> <b0464634> Regards, P. Schweitzer

14 years, 9 months

Releasing

by Aleksey Bragin

Hi, recently amount of new features added to the trunk decreased, and there were quite a lot of bugfixes coming in. In my opinion, it is a very good time for a release. After release is branched, it would be possible to sync wine shared code and continue with other changes. If there are no objections, let's start the work right away. Testers being the first team working, and Colin - when/if you have time for this release? WBR, Aleksey Bragin.

14 years, 9 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 50616: [RTL] Minor code changes to RTL (one would call them "optimisation"). Added some missing paged code. Plus added useful asserts (used to catch r50615 bug!)

by Timo Kreuzer

You wrote it was an optimization, but it rather looks like a functional change ("+ sizeof(WCHAR)"). is that intended? wdm:8428 #define RtlAnsiStringToUnicodeSize(String) ( \ NLS_MB_CODE_PAGE_TAG ? \ RtlxAnsiStringToUnicodeSize(String) : \ ((String)->Length + sizeof(ANSI_NULL)) * sizeof(WCHAR) \ ) wdm:8916 #define RtlUnicodeStringToAnsiSize(String) ( \ NLS_MB_CODE_PAGE_TAG ? \ RtlxUnicodeStringToAnsiSize(String) : \ ((String)->Length + sizeof(UNICODE_NULL)) / sizeof(WCHAR) \ ) Am 08.02.2011 00:23, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Mon Feb 7 23:23:33 2011 > New Revision: 50616 > > URL: http://svn.reactos.org/svn/reactos?rev=50616&view=rev > Log: > [RTL] > Minor code changes to RTL (one would call them "optimisation"). Added some missing paged code. > Plus added useful asserts (used to catch r50615 bug!) > ... > - Length = RtlAnsiStringToUnicodeSize(AnsiSource); > + if (NlsMbCodePageTag == FALSE) > + { > + Length = AnsiSource->Length * 2 + sizeof(WCHAR); > + } > + else > + { > + Length = RtlxAnsiStringToUnicodeSize(AnsiSource); > + } ... > > - Length = RtlUnicodeStringToAnsiSize(UniSource); > + ASSERT(!(UniSource->Length& 1)); > + > + if (NlsMbCodePageTag == FALSE) > + { > + Length = (UniSource->Length + sizeof(WCHAR)) / sizeof(WCHAR); > + } > + else > + { > + Length = RtlxUnicodeStringToAnsiSize(UniSource); > + } > if (Length> MAXUSHORT) return STATUS_INVALID_PARAMETER_2;

14 years, 9 months

Re: [ros-dev] [ros-diffs] [pschweitzer] 50612: [NTOSKRNL/PPC] Fix the fix, spotted by "ThFabba" on IRC

by Timo Kreuzer

Under "normal conditions" sizeof of an array covers the whole array. is this different for function paramters? Am 06.02.2011 14:50, schrieb pschweitzer(a)svn.reactos.org: > Author: pschweitzer > Date: Sun Feb 6 13:50:57 2011 > New Revision: 50612 > > URL: http://svn.reactos.org/svn/reactos?rev=50612&view=rev > Log: > [NTOSKRNL/PPC] > Fix the fix, spotted by "ThFabba" on IRC > > Modified: > trunk/reactos/ntoskrnl/ke/powerpc/cpu.c > > Modified: trunk/reactos/ntoskrnl/ke/powerpc/cpu.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/cpu.c?… > ============================================================================== > --- trunk/reactos/ntoskrnl/ke/powerpc/cpu.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/powerpc/cpu.c [iso-8859-1] Sun Feb 6 13:50:57 2011 > @@ -44,7 +44,7 @@ > CPUID(IN ULONG CpuInfo[4], > IN ULONG InfoType) > { > - RtlZeroMemory(CpuInfo, sizeof(CpuInfo) * sizeof(ULONG)); > + RtlZeroMemory(CpuInfo, 4 * sizeof(ULONG)); > } > > VOID > > >

14 years, 10 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 50605: [WIN32K] Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. Fixes bug 2372

by Gabriel ilardi

What about the patch in that bug http://www.reactos.org/bugzilla/attachment.cgi?id=1568 :) ? > Date: Fri, 4 Feb 2011 13:53:50 +0000 > To: ros-diffs(a)reactos.org > From: tkreuzer(a)svn.reactos.org > Subject: [ros-diffs] [tkreuzer] 50605: [WIN32K] Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. Fixes bug 2372 > > Author: tkreuzer > Date: Fri Feb 4 13:53:49 2011 > New Revision: 50605 > > URL: http://svn.reactos.org/svn/reactos?rev=50605&view=rev > Log: > [WIN32K] > Fix a bug in calculation of the background color for 32bpp -> 1bpp color translations. > Fixes bug 2372 > > Modified: > trunk/reactos/subsystems/win32/win32k/eng/xlate.c > > Modified: trunk/reactos/subsystems/win32/win32k/eng/xlate.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/eng/xlate.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/eng/xlate.c [iso-8859-1] Fri Feb 4 13:53:49 2011 > @@ -91,7 +91,7 @@ > iColor >>= 13; > iNewColor |= iColor & 0x3E0; > > - /* Copy green */ > + /* Copy blue */ > iColor >>= 13; > iNewColor |= iColor & 0x1F; > > @@ -417,11 +417,11 @@ > pexlo->aulXlate[0] = > PALETTE_ulGetNearestPaletteIndex(ppalSrc, crSrcBackColor); > } > + else if (ppalSrc->flFlags & PAL_RGB) > + { > + pexlo->aulXlate[0] = crSrcBackColor; > + } > else if (ppalSrc->flFlags & PAL_BGR) > - { > - pexlo->aulXlate[0] = crSrcBackColor; > - } > - else if (ppalSrc->flFlags & PAL_RGB) > { > pexlo->aulXlate[0] = RGB(GetBValue(crSrcBackColor), > GetGValue(crSrcBackColor), > >

14 years, 10 months

ReactOS Project at Chemnitzer Linux-Tage 2011

by Colin Finck

Hi all, Even if it has already been reported through the newsletter, here is the announcement for mailing list readers: The ReactOS Project will have a booth at the Chemnitzer Linux-Tage 2011, the second-largest Open-Source-related exhibition in Germany, from 19th to 20th March. Our project is going to be represented by the ReactOS developers Colin Finck, Timo Kreuzer, Matthias Kupfer, Daniel Reimer and Christoph von Wittich. This year, we will also be joined by Kai Tietz from the MinGW-w64 Project. Like in the last years, you will be able to try out the latest development state of ReactOS as well as getting some merchandising articles. So if you have the time to visit Chemnitz, stop by and say hello at our booth. Cheers, Colin

14 years, 10 months

About debugging ROS

by Xu Liu

I am just a new person who wants to debug ROS, so my questions may be stupid. I have checked http://www.reactos.org/wiki/Debugging . It seems the main debugging way is "Debugging through text messages" (I think it is more like "checking logs"). If I want to use GDB, I have to use QEMU. Would you please tell me is Kdbg the only way to debug code in VMWare or VirtualBox? And if I want to debug ReactOS, do I have to install QEMU or VMWare or VirtualBox? Using "make install" in RosBE can generate many binary files. Is there any build-in way to start ROS from these bin files without any virtual machine? Thank you in advance.

14 years, 10 months

BuildBot changes

by Colin Finck

Hello all, As you have certainly noticed, Amine, Olaf and me have upgraded the BuildBot some days ago. While doing this, we have added Olaf's build slaves which used to be available at http://reactos.ath.cx:8081. The new BuildBot version finally enables authenticated access for features like forcing a build. When you want to do this now, you have to enter your SVN credentials into the respective fields. If you are a tester and need these BuildBot features, please ask Aleksey or me for getting the appropriate credentials. In the next few days, we're probably going to make the testing results of his CMake bot available at http://reactos.org/testman and upload his builds to http://iso.reactos.org. I might also change the BuildBot Web page design. Now that the main part has got wider, we might remove the ReactOS design around it to get some space for the real important stuff. - Colin

14 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev