Ros-dev

ros-dev@reactos.org

1 participants
5790 discussions

Re: [ros-dev] [ros-diffs] [ekohl] 49366: Merge ScmControlService() and ScmSendStartCommand() into ScmSendServiceCommand().

by Cameron Gutman

This commit breaks 2nd stage setup. It fails just before device enumeration with the message: "CMP_WaitNoPendingInstallEvents() failed". The official buildbot also exhibits this bug. Thanks, Cameron Gutman On Oct 30, 2010, at 3:25 PM, ekohl(a)svn.reactos.org wrote: > Author: ekohl > Date: Sat Oct 30 19:25:23 2010 > New Revision: 49366 > > URL: http://svn.reactos.org/svn/reactos?rev=49366&view=rev > Log: > Merge ScmControlService() and ScmSendStartCommand() into ScmSendServiceCommand(). > > Modified: > trunk/reactos/base/system/services/database.c > trunk/reactos/base/system/services/rpcserver.c > trunk/reactos/base/system/services/services.h > > Modified: trunk/reactos/base/system/services/database.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/datab… > ============================================================================== > --- trunk/reactos/base/system/services/database.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/database.c [iso-8859-1] Sat Oct 30 19:25:23 2010 > @@ -678,66 +678,10 @@ > > > DWORD > -ScmControlService(PSERVICE Service, > - DWORD dwControl) > -{ > - PSCM_CONTROL_PACKET ControlPacket; > - SCM_REPLY_PACKET ReplyPacket; > - > - DWORD dwWriteCount = 0; > - DWORD dwReadCount = 0; > - DWORD TotalLength; > - DWORD dwError = ERROR_SUCCESS; > - > - DPRINT("ScmControlService() called\n"); > - > - TotalLength = wcslen(Service->lpServiceName) + 1; > - > - ControlPacket = (SCM_CONTROL_PACKET*)HeapAlloc(GetProcessHeap(), > - HEAP_ZERO_MEMORY, > - sizeof(SCM_CONTROL_PACKET) + (TotalLength * sizeof(WCHAR))); > - if (ControlPacket == NULL) > - return ERROR_NOT_ENOUGH_MEMORY; > - > - ControlPacket->dwControl = dwControl; > - ControlPacket->dwSize = TotalLength; > - ControlPacket->hServiceStatus = (SERVICE_STATUS_HANDLE)Service; > - wcscpy(&ControlPacket->szArguments[0], Service->lpServiceName); > - > - /* Send the control packet */ > - WriteFile(Service->ControlPipeHandle, > - ControlPacket, > - sizeof(SCM_CONTROL_PACKET) + (TotalLength * sizeof(WCHAR)), > - &dwWriteCount, > - NULL); > - > - /* Read the reply */ > - ReadFile(Service->ControlPipeHandle, > - &ReplyPacket, > - sizeof(SCM_REPLY_PACKET), > - &dwReadCount, > - NULL); > - > - /* Release the contol packet */ > - HeapFree(GetProcessHeap(), > - 0, > - ControlPacket); > - > - if (dwReadCount == sizeof(SCM_REPLY_PACKET)) > - { > - dwError = ReplyPacket.dwError; > - } > - > - DPRINT("ScmControlService() done\n"); > - > - return dwError; > -} > - > - > -static DWORD > -ScmSendStartCommand(PSERVICE Service, > - DWORD argc, > - LPWSTR *argv) > +ScmSendServiceCommand(PSERVICE Service, > + DWORD dwControl, > + DWORD argc, > + LPWSTR *argv) > { > PSCM_CONTROL_PACKET ControlPacket; > SCM_REPLY_PACKET ReplyPacket; > @@ -750,7 +694,7 @@ > DWORD dwError = ERROR_SUCCESS; > DWORD i; > > - DPRINT("ScmSendStartCommand() called\n"); > + DPRINT("ScmSendServiceCommand() called\n"); > > /* Calculate the total length of the start command line */ > TotalLength = wcslen(Service->lpServiceName) + 1; > @@ -774,7 +718,7 @@ > if (ControlPacket == NULL) > return ERROR_NOT_ENOUGH_MEMORY; > > - ControlPacket->dwControl = SERVICE_CONTROL_START; > + ControlPacket->dwControl = dwControl; > ControlPacket->hServiceStatus = (SERVICE_STATUS_HANDLE)Service; > ControlPacket->dwSize = TotalLength; > Ptr = &ControlPacket->szArguments[0]; > @@ -819,7 +763,7 @@ > dwError = ReplyPacket.dwError; > } > > - DPRINT("ScmSendStartCommand() done\n"); > + DPRINT("ScmSendServiceCommand() done\n"); > > return dwError; > } > @@ -998,7 +942,10 @@ > DPRINT("Received service process ID %lu\n", dwProcessId); > > /* Send start command */ > - dwError = ScmSendStartCommand(Service, argc, argv); > + dwError = ScmSendServiceCommand(Service, > + SERVICE_CONTROL_START, > + argc, > + argv); > } > } > else > @@ -1227,7 +1174,10 @@ > CurrentService->Status.dwCurrentState == SERVICE_START_PENDING) > { > /* shutdown service */ > - ScmControlService(CurrentService, SERVICE_CONTROL_STOP); > + ScmSendServiceCommand(CurrentService, > + SERVICE_CONTROL_STOP, > + 0, > + NULL); > } > > ServiceEntry = ServiceEntry->Flink; > > Modified: trunk/reactos/base/system/services/rpcserver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/rpcse… > ============================================================================== > --- trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] Sat Oct 30 19:25:23 2010 > @@ -699,8 +699,10 @@ > } > > /* Send control code to the service */ > - dwError = ScmControlService(lpService, > - dwControl); > + dwError = ScmSendServiceCommand(lpService, > + dwControl, > + 0, > + NULL); > > /* Return service status information */ > RtlCopyMemory(lpServiceStatus, > @@ -2864,7 +2866,10 @@ > } > > /* Start the service */ > - dwError = ScmStartService(lpService, argc, (LPWSTR *)argv); > + dwError = ScmSendServiceCommand(lpService, > + SERVICE_CONTROL_START, > + argc, > + (LPWSTR *)argv); > > return dwError; > } > @@ -4072,7 +4077,10 @@ > /* FIXME: Convert argument vector to Unicode */ > > /* Start the service */ > - dwError = ScmStartService(lpService, 0, NULL); > + dwError = ScmSendServiceCommand(lpService, > + SERVICE_CONTROL_START, > + 0, > + NULL); > > /* FIXME: Free argument vector */ > > > Modified: trunk/reactos/base/system/services/services.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/servi… > ============================================================================== > --- trunk/reactos/base/system/services/services.h [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/services.h [iso-8859-1] Sat Oct 30 19:25:23 2010 > @@ -104,9 +104,10 @@ > VOID ScmGetBootAndSystemDriverState(VOID); > VOID ScmAutoStartServices(VOID); > VOID ScmAutoShutdownServices(VOID); > -DWORD ScmStartService(PSERVICE Service, > - DWORD argc, > - LPWSTR *argv); > +DWORD ScmSendServiceCommand(PSERVICE Service, > + DWORD dwControl, > + DWORD argc, > + LPWSTR *argv); > > PSERVICE ScmGetServiceEntryByName(LPCWSTR lpServiceName); > PSERVICE ScmGetServiceEntryByDisplayName(LPCWSTR lpDisplayName); > @@ -115,9 +116,6 @@ > PSERVICE *lpServiceRecord); > VOID ScmDeleteServiceRecord(PSERVICE lpService); > DWORD ScmMarkServiceForDelete(PSERVICE pService); > - > -DWORD ScmControlService(PSERVICE Service, > - DWORD dwControl); > > BOOL ScmLockDatabaseExclusive(VOID); > BOOL ScmLockDatabaseShared(VOID); > >

14 years, 10 months

Static - dynamic generation of reactos.dff

by Jérôme Gardou

Hi reactos developers. As many of you know, the cmake branch development is going along and is the occasion of many innovations in the way reactos is built. One of this way is the reactos.dff file. Currently, it is a static file, meaning that each time you want to add a module to reactos, you have to edit this file. What I propose is to create this file dynamically, when parsing the build system file. Adding a reactos module twould then be as simple as (!) creating a new build file for this module. For those who are concerned about slipstreaming or optional files like wallpapers or whatever hacking they do with the current reactos.dff, it will be as easy as before. There will be a file to edit, which will be the "static" part of it. Whatever you'll write in this file will be written back to reactos.dff, so there is no need to worry about that. What do you think? Regards. Jérôme. PS : The patch is there. It waits for your approval :-)

14 years, 10 months

Re: [ros-dev] True multiuser support?

by WaxDragon

Where is my Server core style command prompt login? Screw explorer. Oh, and I want RDP. ;0p On Oct 27, 2010 4:18 PM, "Adam Kachwalla" <geekdundee(a)gmail.com> wrote: We need to first fix up the logon screen. I have tried this, except the problem lies with CreateDesktop() not wanting to create more than one desktop within the Winlogon process. At this stage, the logon/logoff functionality does not work at all, and some processes still linger about. It appears explorer shell is one of them. On Thu, 28 Oct 2010 02:22:36 +1100, Javier Agustìn Fernàndez Arroyo < elhoir(a)gmail.com> wrote: > H... -- Give a man a fish and he will eat for a day. Teach a man to fish and he will eat for a lifetime. Give a man religion and he will die praying for a fish. _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://ww...

14 years, 10 months

True multiuser support?

by Javier Agustìn Fernàndez Arroyo

Hello, devs! ok, lets stop flaming and lets do anything useful 3:> For the future: will ReactOS support "true" multiuser sessions (that is, *simultaneously*)? Is it possible? that would be a big enhancement over Windows :)

14 years, 10 months

Wine Gecko

by Adam Kachwalla

I think that Wine Gecko should be integrated in the ReactOS releases. It is needed IIRC for things like Winhlp32 (I think) and HTML Help (defiitely) and applications which use IE browser controls.

14 years, 10 months

Short summary of our September meeting in Sweden, jointly written by JaixBly and Fireball

by Aleksey Bragin

Hi ReactOS friends and colleagues. There have been exciting years, I first started to have an eye on the freewin95 project. When I first found the ReactOS project and saw that they actually gave away free zip-files with files to try it out I was eager to test it my self, I first downloaded my first “bochs-1.3-reactos-images.zip” the third april 2002, and it worked! I was amazed, so I downloaded and tested everything that I could test. A long time has gone since that time and I have seen a lot of progress during the years, however it's a lot of years, for me about nine years of downloading, compiling, testing and reading svn- messages. For many people it has been too many years and many have fallen away, now however we are close to something that can actually be used, the kernel is pretty stable other parts of the OS is improving and getting there too. During the last many years we have had about 100 individuals in the IRC channel at all time, it indicates in my mind that we attract as many people as we loose, I guess that is kind of the status for our project, we should be able to change that in a short while I think. If we can release a some real-life applications for our OS we could draw some attention that could be permanent and the project could really start to grow for real. I and Aleksey met in Björkvik, Sweden for a discussion on how to get the ball rolling, we have some suggestions that could serve as step stones for such development. The key is to release a package of the project and see to that it can really do that but not everything else, for example, a web server, it doesn't need all the OS but the ones it needs it has to do really good. Even with this in mind ReactOS isn't well suited for many real applications, so we just looked at a few to see if it would be a way to go, you could perhaps suggest some more, and we would welcome that, we only have to ensure there isn't too much work to actually come to the finish line. Here we present some ideas and what needs to get in place to actually make it work. Webserver - Network subsystem (mainly tcpip.sys driver, and some winsock improvement) - VNC support (future RDP support) - Apache/MySQL/PHP support - XAMPP with toolbox - WEBMIN Thin Client (LiveCD or BootCD) - Re-port our MSTSC.EXE - Local printing (USB/LPT printer support?) Please give us your opinion and please also add possible ideas that you have and think through what needs to get in place to see it come to pass. Yours sincerely, Aleksey & Jan (Jaix) through Jan

14 years, 10 months

Re: [ros-dev] [ros-diffs] [jgardou] 49281: [PSDK] - Add MIDL_user_allocate and MIDL_user_free definitions - #ifdef a GCC hack

by Timo Kreuzer

Am 26.10.2010 18:01, schrieb jgardou(a)svn.reactos.org: > +#ifdef __GCC__ > /* Note: this should return a CLIENT_CALL_RETURN, but calling convention for > * returning structures/unions is different between Windows and gcc on i386. */ > LONG_PTR RPC_VAR_ENTRY > @@ -659,6 +663,13 @@ > NdrAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ... ); > LONG_PTR RPC_VAR_ENTRY > NdrDcomAsyncClientCall( PMIDL_STUB_DESC pStubDescriptor, PFORMAT_STRING pFormat, ... ); > +#else > +CLIENT_CALL_RETURN RPC_VAR_ENTRY NdrClientCall2( > + PMIDL_STUB_DESC pStubDescriptor, > + PFORMAT_STRING pFormat, > + ... > +); > +#endif > Is this hack even neccessary? I couldn't see any difference between gcc and msvc with the correct prototype. Both return the result in eax.

14 years, 10 months

Yarotows trunk integration

by Gregor Schneider

Hi, good to see the branch work back in trunk, I suspected this work would be left to rot and finally be forgotten (like in most other experimental branches). Altogether this looks like a huge step forward, got to test those mode switches it once I have enough time. One thing I noticed from the diffs is the eng/mem.c file, which exceeded my EVIL / HACK threshold. Is this supposed to stay - especially in the context of ARM3's to be proven awesomeness? --- snippet --- EngSecureMem(PVOID Address, ULONG Length) { return (HANDLE)-1; // HACK!!! } EngUnsecureMem(HANDLE Mem) { if (Mem == (HANDLE)-1) return; // HACK!!! } --- snippet --- Good work anyway, thanks to the people involved! Regards, Gregor

14 years, 10 months

Re: [ros-dev] Please tell me

by WaxDragon

You could always run two installs in different directories. On Oct 25, 2010 10:51 AM, "Bernd Blaauw" <bblaauw(a)home.nl> wrote: Op 25-10-2010 16:09, Fan Zhang schreef: > > Thanks. But I don't know if i run ReactOS, how could I replace the kernel file, such as ntoskrl... So basicly running a ReactOS installation with RosBE installed as application, sources downloaded and modified, and then you want a way to update files from this ReactOS installation itself? As long as ReactOS installs only on FAT filesystem, I guess you could use a DOS bootdisk/installation to overwrite any files. It's not entirely convenient. Is there basicly a set of lists of ReactOS files for the following: * which ReactOS files can be overwritten by a new file while you're still running in ReactOS? .inf files? small games like solitaire? * which ReactOS files can be overwritten, but require a reboot to be properly noticed? some drivers perhaps? * which ReactOS files require you to be outside of ReactOS in order to replace them? ntoskrnl comes to mind, explorer I guess All in all, mr Fan Zhang might be asking for some kind of update mechanism. If you had an old machine which you run ReactOS on, together with same casual data (audio files perhaps), do you need to reformat the disk to update ReactOS? or only remove the installation directory? or pick a different installation directory? or same directory? After all, you don't want to lose any user data. _______________________________________________ Ros-dev mailing list Ros-dev(a)reactos.org http://ww...

14 years, 10 months

Please tell me

by Fan Zhang

Hi guys, I want to know how do you debug ReactOS. For example, when I change the code, I used to execute 'Make bootcd'. After that, I will install the ReactOS system by ReactOS.iso. So I'm confused if I have to install the whoe system after compiling. Do you have some easy way? Thanks. Fan

14 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev