Ros-dev

ros-dev@reactos.org

5790 discussions

Start a nNew thread

(no subject)

by Mikhail Zuev

-- С уважением Михаил

14 years, 11 months

Introduction

by Oleg Baikalow

Hi, I thought I would drop a line here finally :) My name is Oleg, I am from Russia (some 180km from Moscow :)). I worked with Aleksey many years ago on some kernelmode networking-related tasks for Windows NT 4.0 and later Windows 2000. Your recent 0.3.12 release news was all over the place here on Russian news sites, my congratulations! ReactOS is a great project, though I never had enough time to actually start hacking, but recent achievements seems to motivate me more. What is situation with networking in ReactOS? I think this could be my main direction of work. I would glad if someone writes a current state of networking in ROS, so I would know where to start. // Oleg Baikalow.

14 years, 11 months

yarotows

by Timo Kreuzer

Hi everyone, I'd like to announce that I'm soon going to merge yarotows back into trunk, if no other regressions are found. The current issues (red icons and blue text on disabled buttons will be fixed, Kamil has already a fix.) Last chance to test and object ;-) Regards, Timo

14 years, 11 months

0.3.12 milestones status

by victor martinez

I am currently checking our 0.3.12 milestones. And the milestones status is: **********(Bug 5517)Some icons look wrong (blue background)********** There is a Hack for the release. **********(Bug5560): Adobe Acrobat Reader 7.1 throws exception at start**** This is a Wine regression. It is not in our hands.We have to wait for a Fix. **********(Bug 5472) comctl32: Keyboard shortcuts don't work after winesync*** Not as bad as it sounds. It does not work just in 2nd Installation Stage. Anyway, there is a Hack for this issue too. **********(Bug 5314) REGRESSION: Acrobat Reader: pen leak******* It is supposed to be fixed, but it is Bug5560 dependant so it is impossible to confirm the Fixed status. **********(Bug 5598) PATCH: Opera 9.64, FireFox 3.0+ crash when using Russian/Lithuanin/Ukrainian locale**** Reverting the *.nls changes solves the issue. There is a Hack attached. **********(Bug 5482)REGRESSION: ExplorerXP: black background on treeview area***** This is a Wine regression. It is not in our hands. We have to wait for a Fix. **********(Bug 4106) REGRESSION: Wrong text spacing in popup menus / icons after show a font in control applet / Remote Desktop******* It is a minor regression since it has been there for a while. Also Yarotows seems to fix some of the issues. **********(Bug 5591) REGRESSION: devmgr: wrong icons in the TreeView ***** Updating comctl32 will fix the issues. Or we can revert the comctl32 changes. ************** * Summing up * ************** There are 8 regressions. 4 has different options to be solved (Hack or Wine update/revert) 2 are current Wine regressions (we have to wait for a fix or revert Ole32/Comctl32 changes) 1 could be fixed (the Acrobar Reader leakage) but we need to fix Acrobat first(reverting?) 1 is a minor regression without a solution ( "Bug 4106") So we can solve 7/8 regressions. Is it time to think about a 0.3.12 release? It is time to take decisions (reverting/updating/waiting Fixes) since there are solutions. I don't think having the Trunk frozen is good for the project. So, opinions?

15 years

ReactOS development cycle

by Olaf Siejka

I think its a good time to discuss current development cycle. It become clear to me, that there is no way we can currently adhere to 3 months development cycle. Its pointless to stick to something we managed to succeed only once or twice. Agreeing with the fact we do need releases, for various reasons, i would like to propose a new, longer cycle. The most apparent choices to me are 4 and 6 month ones. At least half of the cycle would be spent on all out development, with the following half turning its concentration to stabilizing trunk, searching for regressions and bugs, fixing them. The cycles would be separated by branching the release version. The actual release would be taking place on the first month of the NEXT DEVELOPMENT cycle. The actual emergency hacking, writing changelog etc. One month is more than enough, to release two RC (at the branching and next one - after two weeks). End of the month must result in final release. RC should be rather released internally for testing purposes on a default iso. The actual proposals are: 4 months: month 1: Development on version x. At the same time, the Release x-1 is to be final-tested, emergency-hacked, changelogged and shipped. The deadline is end of month 1. month 2: Development on version x. All development that can affect trunk stability, but also will not be shipped with the release X should end or be limited to branch only by the end of this month; month 3: Switching from development more to stabilizing trunk, searching for regressions, fixing bugs. Finalizing sub-projects that are to be included in release x; month 4; No new functionality/code, bug-fixing and hunting regressions. This month should end with branching for release x; 6 months: month 1: Development on version x. At the same time, the Release x-1 is to be final-tested, emergency-hacked, changelogged and shipped. The deadline is end of month 1. month 2: Development on version x; month 3: Development on version x. All development that can affect trunk stability, but also will not be shipped with the release X should end or be limited to branch only by the end of this month; month 4: Switching from development more to stabilizing trunk, searching for regressions, fixing bugs. Ongoing development work only for features that are to be shipped with release x; month 5: Switching from development more to stabilizing trunk, searching for regressions, fixing bugs. Finalizing sub-projects that are to be included in release x; month 6: No new functionality/code, bug-fixing and hunting regressions. This month should end with branching for release x;

15 years

Goodbye Window Object

by James Tabor

Hi! Since I'm starting to move around now and fell better. Let's just say, I guess it's time to move from the window object and move to the wnd one. I have two local branches here on the portable system, one for Right to Left support (wine sync) I've started and the standard test one. I would like to have all the available Win32 developers help out. You too Ged! Try to get this done before to much goes into CMAKE and have to rework it all. >From window.h: /* Scrollbar info */ PSBINFOEX pSBInfo; // convert to PSBINFO /* Entry in the list of thread windows. */ LIST_ENTRY ThreadListEntry; } WINDOW_OBJECT; /* PWINDOW_OBJECT already declared at top of file */ /* Window flags. */ #define WINDOWOBJECT_NEED_SIZE WNDS_SENDSIZEMOVEMSGS #define WINDOWOBJECT_NEED_ERASEBKGND WNDS_ERASEBACKGROUND #define WINDOWOBJECT_NEED_NCPAINT WNDS_SENDNCPAINT #define WINDOWOBJECT_RESTOREMAX (0x00000020) // Set/Clr WS_MAXIMIZE & #define WINDOWSTATUS_DESTROYING WNDS2_INDESTROY <----- "WNDS2" state2 flag #define WINDOWSTATUS_DESTROYED WNDS_DESTROYED <----- "WNDS" state flag Move this to ntuser.h including the SBINFOEX too, not sure I did that one yet, and start hacking it then test the hell out of it. The flags just convert them to the correct ones, _RESTOREMAX may need more research (another word for HAX). Just writing this and it looks simple, but this is one file that effects the whole w32k tree. Thanks, James

15 years

Re: [ros-dev] [ros-diffs] [sir_richard] 49000: [NTOS]: Fix whitespace typo in comment (two spaces instead of one). That's right. I'm not a fun person.

by Timo Kreuzer

That will be hard to beat for r50000... > Author: sir_richard > Date: Tue Oct 5 15:59:47 2010 > New Revision: 49000 > > URL: http://svn.reactos.org/svn/reactos?rev=49000&view=rev > Log: > [NTOS]: Fix whitespace typo in comment (two spaces instead of one). > That's right. I'm not a fun person. >

15 years

Patch: Win32k Initialization Sequence Bug.

by James Tabor

This is a possible fix for the initialization problem reactos suffers from. Just let me know, how it goes with testing. ATM QEmu works okay and no hardware test was run. Thanks, James

15 years

[ros-diffs] [sir_richard] 48712: [WIN32K]: Fix large amount of set-but-unused variables.

by James Tabor

LOL! Keeping it from running off the side of the page! Know one told you!? The screen is flat! If you go out to far, the characters will fall off! @@ -217,7 +216,8 @@ !(pEH->Flags & WINEVENT_SKIPOWNPROCESS)) || !pEH->idProcess ) ) { - Result = co_IntCallEventProc( UserHMGetHandle(pEH), + // What in the deuce is this right-aligned formatting? + co_IntCallEventProc( UserHMGetHandle(pEH), Event, UserHMGetHandle(pWnd), idObject, I'll audit your code and commit ass cocking comments too........ James

15 years

Re: [ros-dev] [ros-diffs] [sir_richard] 48940: [NTOS]: He's climbing in yo PFN database, he snatching yo pages up, tryin to page em so y'all need to hide your pool hide your cache, and hide your working set cuz they grabbin...

by Ged Murphy

This commit needs a 'like' button :) -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sir_richard(a)svn.reactos.org Sent: 30 September 2010 05:41 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sir_richard] 48940: [NTOS]: He's climbing in yo PFN database, he snatching yo pages up, tryin to page em so y'all need to hide your pool hide your cache, and hide your working set cuz they grabbin... Author: sir_richard Date: Thu Sep 30 04:40:31 2010 New Revision: 48940 URL: http://svn.reactos.org/svn/reactos?rev=48940&view=rev Log: [NTOS]: He's climbing in yo PFN database, he snatching yo pages up, tryin to page em so y'all need to hide your pool hide your cache, and hide your working set cuz they grabbin' all the pages out there. We gonna page you, we gonna page you, so you can run and fault on that, run and fault on that, home boy, homeboy, home homeboy. Enable ARM3 Paged Pool and remove all related deprecated code. Install tested on several VMs, it might cause new regressions. Let's fix them before 0.3.13 instead of reverting. Modified: trunk/reactos/ntoskrnl/ex/init.c trunk/reactos/ntoskrnl/mm/ARM3/expool.c trunk/reactos/ntoskrnl/mm/mmfault.c trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/mm/ppool.c Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=489… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Thu Sep 30 04:40:31 2010 @@ -1270,8 +1270,6 @@ SharedUserData->ImageNumberHigh = IMAGE_FILE_MACHINE_ARCHITECTURE; } -extern BOOLEAN AllowPagedPool; - VOID NTAPI Phase1InitializationDiscard(IN PVOID Context) @@ -1891,9 +1889,6 @@ /* Update progress bar */ InbvUpdateProgressBar(90); - /* Enough fun for now */ - AllowPagedPool = FALSE; - /* Launch initial process */ ProcessInfo = &InitBuffer->ProcessInfo; ExpLoadInitialProcess(InitBuffer, &ProcessParameters, &Environment); Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] Thu Sep 30 04:40:31 2010 @@ -19,8 +19,6 @@ #undef ExAllocatePoolWithQuota #undef ExAllocatePoolWithQuotaTag -BOOLEAN AllowPagedPool = TRUE; - /* GLOBALS ********************************************************************/ ULONG ExpNumberOfPagedPools; @@ -454,11 +452,6 @@ PPOOL_HEADER Entry, NextEntry, FragmentEntry; KIRQL OldIrql; ULONG BlockSize, i; - - // - // Check for paged pool - // - if (!(AllowPagedPool) && (PoolType == PagedPool)) return ExAllocatePagedPoolWithTag(PagedPool, NumberOfBytes, Tag); // // Some sanity checks @@ -761,19 +754,6 @@ BOOLEAN Combined = FALSE; // - // Check for paged pool - // - if ((P >= MmPagedPoolBase) && - (P <= (PVOID)((ULONG_PTR)MmPagedPoolBase + MmPagedPoolSize))) - { - // - // Use old allocator - // - ExFreePagedPool(P); - return; - } - - // // Quickly deal with big page allocations // if (PAGE_ALIGN(P) == P) Modified: trunk/reactos/ntoskrnl/mm/mmfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mmfault.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mmfault.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mmfault.c [iso-8859-1] Thu Sep 30 04:40:31 2010 @@ -105,10 +105,6 @@ switch (MemoryArea->Type) { - case MEMORY_AREA_PAGED_POOL: - Status = STATUS_SUCCESS; - break; - case MEMORY_AREA_SECTION_VIEW: Status = MmAccessFaultSectionView(AddressSpace, MemoryArea, @@ -196,12 +192,6 @@ switch (MemoryArea->Type) { - case MEMORY_AREA_PAGED_POOL: - { - Status = MmCommitPagedPoolAddress((PVOID)Address, Locked); - break; - } - case MEMORY_AREA_SECTION_VIEW: Status = MmNotPresentFaultSectionView(AddressSpace, MemoryArea, @@ -293,25 +283,3 @@ } } -NTSTATUS -NTAPI -MmCommitPagedPoolAddress(PVOID Address, BOOLEAN Locked) -{ - NTSTATUS Status; - PFN_NUMBER AllocatedPage; - - Status = MmRequestPageMemoryConsumer(MC_PPOOL, FALSE, &AllocatedPage); - if (!NT_SUCCESS(Status)) - { - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - Status = MmRequestPageMemoryConsumer(MC_PPOOL, TRUE, &AllocatedPage); - MmLockAddressSpace(MmGetKernelAddressSpace()); - } - Status = - MmCreateVirtualMapping(NULL, - (PVOID)PAGE_ROUND_DOWN(Address), - PAGE_READWRITE, - &AllocatedPage, - 1); - return(Status); -} Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=4… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Thu Sep 30 04:40:31 2010 @@ -199,21 +199,6 @@ ASSERT(Status == STATUS_SUCCESS); // - // And now, ReactOS paged pool - // - BaseAddress = MmPagedPoolBase; - Status = MmCreateMemoryArea(MmGetKernelAddressSpace(), - MEMORY_AREA_PAGED_POOL | MEMORY_AREA_STATIC, - &BaseAddress, - MmPagedPoolSize, - PAGE_READWRITE, - &MArea, - TRUE, - 0, - BoundaryAddressMultiple); - ASSERT(Status == STATUS_SUCCESS); - - // // Next, the KPCR // BaseAddress = (PVOID)PCR; @@ -287,10 +272,6 @@ MmSystemRangeStart, (ULONG_PTR)MmSystemRangeStart + MmBootImageSize, "Boot Loaded Image"); - DPRINT1(" 0x%p - 0x%p\t%s\n", - MmPagedPoolBase, - (ULONG_PTR)MmPagedPoolBase + MmPagedPoolSize, - "Paged Pool"); DPRINT1(" 0x%p - 0x%p\t%s\n", MmPfnDatabase, (ULONG_PTR)MmPfnDatabase + (MxPfnAllocation << PAGE_SHIFT), @@ -373,12 +354,7 @@ /* Initialize ARMÂ³ in phase 0 */ MmArmInitSystem(0, KeLoaderBlock); - - /* Put the paged pool after the loaded modules */ - MmPagedPoolBase = (PVOID)PAGE_ROUND_UP((ULONG_PTR)MmSystemRangeStart + - MmBootImageSize); - MmPagedPoolSize = MM_PAGED_POOL_SIZE; - + /* Intialize system memory areas */ MiInitSystemMemoryAreas(); @@ -387,7 +363,6 @@ } else if (Phase == 1) { - MmInitializePagedPool(); MiInitializeUserPfnBitmap(); MmInitializeMemoryConsumer(MC_USER, MmTrimUserMemory); MmInitializeRmapList(); Modified: trunk/reactos/ntoskrnl/mm/ppool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ppool.c?rev=48… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ppool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ppool.c [iso-8859-1] Thu Sep 30 04:40:31 2010 @@ -13,10 +13,6 @@ #include <ntoskrnl.h> #define NDEBUG #include <debug.h> - -#if defined (ALLOC_PRAGMA) -#pragma alloc_text(INIT, MmInitializePagedPool) -#endif #undef ASSERT #define ASSERT(x) if (!(x)) {DbgPrint("Assertion "#x" failed at %s:%d\n", __FILE__,__LINE__); DbgBreakPoint(); } @@ -967,26 +963,6 @@ R_RELEASE_MUTEX(pool); } -VOID -INIT_FUNCTION -NTAPI -MmInitializePagedPool(VOID) -{ - /* - * We are still at a high IRQL level at this point so explicitly commit - * the first page of the paged pool before writing the first block header. - */ - MmCommitPagedPoolAddress ( (PVOID)MmPagedPoolBase, FALSE ); - - MmPagedPool = RPoolInit ( MmPagedPoolBase, - MmPagedPoolSize, - MM_POOL_ALIGNMENT, - MM_CACHE_LINE_SIZE, - PAGE_SIZE ); - - ExInitializeFastMutex(&MmPagedPool->Mutex); -} - PVOID NTAPI ExAllocatePagedPoolWithTag (IN POOL_TYPE PoolType, IN ULONG NumberOfBytes,

15 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev