Ros-dev

ros-dev@reactos.org

5788 discussions

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 44885: - Switch to using ARM3 paged pool -- all pool allocations are now handled by ARM3, which should be much more efficient, and combines both NP and P code together.

by Alex Ionescu

I guess you'll be claiming your Millennium Prize now. (For the uninformed: http://en.wikipedia.org/wiki/P_versus_NP_problem) On 2010-01-02, at 11:17 AM, ros-arm-bringup(a)svn.reactos.org wrote: > and combines both NP and P code together. Best regards, Alex Ionescu

14 years, 8 months

Re: [ros-dev] Ros-dev Digest, Vol 65, Issue 2

by Babar Shafiq

Hi All, Just want to say thanks for this wonderful project. Works like a charm in VritualBox image. It is unbelievable that total size of this great OS is just 37MB. In Virtual Box, default config for Video memory is too low which cause error on loading the VirtualBox image, after increasing it to 16mb all works fine. May be useful for someone else on the list. Waiting for the stable version to use on my laptop. Babar Shafiq Nazmi.

14 years, 8 months

Relocations, relocations!

by Alex Ionescu

Second-stage install would probably go much faster if these were fixed: Pretty please? It shouldn't be too hard. (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 00F70000) C:\ReactOS\System32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00FFE000) C:\ReactOS\System32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (74a30000 -> 01130000) C:\ReactOS\system32\syssetup.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00F63000) C:\ReactOS\system32\shlwapi.dll (dll/ntdll/ldr/utils.c:2355) Relocating (35680000 -> 01880000) C:\ReactOS\System32\devenum.dll (dll/ntdll/ldr/utils.c:2355) Relocating (6b360000 -> 018A4000) C:\ReactOS\System32\dsound.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76150000 -> 018E9000) C:\ReactOS\System32\inetcomm.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76660000 -> 018E9000) C:\ReactOS\System32\mshtml.dll (dll/ntdll/ldr/utils.c:2355) Relocating (77b10000 -> 00411000) C:\ReactOS\System32\olepro32.dll (dll/ntdll/ldr/utils.c:2355) Relocating (76120000 -> 00760000) C:\ReactOS\System32\shlwapi.dll Best regards, Alex Ionescu

14 years, 8 months

Invitation for ReactOS to Southern California Linux Expo 8x

by Aleksey Bragin

Do we have people for SOCAL 2010 this time? > From: "Gareth J. Greenaway" <gareth(a)socallinuxexpo.org> > Date: January 1, 2010 12:30:09 AM GMT+03:00 > To: aleksey(a)reactos.org > Cc: joe(a)socallinuxexpo.org > Subject: Invitation for ReactOS to Southern California Linux Expo 8x > > Greetings Aleksey, > > I hope this email finds you doing well. I wanted to formerly > invite the ReactOS project to attend and exhibit the Southern > California Linux Expo, which will be taking place February > 19th-21st, 2010 in Los Angeles, California at the Westin LAX hotel. > > This would be an excellent venue to showcase all the great work > going into the ReactOS project. We would provide a complementary > booth including all the usual amenities as well as complementary > passes to the show. > > If this sounds like something that the ReactOS project might be > interested in, please let us know as space will be filling up quickly. > > Thanks and Happy New Year! > Gareth > > -- > Gareth J. Greenaway | gareth(a)socallinuxexpo.org > Voice - 877-831-2569 x130 > Southern California Linux Expo > http://www.socallinuxexpo.org >

14 years, 8 months

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 44871: NMI Support Patch 10: [NTOS]: Write barebones NMI Trap handler which does a TSS context switch to the NMI TSS and then calls the HAL NMI handler. [NTOS]: Implement KiSaveProcessorState for doing a PRCB context save/restore. You should now be able to test the new NMI functionality by either building the circuit referenced in my e-mail and attaching it to your PCI bus, or by using "nmi 0" in the QEMU stdio console.

by Timo Kreuzer

ros-arm-bringup(a)svn.reactos.org schrieb: > Author: ros-arm-bringup > Date: Sat Jan 2 02:34:27 2010 > New Revision: 44871 > ... > @@ -790,9 +791,138 @@ > .globl _KiTrap2 > .func KiTrap2 > _KiTrap2: > - > - /* FIXME: This is an NMI, nothing like a normal exception */ > - mov eax, 2 > + // > + // Don't allow any other NMIs to come in for now > + // > + cli // Disable interrupts > But you know that CLI has no effect on NMIs?

14 years, 8 months

Re: [ros-dev] [ros-diffs] [ros-arm-bringup] 44856: NMI Support Patch 5: [HAL]: Do correct TLB flushing for systems with global page support. [HAL]: Clean leading whitespace and comments.

by Alex Ionescu

Why don't you cache this instead of querying it for each TLB flush? Seems stupidly wasteful -- I thought the point was to "make it better"?? Isn't this what HalpGetFeatureBits is for? On 2010-01-01, at 11:37 AM, ros-arm-bringup(a)svn.reactos.org wrote: > + // > + // Check for CPUID support > + // > + if (KeGetCurrentPrcb()->CpuID) > + { > + // > + // Check for global bit in CPU features > + // > + __cpuid(CpuInfo, 1); > + if (CpuInfo[3] & 0x2000) > + { Best regards, Alex Ionescu

14 years, 8 months

Re: [ros-dev] [ros-diffs] [sserapion] 44807: Add definitions for the x86bios emulator. http://www.geoffchappell.com/viewer.htm?doc=studies/windows/km/hal/api/x86bios/index.htm

by Colin Finck

sserapion(a)svn.reactos.org wrote: > Add definitions for the x86bios emulator. > http://www.geoffchappell.com/viewer.htm?doc=studies/windows/km/hal/api/x86bi os/index.htm >From the link: "The HAL in x86 builds of Windows Vista introduces a set of functions for accessing the 16-bit firmware that Windows started from." So you're adding functions from the x86 HAL in NT6 to our NT5.2-targeted AMD64 HAL? Is it just me who gets confused here? If it's alright, I'd like to hear some explanations. Best regards, Colin

14 years, 8 months

Re: [ros-dev] [ros-diffs] [tkreuzer] 44840: [HAL] Replace the asm implementations of HalpAcquireSystemHardwareSpinLock and HalpReleaseCmosSpinLock with C implementations. The old ones didn't work on SMP, as they were only compiled once as UP.

by Alex Ionescu

... You don't need them on SMP... sigh. Please stop replacing code when you have NO idea what you're doing!!! On 2009-12-31, at 6:45 PM, tkreuzer(a)svn.reactos.org wrote: > Author: tkreuzer > Date: Fri Jan 1 00:45:36 2010 > New Revision: 44840 > > URL: http://svn.reactos.org/svn/reactos?rev=44840&view=rev > Log: > [HAL] > Replace the asm implementations of HalpAcquireSystemHardwareSpinLock and HalpReleaseCmosSpinLock with C implementations. The old ones didn't work on SMP, as they were only compiled once as UP. > > Modified: > branches/ros-amd64-bringup/reactos/hal/halx86/generic/amd64/systimer.S > branches/ros-amd64-bringup/reactos/hal/halx86/generic/cmos.c > branches/ros-amd64-bringup/reactos/hal/halx86/generic/i386/systimer.S > > Modified: branches/ros-amd64-bringup/reactos/hal/halx86/generic/amd64/systimer.S > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/hal/h… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/hal/halx86/generic/amd64/systimer.S [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/hal/halx86/generic/amd64/systimer.S [iso-8859-1] Fri Jan 1 00:45:36 2010 > @@ -14,9 +14,6 @@ > > .data > > -_UnhandledMsg: > - .asciz "\n\x7\x7!!! Unhandled or Unexpected Code at line: %lx!!!\n" > - > .global _MsgUnimplemented > _MsgUnimplemented: > .asciz "WARNING: %s at %s:%d is UNIMPLEMENTED!\n" > @@ -26,18 +23,6 @@ > > .text > .code64 > - > -.global _HalpReleaseCmosSpinLock > -.func HalpReleaseCmosSpinLock > -_HalpReleaseCmosSpinLock: > - > -.endfunc > - > -.global _HalpAcquireSystemHardwareSpinLock > -.func HalpAcquireSystemHardwareSpinLock > -_HalpAcquireSystemHardwareSpinLock: > - > -.endfunc > > .global _HalpCalibrateStallExecution@0 > .func HalpCalibrateStallExecution@0 > > Modified: branches/ros-amd64-bringup/reactos/hal/halx86/generic/cmos.c > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/hal/h… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/hal/halx86/generic/cmos.c [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/hal/halx86/generic/cmos.c [iso-8859-1] Fri Jan 1 00:45:36 2010 > @@ -5,6 +5,7 @@ > * PURPOSE: CMOS Access Routines (Real Time Clock and LastKnownGood) > * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) > * Eric Kohl (ekohl(a)abo.rhein-zeitung.de) > + * Timo Kreuzer (timo.kreuzer(a)reactos.org) > */ > > /* INCLUDES ******************************************************************/ > @@ -17,8 +18,50 @@ > > KSPIN_LOCK HalpSystemHardwareLock; > UCHAR HalpCmosCenturyOffset; > +ULONG HalpSystemHardwareFlags; > > /* PRIVATE FUNCTIONS *********************************************************/ > + > +VOID > +NTAPI > +HalpAcquireSystemHardwareSpinLock(VOID) > +{ > + ULONG Flags; > + > + /* Get flags and disable interrupts */ > + Flags = __readeflags(); > + _disable(); > + > + /* Try to acquire the lock */ > + while (InterlockedBitTestAndSet((PLONG)&HalpSystemHardwareLock, 0)) > + { > + /* Lock is held, short wait and try again */ > + YieldProcessor(); > + } > + > + /* We have the lock, save the flags now */ > + HalpSystemHardwareFlags = Flags; > +} > + > +VOID > +NTAPI > +HalpReleaseCmosSpinLock(VOID) > +{ > + ULONG Flags; > + > + /* Get the flags */ > + Flags = HalpSystemHardwareFlags; > + > + /* Release lock and check if we owned it */ > + if (!InterlockedBitTestAndReset((PLONG)&HalpSystemHardwareLock, 0)) > + { > + /* The spin lock was not owned! */ > + KeBugCheckEx(SPIN_LOCK_NOT_OWNED, 0, 0, 0, 0); > + } > + > + /* Restore the flags */ > + __writeeflags(Flags); > +} > > FORCEINLINE > UCHAR > > Modified: branches/ros-amd64-bringup/reactos/hal/halx86/generic/i386/systimer.S > URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/hal/h… > ============================================================================== > --- branches/ros-amd64-bringup/reactos/hal/halx86/generic/i386/systimer.S [iso-8859-1] (original) > +++ branches/ros-amd64-bringup/reactos/hal/halx86/generic/i386/systimer.S [iso-8859-1] Fri Jan 1 00:45:36 2010 > @@ -17,82 +17,11 @@ > _HalpLastPerfCounterHigh: .long 0 > _HalpPerfCounterLow: .long 0 > _HalpPerfCounterHigh: .long 0 > -_HalpSystemHardwareFlags: .long 0 > > _UnhandledMsg: > .asciz "\n\x7\x7!!! Unhandled or Unexpected Code at line: %lx!!!\n" > > /* FUNCTIONS *****************************************************************/ > - > -.global _HalpReleaseCmosSpinLock@0 > -.func HalpReleaseCmosSpinLock@0 > -_HalpReleaseCmosSpinLock@0: > - > -#ifdef CONFIG_SMP > - /* Save clobbered register */ > - push eax > - > - /* Push saved EFLAGS */ > - push _HalpSystemHardwareFlags > - > - /* Release the lock */ > - lea eax, _HalpSystemHardwareLock > - RELEASE_SPINLOCK(eax) > - > - /* Restore EFLAGS */ > - popf > - > - /* Return */ > - pop eax > - ret > -#else > - /* Restore EFLAGS and return */ > - push _HalpSystemHardwareFlags > - popf > - ret > -#endif > - > -.endfunc > - > -.global _HalpAcquireSystemHardwareSpinLock@0 > -.func HalpAcquireSystemHardwareSpinLock@0 > -_HalpAcquireSystemHardwareSpinLock@0: > - > -#ifdef CONFIG_SMP > - /* Save clobbered register */ > - push eax > - > -HardwareLock: > - /* Save EFLAGS and disable interrupts */ > - pushf > - cli > - > - /* This is the CMOS lock, acquire it */ > - lea eax, _HalpSystemHardwareLock > - ACQUIRE_SPINLOCK(eax, CmosSpin) > - > - /* We have it, return the flags */ > - pop _HalpSystemHardwareFlags > - pop eax > - ret > - > -CmosSpin: > - > - /* Restore EFLAGS */ > - pushf _HalpSystemHardwareLock > - popf > - > - /* Spin */ > - SPIN_ON_LOCK(eax, HardwareLock) > -#else > - /* Save EFLAGS, disable interrupts and return */ > - pushf > - cli > - pop _HalpSystemHardwareFlags > - ret > -#endif > - > -.endfunc > > .global _HalpCalibrateStallExecution@0 > .func HalpCalibrateStallExecution@0 > > Best regards, Alex Ionescu

14 years, 8 months

NMI Support

by Ros Arm

Hello, I have identified a major deficiency in the x86 kernel that requires minor overhaul of multiple low-level components, and stems from poorly understood implementation details of the x86 architecture, which is NMI support. NMIs are Non Maskable Interrupts, similar to SMIs (generated for SMM) mode but typically used for critical hardware errors (somewhat a precursor to MCEs). Most modern operating systems support NMI as a debugging tool: when a system is deadlocked due to interrupt issues or perhaps in a state with interrupts disabled, it is often hard to "break-in" the system to analyze the issue. They are also used as a last resort to terminate the system in case of major hardware error (such as power issues or parity errors). NMIs can also be generated by external hardware: This simple circuit generates a tri-state one-cycle SERR# pulse on the PCI bus, which causes an NMI. It can be used as an emergency dump switch, when other methods fail. Â The following issues exist in ReactOS that hinder NMI support: Â - The I/O Privilege Map (IOPM) configuration is done dangerously and incorrectly. A number of misunderstood hardcoded values are used throughout the code, assumptions are made on the number of IOPMs, and IOPM switching is done very poorly during BIOS Calls. Â - BIOS Calls are currently executing on the TSS context of the current state. This works fine with the normal KGDT_TSS that NTOS executes on, but causes dangerous errors on scenarios such as Double Faults (KGDT_DF_TSS) and NMIs (KGDT_NMI_TSS). These TSS segments do not have an IOPM allocated, which causes memory corruption when the BIOS Call code attempts to save and restore the IOPM by assuming it's there. It also causes BIOS code to fail during execution; after tracing with an IDP we discovered that BIOS I/O Port accesses were generating exceptions, which turned out to be due to the fact the BIOS was reading the bogus, non-existing IOPM and thus failing to validate I/O Port access. This is currently a problem in ReactOS as a double-fault trap will trigger massive corruption, as the panic code will attempt to draw the "Blue screen of death", requiring a Video ROM Interrupt 10h through a BIOS Call, which will fail as explained. In an NMI case, the same scenario would also happen. Â - The NMI trap code is not yet implemented. Â - The KeRegisterNmiCallback and KeDeregisterNmiCallback routines are not yet implemented. Â - KPRCB Context-switching is not yet implemented, along with related routines. Only the high-level routines used during debug traps are implemented, but not the support required for resuming after an NMI. Â - HalHandleNMI is subject to recursive NMI scenarios. Â - BIOS Calls do excessive TLB flushing. Â - The logic for IDT write-protection during BIOS Calls is overcomplicated. The IDT should always be made read-only and restore to its previous state. Â - TLB flushing in the HAL appears to be broken when global pages are used. Additionally, the same problem exists in NTOS -- there is no support for TLB flushing when Global Pages are used, even though Global Page support is enabled in the MMU and the bit is used on kernel PTEs. This leads to either over-flushing global pages during context switching, which shouldn't be done, or non-flushing of global pages, when they should be flushed. Â - Tangential issue: I have written a new UNIMPLEMENTED_PATH macro that now describes the exact path that was touched. Previously only the PC was given, which makes it nearly impossible to connect to the line of source causing the issue, especially for non developers. This new macro outputs a string reason. Additionally, an UNIMPLEMENTED_V86_PATH is used for scenarios where the path is only expected in VDM/V8086 scenarios, to differentiate from unlikely paths in normal execution flows. Â These issues have all been fixed in my toilet. All this work stemmed from doing some testing of the new ARM3 section code written recently (never debug other people's code!), which led to significant debugging pains without NMI support. It has nothing to do with the ARM port but since I've written it, I might as well pass it on instead of keeping it locally for eternity. Â Thoughts/comments? Â -r

14 years, 8 months

Thank you

by Ros Arm

Dear ReactOS Members, We'd like to issue you our warmest holiday greetings and a happy new year! Withal, receive our cordial gratitude for the recent work on getting the ARM tree building again as well as for extending support for Windows and Mac OS X build systems throughout this troubled time. -r

14 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev