Ros-dev

ros-dev@reactos.org

5788 discussions

Start a nNew thread

ReactOS 0.3.11 Released

by Dmitry Gorbachev

Hi! I see that the release was not announced on ros-general and on ros-announce lists…

14 years, 8 months

Re: [ros-dev] [ros-diffs] [jimtabor] 44806: [Win32k] - Setting up for region attribute support. - Removed old code and use GreDeleteObject for dc and region types.

by Timo Kreuzer

Please bear in mind that our GDI object implementation uses a callback based deletion, and in my working copy I already modified DC cleanup to be fully done in the callback. This is much cleaner and safer than doing it in GreDeleteObject. Especially since objects might be subject to deferred deletion. jimtabor(a)svn.reactos.org schrieb: > Author: jimtabor > Date: Tue Dec 29 22:07:04 2009 > New Revision: 44806 > > URL: http://svn.reactos.org/svn/reactos?rev=44806&view=rev > Log: > [Win32k] > - Setting up for region attribute support. > - Removed old code and use GreDeleteObject for dc and region types. > > Modified: > trunk/reactos/subsystems/win32/win32k/eng/engwindow.c > trunk/reactos/subsystems/win32/win32k/include/dc.h > trunk/reactos/subsystems/win32/win32k/include/region.h > trunk/reactos/subsystems/win32/win32k/ntuser/painting.c > trunk/reactos/subsystems/win32/win32k/ntuser/window.c > trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c > trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c > trunk/reactos/subsystems/win32/win32k/objects/dclife.c > trunk/reactos/subsystems/win32/win32k/objects/dcstate.c > trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c > trunk/reactos/subsystems/win32/win32k/objects/region.c > > Modified: trunk/reactos/subsystems/win32/win32k/eng/engwindow.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/eng/engwindow.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/eng/engwindow.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -89,7 +89,7 @@ > if (hVisRgn != NULL) > { > NtGdiOffsetRgn(hVisRgn, Window->Wnd->rcClient.left, Window->Wnd->rcClient.top); > - visRgn = REGION_LockRgn(hVisRgn); > + visRgn = RGNOBJAPI_Lock(hVisRgn, NULL); > if (visRgn != NULL) > { > if (visRgn->rdh.nCount > 0) > @@ -110,7 +110,7 @@ > } > } > } > - REGION_UnlockRgn(visRgn); > + RGNOBJAPI_Unlock(visRgn); > } > else > { > > Modified: trunk/reactos/subsystems/win32/win32k/include/dc.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/include/dc.h [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/include/dc.h [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -144,7 +144,6 @@ > HDC FASTCALL DC_AllocDC(PUNICODE_STRING Driver); > VOID FASTCALL DC_InitDC(HDC DCToInit); > HDC FASTCALL DC_FindOpenDC(PUNICODE_STRING Driver); > -VOID FASTCALL DC_FreeDC(HDC); > VOID FASTCALL DC_AllocateDcAttr(HDC); > VOID FASTCALL DC_FreeDcAttr(HDC); > BOOL INTERNAL_CALL DC_Cleanup(PVOID ObjectBody); > > Modified: trunk/reactos/subsystems/win32/win32k/include/region.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/include/region.h [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/include/region.h [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -48,6 +48,8 @@ > INT FASTCALL IntGdiCombineRgn(PROSRGNDATA, PROSRGNDATA, PROSRGNDATA, INT); > INT FASTCALL REGION_Complexity(PROSRGNDATA); > PROSRGNDATA FASTCALL IntGdiCreateRectRgn(INT, INT, INT, INT); > +PROSRGNDATA FASTCALL RGNOBJAPI_Lock(HRGN,PRGN_ATTR *); > +VOID FASTCALL RGNOBJAPI_Unlock(PROSRGNDATA); > > #define UnsafeIntCreateRectRgnIndirect(prc) \ > NtGdiCreateRectRgn((prc)->left, (prc)->top, (prc)->right, (prc)->bottom) > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/painting.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/painting.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/painting.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -1006,10 +1006,10 @@ > } > else > { > - RgnData = REGION_LockRgn(Window->UpdateRegion); > + RgnData = RGNOBJAPI_Lock(Window->UpdateRegion, NULL); > ASSERT(RgnData != NULL); > RegionType = REGION_GetRgnBox(RgnData, &Rect); > - REGION_UnlockRgn(RgnData); > + RGNOBJAPI_Unlock(RgnData); > > if (RegionType != ERROR && RegionType != NULLREGION) > RECTL_bIntersectRect(&Rect, &Rect, &Window->Wnd->rcClient); > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -4557,10 +4557,10 @@ > /* Copy the region into hRgn */ > NtGdiCombineRgn(hRgn, VisRgn, NULL, RGN_COPY); > > - if((pRgn = REGION_LockRgn(hRgn))) > + if((pRgn = RGNOBJAPI_Lock(hRgn, NULL))) > { > Ret = pRgn->rdh.iType; > - REGION_UnlockRgn(pRgn); > + RGNOBJAPI_Unlock(pRgn); > } > else > Ret = ERROR; > @@ -4596,11 +4596,11 @@ > if(Window->WindowRegion && !(Wnd->style & WS_MINIMIZE)) > NtGdiCombineRgn(VisRgn, VisRgn, Window->WindowRegion, RGN_AND); > > - if((pRgn = REGION_LockRgn(VisRgn))) > + if((pRgn = RGNOBJAPI_Lock(VisRgn, NULL))) > { > Ret = pRgn->rdh.iType; > *Rect = pRgn->rdh.rcBound; > - REGION_UnlockRgn(pRgn); > + RGNOBJAPI_Unlock(pRgn); > } > else > Ret = ERROR; > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -953,16 +953,16 @@ > VisBefore = VIS_ComputeVisibleRegion(Window, FALSE, FALSE, TRUE); > VisRgn = NULL; > > - if (VisBefore != NULL && (VisRgn = (PROSRGNDATA)REGION_LockRgn(VisBefore)) && > + if (VisBefore != NULL && (VisRgn = (PROSRGNDATA)RGNOBJAPI_Lock(VisBefore, NULL)) && > REGION_GetRgnBox(VisRgn, &TempRect) == NULLREGION) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > GreDeleteObject(VisBefore); > VisBefore = NULL; > } > else if(VisRgn) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > NtGdiOffsetRgn(VisBefore, -Window->Wnd->rcWindow.left, -Window->Wnd->rcWindow.top); > } > } > @@ -1112,16 +1112,16 @@ > VisAfter = VIS_ComputeVisibleRegion(Window, FALSE, FALSE, TRUE); > VisRgn = NULL; > > - if (VisAfter != NULL && (VisRgn = (PROSRGNDATA)REGION_LockRgn(VisAfter)) && > + if (VisAfter != NULL && (VisRgn = (PROSRGNDATA)RGNOBJAPI_Lock(VisAfter, NULL)) && > REGION_GetRgnBox(VisRgn, &TempRect) == NULLREGION) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > GreDeleteObject(VisAfter); > VisAfter = NULL; > } > else if(VisRgn) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > NtGdiOffsetRgn(VisAfter, -Window->Wnd->rcWindow.left, -Window->Wnd->rcWindow.top); > } > > @@ -1156,9 +1156,9 @@ > RECTL_vOffsetRect(&ORect, - OldWindowRect.left, - OldWindowRect.top); > RECTL_vOffsetRect(&NRect, - NewWindowRect.left, - NewWindowRect.top); > RECTL_bIntersectRect(&CopyRect, &ORect, &NRect); > - pCopyRgn = REGION_LockRgn(CopyRgn); > + pCopyRgn = RGNOBJAPI_Lock(CopyRgn, NULL); > REGION_CropAndOffsetRegion(pCopyRgn, pCopyRgn, &CopyRect, NULL); > - REGION_UnlockRgn(pCopyRgn); > + RGNOBJAPI_Unlock(pCopyRgn); > } > > /* No use in copying bits which are in the update region. */ > @@ -1174,11 +1174,11 @@ > * there's nothing to copy. Also, it's no use copying bits onto > * themselves. > */ > - if ((VisRgn = (PROSRGNDATA)REGION_LockRgn(CopyRgn)) && > + if ((VisRgn = (PROSRGNDATA)RGNOBJAPI_Lock(CopyRgn, NULL)) && > REGION_GetRgnBox(VisRgn, &CopyRect) == NULLREGION) > { > /* Nothing to copy, clean up */ > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > GreDeleteObject(CopyRgn); > CopyRgn = NULL; > } > @@ -1187,7 +1187,7 @@ > { > if(VisRgn) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > } > > /* > @@ -1214,7 +1214,7 @@ > } > else if(VisRgn) > { > - REGION_UnlockRgn(VisRgn); > + RGNOBJAPI_Unlock(VisRgn); > } > } > else > > Modified: trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -36,7 +36,7 @@ > NtGdiCombineRgn(Dc->rosdc.hGCClipRgn, Dc->rosdc.hClipRgn, Dc->rosdc.hVisRgn, RGN_AND); > NtGdiOffsetRgn(Dc->rosdc.hGCClipRgn, Dc->ptlDCOrig.x, Dc->ptlDCOrig.y); > > - if((CombinedRegion = REGION_LockRgn(Dc->rosdc.hGCClipRgn))) > + if((CombinedRegion = RGNOBJAPI_Lock(Dc->rosdc.hGCClipRgn, NULL))) > { > if (Dc->rosdc.CombinedClip != NULL) > IntEngDeleteClipRegion(Dc->rosdc.CombinedClip); > @@ -46,7 +46,7 @@ > CombinedRegion->Buffer, > &CombinedRegion->rdh.rcBound); > > - REGION_UnlockRgn(CombinedRegion); > + RGNOBJAPI_Unlock(CombinedRegion); > } > > if ( NULL == Dc->rosdc.CombinedClip ) > @@ -123,10 +123,10 @@ > { > PROSRGNDATA Rgn; > RECTL rect; > - if((Rgn = REGION_LockRgn(dc->rosdc.hVisRgn))) > + if((Rgn = RGNOBJAPI_Lock(dc->rosdc.hVisRgn, NULL))) > { > REGION_GetRgnBox(Rgn, &rect); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > dc->rosdc.hClipRgn = UnsafeIntCreateRectRgnIndirect(&rect); > } > else > @@ -177,13 +177,13 @@ > return ERROR; > } > > - if (!(Rgn = REGION_LockRgn(dc->rosdc.hGCClipRgn))) > + if (!(Rgn = RGNOBJAPI_Lock(dc->rosdc.hGCClipRgn, NULL))) > { > DC_UnlockDc(dc); > return ERROR; > } > retval = REGION_GetRgnBox(Rgn, rc); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > IntDPtoLP(dc, (LPPOINT)rc, 2); > DC_UnlockDc(dc); > > @@ -407,11 +407,11 @@ > > if (dc->rosdc.hGCClipRgn) > { > - if((Rgn = (PROSRGNDATA)REGION_LockRgn(dc->rosdc.hGCClipRgn))) > + if((Rgn = (PROSRGNDATA)RGNOBJAPI_Lock(dc->rosdc.hGCClipRgn, NULL))) > { > IntLPtoDP(dc, (LPPOINT)&Rect, 2); > Result = REGION_RectInRegion(Rgn, &Rect); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > } > } > DC_UnlockDc(dc); > > Modified: trunk/reactos/subsystems/win32/win32k/objects/dclife.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/dclife.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -133,23 +133,6 @@ > NewDC->dclevel.pSurface = SURFACE_ShareLockSurface(hsurf); > > return NewDC; > -} > - > -VOID FASTCALL > -DC_FreeDC(HDC DCToFree) > -{ > - DC_FreeDcAttr(DCToFree); > - if (!IsObjectDead(DCToFree)) > - { > - if (!GDIOBJ_FreeObjByHandle(DCToFree, GDI_OBJECT_TYPE_DC)) > - { > - DPRINT1("DC_FreeDC failed\n"); > - } > - } > - else > - { > - DPRINT1("Attempted to Delete 0x%x currently being destroyed!!!\n",DCToFree); > - } > } > > BOOL INTERNAL_CALL > @@ -537,7 +520,7 @@ > PATH_Delete(DCToDelete->dclevel.hPath); > > DC_UnlockDc(DCToDelete); > - DC_FreeDC(hDC); > + GreDeleteObject(hDC); > return TRUE; > } > > > Modified: trunk/reactos/subsystems/win32/win32k/objects/dcstate.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/dcstate.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/dcstate.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -180,7 +180,7 @@ > } > > /* Delete the saved dc */ > - DC_FreeDC(hdcSave); > + GreDeleteObject(hdcSave); > } > > DC_UnlockDc(pdc); > > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -663,11 +663,34 @@ > FASTCALL > GreDeleteObject(HGDIOBJ hObject) > { > + INT Index; > + PGDI_TABLE_ENTRY Entry; > + DWORD dwObjectType; > + PVOID pAttr = NULL; > + > DPRINT("NtGdiDeleteObject handle 0x%08x\n", hObject); > if (!IsObjectDead(hObject)) > { > - return NULL != hObject > - ? GDIOBJ_FreeObjByHandle(hObject, GDI_OBJECT_TYPE_DONTCARE) : FALSE; > + dwObjectType = GDIOBJ_GetObjectType(hObject); > + > + Index = GDI_HANDLE_GET_INDEX(hObject); > + Entry = &GdiHandleTable->Entries[Index]; > + pAttr = Entry->UserData; > + > + switch (dwObjectType) > + { > +// case GDI_OBJECT_TYPE_BRUSH: > + case GDI_OBJECT_TYPE_REGION: > + if (pAttr) FreeObjectAttr(pAttr); > + break; > + > + case GDI_OBJECT_TYPE_DC: > + DC_FreeDcAttr(hObject); > + break; > + } > + > + return NULL != hObject > + ? GDIOBJ_FreeObjByHandle(hObject, dwObjectType) : FALSE; > } > else > { > > Modified: trunk/reactos/subsystems/win32/win32k/objects/region.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/region.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/region.c [iso-8859-1] Tue Dec 29 22:07:04 2009 > @@ -467,7 +467,7 @@ > { > ROSRGNDATA *Data; > > - Data = REGION_LockRgn(hRgn); > + Data = RGNOBJAPI_Lock(hRgn, NULL); > if (Data == NULL) > { > DbgPrint("IntDumpRegion called with invalid region!\n"); > @@ -482,7 +482,7 @@ > Data->rdh.rcBound.bottom, > Data->rdh.iType); > > - REGION_UnlockRgn(Data); > + RGNOBJAPI_Unlock(Data); > } > #endif /* not NDEBUG */ > > @@ -1739,7 +1739,7 @@ > trb = REGION_AllocRgnWithHandle(srb->rdh.nCount + 1); > if (!trb) > { > - REGION_UnlockRgn(tra); > + RGNOBJAPI_Unlock(tra); > GreDeleteObject(htra); > return; > } > @@ -1748,8 +1748,8 @@ > REGION_SubtractRegion(tra, sra, srb); > REGION_SubtractRegion(trb, srb, sra); > REGION_UnionRegion(dr, tra, trb); > - REGION_UnlockRgn(tra); > - REGION_UnlockRgn(trb); > + RGNOBJAPI_Unlock(tra); > + RGNOBJAPI_Unlock(trb); > > GreDeleteObject(htra); > GreDeleteObject(htrb); > @@ -1863,26 +1863,26 @@ > PRECTL rc; > ULONG i; > > - if (!(srcObj = REGION_LockRgn(hSrc))) > + if (!(srcObj = RGNOBJAPI_Lock(hSrc, NULL))) > { > return FALSE; > } > if (!REGION_NOT_EMPTY(srcObj)) > { > - REGION_UnlockRgn(srcObj); > + RGNOBJAPI_Unlock(srcObj); > return FALSE; > } > - if (!(destObj = REGION_LockRgn(hDest))) > - { > - REGION_UnlockRgn(srcObj); > + if (!(destObj = RGNOBJAPI_Lock(hDest, NULL))) > + { > + RGNOBJAPI_Unlock(srcObj); > return FALSE; > } > > EMPTY_REGION(destObj); > if (!REGION_CopyRegion(destObj, srcObj)) > { > - REGION_UnlockRgn(destObj); > - REGION_UnlockRgn(srcObj); > + RGNOBJAPI_Unlock(destObj); > + RGNOBJAPI_Unlock(srcObj); > return FALSE; > } > > @@ -1891,8 +1891,8 @@ > if (!REGION_CreateSimpleFrameRgn(destObj, x, y)) > { > EMPTY_REGION(destObj); > - REGION_UnlockRgn(destObj); > - REGION_UnlockRgn(srcObj); > + RGNOBJAPI_Unlock(destObj); > + RGNOBJAPI_Unlock(srcObj); > return FALSE; > } > } > @@ -1951,8 +1951,8 @@ > REGION_SubtractRegion(destObj, srcObj, destObj); > } > > - REGION_UnlockRgn(destObj); > - REGION_UnlockRgn(srcObj); > + RGNOBJAPI_Unlock(destObj); > + RGNOBJAPI_Unlock(srcObj); > return TRUE; > } > > @@ -1986,11 +1986,11 @@ > goto done; > } > > - if ( !(srcObj = REGION_LockRgn(hSrc)) ) > + if ( !(srcObj = RGNOBJAPI_Lock(hSrc, NULL)) ) > goto done; > - if ( !(destObj = REGION_LockRgn(hDest)) ) > - { > - REGION_UnlockRgn(srcObj); > + if ( !(destObj = RGNOBJAPI_Lock(hDest, NULL)) ) > + { > + RGNOBJAPI_Unlock(srcObj); > goto done; > } > EMPTY_REGION(destObj); > @@ -2021,8 +2021,8 @@ > } > ret = TRUE; > > - REGION_UnlockRgn(srcObj); > - REGION_UnlockRgn(destObj); > + RGNOBJAPI_Unlock(srcObj); > + RGNOBJAPI_Unlock(destObj); > > done: > return ret; > @@ -2054,7 +2054,7 @@ > pReg->Buffer = ExAllocatePoolWithTag(PagedPool, nReg * sizeof(RECT), TAG_REGION); > if (!pReg->Buffer) > { > - REGION_UnlockRgn(pReg); > + RGNOBJAPI_Unlock(pReg); > GDIOBJ_FreeObjByHandle(hReg, GDI_OBJECT_TYPE_REGION); > return NULL; > } > @@ -2264,17 +2264,21 @@ > } > else if (src2Rgn == NULL) > { > - DPRINT1("IntGdiCombineRgn requires hSrc2 != NULL for combine mode %d!\n", CombineMode); > - SetLastWin32Error(ERROR_INVALID_HANDLE); > + DPRINT1("IntGdiCombineRgn requires hSrc2 != NULL for combine mode %d!\n", CombineMode); > + SetLastWin32Error(ERROR_INVALID_HANDLE); > } > } > + } > + else > + { > + DPRINT("IntGdiCombineRgn: hSrc1 unavailable\n"); > + SetLastWin32Error(ERROR_INVALID_HANDLE); > } > } > else > { > DPRINT("IntGdiCombineRgn: hDest unavailable\n"); > SetLastWin32Error(ERROR_INVALID_HANDLE); > - result = ERROR; > } > return result; > } > @@ -2297,30 +2301,30 @@ > return ERROR; > } > > - destRgn = REGION_LockRgn(hDest); > + destRgn = RGNOBJAPI_Lock(hDest, NULL); > if (!destRgn) > { > SetLastWin32Error(ERROR_INVALID_HANDLE); > return ERROR; > } > > - src1Rgn = REGION_LockRgn(hSrc1); > + src1Rgn = RGNOBJAPI_Lock(hSrc1, NULL); > if (!src1Rgn) > { > - REGION_UnlockRgn(destRgn); > + RGNOBJAPI_Unlock(destRgn); > SetLastWin32Error(ERROR_INVALID_HANDLE); > return ERROR; > } > > if (hSrc2) > - src2Rgn = REGION_LockRgn(hSrc2); > + src2Rgn = RGNOBJAPI_Lock(hSrc2, NULL); > > result = IntGdiCombineRgn( destRgn, src1Rgn, src2Rgn, CombineMode); > > if (src2Rgn) > - REGION_UnlockRgn(src2Rgn); > - REGION_UnlockRgn(src1Rgn); > - REGION_UnlockRgn(destRgn); > + RGNOBJAPI_Unlock(src2Rgn); > + RGNOBJAPI_Unlock(src1Rgn); > + RGNOBJAPI_Unlock(destRgn); > > return result; > } > @@ -2347,7 +2351,7 @@ > if (!(pRgn = REGION_AllocRgnWithHandle(1))) return NULL; > > REGION_SetRectRgn(pRgn, LeftRect, TopRect, RightRect, BottomRect); > - REGION_UnlockRgn(pRgn); > + RGNOBJAPI_Unlock(pRgn); > // Return pointer with Share locks. > pRgn = GDIOBJ_ShareLockObj(pRgn->BaseObject.hHmgr, GDI_OBJECT_TYPE_REGION); > > @@ -2370,7 +2374,7 @@ > hRgn = pRgn->BaseObject.hHmgr; > > REGION_SetRectRgn(pRgn, LeftRect, TopRect, RightRect, BottomRect); > - REGION_UnlockRgn(pRgn); > + RGNOBJAPI_Unlock(pRgn); > > return hRgn; > } > @@ -2490,7 +2494,7 @@ > REGION_UnionRectWithRgn(obj, &rect); > } > > - REGION_UnlockRgn(obj); > + RGNOBJAPI_Unlock(obj); > return hrgn; > } > > @@ -2506,12 +2510,12 @@ > ULONG i; > BOOL bRet = FALSE; > > - if ( !(rgn1 = REGION_LockRgn(hSrcRgn1)) ) > + if ( !(rgn1 = RGNOBJAPI_Lock(hSrcRgn1, NULL)) ) > return ERROR; > > - if ( !(rgn2 = REGION_LockRgn(hSrcRgn2)) ) > - { > - REGION_UnlockRgn(rgn1); > + if ( !(rgn2 = RGNOBJAPI_Lock(hSrcRgn2, NULL)) ) > + { > + RGNOBJAPI_Unlock(rgn1); > return ERROR; > } > > @@ -2540,8 +2544,8 @@ > bRet = TRUE; > > exit: > - REGION_UnlockRgn(rgn1); > - REGION_UnlockRgn(rgn2); > + RGNOBJAPI_Unlock(rgn1); > + RGNOBJAPI_Unlock(rgn2); > return bRet; > } > > @@ -2637,12 +2641,12 @@ > if (!NT_SUCCESS(Status)) > { > SetLastWin32Error(ERROR_INVALID_PARAMETER); > - REGION_UnlockRgn(Region); > + RGNOBJAPI_Unlock(Region); > GreDeleteObject(hRgn); > return NULL; > } > > - REGION_UnlockRgn(Region); > + RGNOBJAPI_Unlock(Region); > > return hRgn; > } > @@ -2659,14 +2663,14 @@ > PROSRGNDATA rgn; > PRECTL r; > > - if (NULL == (rgn = REGION_LockRgn(hRgn))) > + if (NULL == (rgn = RGNOBJAPI_Lock(hRgn, NULL))) > { > return FALSE; > } > > if (NULL == (oldhBrush = NtGdiSelectBrush(hDC, hBrush))) > { > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > return FALSE; > } > > @@ -2675,7 +2679,7 @@ > NtGdiPatBlt(hDC, r->left, r->top, r->right - r->left, r->bottom - r->top, PATCOPY); > } > > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > NtGdiSelectBrush(hDC, oldhBrush); > > return TRUE; > @@ -2816,13 +2820,13 @@ > PROSRGNDATA Rgn; > DWORD ret; > > - if (!(Rgn = REGION_LockRgn(hRgn))) > + if (!(Rgn = RGNOBJAPI_Lock(hRgn, NULL))) > { > return ERROR; > } > > ret = REGION_GetRgnBox(Rgn, pRect); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > > return ret; > } > @@ -2839,13 +2843,13 @@ > DWORD ret; > NTSTATUS Status = STATUS_SUCCESS; > > - if (!(Rgn = REGION_LockRgn(hRgn))) > + if (!(Rgn = RGNOBJAPI_Lock(hRgn, NULL))) > { > return ERROR; > } > > ret = REGION_GetRgnBox(Rgn, &SafeRect); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > if (ERROR == ret) > { > return ret; > @@ -2880,7 +2884,7 @@ > ULONG i; > PRECTL rc; > > - if (!(RgnData = REGION_LockRgn(hRgn))) > + if (!(RgnData = RGNOBJAPI_Lock(hRgn, NULL))) > { > SetLastWin32Error(ERROR_INVALID_HANDLE); > return FALSE; > @@ -2892,13 +2896,13 @@ > > if (!NtGdiPatBlt(hDC, rc->left, rc->top, rc->right - rc->left, rc->bottom - rc->top, DSTINVERT)) > { > - REGION_UnlockRgn(RgnData); > + RGNOBJAPI_Unlock(RgnData); > return FALSE; > } > rc++; > } > > - REGION_UnlockRgn(RgnData); > + RGNOBJAPI_Unlock(RgnData); > return TRUE; > } > > @@ -2910,7 +2914,7 @@ > INT YOffset > ) > { > - PROSRGNDATA rgn = REGION_LockRgn(hRgn); > + PROSRGNDATA rgn = RGNOBJAPI_Lock(hRgn, NULL); > INT ret; > > DPRINT("NtGdiOffsetRgn: hRgn %d Xoffs %d Yoffs %d rgn %x\n", hRgn, XOffset, YOffset, rgn ); > @@ -2946,7 +2950,7 @@ > } > } > ret = REGION_Complexity(rgn); > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > return ret; > } > > @@ -2982,7 +2986,7 @@ > > NtGdiCombineRgn(tmpVisRgn, tmpVisRgn, dc->rosdc.hGCClipRgn, RGN_AND); > > - visrgn = REGION_LockRgn(tmpVisRgn); > + visrgn = RGNOBJAPI_Lock(tmpVisRgn, NULL); > if (visrgn == NULL) > { > GreDeleteObject(tmpVisRgn); > @@ -3005,7 +3009,7 @@ > &BrushOrigin, > 0xFFFF);//FIXME:don't know what to put here > > - REGION_UnlockRgn(visrgn); > + RGNOBJAPI_Unlock(visrgn); > GreDeleteObject(tmpVisRgn); > > // Fill the region > @@ -3024,7 +3028,7 @@ > ULONG i; > PRECTL r; > > - if (!(rgn = REGION_LockRgn(hRgn) ) ) > + if (!(rgn = RGNOBJAPI_Lock(hRgn, NULL) ) ) > return FALSE; > > if (rgn->rdh.nCount > 0 && INRECT(rgn->rdh.rcBound, X, Y)) > @@ -3034,13 +3038,13 @@ > { > if (INRECT(*r, X, Y)) > { > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > return TRUE; > } > r++; > } > } > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > return FALSE; > } > > @@ -3108,7 +3112,7 @@ > BOOL Ret; > NTSTATUS Status = STATUS_SUCCESS; > > - if (!(Rgn = REGION_LockRgn(hRgn))) > + if (!(Rgn = RGNOBJAPI_Lock(hRgn, NULL))) > { > return ERROR; > } > @@ -3126,14 +3130,14 @@ > > if (!NT_SUCCESS(Status)) > { > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > SetLastNtError(Status); > DPRINT1("NtGdiRectInRegion: bogus rc\n"); > return ERROR; > } > > Ret = REGION_RectInRegion(Rgn, &rc); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > return Ret; > } > > @@ -3189,14 +3193,14 @@ > { > PROSRGNDATA rgn; > > - if ( !(rgn = REGION_LockRgn(hRgn)) ) > + if ( !(rgn = RGNOBJAPI_Lock(hRgn, NULL)) ) > { > return 0; //per documentation > } > > REGION_SetRectRgn(rgn, LeftRect, TopRect, RightRect, BottomRect); > > - REGION_UnlockRgn(rgn); > + RGNOBJAPI_Unlock(rgn); > return TRUE; > } > > @@ -3210,7 +3214,7 @@ > PROSRGNDATA Rgn; > NTSTATUS Status = STATUS_SUCCESS; > > - if (!(Rgn = REGION_LockRgn(hDest))) > + if (!(Rgn = RGNOBJAPI_Lock(hDest, NULL))) > { > SetLastWin32Error(ERROR_INVALID_HANDLE); > return NULL; > @@ -3229,13 +3233,13 @@ > > if (! NT_SUCCESS(Status)) > { > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > SetLastNtError(Status); > return NULL; > } > > REGION_UnionRectWithRgn(Rgn, &SafeRect); > - REGION_UnlockRgn(Rgn); > + RGNOBJAPI_Unlock(Rgn); > return hDest; > } > > @@ -3257,7 +3261,7 @@ > ) > { > DWORD size; > - PROSRGNDATA obj = REGION_LockRgn(hrgn); > + PROSRGNDATA obj = RGNOBJAPI_Lock(hrgn, NULL); > NTSTATUS Status = STATUS_SUCCESS; > > if (!obj) > @@ -3266,7 +3270,7 @@ > size = obj->rdh.nCount * sizeof(RECT); > if (count < (size + sizeof(RGNDATAHEADER)) || rgndata == NULL) > { > - REGION_UnlockRgn(obj); > + RGNOBJAPI_Unlock(obj); > if (rgndata) /* buffer is too small, signal it by return 0 */ > return 0; > else /* user requested buffer size with rgndata NULL */ > @@ -3288,11 +3292,11 @@ > if (!NT_SUCCESS(Status)) > { > SetLastNtError(Status); > - REGION_UnlockRgn(obj); > + RGNOBJAPI_Unlock(obj); > return 0; > } > > - REGION_UnlockRgn(obj); > + RGNOBJAPI_Unlock(obj); > return size + sizeof(RGNDATAHEADER); > } > > @@ -3778,7 +3782,7 @@ > (Pts[2].x == Pts[3].x) && > (Pts[3].y == Pts[0].y)))) > { > - REGION_UnlockRgn(region); > + RGNOBJAPI_Unlock(region); > NtGdiSetRectRgn(hrgn, min(Pts[0].x, Pts[2].x), min(Pts[0].y, Pts[2].y), > max(Pts[0].x, Pts[2].x), max(Pts[0].y, Pts[2].y)); > return hrgn; > @@ -3927,7 +3931,7 @@ > curPtBlock = tmpPtBlock; > } > ExFreePoolWithTag(pETEs, TAG_REGION); > - REGION_UnlockRgn(region); > + RGNOBJAPI_Unlock(region); > return hrgn; > } > > > > >

14 years, 8 months

[ros-diffs] [tkreuzer] 44766: [KDBG] Hackfix the problem with attaching to processes introduced in r44743, by lowering IRQL to passive level, although interrupts are off. Needed because KDBG calls pageable code.

by Dmitry Gorbachev

This problem was in bugzilla for more then 1 year…

14 years, 9 months

Re: [ros-dev] [ros-diffs] [ekohl] 44713: - Remove unused variable - Get rid of those ugly single line if-statements. - No code changes

by Gabriel ilardi

It's nice to see you again between us. Welcome back. :) > Date: Tue, 22 Dec 2009 16:51:33 +0000 > To: ros-diffs(a)reactos.org > From: ekohl(a)svn.reactos.org > Subject: [ros-diffs] [ekohl] 44713: - Remove unused variable - Get rid of those ugly single line if-statements. - No code changes > > Author: ekohl > Date: Tue Dec 22 17:51:33 2009 > New Revision: 44713 > > URL: http://svn.reactos.org/svn/reactos?rev=44713&view=rev > Log: > - Remove unused variable > - Get rid of those ugly single line if-statements. > - No code changes > > Modified: > trunk/reactos/base/system/services/rpcserver.c > > Modified: trunk/reactos/base/system/services/rpcserver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/rpcse… > ============================================================================== > --- trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] (original) > +++ trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] Tue Dec 22 17:51:33 2009 > @@ -2228,7 +2228,8 @@ > return ERROR_ACCESS_DENIED; > } > > - if (lpResumeHandle) dwLastResumeCount = *lpResumeHandle; > + if (lpResumeHandle) > + dwLastResumeCount = *lpResumeHandle; > > /* FIXME: Lock the service list shared */ > > @@ -2306,7 +2307,9 @@ > > DPRINT("*pcbBytesNeeded: %lu\n", dwRequiredSize); > > - if (lpResumeHandle) *lpResumeHandle = dwLastResumeCount; > + if (lpResumeHandle) > + *lpResumeHandle = dwLastResumeCount; > + > *lpServicesReturned = dwServiceCount; > *pcbBytesNeeded = dwRequiredSize; > > @@ -3244,7 +3247,8 @@ > KEY_READ, > &hServicesKey); > > - if (dwError != ERROR_SUCCESS) return dwError; > + if (dwError != ERROR_SUCCESS) > + return dwError; > > /* NOTE: Windows calculates the pcbBytesNeeded based on WCHAR strings for > both EnumDependentServicesA and EnumDependentServicesW. So returned pcbBytesNeeded > @@ -3376,8 +3380,7 @@ > } > } > > - dwError = REnumServicesStatusW(//BindingHandle, > - hSCManager, > + dwError = REnumServicesStatusW(hSCManager, > dwServiceType, > dwServiceState, > (LPBYTE)lpStatusPtrW, > @@ -3387,7 +3390,8 @@ > lpResumeHandle); > > /* if no services were returned then we are Done */ > - if (*lpServicesReturned == 0) goto Done; > + if (*lpServicesReturned == 0) > + goto Done; > > lpStatusPtrA = (LPENUM_SERVICE_STATUSA)lpBuffer; > lpStringPtrA = (LPSTR)((ULONG_PTR)lpBuffer + > @@ -3434,7 +3438,8 @@ > } > > Done:; > - if (lpStatusPtrW) HeapFree(GetProcessHeap(), 0, lpStatusPtrW); > + if (lpStatusPtrW) > + HeapFree(GetProcessHeap(), 0, lpStatusPtrW); > > DPRINT("REnumServicesStatusA() done (Error %lu)\n", dwError); > > > _________________________________________________________________ 25 Gigabyte per le tue foto online http://www.windowslive.it/foto.aspx

14 years, 9 months

Re: [ros-dev] [ros-diffs] [janderwald] 44644: [SETUPAPI] - Implement SetupDiInstallDeviceInterfaces, SetupDiCreateDeviceInterfaceRegKeyW which are required to store device specific information

by Hervé Poussineau

janderwald(a)svn.reactos.org a écrit : > Author: janderwald > Date: Fri Dec 18 05:37:15 2009 > New Revision: 44644 > > URL: http://svn.reactos.org/svn/reactos?rev=44644&view=rev > Log: > [SETUPAPI] > - Implement SetupDiInstallDeviceInterfaces, SetupDiCreateDeviceInterfaceRegKeyW which are required to store device specific information > > Modified: > trunk/reactos/dll/win32/setupapi/devinst.c > trunk/reactos/dll/win32/setupapi/interface.c > trunk/reactos/dll/win32/setupapi/setupapi_private.h > > [...] > + > + InsertTailList(&devInfo->InterfaceListHead, &DevItf->ListEntry); > + > + memcpy(&DeviceInterfaceData.InterfaceClassGuid, &DevItf->InterfaceClassGuid, sizeof(GUID)); > + DeviceInterfaceData.cbSize = sizeof(SP_DEVICE_INTERFACE_DATA); > + DeviceInterfaceData.Flags = DevItf->Flags; > + DeviceInterfaceData.Reserved = (ULONG_PTR)DevItf; > + > + hKey = SetupDiCreateDeviceInterfaceRegKeyW(DeviceInfoSet, &DeviceInterfaceData, 0, KEY_ALL_ACCESS, NULL, 0); > + HeapFree(GetProcessHeap(), 0, DevItf); > + if (hKey == INVALID_HANDLE_VALUE) > + { > + return FALSE; > + } > + > Seems like you're keeping in DeviceInterfaceData.Reserved a pointer to a deleted structure... Is it intentional?

14 years, 9 months

Doxygen....

by Timo Kreuzer

... is completely broken. Anyone working on this? Thanks, Timo

14 years, 9 months

Re: [ros-dev] Improving our procedure

by Matthias Kupfer

Hi, just for your information, I have already written a script and it's already available in trunk (/trunk/tools/changelog/autocl.py), but Aleksey decided to make the ChangeLog manually. Of course the script can't do any magic, but it was intended to setup up a ChangeLog-base for manual adjustments with the great advantage that nothing will be forgotten. Maybe we can improve the script to fit it to our needs and make it as much flexible as possible, but nevertheless, we have to give it a chance to judge... Matthias -- Matthias Kupfer phone +49 (0) 371 236 46 52 Wilhelm-Firl-Straße 21 mobile +49 (0) 160 859 43 54 09122 Chemnitz, Germany

14 years, 9 months

Improving our procedure

by victor martinez

Hi, This is incredible. I can understand a delay in a release because fixing Blockers, i can understand a delay because we are afraid of "2012" movie.But i can not understand why the Changelog is not made!!. On 3rd of November Aleksey sent an email saying a Blocker was present to release 0.3.11, this means that on 3rd of November a full Changelog should have been done and just 2 lines (explaining the Fix,if needed) should have been added afterwards. But the fact is that the Blocker has been solved more than one week ago, that we are still waiting for changelog to be done(after more than a month) and that the binaries are stored in SF waiting indefinitely to link them. So this strikes again, what is happening with Changelogs?What happens if noone wants to write his Changelog?Are we going to stay here waiting it indefinitely?Is our actual procedure correct?Or is it not practical?How can we shorten the time for a release?What happens if one of the Steps before releasing (like Changelog Step) is not properlly done?Do we have a PlanB? Let´s review our Teorical steps before a release and finding Bottlenecks as i do in my work: 1) Coding Time.During this time Devs creates ReactOS code.Since 0.3.9 also the GoldenApps and CandidateApps are being tested during this time in regular basis to reduce the possible Blockers. 2) Choosing Minute. An ISO is chosen as Candidate. Doubts: When the Candidate is chosen?Following which criterias?Why sometimes we take an ISO after one month and other times after 2 months? 3) Colin creates a Pre-release ISO. 4) Colin creates the 0.3.XX wikipage.Tests begins and Changelog begins to be written. 5) Performing Testing on Candidate. It usually takes less than a week, and thanks to previous testings in Coding Time, there are less Blockers each time. 6A) Blocker found. If a Blocker is found, a regression testing begins(if needed) and a patch/hack is made.GoTo 7 6B) Blocker not found. prerelease ISO is released as definitive.END. 7)Patch is added to release branch, Colin creates a second RC and testers perform a full test focusing in the regression. Release.END. Let´s begin studying the 0.3.11 case. Step 1 was done correctly.We have devs still working on ROS.great! Step 2 was a CHAOS. I have been asked to select first an ISO before asking Colin to make a prerelease ISO of it. Testing that first ISO we found the Vmware regression but it took a little(more than a month to fix it) so we select a different ISO and we performed a full testing (again) before asking Colin to create a prerelease. Changing the ISO is not inside the Teorical steps,but since the patch for Vmware wasnt made and we had time it didnt suppose really a lose of time. Step 3.First bottleneck. It took a little to contact with Colin,because he was busy with RL, so we had to wait him to create a Branch,include the reverts and create the prerelease.If I recall correctly it took more than a Week. Without the prerelease done is impossible to test anything.We should have an alternative to Colin in case Colin is busy with RL.We dont have a PlanB for this situation. Step4. Colin creates the Wikipage. Step5.Test begins but Changelog didnt begin to be written, it has been asked twice via ML, and zillions via IRC. Currently we are waiting for having it complete. And now second bottleneck: In 0.3.11 case,Blockers were solved BEFORE prerelease was made, so when Colin uploaded the prerelease iso it doesnt have any Blocker and it is ready to be released.And then the bottleneck comes:Changelog. Changelog can be created without hurry if we are in step 6A(a Blocker found) but in case 6B (as 0.3.11 prerelease is) you dont have real time to create it. When a Blocker is found,Changelog can be created during the extra time of regtesting+finding a patch+adding to branch+creating a new iso+performing again all the Tests, (this extra time is usually 4 weeks). But when non Blocker is found in Step6, Changelog stops our release.You cant made a proper Changelog of 2 months changes in a week. So our procedure currently is not optimal at all. First bottleneck: Relying in just one guy to merge stuff in the branch+create the ISO should be solved. Second bottleneck: If we expect that our prereleases doesnt have any blocker,then Changelog will be stopping our releases. To avoid this i propose a new procedure for 0.3.12, which is more multitasking. STEP1: Create 0.3.12 Changelog page.Open to include the changes since the Beginning. STEP2: Coding time. Meanwhile,testers tests goldenapps and candidateapps. STEP2: Choosing minute.The candidate ISO is selected, Devs are warned in Changelog page which is the latest revision to include the changes and that just they have one week to finish their Changelogs. STEP3: Release Engineers(not just Colin) creates the branch and the prerelease iso. STEP4: Release Engineers creates a Test 0.3.12 wikipage. STEP5: Tests are performed. This gives one week of extra time to have the Changelog done(more if a blocker is found). If Changelog is critical for releasing, then we need a PlanB if a Dev rejects or cant make a changelog.This is called SCRIPT. I´m really bored of those guys who doesnt want the Script but doesnt write their changes in Changelog neither. we should have a Script that by request or by lazyness of the devs can make a Changelog giving a revision range,a component or|and an author.This will make the life easier and healthier.Btw, some Devs doesnt want to waste the time writting Changelogs and prefer coding, so this tool is a must.I dont want to see devs sending less code to avoid writting a changelog. Sorry about this long post.My fingers were trained in our Wiki this morning, btw, i hope someone can review my recent changes on the Changelog 0.3.11 to be sure i put the commits in their correct place.Thanks. _________________________________________________________________ Date una vuelta por Sietes y conoce el pueblo de los expertos en Windows 7 http://www.sietesunpueblodeexpertos.com/

14 years, 9 months

Re: [ros-dev] [ros-diffs] [dreimer] 44603: Using the right Cross Compiler is useful, of course. Now We just need a native one, because the cygwin one has evil *nix, blasphemical, god negating and devil worshipping search paths.

by Steven Edwards

On Tue, Dec 15, 2009 at 11:07 AM, <dreimer(a)svn.reactos.org> wrote: > Author: dreimer > Date: Tue Dec 15 17:07:47 2009 > New Revision: 44603 > > URL: http://svn.reactos.org/svn/reactos?rev=44603&view=rev > Log: > Using the right Cross Compiler is useful, of course. Now We just need a native one, because the cygwin one has evil *nix, blasphemical, god negating and devil worshipping search paths. Don't hold back. Tell us how you really feel. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

14 years, 9 months

yes

by Yoandri Saavedra González

You victory Alex....you know... -- Técnico en la FPGISB UCP 'Pepito Tey' 'Creo en el software libre' Ubuntu "Linux for human beings" Lo último que se sabe cuando se realiza un trabajo es por donde empezar. (Blaise Pascal, matemático francés)

14 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev