Ros-dev

ros-dev@reactos.org

5789 discussions

Re: [ros-dev] [ros-diffs] [sginsberg] 42973: - %llx -> %I64x - Don't pass a string literal to strcmp

by Timo Kreuzer

Huh? Why shouldn't one use a string literal in strcmp? What are you trying to "fix"? sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Sun Aug 30 20:40:58 2009 > New Revision: 42973 > > URL: http://svn.reactos.org/svn/reactos?rev=42973&view=rev > Log: > - %llx -> %I64x > - Don't pass a string literal to strcmp > > Modified: > trunk/rosapps/applications/devutils/symdump/symdump.c > trunk/rosapps/applications/devutils/syscalldump/syscalldump.c > trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c > > Modified: trunk/rosapps/applications/devutils/symdump/symdump.c > URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/devutils/symd… > ============================================================================== > --- trunk/rosapps/applications/devutils/symdump/symdump.c [iso-8859-1] (original) > +++ trunk/rosapps/applications/devutils/symdump/symdump.c [iso-8859-1] Sun Aug 30 20:40:58 2009 > @@ -875,7 +875,7 @@ > } > else > { > - printf("Symbol: %s, TypeIndex=%ld, Flags=%lx, Value=0x%llx\n", > + printf("Symbol: %s, TypeIndex=%ld, Flags=%lx, Value=0x%I64x\n", > pSymInfo->Name, pSymInfo->TypeIndex, pSymInfo->Flags, pSymInfo->Value); > //if (pSymInfo->Flags & SYMFLAG_FUNCTION) > { > > Modified: trunk/rosapps/applications/devutils/syscalldump/syscalldump.c > URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/devutils/sysc… > ============================================================================== > --- trunk/rosapps/applications/devutils/syscalldump/syscalldump.c [iso-8859-1] (original) > +++ trunk/rosapps/applications/devutils/syscalldump/syscalldump.c [iso-8859-1] Sun Aug 30 20:40:58 2009 > @@ -36,7 +36,7 @@ > printf("SymGetSymFromName64() failed: %ld\n", GetLastError()); > return 0; > } > - printf("looking up adress for %s: 0x%llx\n", Name, pSym->Address); > + printf("looking up adress for %s: 0x%I64x\n", Name, pSym->Address); > > NtHeaders = ImageNtHeader(pModule); > p = ImageRvaToVa(NtHeaders, pModule, pSym->Address - pSym->ModBase, NULL); > > Modified: trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c > URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/sysutils/syst… > ============================================================================== > --- trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c [iso-8859-1] (original) > +++ trunk/rosapps/applications/sysutils/systeminfo/systeminfo.c [iso-8859-1] Sun Aug 30 20:40:58 2009 > @@ -358,7 +358,8 @@ > int > main(int argc, char *argv[]) > { > - if (argc > 1 && !strcmp(argv[1], "/?")) > + char str[] = "/?"; > + if (argc > 1 && !strcmp(argv[1], str)) > { > Usage(); > return 0; > > > >

15 years, 10 months

Re: [ros-dev] String literals

by Love Nystrom

> From: timo.kreuzer(a)web.de > To: ros-dev(a)reactos.org > Date: Sun, 30 Aug 2009 21:30:02 +0200 > Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 42973: - %llx -> %I64x - Don't pass a string literal to strcmp > > Huh? Why shouldn't one use a string literal in strcmp? > What are you trying to "fix"? IMHO: In regards to ReactOS proper, there's the internationalization/localization issues to consider. But regarding dev utils like sysdump I'd say it's not critical. Anyone feel different ? - Love Nystrom (I'm sorry if responses are slow. I live in a technically deficient area) _________________________________________________________________ Share your memories online with anyone you want. http://www.microsoft.com/middleeast/windows/windowslive/products/photos-sha…

15 years, 10 months

Regarding build breakage.

by Daniel Reimer

Hi, as you can see I tried to sync Wine's D3D in our tree. This went quite well and works fine. Problem is now... ddraw fails to build, ours and the HEAD wine rev with the same error you can see in the build logs. After some hours of toying with ddraw.h i got dozens of different errors, but it fails. The only way for me to get it build is using wine's ddraw.h and ddrawi.h which would again break even more stuff in ROS's tree. Maybe someone has a idea? If not, i will revert it this morning after i woke up. Night

15 years, 10 months

Re: [ros-dev] [ros-diffs] [fireball] 42955: - Remove the window station hack, it's not really needed anymore. Window station is not properly created by winlogon.

by Aleksey Bragin

On Aug 27, 2009, at 1:18 PM, fireball(a)svn.reactos.org wrote: > Author: fireball > Date: Thu Aug 27 11:18:34 2009 > New Revision: 42955 > > URL: http://svn.reactos.org/svn/reactos?rev=42955&view=rev > Log: > - Remove the window station hack, it's not really needed anymore. > Window station is not properly created by winlogon. A typo came here. Correct way would be "Window station is *now* properly created by winlogon". WBR, Aleksey Bragin.

15 years, 10 months

Win7 support

by Jun Koi

Hi, Now Windows 7 is officially released. Do we have any plan to support this version in the near future? Thanks, J

15 years, 10 months

Re: [ros-dev] [ros-diffs] [sginsberg] 42920: - Get rid of TAG() from the kernel - mmtypes.h: Goodbye TAG(), you won't be missed

by Steven Edwards

On Mon, Aug 24, 2009 at 2:19 PM, <sginsberg(a)svn.reactos.org> wrote: > Author: sginsberg > Date: Mon Aug 24 20:19:53 2009 > New Revision: 42920 > > URL: http://svn.reactos.org/svn/reactos?rev=42920&view=rev > Log: > - Get rid of TAG() from the kernel > - mmtypes.h: Goodbye TAG(), you won't be missed Maybe this has already been done but if not, we should look in to making a janitorial project for it, Alex and I talked years ago about trying to maintain a list with all of the tags that were in use and apply some consistency to the names. I think there is a list somewhere on MSDN that shows all the tag's used in Windows, and we should try to check ours to make sure they match up. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 10 months

Regarding Bug 4810 and building the evil GCC 4.4

by Daniel Reimer

Hi. After two weeks of disappointing escapades over building GCC 4.4.X I decided to try out the official mingw32 build from sf.net always in my mind that all patches we had to use in GCC 4.1.3 are already included in GCC 4.4.X. Well at first it built well (with disabled rsym, which fucks up dwarf2 headers in a way which renders a executable unuseable) but then it died with the error you can see in the bug report. (http://www.reactos.org/bugzilla/show_bug.cgi?id=4810) OK, I hoped someone comes up with a fix in our code, but hto answered with a patch in gcc. My 1. question now: Is this patch needed or is the error our fault? If we really need this patch i could need someone's helping hand with building GCC. We started a wiki entry (http://www.reactos.org/wiki/Compiling_GCC_From_Windows) which shows our recent tries to build a recent GCC without dwarf2 support. it builds quite well if i do "make all-gcc", but i want and need a full "make all" and there i get this one: http://img24.imageshack.us/img24/8817/1007360g.jpg Any Ideas? (Yes this is question 2.) Question 3 is: Anyone succeeded building cloog-ppl? And the last question: Any other useless crap in our settings in the wiki? Any needed fixes settings etc? Thx.

15 years, 10 months

by Filip Navara

On Fri, Aug 21, 2009 at 5:57 PM, <sginsberg(a)svn.reactos.org> wrote: > --- trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] Fri Aug 21 17:57:26 2009 > @@ -705,7 +705,14 @@ > > while (j < str.Length && str.Buffer[j] != '\0') j++; > > - *NetworkAddressLength = (UINT)((j/2)+0.5); > + if ((j % 2) == 0) > + { > + *NetworkAddressLength = (UINT)(j/2); > + } > + else > + { > + *NetworkAddressLength = (UINT)((j/2)+1); > + } Why not use *NetworkAddressLength = (UINT)((j+1)/2); unconditionally? > > if ((*NetworkAddressLength) == 0) > { > F.

15 years, 10 months

Re: [ros-dev] [ros-diffs] [fireball] 42833: - Implement windows moving (with contents).

by Steven Edwards

On Fri, Aug 21, 2009 at 3:13 PM, <fireball(a)svn.reactos.org> wrote: > Author: fireball > Date: Fri Aug 21 21:13:00 2009 > New Revision: 42833 > > URL: http://svn.reactos.org/svn/reactos?rev=42833&view=rev > Log: > - Implement windows moving (with contents). This is one of the Greatest. Commits. Ever. I wish that we could make Office 2007 run just by removing half the commented out code. ;) -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 10 months

Re: [ros-dev] [ros-diffs] [sginsberg] 42829: - svchost: #ifdef _MSC_VER doesn't mean "using Microsoft's headers" anymore - ddraw, imm32, msxml3, oleaut32, riched20: Include typeof.h for typeof emulation when compiling under MSVC and remove from ReactOS-generic.rbuild (this can't go to port.h as the modules do not include it). - TCPIP: Fix a check for MSVC. - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying to link to ftol (gcc inlined the operation). - SAMLIB: Use __VA_ARG

by Timo Kreuzer

lol+1! sginsberg(a)svn.reactos.org wrote: > Author: sginsberg > Date: Fri Aug 21 17:57:26 2009 > New Revision: 42829 > > URL: http://svn.reactos.org/svn/reactos?rev=42829&view=rev > Log: > [...] > - NDIS: Don't use floating point arithmetics in kernel mode -- spotted by MSVC trying to link to ftol (gcc inlined the operation). > [...] > > > Modified: trunk/reactos/drivers/network/ndis/ndis/config.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] Fri Aug 21 17:57:26 2009 > @@ -705,7 +705,14 @@ > > while (j < str.Length && str.Buffer[j] != '\0') j++; > > - *NetworkAddressLength = (UINT)((j/2)+0.5); > + if ((j % 2) == 0) > + { > + *NetworkAddressLength = (UINT)(j/2); > + } > + else > + { > + *NetworkAddressLength = (UINT)((j/2)+1); > + } > > if ((*NetworkAddressLength) == 0) > { > >

15 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev