Ros-dev

ros-dev@reactos.org

5790 discussions

Re: [ros-dev] [ros-diffs] [fireball] 42333: - Handle case when RosGdiSetDeviceClipping is being called without rects at all (with a respective DPRINT1). - Use combined clipping object everywhere to ensure drawing happens only in allowed rectangle, se
by Alex Ionescu 02 Aug '09

02 Aug '09

A similar question would apply to the ninjas' "issue #" that crept up once or twice... Best regards, Alex Ionescu On Sun, Aug 2, 2009 at 3:26 PM, Steven Edwards <winehacker(a)gmail.com> wrote: > On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > > - Use combined clipping object everywhere to ensure drawing happens only > in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox > and other apps which would corrupt memory if trying to blit to area outside > of DC. > > I keep seeing these comments, 'see arwinss nr. #'. Where do I go to > look this up? > > Thanks > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

02 Aug '09

On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > - Use combined clipping object everywhere to ensure drawing happens only in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox and other apps which would corrupt memory if trying to blit to area outside of DC. I keep seeing these comments, 'see arwinss nr. #'. Where do I go to look this up? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

02 Aug '09

http://www.reactos.org/wiki/Arwinss ? On Mon, Aug 3, 2009 at 12:26 AM, Steven Edwards <winehacker(a)gmail.com>wrote: > On Sun, Aug 2, 2009 at 6:32 AM, <fireball(a)svn.reactos.org> wrote: > > - Use combined clipping object everywhere to ensure drawing happens only > in allowed rectangle, see arwinss nr. 15. As a side effect, it fixes FireFox > and other apps which would corrupt memory if trying to blit to area outside > of DC. > > I keep seeing these comments, 'see arwinss nr. #'. Where do I go to > look this up? > > Thanks > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

Re: [ros-dev] [ros-diffs] [dgorbachev] 42305: Add a hack in KiSystemStartupReal function until Better Times.
by Aleksey Bragin 02 Aug '09

02 Aug '09

That function is not supposed to be called by old bootloader directly. Why is that needed? And why in this function? WBR, Aleksey Bragin. On Jul 30, 2009, at 9:54 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Thu Jul 30 19:54:01 2009 > New Revision: 42305 > > URL: http://svn.reactos.org/svn/reactos?rev=42305&view=rev > Log: > Add a hack in KiSystemStartupReal function until Better Times. > > Modified: > trunk/reactos/ntoskrnl/ke/i386/kiinit.c > > Modified: trunk/reactos/ntoskrnl/ke/i386/kiinit.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/ > i386/kiinit.c?rev=42305&r1=42304&r2=42305&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/ke/i386/kiinit.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/i386/kiinit.c [iso-8859-1] Thu Jul 30 > 19:54:01 2009 > @@ -712,18 +712,34 @@ > Ke386SetDs(KGDT_R3_DATA | RPL_MASK); > Ke386SetEs(KGDT_R3_DATA | RPL_MASK); > > - /* Save NMI and double fault traps */ > - RtlCopyMemory(&NmiEntry, &Idt[2], sizeof(KIDTENTRY)); > - RtlCopyMemory(&DoubleFaultEntry, &Idt[8], sizeof(KIDTENTRY)); > - > - /* Copy kernel's trap handlers */ > - RtlCopyMemory(Idt, > - (PVOID)KiIdtDescriptor.Base, > - KiIdtDescriptor.Limit + 1); > - > - /* Restore NMI and double fault */ > - RtlCopyMemory(&Idt[2], &NmiEntry, sizeof(KIDTENTRY)); > - RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); > + /* HACK compensates for KiRosPrepareForSystemStartup hack */ > + if ((ULONG)Idt == KiIdtDescriptor.Base) > + { > + USHORT FlippedSelector; > + > + FlippedSelector = KiIdt[2].Selector; > + KiIdt[2].Selector = KiIdt[2].ExtendedOffset; > + KiIdt[2].ExtendedOffset = FlippedSelector; > + > + FlippedSelector = KiIdt[8].Selector; > + KiIdt[8].Selector = KiIdt[8].ExtendedOffset; > + KiIdt[8].ExtendedOffset = FlippedSelector; > + } > + else > + { > + /* Save NMI and double fault traps */ > + RtlCopyMemory(&NmiEntry, &Idt[2], sizeof(KIDTENTRY)); > + RtlCopyMemory(&DoubleFaultEntry, &Idt[8], sizeof(KIDTENTRY)); > + > + /* Copy kernel's trap handlers */ > + RtlCopyMemory(Idt, > + (PVOID)KiIdtDescriptor.Base, > + KiIdtDescriptor.Limit + 1); > + > + /* Restore NMI and double fault */ > + RtlCopyMemory(&Idt[2], &NmiEntry, sizeof(KIDTENTRY)); > + RtlCopyMemory(&Idt[8], &DoubleFaultEntry, sizeof(KIDTENTRY)); > + } > > AppCpuInit: > /* Loop until we can release the freeze lock */ > >

4 11

Re: [ros-dev] [ros-diffs] [gschneider] 42311: - Implement Floodfill: iterative four neighbors version - Details for this algorithm are described in the comments - Nice with the paint clone since the bucket fill tool works now
by Timo Kreuzer 31 Jul '09

31 Jul '09

1.) Why are you using global variables? 2.) Why are you using an XLATEOBJ inside the fill loop? gschneider(a)svn.reactos.org schrieb: > Author: gschneider > Date: Fri Jul 31 17:41:09 2009 > New Revision: 42311 > > URL: http://svn.reactos.org/svn/reactos?rev=42311&view=rev > Log: > - Implement Floodfill: iterative four neighbors version > - Details for this algorithm are described in the comments > - Nice with the paint clone since the bucket fill tool works now > > Added: > trunk/reactos/subsystems/win32/win32k/dib/floodfill.c (with props) > Modified: > trunk/reactos/subsystems/win32/win32k/dib/dib.h > trunk/reactos/subsystems/win32/win32k/objects/fillshap.c > trunk/reactos/subsystems/win32/win32k/win32k.rbuild > > Modified: trunk/reactos/subsystems/win32/win32k/dib/dib.h > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/di… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/dib/dib.h [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/dib/dib.h [iso-8859-1] Fri Jul 31 17:41:09 2009 > @@ -133,6 +133,7 @@ > BOOLEAN DIB_32BPP_AlphaBlend(SURFOBJ*, SURFOBJ*, RECTL*, RECTL*, CLIPOBJ*, XLATEOBJ*, BLENDOBJ*); > > BOOLEAN DIB_XXBPP_StretchBlt(SURFOBJ*,SURFOBJ*,SURFOBJ*,SURFOBJ*,RECTL*,RECTL*,POINTL*,BRUSHOBJ*,POINTL*,XLATEOBJ*,XLATEOBJ*,ROP4); > +BOOLEAN DIB_XXBPP_FloodFill(SURFOBJ*, BRUSHOBJ*, RECTL*, POINTL*, XLATEOBJ*, COLORREF, UINT); > > extern unsigned char notmask[2]; > extern unsigned char altnotmask[2]; > > Added: trunk/reactos/subsystems/win32/win32k/dib/floodfill.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/di… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/dib/floodfill.c (added) > +++ trunk/reactos/subsystems/win32/win32k/dib/floodfill.c [iso-8859-1] Fri Jul 31 17:41:09 2009 > @@ -1,0 +1,168 @@ > +/* > + * COPYRIGHT: See COPYING in the top level directory > + * PROJECT: ReactOS win32 subsystem > + * PURPOSE: Flood filling support > + * FILE: subsystems/win32/win32k/dib/floodfill.c > + * PROGRAMMER: Gregor Schneider, <grschneider AT gmail DOT com> > + */ > + > +#include <w32k.h> > + > +#define NDEBUG > +#include <debug.h> > + > +/* > +* This floodfill algorithm is an iterative four neighbors version. It works with an internal stack like data structure. > +* The stack is kept in an array, sized for the worst case scenario of having to add all pixels of the surface. > +* This avoids having to allocate and free memory blocks all the time. The stack grows from the end of the array towards the start. > +* All pixels are checked before being added, against belonging to the fill rule (FLOODFILLBORDER or FLOODFILLSURFACE) > +* and the position in respect to the clip region. This guarantees all pixels lying on the stack belong to the filled surface. > +* Further optimisations of the algorithm are possible. > +*/ > + > +/* Floodfil helper structures and functions */ > +typedef struct _floodItem > +{ > + ULONG x; > + ULONG y; > +} FLOODITEM; > + > +static ULONG floodLen = 0; > +static FLOODITEM *floodStart = NULL, *floodData = NULL; > + > +static __inline BOOL initFlood(RECTL *DstRect) > +{ > + ULONG width = DstRect->right - DstRect->left; > + ULONG height = DstRect->bottom - DstRect->top; > + floodData = ExAllocatePoolWithTag(NonPagedPool, width * height * sizeof(FLOODITEM), TAG_DIB); > + if (floodData == NULL) > + { > + return FALSE; > + } > + floodStart = (FLOODITEM*)((PBYTE)floodData + (width * height * sizeof(FLOODITEM))); > + return TRUE; > +} > +static __inline VOID finalizeFlood() > +{ > + ExFreePoolWithTag(floodData, TAG_DIB); > +} > +static __inline VOID addItemFlood(ULONG x, > + ULONG y, > + SURFOBJ *DstSurf, > + RECTL *DstRect, > + XLATEOBJ* ColorTranslation, > + COLORREF Color, > + BOOL isSurf) > +{ > + if (x >= DstRect->left && x <= DstRect->right && > + y >= DstRect->top && y <= DstRect->bottom) > + { > + if (isSurf == TRUE && XLATEOBJ_iXlate(ColorTranslation, > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y)) != Color) > + { > + return; > + } > + else if (isSurf == FALSE && XLATEOBJ_iXlate(ColorTranslation, > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y)) == Color) > + { > + return; > + } > + floodStart--; > + floodStart->x = x; > + floodStart->y = y; > + floodLen++; > + } > +} > +static __inline VOID removeItemFlood() > +{ > + floodStart++; > + floodLen--; > +} > +static __inline BOOL isEmptyFlood() > +{ > + if (floodLen == 0) > + { > + return TRUE; > + } > + return FALSE; > +} > + > +BOOLEAN DIB_XXBPP_FloodFill(SURFOBJ *DstSurf, > + BRUSHOBJ *Brush, > + RECTL *DstRect, > + POINTL *Origin, > + XLATEOBJ *ColorTranslation, > + COLORREF Color, > + UINT FillType) > +{ > + ULONG x, y; > + ULONG BrushColor; > + > + BrushColor = Brush->iSolidColor; > + x = Origin->x; > + y = Origin->y; > + > + if (FillType == FLOODFILLBORDER) > + { > + /* Check if the start pixel has the border color */ > + if (XLATEOBJ_iXlate(ColorTranslation, > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y)) == Color) > + { > + return FALSE; > + } > + > + if (initFlood(DstRect) == FALSE) > + { > + return FALSE; > + } > + addItemFlood(x, y, DstSurf, DstRect, ColorTranslation, Color, FALSE); > + while (!isEmptyFlood()) > + { > + x = floodStart->x; > + y = floodStart->y; > + removeItemFlood(); > + > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_PutPixel(DstSurf, x, y, BrushColor); > + addItemFlood(x, y + 1, DstSurf, DstRect, ColorTranslation, Color, FALSE); > + addItemFlood(x, y - 1, DstSurf, DstRect, ColorTranslation, Color, FALSE); > + addItemFlood(x + 1, y, DstSurf, DstRect, ColorTranslation, Color, FALSE); > + addItemFlood(x - 1, y, DstSurf, DstRect, ColorTranslation, Color, FALSE); > + } > + finalizeFlood(); > + } > + else if (FillType == FLOODFILLSURFACE) > + { > + /* Check if the start pixel has the surface color */ > + if (XLATEOBJ_iXlate(ColorTranslation, > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y)) != Color) > + { > + return FALSE; > + } > + > + if (initFlood(DstRect) == FALSE) > + { > + return FALSE; > + } > + addItemFlood(x, y, DstSurf, DstRect, ColorTranslation, Color, TRUE); > + while (!isEmptyFlood()) > + { > + x = floodStart->x; > + y = floodStart->y; > + removeItemFlood(); > + > + DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_PutPixel(DstSurf, x, y, BrushColor); > + addItemFlood(x, y + 1, DstSurf, DstRect, ColorTranslation, Color, TRUE); > + addItemFlood(x, y - 1, DstSurf, DstRect, ColorTranslation, Color, TRUE); > + addItemFlood(x + 1, y, DstSurf, DstRect, ColorTranslation, Color, TRUE); > + addItemFlood(x - 1, y, DstSurf, DstRect, ColorTranslation, Color, TRUE); > + > + } > + finalizeFlood(); > + } > + else > + { > + DPRINT1("Unsupported FloodFill type!\n"); > + return FALSE; > + } > + return TRUE; > +} > > Propchange: trunk/reactos/subsystems/win32/win32k/dib/floodfill.c > ------------------------------------------------------------------------------ > svn:eol-style = native > > Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c [iso-8859-1] Fri Jul 31 17:41:09 2009 > @@ -1072,12 +1072,11 @@ > PDC dc; > PDC_ATTR pdcattr; > SURFACE *psurf = NULL; > - PBRUSH pbrFill = NULL; > + HPALETTE Pal = 0; > + XLATEOBJ *XlateObj = NULL; > BOOL Ret = FALSE; > RECTL DestRect; > POINTL Pt; > - > - DPRINT1("FIXME: NtGdiExtFloodFill is UNIMPLEMENTED\n"); > > dc = DC_LockDc(hDC); > if (!dc) > @@ -1110,17 +1109,21 @@ > else > goto cleanup; > > - pbrFill = dc->dclevel.pbrFill; > - if (!pbrFill) > + psurf = dc->dclevel.pSurface; > + if (!psurf) > { > Ret = FALSE; > goto cleanup; > } > - psurf = dc->dclevel.pSurface; > - if (!psurf) > - { > - Ret = FALSE; > - goto cleanup; > + > + Pal = dc->dclevel.pSurface->hDIBPalette; > + if (!Pal) Pal = pPrimarySurface->DevInfo.hpalDefault; > + XlateObj = (XLATEOBJ*)IntEngCreateXlate(PAL_RGB, 0, NULL, Pal); > + > + if (XlateObj != NULL) > + { > + Ret = DIB_XXBPP_FloodFill(&psurf->SurfObj, &dc->eboFill.BrushObject, &DestRect, &Pt, XlateObj, Color, FillType); > + EngDeleteXlate(XlateObj); > } > > cleanup: > > Modified: trunk/reactos/subsystems/win32/win32k/win32k.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/wi… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/win32k.rbuild [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/win32k.rbuild [iso-8859-1] Fri Jul 31 17:41:09 2009 > @@ -31,6 +31,7 @@ > <file>dib32bpp.c</file> > <file>dibXXbpp.c</file> > <file>dib.c</file> > + <file>floodfill.c</file> > > <if property="ARCH" value="i386"> > <directory name="i386"> > > > >

1 1

Introducing myself & a few questions
by John Jackson 31 Jul '09

31 Jul '09

Hello all. My name is John Jackson and I'm looking to start doing driver development on Reactos. I've worked as a C++ / C# programmer for about 7 years, and I want to get back into more hard-core C development. Driver writing appeals to me since it sounds like a real challenge. I've never programmed drivers before, but I've been reading up on it and looking at code. (Also, I don't mean any of my questions or wordings in a negative way, I'm not entirely sure how to phrase some of my questions) I'd like to start by working on USB support. I've taken a couple glances through svn, and I've got some questions. 1. Does the reactos build environment support Windows Driver Framework or just the Windows Driver model? 2. I see under /drivers/usb there is an nt4compat folder. I understand basic usb keyboard/mouse support comes from here, but it's not coded using the new driver models introduced in xp. Is anyone currently working on a "proper" usb implementation? I see there are several stubs in /drviers/usb/ that just return true. 3. I assume the place to start with usb support is bus drivers? Do usb1 and usb2 mean different bus drivers? (I've not read up much on usb yet, I'm still trying to wrap my head around driver development) I'll try to get on the irc channel either tomorrow or Sunday to say hi in person, but I think this is a good start for conversation. --John Jackson --taladon(a)gmail.com

3 2

Arwinss architecture
by Aleksey Bragin 30 Jul '09

30 Jul '09

Hello, I will be thoroughly explaining the arwinss architecture, and the very first start is the general flow diagram which could be seen here: http://www.reactos.org/wiki/Arwinss_architecture This page will also get more updates with regard to architecture and design of all modules, but most attention will be paid to win32k.sys internals and native gdi/user driver (so-called winent.drv). With the best regards, Aleksey bragn.

12 28

FullFAT replacement for Fastfat.sys
by James Walmsley 30 Jul '09

30 Jul '09

Hi Everyone, I just thought I'd introduce myself. I am the author of a new FAT implementation that was really designed for embedded systems. As such it provides very good performance. (See www.fullfat-fs.co.uk). Fireball contacted me a few days ago to discuss the current development of FullFAT, and since I have agreed to implement an IFS driver based on FullFAT with a view to replacing the current fastfat.sys implementation. During the conversation we also discussed implementing a special journaling extension to FullFAT via the windows driver. I hope to start work on this project in the next few weeks, and further to this I would also like to help in some other areas of ReactOS. I shall be taking a closer look at the ReactOS code over the coming weeks, and will probably post some questions about various aspects. I have just bought the Windows Internals, fifth edition co-authored by Alex Ionescu, hopefully this will provide me with a good overview of the Windows architecture etc. For complete Windows XP compatibility, just how much of the implementation is currently missing from ReactOS? Nice to meet you all, and I hope to provide some good contributions to ReactOS in the near future. James -- James Walmsley ---------------------------------------- james(a)worm.me.uk

17 27

Committing to trunk
by Aleksey Bragin 28 Jul '09

28 Jul '09

Hello, our debug buildslave is currently offline, I'd like to ask developers to abstain from committing to trunk till it comes back online (hopefully we can thing something up, have a spare buildslave, turn release buildslave into a debug one or something). Otherwise we may miss potential regressions. Thanks for understanding, Aleksey Bragin.

1 1

[BUG] Utterly incorrect implementation of input device coordinates.
by codeforfood＠pulseforce.com 27 Jul '09

27 Jul '09

Here's the information required to patch the incorrect implementation. Abstract: - SendInput()/NtUserSendInput() broken: --- Relative hardware mouse input "working", but not well implemented due to lack of modifying the travel distance using cursor acceleration and movement speeds (I've provided info on this as well below), input-virtual vs screen-real coordinates (even in the relative moves), etc. The two coordinate spaces are not the same thing! --- Absolute hardware mouse input broken (used by things like touchscreens), by a complete misunderstanding of how the virtual input device coordinate space works (it's NOT in ANY way a 1:1 map that's translatable to the screen, but the function uses it this way everywhere!) read below for full info since this is the serious problem. - SetCursorPos() broken (should NOT be using SendInput() since that's pointless and ineffective and is meant for the hardware input queue, we already have the desired coordinates and should move the cursor directly; and even its use of SendInput() is incorrect since it should FIRST convert the desired SCREEN coordinates to absolute-INPUT-coordinate-space), BUT since it's using the broken SendInput() (which currently doesn't know that absolute input coordinates have NOTHING to do with screen coordinates) it works correctly and will place cursors at the right location. This will have to be changed when SendInput() is patched; preferrably to a direct cursor update (elaborated in the recap below, before the log), rather than the current indirect/slow approach which places a message in the serial (as in serial-processing, first-come-first-serve) mouse-input-translation queue. So to recap: - Need to improve relative movement (to handle acceleration and mouse speed modifiers) - Need to change the code everywhere where you've been thinking that input coordinates are the same as screen coordinates (most likely only within SetCursorPos(), and SendInput()/NtUserSendInput()) - Absolute cursor placement inside SendInput() needs to be rewritten to convert absolute input-space coordinates to absolute screen-space coordinates (quite an easy change) using the algorithm I provide below, which is what Windows uses internally. - SetCursorPos() needs to COMPLETELY stop using SendInput() and instead manipulate the cursor X/Y struct directly, or equivalent methods, instead of injecting itself into the input queue. Alternatively, if it keeps using the input queue, it needs a reverse-algorithm to turn the desired screen-coordinates into virtual inputspace-coordinates, such as int mouseinput_abs_x_or_y_pos = (((65536 * screen_x_or_y_pos) / screen_width_or_height) + 1). The +1 is necessary for proper rounding. However, I see no reason to use the input queue within this function as that involves much more work than simply writing the cursor's location directly (which is what SendInput EVENTUALLY gets around to doing after LOTS of processing, and saving on cycles/jumps/calls is GOOD ;)). All details on how to fix these things are in the below log. Let me know if there's any questions. Log (most unrelated discussions/events snipped and long breaks between explaining different details have been separated with "..."): 19:56 Yewbacca . I am sure you've implemented SetCursorPos() incorrectly. Checking your source code for it at cursor.c:280. This function is SUPPOSED to take a SCREEN X/Y coordinate (ie X=1400, Y=800 on a 1440x900 screen, and then moves the cursor location directly, without emulating mouse movement. 19:57 Yewbacca . Instead, your version calls SendInput() with the x/y unmodified, that's awful. SendInput()'s absolute space is a virtual desktop square that stretches from 0-65535 in each direction and will not even be remotely close to what the intended destination is. 19:57 _0_ . sounds like a patch is in order Yewbacca 19:57 _0_ . :P 19:58 +encoded . Yewbacca, file bug report! 19:58 Yewbacca . _0_ Well I'd have to know how you're writing the cursor position inside NtSendUserInput etc. 19:58 Yewbacca . Or file a bug report, I'll do that. 20:01 Yewbacca . Related to this, Windows actually uses a slightly unexpected algorithm for its SendInput() absolute-mode coordinates-to-screen conversion. 20:01 Yewbacca . int destx_or_y = (screen_width_or_height * x_or_y_abs_coord) / 65536 20:01 Yewbacca . If you want pixel precise SendInput() that works as on windows you'd have to verify this. I'll bug report that too. 20:02 +encoded . <3 Yewbacca 20:02 Yewbacca . :) 20:02 +encoded . you can ofcourse see the source code of NtSendUserInput 20:03 Yewbacca . Yeah I was about to check that to make sure it's not already correct 20:04 +encoded . its in \subsystems\win32\win32k\ntuser\input.c 20:04 Yewbacca . Ah thanks, that saves a slow grep. 20:05 +encoded . wait opps 20:05 . garrythefish_ [n=fisher@unaffiliated/garrythefish] has joined #reactos 20:05 +encoded . oh well, nvm me 20:05 garrythefish_ . community choice award today. hope you guys win. :D 20:10 Yewbacca . Okay after brief confusion I noticed that IntMouseInput() contains the actual logic for mouse-type input to SendInput(), input.c:1081. Time to check it. ... 20:14 Yewbacca . Okay now I'm really confused. I read through IntMouseInput() from input.c:1081-1333 and unless I missed a call to a driver-coordinates-to-screen-coordinates somewhere, this function is miscoded as well. That'd mean that SetCursorPos() would work correctly since SendInput() would work incorrectly, and that normal SendInput() calls that expect a 0 to 65535 range would not work at all. 20:15 Yewbacca . It really seems to directly write the pointers for cursor X and Y with the values it has received 20:15 Yewbacca . with no conversion whatsoever 20:15 Yewbacca . even though the incoming values are in a 0 to 65535 range 20:15 Yewbacca . of that virtual space ... 20:16 Yewbacca . Basically for anyone unfamiliar with it, the driver implements a virtual space for the cursor to either move relatively within, or absolutely, to allow things like touchscreens to function easily (they'd just have to SendInput() their current position as a percentage of the 65535 range). 20:16 Yewbacca . So all incoming absolute-mode coordinates must be converted to screen coordinates, and microsoft does it with int destx_or_y = (screen_width_or_height * x_or_y_abs_coord) / 65536 20:17 Yewbacca . I'm going to re-read it again to see if I missed some conversion call. If not, that'll be 2 reports. Quite easy fixes luckily. 20:18 +encoded . <3 Yewbacca 20:18 Yewbacca . I think the reason you got by this far is because the HARDWARE mouse sends coordinates relatively 20:18 Yewbacca . The problem'd only appear with absolute input like touchscreens. And since SendInput()'s absolute mode is broken that means program's SetCursorPos() would work, so it's doubly broken and would only cause problems for absolute hardware-input (again, touchscreens mainly). 20:18 Yewbacca . :P 20:19 Yewbacca . Reading again 20:20 +encoded . Yewbacca, we can use someone like you who has knowledge of windows internals 20:20 Yewbacca . Maybe, right now I'm tied up with some major work :) ... 20:28 Yewbacca . Alright I've finished checking everything. IntMouseInput() stretches from input.c:1081-1333 and is the function that's called when NtUserSendInput()/SendInput() receives a mouse-type event. At line 1140 it grabs the pointer to the cursor's X/Y struct with IntGetCursorLocation(WinSta, &MousePos). Then we get to the significant errors. 20:29 Yewbacca . At lines 1146-1150 it incorrectly writes the virtual x/y of the INPUT coordinate system right into the memory holding the SCREEN x/y cursor location 20:30 Yewbacca . At lines 1151-1155 it handles relative movement but doesn't take into account cursor acceleration and movement speed (those settings we all love in the control panel->mouse), which in turn can increase the movement distance as much as 4 times the input value. 20:31 Yewbacca . Those two behaviours right there would need to be patched. The first should determine the destination on the screen through int destx_or_y = (screen_width_or_height * x_or_y_abs_coord) / 65536. The latter should implement handling for cursor acceleration (check MSDN, it describes acceleration on SendInput()). 20:32 Yewbacca . And lastly, SetCursorPos() (forgot which file it's in) needs to *completely* skip the SendInput() baloney that it's doing right now (http://pastebin.com/d2db76985) and just directly grab the cursor X/Y pointer and update it in a simple assignment, AFTER checking that it's in range of course (otherwise clamping it to the screen). 20:33 +Lone_Rifle . Yewbacca, suggest that you subscribe to ros-dev and retype or copy-paste your findings there, it's quite a bit of text to go through in one sitting 20:33 Yewbacca . Oh yeah and if you wanna be 100% complete, also implement a check for ClipCursor() and don't allow the cursor to move outside that, no matter if it's from hardware input or SetCursorPos(). If it's outside, it should be clamped to the nearest inside value. 20:34 Yewbacca . Lone_Rifle Yeah, I agree and was going to submit it. I'll do that now. ... 20:37 Yewbacca . Acceleration is described at http://msdn.microsoft.com/en-us/library/ms646273(VS.85).aspx (info for the MOUSEINPUT struct). I'll submit this log to the mailing list. =EOF=

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev