Ros-dev

ros-dev@reactos.org

5789 discussions

by James Tabor

Hi all! I noticed we still have drawing issues even after fixing some gdi code. Well, I guess we need to look at the main windowing side of the house now. I guess, based on a stable release we can sync up wine and patch by hand the forked code too. I know of some Delphi issues that could use a good non static update. Bulk of our user code is from wine and that includes the window positioning bug everyone has had a crack at as well. I notices that most of the syncs in comdlg/controls depend on user code updates. If Richedit breaks windowing, it could be related to user32/win32k code not updated or based on behavior that is wrong. Syncing and updating forked code is not fun, with both, one needs to take into account local fixes. When you find them, mark them like "REACTOS HACK" or "REACTOS ONLY" or "REACTOS ????" what ever. Reading the change logs for each file should help with determining local patches that have been applied and need to be taken into account as well. If you have a bug report, please mark it as WINE SYNC or WINE UPDATE, something to let us know, it's a wine sync of some kind. We have a file in our media doc directory that holds the sync/fork information, please include it with your updates. Thanks, James Ref: README.WINE: User32 - reactos/dll/win32/user32/controls/button.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/controls/combo.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/controls/edit.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/controls/icontitle.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/controls/listbox.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/controls/scrollbar.c # Forked reactos/dll/win32/user32/controls/static.c # Synced at 20071024 reactos/dll/win32/user32/misc/dde.c # Synced to wine 1.1.17 (dde_misc.c) reactos/dll/win32/user32/misc/ddeclient.c # Synced to wine 1.1.17 reactos/dll/win32/user32/misc/ddeserver.c # Synced to wine 1.1.17 reactos/dll/win32/user32/misc/exticon.c # Last sync date unknown reactos/dll/win32/user32/misc/resources.c # Forked? reactos/dll/win32/user32/misc/winhelp.c # Last sync date unknown reactos/dll/win32/user32/misc/wsprintf.c # Synced to Wine-1_1_13 reactos/dll/win32/user32/windows/defwnd.c # Forked reactos/dll/win32/user32/windows/draw.c # Forked at Wine-20020904 (uitools.c) reactos/dll/win32/user32/windows/mdi.c # Synced at 20060703 reactos/dll/win32/user32/windows/menu.c # Forked reactos/dll/win32/user32/windows/messagebox.c # Forked reactos/dll/win32/user32/windows/rect.c # Forked (uitools.c) reactos/dll/win32/user32/windows/text.c # Forked (lstr.c) reactos/dll/win32/user32/windows/winpos.c # Forked

16 years

Re: [ros-dev] [ros-diffs] [jimtabor] 41250: - Hax-implement NtGdiSetPixelFormat and add a support function UserGethWnd with some code cleanup.

by Timo Kreuzer

This looks like ultra-hax. Can you explain why this should be correct? It would mean DrvSetPixelFormat would be passed a SURFACE rather than a SURFOBJ. jimtabor(a)svn.reactos.org schrieb: > Author: jimtabor > Date: Tue Jun 2 10:50:36 2009 > New Revision: 41250 > > URL: http://svn.reactos.org/svn/reactos?rev=41250&view=rev > Log: > - Hax-implement NtGdiSetPixelFormat and add a support function UserGethWnd with some code cleanup. > > Modified: > [...] > + /* > + Based on some rules! InfoDC to DC or, based on wiki information! > + All pointers, it's a "must be!", (CONTAINING_RECORD +10h = SURFOBJ), the > + pointer will start at SURFOBJ of the SURFACE structure. > + */ > + pso = (SURFOBJ *)pdc->dclevel.pSurface; > + if (!pso) pso = pdc->pSurfInfo; > + if (!pso) pso = ppdev->pSurface; > + } > + > + if (ppdev->flFlags & PDEV_META_DEVICE) > + { > + UNIMPLEMENTED; > + goto Exit; > + } > + > + if (ppdev->DriverFunctions.SetPixelFormat) > + { > + Ret = ppdev->DriverFunctions.SetPixelFormat( > + pso, > + ipfd, > + hWnd); > + } >

16 years

Re: [ros-dev] [ros-diffs] [dgorbachev] 41284: Remove KeBugCheckWithTf() hack, fix VBEResetHw(). Stefan Ginsberg, bug #4581.

by Aleksey Bragin

He has write access (sginsberg), however he posted that to bugzilla for peer review and comments before committing, not because he lacks time to commit himself. WBR, Aleksey Bragin. On Jun 4, 2009, at 5:54 PM, dgorbachev(a)svn.reactos.org wrote: > Author: dgorbachev > Date: Thu Jun 4 17:54:27 2009 > New Revision: 41284 > > URL: http://svn.reactos.org/svn/reactos?rev=41284&view=rev > Log: > Remove KeBugCheckWithTf() hack, fix VBEResetHw(). Stefan Ginsberg, > bug #4581. > > Modified: > trunk/reactos/drivers/video/miniport/vbe/vbemp.c > trunk/reactos/ntoskrnl/ke/bug.c > > Modified: trunk/reactos/drivers/video/miniport/vbe/vbemp.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/ > miniport/vbe/vbemp.c?rev=41284&r1=41283&r2=41284&view=diff > ====================================================================== > ======== > --- trunk/reactos/drivers/video/miniport/vbe/vbemp.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/video/miniport/vbe/vbemp.c [iso-8859-1] > Thu Jun 4 17:54:27 2009 > @@ -546,56 +546,8 @@ > ULONG Columns, > ULONG Rows) > { > - INT10_BIOS_ARGUMENTS BiosRegisters; > - PVBE_DEVICE_EXTENSION VBEDeviceExtension = > - (PVBE_DEVICE_EXTENSION)DeviceExtension; > - > - if (!VBEResetDevice(DeviceExtension, NULL)) > - return FALSE; > - > - /* Change number of columns/rows */ > - VideoPortZeroMemory(&BiosRegisters, sizeof(BiosRegisters)); > - > - if (Columns == 80 && Rows == 25) > - { > - /* Default text size, don't change anything. */ > - return TRUE; > - } > - else if (Columns == 80 && Rows == 28) > - { > - /* Use 9x14 font (80x28) */ > - BiosRegisters.Eax = 0x1111; > - } > - else if (Columns == 80 && Rows == 43) > - { > - /* Use 8x8 font in 350 scans mode (80x43) */ > - BiosRegisters.Eax = 0x1201; > - BiosRegisters.Ebx = 0x30; > - VBEDeviceExtension->Int10Interface.Int10CallBios( > - VBEDeviceExtension->Int10Interface.Context, > - &BiosRegisters); > - > - BiosRegisters.Eax = 0x3; > - BiosRegisters.Ebx = 0; > - VBEDeviceExtension->Int10Interface.Int10CallBios( > - VBEDeviceExtension->Int10Interface.Context, > - &BiosRegisters); > - > - BiosRegisters.Eax = 0x1112; > - } > - else if (Columns == 80 && Rows == 50) > - { > - /* Use 8x8 font (80x50) */ > - BiosRegisters.Eax = 0x1112; > - } > - else > - return FALSE; > - > - VBEDeviceExtension->Int10Interface.Int10CallBios( > - VBEDeviceExtension->Int10Interface.Context, > - &BiosRegisters); > - > - return TRUE; > + /* Return FALSE to let HAL reset the display with INT10 */ > + return FALSE; > } > > /* > > Modified: trunk/reactos/ntoskrnl/ke/bug.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/ > bug.c?rev=41284&r1=41283&r2=41284&view=diff > ====================================================================== > ======== > --- trunk/reactos/ntoskrnl/ke/bug.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/ke/bug.c [iso-8859-1] Thu Jun 4 > 17:54:27 2009 > @@ -1138,13 +1138,11 @@ > #endif > > /* Display the BSOD */ > - KeLowerIrql(APC_LEVEL); // This is a nastier hack than any > ever before > KiDisplayBlueScreen(MessageId, > IsHardError, > HardErrCaption, > HardErrMessage, > AnsiName); > - KeRaiseIrql(HIGH_LEVEL, &OldIrql); > > /* Check if the debugger is disabled but we can enable it */ > if (!(KdDebuggerEnabled) && !(KdPitchDebugger)) >

16 years

how to use the macro CHECKPOINT

by Zhang Fan

I find the defination of CHECKPOINT #define CHECKPOINT do { DbgPrint("%s:%d\n",__FILE__,__LINE__); ExAllocatePool(NonPagedPool,0); } while(0); I don't know why alloc memory with 0 byte

16 years

Re: [ros-dev] [ros-diffs] [mjmartin] 41269: - IopCreateDriver: Change MajorFunction routines back to internal function IopInvalidDeviceRequest for ones that were set to NULL in the Drivers DriverEntry. Windows does it and so shall we.

by Alex Ionescu

I must say that I protest to all the recent I/O changes, and in my opinion, they are all wrong and badly researched, and have hacked what was once good code. Best regards, Alex Ionescu On Wed, Jun 3, 2009 at 2:48 AM, <mjmartin(a)svn.reactos.org> wrote: > Author: mjmartin > Date: Wed Jun 3 13:48:33 2009 > New Revision: 41269 > > URL: http://svn.reactos.org/svn/reactos?rev=41269&view=rev > Log: > - IopCreateDriver: Change MajorFunction routines back to internal function IopInvalidDeviceRequest for ones that were set to NULL in the Drivers DriverEntry. Windows does it and so shall we. > > Modified: > trunk/reactos/ntoskrnl/io/iomgr/driver.c > > Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… > ============================================================================== > --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed Jun 3 13:48:33 2009 > @@ -1302,7 +1302,7 @@ > RtlZeroMemory(DriverObject, ObjectSize); > DriverObject->Type = IO_TYPE_DRIVER; > DriverObject->Size = sizeof(DRIVER_OBJECT); > - DriverObject->Flags = DRVO_BUILTIN_DRIVER; > + DriverObject->Flags = DRVO_LEGACY_DRIVER;//DRVO_BUILTIN_DRIVER; > DriverObject->DriverExtension = (PDRIVER_EXTENSION)(DriverObject + 1); > DriverObject->DriverExtension->DriverObject = DriverObject; > DriverObject->DriverInit = InitializationFunction; > @@ -1398,6 +1398,14 @@ > { > /* Returns to caller the object */ > *pDriverObject = DriverObject; > + } > + > + /* Loop all Major Functions */ > + for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) > + { > + /* Set each function that was set to NULL to internal routine */ > + if (!DriverObject->MajorFunction[i]) > + DriverObject->MajorFunction[i] = IopInvalidDeviceRequest; > } > > /* Return the Status */ > >

16 years

Re: [ros-dev] [ros-diffs] [cgutman] 41213: - Export and hackplement NdisSetTimerEx - Implementation is #ifed out currently but I may enable it later - Hopefully somebody can think of a better way to do it than the current code

by Alex Ionescu

There's nothing ugly about this -- this is exactly what the field is for. Best regards, Alex Ionescu On Sat, May 30, 2009 at 4:07 PM, <cgutman(a)svn.reactos.org> wrote: > Author: cgutman > Date: Sun May 31 03:07:13 2009 > New Revision: 41213 > > URL: http://svn.reactos.org/svn/reactos?rev=41213&view=rev > Log: > - Export and hackplement NdisSetTimerEx > - Implementation is #ifed out currently but I may enable it later > - Hopefully somebody can think of a better way to do it than the current code > > Modified: > trunk/reactos/drivers/network/ndis/ndis.def > trunk/reactos/drivers/network/ndis/ndis/time.c > > Modified: trunk/reactos/drivers/network/ndis/ndis.def > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis.… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] Sun May 31 03:07:13 2009 > @@ -257,6 +257,7 @@ > NdisSetPacketPoolProtocolId@8 > ;NdisSetProtocolFilter ? > NdisSetTimer@8 > +NdisSetTimerEx@12 > NdisSetupDmaTransfer@24 > NdisSystemProcessorCount@0 > NdisTerminateWrapper@8 > > Modified: trunk/reactos/drivers/network/ndis/ndis/time.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… > ============================================================================== > --- trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] Sun May 31 03:07:13 2009 > @@ -243,5 +243,26 @@ > KeSetTimer (&Timer->Timer, Timeout, &Timer->Dpc); > } > > +VOID > +EXPORT > +NdisSetTimerEx( > + IN PNDIS_TIMER Timer, > + IN UINT MillisecondsToDelay, > + IN PVOID FunctionContext) > +{ > +#if 0 > + /* FIXME: I'm not sure how to this in a nice way > + * We can't store the function context anywhere in NDIS_TIMER > + * so I'm forced to do this > + */ > + > + Timer->Dpc.DeferredContext = FunctionContext; > + > + NdisSetTimer(Timer, MillisecondsToDelay); > +#else > + UNIMPLEMENTED > +#endif > +} > + > /* EOF */ > > >

16 years

ReactOS debug on bochs

by Fan Zhang

Hi I download a very early edtion of reactos(0.0.21), I think it would be easy to understand for me. I disable the NDEBUG macro, so I can catch the debug info. By default, I use the /DEBUGPORT=SCREEN, and the log info is printed on the screen. Then I changed to /DEBUGPORT=BOCHS, but there is no any info on the bochs console. Could you tell me how to catch the log on the bochs? Fan Zhang

16 years

Re: [ros-dev] [ros-diffs] [spetreolle] 41204: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0.

by Ged

This seems very strange -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of spetreolle(a)svn.reactos.org Sent: 30 May 2009 13:23 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [spetreolle] 41204: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0. Author: spetreolle Date: Sat May 30 16:23:20 2009 New Revision: 41204 URL: http://svn.reactos.org/svn/reactos?rev=41204&view=rev Log: ChangeDisplaySettingsA and ChangeDisplaySettingsW should reset dmDriverExtra to 0. Modified: trunk/reactos/dll/win32/user32/misc/display.c Modified: trunk/reactos/dll/win32/user32/misc/display.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/disp… ============================================================================== --- trunk/reactos/dll/win32/user32/misc/display.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/misc/display.c [iso-8859-1] Sat May 30 16:23:20 2009 @@ -493,7 +493,10 @@ LPDEVMODEA lpDevMode, DWORD dwflags) { - return ChangeDisplaySettingsExA ( NULL, lpDevMode, NULL, dwflags, 0 ); + LONG Status = ChangeDisplaySettingsExA ( NULL, lpDevMode, NULL, dwflags, 0 ); + if(lpDevMode) + lpDevMode->dmDriverExtra = 0; + return Status; } @@ -533,5 +536,8 @@ LPDEVMODEW lpDevMode, DWORD dwflags) { - return ChangeDisplaySettingsExW ( NULL, lpDevMode, NULL, dwflags, 0 ); -} + LONG Status = ChangeDisplaySettingsExW ( NULL, lpDevMode, NULL, dwflags, 0 ); + if(lpDevMode) + lpDevMode->dmDriverExtra = 0; + return Status; +}

16 years

Re: [ros-dev] [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable.

by Ged

Did you mean to remove IRP_MJ_CLEANUP? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of dgorbachev(a)svn.reactos.org Sent: 27 May 2009 21:27 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [dgorbachev] 41153: Do not assign twice to the same variable. Author: dgorbachev Date: Thu May 28 00:27:09 2009 New Revision: 41153 URL: http://svn.reactos.org/svn/reactos?rev=41153&view=rev Log: Do not assign twice to the same variable. Modified: trunk/reactos/drivers/storage/ide/pciide/pciide.c trunk/reactos/ntoskrnl/io/iomgr/rawfs.c Modified: trunk/reactos/drivers/storage/ide/pciide/pciide.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/pciide… ============================================================================== --- trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/pciide/pciide.c [iso-8859-1] Thu May 28 00:27:09 2009 @@ -104,7 +104,7 @@ ControllerProperties->SupportedTransferMode[0][0] = ControllerProperties->SupportedTransferMode[0][1] = ControllerProperties->SupportedTransferMode[1][0] = - ControllerProperties->SupportedTransferMode[1][0] = + ControllerProperties->SupportedTransferMode[1][1] = PIO_MODE0 | PIO_MODE1 | PIO_MODE2 | PIO_MODE3 | PIO_MODE4 | SWDMA_MODE0 | SWDMA_MODE1 | SWDMA_MODE2 | MWDMA_MODE0 | MWDMA_MODE1 | MWDMA_MODE2 | Modified: trunk/reactos/ntoskrnl/io/iomgr/rawfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/rawfs.c?… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/rawfs.c [iso-8859-1] Thu May 28 00:27:09 2009 @@ -1082,7 +1082,6 @@ DriverObject->MajorFunction[IRP_MJ_QUERY_INFORMATION] = DriverObject->MajorFunction[IRP_MJ_SET_INFORMATION] = DriverObject->MajorFunction[IRP_MJ_QUERY_VOLUME_INFORMATION] = - DriverObject->MajorFunction[IRP_MJ_CLEANUP] = DriverObject->MajorFunction[IRP_MJ_FILE_SYSTEM_CONTROL] = DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = (PDRIVER_DISPATCH)RawDispatch;

16 years, 1 month

Re: [ros-dev] [ros-diffs] [dchapyshev] 41115: - Stubimplement SPI_GETFONTSMOOTHINGTYPE/SPI_SETFONTSMOOTHINGTYPE

by Timo Kreuzer

Ok before you go on in this area, I am currently working on a complete rewrite of sysparams stuff. It should hopefully be ready this week and should fix almost all winetests and additional tests in this area. Regards, Timo dchapyshev(a)svn.reactos.org schrieb: > Author: dchapyshev > Date: Mon May 25 17:08:57 2009 > New Revision: 41115 > > URL: http://svn.reactos.org/svn/reactos?rev=41115&view=rev > Log: > - Stubimplement SPI_GETFONTSMOOTHINGTYPE/SPI_SETFONTSMOOTHINGTYPE > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c > > Modified: trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… > ============================================================================== > --- trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/win32k/ntuser/sysparams.c [iso-8859-1] Mon May 25 17:08:57 2009 > @@ -699,6 +699,22 @@ > { > ASSERT(pvParam); > *((BOOL*)pvParam) = IntIsFontRenderingEnabled(); > + break; > + } > + case SPI_SETFONTSMOOTHINGTYPE: > + { > + if (*((UINT*)pvParam) == FE_FONTSMOOTHINGCLEARTYPE) > + { > + DPRINT1("ReactOS does not support ClearType smoothing but it is returned TRUE\n"); > + } > + bChanged = TRUE; > + break; > + } > + case SPI_GETFONTSMOOTHINGTYPE: > + { > + /* We do not support ClearType. Only standard smoothing */ > + DPRINT1("ReactOS does not support ClearType smoothing. Returned FE_FONTSMOOTHINGSTANDARD\n"); > + *((UINT*)pvParam) = FE_FONTSMOOTHINGSTANDARD; > break; > } > case SPI_GETICONTITLELOGFONT: > > >

16 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev