Ros-dev

ros-dev@reactos.org

2 participants
5791 discussions

[ros-diffs] [dchapyshev] 41068: - Sync comctl32 with Wine 1.1.22 (without listview.c. Somebody help to sync listview! Now after sync listview there is a bug: http://opendn.org/listview.png)
by James Tabor 23 May '09

23 May '09

Hi all! What is missing with this? Do we need to fix User32? Did we not sync user32 controls? Edit, Combo, etc...? Thanks, James

1 0

Re: [ros-dev] [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged?
by Ged 23 May '09

23 May '09

I have the code to complete this functionality locally, I just haven't committed it yet as it's not tested. Thanks for the conflict :-P -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of tkreuzer(a)svn.reactos.org Sent: 22 May 2009 23:18 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [tkreuzer] 41046: #if out an unused static funtion. Don't know if it's still useful. Ged? Author: tkreuzer Date: Sat May 23 02:17:55 2009 New Revision: 41046 URL: http://svn.reactos.org/svn/reactos?rev=41046&view=rev Log: #if out an unused static funtion. Don't know if it's still useful. Ged? Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c Modified: branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/applications/mscutils/servman/propsheet_depends.c [iso-8859-1] Sat May 23 02:17:55 2009 @@ -50,6 +50,7 @@ return TreeView_InsertItem(hTreeView, &tvins); } +#if 0 // FIXME: What is this good for? static VOID AddServiceDependency(PSERVICEPROPSHEET dlgInfo, HWND hTreeView, @@ -123,6 +124,7 @@ } } +#endif static VOID AddServiceDependent(HWND hTreeView,

2 1

Re: [ros-dev] [ros-diffs] [dchapyshev] 41042: - Formatting fix. No code change
by Aleksey Bragin 23 May '09

23 May '09

I hope you asked James and Timo, who may have uncommitted patches to this file (which would fail to apply now). WBR, Aleksey Bragin. On May 22, 2009, at 4:50 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Fri May 22 16:50:31 2009 > New Revision: 41042 > > URL: http://svn.reactos.org/svn/reactos?rev=41042&view=rev > Log: > - Formatting fix. No code change > > Modified: > trunk/reactos/subsystems/win32/win32k/ntuser/hook.c >

3 2

Network source code
by Timo Kreuzer 22 May '09

22 May '09

2 1

Re: [ros-dev] [ros-diffs] [sedwards] 40919: imported the MT snapshot of the GPL tftp-server for win32 from sourceforge. Minor changes such as formatting and renaming the files, totally untested except for building, will be used later to serve up Reac
by Steven Edwards 20 May '09

20 May '09

On Thu, May 14, 2009 at 2:52 PM, KJK::Hyperion <hackbunny(a)reactos.org> wrote: > Ged wrote: >> Another unix like addition? >> Do we really need this and the previous telnet server in our source? > > to be fair, Windows does provide a command line TFTP client/server. So > far, I've only seen it used for malware spreading, but it's there and we > should provide one too Where I work we use dhcpd/tftp and PXEboot on both Linux and Windows to do automagical deployment services. The end goal with all of this is a ReactOS deployment system from a single image that can provision ReactOS thinkclients/diskless workstations without the need of a Linux or Windows host. Pushing out a freeldr or grub+freeldr or even pxelinux+grub+freeldr image with a blob containing a ROS ramdisk should be pretty simple using isc-dhcpd/tftp on Linux but I'm more interested in the infrastructure side of things right now. Currently the dhcpd with PXE support is the only part we are really missing. We COULD do it from Linux or Windows right now, but I want to get all the infrastructure in place where we don't need any other OS. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

10 16

Re: [ros-dev] runtime time function question in freeldr
by Zhang Fan 20 May '09

20 May '09

Thank you for your answer. But I'm still perplexd. pushl %eax //at that time ,%eax=0? so BootMain will receive NULL parameter? call _BootMain --- On Wed, 5/20/09, pay7n(a)o2.pl <pay7n(a)o2.pl> wrote: > From: pay7n(a)o2.pl <pay7n(a)o2.pl> > Subject: Re: [ros-dev] runtime time function question in freeldr > To: "ReactOS Development List" <ros-dev(a)reactos.org> > Date: Wednesday, May 20, 2009, 3:18 AM > This is not an Intel syntax. > Operands in memory operations have inverted order: > > mov src, dest > > not > > mov dest, src > > thus eax == 0 > > > Zhang Fan pisze: > > Hi everybody, > > I'm a newbie of ReactOS, and I've just looked a piece > of code in freeldr module. I found some runtime function > such as strstr(). I want to know if the run time lib should > be initialized, and where the initialized code. > > Another question is that a piece of code in arch.S > > > > > > EXTERN(RealEntryPoint) > > > > //.... > > .code32 > > > > /* Zero BootDrive and BootPartition > */ > > xorl %eax,%eax > > movl > %eax,(_BootDrive) > > movl > %eax,(_BootPartition) > > > > /* Store the boot drive */ > > movb > %dl,(_BootDrive) > > > > /* Store the boot partition */ > > movb > %dh,(_BootPartition) > > > > /* GO! */ > > pushl %eax > > call _BootMain > > > > At there, I think %eax should equal zero, and BootMain > will call CmdLineParse(),and CmdLineParse will call > strstr(). So it cause strstr will receive a NULL parameter. > Is it right? > > > > Thank you. > > > > Fan Zhang > > > > > > > > > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev(a)reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev(a)reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

1 0

runtime time function question in freeldr
by Zhang Fan 19 May '09

19 May '09

Hi everybody, I'm a newbie of ReactOS, and I've just looked a piece of code in freeldr module. I found some runtime function such as strstr(). I want to know if the run time lib should be initialized, and where the initialized code. Another question is that a piece of code in arch.S EXTERN(RealEntryPoint) //.... .code32 /* Zero BootDrive and BootPartition */ xorl %eax,%eax movl %eax,(_BootDrive) movl %eax,(_BootPartition) /* Store the boot drive */ movb %dl,(_BootDrive) /* Store the boot partition */ movb %dh,(_BootPartition) /* GO! */ pushl %eax call _BootMain At there, I think %eax should equal zero, and BootMain will call CmdLineParse(),and CmdLineParse will call strstr(). So it cause strstr will receive a NULL parameter. Is it right? Thank you. Fan Zhang

2 1

Re: [ros-dev] [ros-diffs] [tkreuzer] 40963: MmGrowKernelStack: Don't assert, but fail, when the kernel stack can't grow any more. Fixes a crash with recursive user calls. See issue #4060 for more details.
by Alex Ionescu 19 May '09

19 May '09

The code SHOULD assert. This is a hack. Best regards, Alex Ionescu On Sun, May 17, 2009 at 11:51 PM, <tkreuzer(a)svn.reactos.org> wrote: > Author: tkreuzer > Date: Mon May 18 01:51:31 2009 > New Revision: 40963 > > URL: http://svn.reactos.org/svn/reactos?rev=40963&view=rev > Log: > MmGrowKernelStack: Don't assert, but fail, when the kernel stack can't grow > any more. Fixes a crash with recursive user calls. > See issue #4060 for more details. > > Modified: > trunk/reactos/ntoskrnl/mm/procsup.c > > Modified: trunk/reactos/ntoskrnl/mm/procsup.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/procsup.c?rev=… > > ============================================================================== > --- trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] (original) > +++ trunk/reactos/ntoskrnl/mm/procsup.c [iso-8859-1] Mon May 18 01:51:31 > 2009 > @@ -259,8 +259,11 @@ > PETHREAD Thread = PsGetCurrentThread(); > > /* Make sure we have reserved space for our grow */ > - ASSERT(((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) > <= > - (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)); > + if (((PCHAR)Thread->Tcb.StackBase - (PCHAR)Thread->Tcb.StackLimit) > > + (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)) > + { > + return STATUS_NO_MEMORY; > + } > > /* > * We'll give you three more pages. > >

5 6

Re: [ros-dev] [ros-diffs] [janderwald] 40967: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM
by Ged 18 May '09

18 May '09

This shouldn't be in here. I can't tell you where it should be as I've never looked, but it's not userinit's responsibility to play logon music. -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of janderwald(a)svn.reactos.org Sent: 18 May 2009 16:41 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [janderwald] 40967: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM Author: janderwald Date: Mon May 18 19:41:00 2009 New Revision: 40967 URL: http://svn.reactos.org/svn/reactos?rev=40967&view=rev Log: - Play default logon sound when logging on - Due to unknown issues, this only works at the 2nd login ATM Modified: trunk/reactos/base/system/userinit/userinit.c Modified: trunk/reactos/base/system/userinit/userinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/useri… ============================================================================== --- trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] Mon May 18 19:41:00 2009 @@ -591,6 +591,51 @@ WARN("RegOpenKeyEx() failed with error %lu\n", rc); } +static VOID +PlayLogonSound() +{ + HKEY hKey; + WCHAR szBuffer[MAX_PATH] = {0}; + WCHAR szDest[MAX_PATH]; + DWORD dwSize = sizeof(szBuffer); + HMODULE hLibrary; + typedef BOOL WINAPI (*PLAYSOUNDW)(LPCWSTR,HMODULE,DWORD); + PLAYSOUNDW Play; + + if (RegOpenKeyExW(HKEY_CURRENT_USER, L"AppEvents\\Schemes\\Apps\\.Default\\WindowsLogon\\.Current", 0, KEY_READ, &hKey) != ERROR_SUCCESS) + { + return; + } + + if (RegQueryValueExW(hKey, NULL, NULL, NULL, (LPBYTE)szBuffer, &dwSize) != ERROR_SUCCESS) + { + RegCloseKey(hKey); + return; + } + + + RegCloseKey(hKey); + + if (!szBuffer[0]) + return; + + + szBuffer[MAX_PATH-1] = L'\0'; + if (ExpandEnvironmentStringsW(szBuffer, szDest, MAX_PATH)) + { + hLibrary = LoadLibraryW(L"winmm.dll"); + if (hLibrary) + { + Play = (PLAYSOUNDW)GetProcAddress(hLibrary, "PlaySoundW"); + if (Play) + { + Play(szDest, NULL, SND_FILENAME); + } + FreeLibrary(hLibrary); + } + } +} + static VOID SetUserSettings(VOID) { @@ -640,6 +685,7 @@ SetUserSettings(); StartShell(); NotifyLogon(); + PlayLogonSound(); return 0; }

1 0

I want to develop the kernel of ReactOS, how do i join????
by Joshua Bailey 18 May '09

18 May '09

Hello mailing list folks! While Xiaoming wouldn't be able to have commit access, would he be able to contribute in other ways not related to coding, i.e., hardware or software testing? Just curious. Mr. Ionescu, I probably would have tried to tell Xiaoming what I know about the rules, too, even though I'm not a developer. Actually, the FAQ is pretty clear in regards to ReactOS only using clean-room reverse engineering. http://www.reactos.org/en/about_userfaq.html. I would have just referred him to this, if you or another developer hadn't jumped in to give a more precise answer. I usually leave it up to the devs to answer questions, but I try to answer questions if I can when no developer is at hand at the moment. I hope that doesn't mean I have a drug problem. :) To be honest, I was pretty confused myself about who could do what if they had seen Windows source code beforehand. I know the current position is that seeing source code != no ReactOS programming for you, but then again there was the whole debate a few years back about whether the devs at the top had seen any Windows source code and I'm still not sure how that got resolved. I had alternately heard that people who had seen source code couldn't contribute, or if they had they could only code stuff whose Windows equivalents they hadn't seen the source code to, so it's not something that was just made up. I'm not trying to restart old flame wars, but the fact is that the policy regarding Windows source code hasn't always been so clear, which may have left some people (myself included) confused. While I personally wouldn't have replied assuming the same level of authority as a developer, I don't think us ordinary folks should be blamed if we've gotten a little confused about this througout the course of the past few years. I don't mean to start off here on a bad note, but I get irritated because on the forums someone asks a simple question, someone answers, the devs get angry because they feel someone overstepped their authority, even thought the devs tend to give a terse answer with no explanation. The newbie scared of asking anything else about the project because folks get so angry with one another, and figures it's not worth the trouble of getting involved. By the way, if the formatting here looks like it was written by a crackhead, it's because this is my first time posting on the mailing list. (I'm more active on the forums.) Then again, my hometown inspired The Wire, so who knows. :P -Joshua Bailey

3 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev