Ros-dev

ros-dev@reactos.org

2 participants
5789 discussions

Re: [ros-dev] [ros-diffs] [hyperion] 40541: This is why we can't have nice things. Reverting r40536, r40537, due to RosBE differences between Windows and Linux hosts (because RosBE sucks)

by Steven Edwards

On Thu, Apr 16, 2009 at 12:57 AM, <hyperion(a)svn.reactos.org> wrote: > Author: hyperion > Date: Thu Apr 16 08:57:28 2009 > New Revision: 40541 > > URL: http://svn.reactos.org/svn/reactos?rev=40541&view=rev > Log: > This is why we can't have nice things. Reverting r40536, r40537, due to RosBE differences between Windows and Linux hosts (because RosBE sucks) I don't think this is fair to the guys that have put a lot of hard work in to RosBE. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

15 years, 9 months

by Aleksey Bragin

I called a feature freeze if you have not noticed. WBR, Aleksey Bragin. On Apr 16, 2009, at 6:27 AM, hyperion(a)svn.reactos.org wrote: > Author: hyperion > Date: Thu Apr 16 06:27:50 2009 > New Revision: 40538 > > URL: http://svn.reactos.org/svn/reactos?rev=40538&view=rev > Log: > Rbuild rationalization commit, umpteenth of infinite

15 years, 9 months

Re: [ros-dev] [ros-diffs] General speech held by V?\195?\173ctor Mart?\195?\173nez (vicmarcal) and Javier Fernand?\195?\169z (elhoir) at Imagin?\195?\161tica 2009

by Colin Finck

> trunk/press-media/presentations/Imaginatica 2009/reactos_imaginatica.pptx Could we rather save such files as PPT? As far as I know, there is currently no loss in information if you save a file as PPT instead of PPTX in PowerPoint 2007. Furthermore, this makes it possible to open and edit such files with older PowerPoint versions or OpenOffice. Additionally, neither the PPTX import nor the ODP export (looking at the other Imaginatica presentation) of OpenOffice seem to work as reliable as the PPT import yet. Best regards, Colin

15 years, 9 months

Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service, enable it by default

by Gabriel ilardi

This is a really nice feature, but why enabling it by default? XP SP3 default state is disabled. > Date: Mon, 13 Apr 2009 16:26:50 +0000 > To: ros-diffs(a)reactos.org > From: sedwards(a)svn.reactos.org > Subject: [ros-diffs] [sedwards] 40485: add telnet service, enable it by default > > Author: sedwards > Date: Mon Apr 13 20:26:49 2009 > New Revision: 40485 > > URL: http://svn.reactos.org/svn/reactos?rev=40485&view=rev > Log: > add telnet service, enable it by default > > Modified: > trunk/reactos/base/services/services.rbuild > trunk/reactos/base/services/telnetd/serviceentry.c > trunk/reactos/base/services/telnetd/telnetd.c > trunk/reactos/base/services/telnetd/telnetd.rbuild > trunk/reactos/boot/bootdata/hivesys_i386.inf > trunk/reactos/boot/bootdata/packages/reactos.dff > > Modified: trunk/reactos/base/services/services.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/services.rbu… > ============================================================================== > --- trunk/reactos/base/services/services.rbuild [iso-8859-1] (original) > +++ trunk/reactos/base/services/services.rbuild [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -22,6 +22,9 @@ > <directory name="tcpsvcs"> > <xi:include href="tcpsvcs/tcpsvcs.rbuild" /> > </directory> > + <directory name="telnetd"> > + <xi:include href="telnetd/telnetd.rbuild" /> > + </directory> > <directory name="umpnpmgr"> > <xi:include href="umpnpmgr/umpnpmgr.rbuild" /> > </directory> > > Modified: trunk/reactos/base/services/telnetd/serviceentry.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/serv… > ============================================================================== > --- trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1] (original) > +++ trunk/reactos/base/services/telnetd/serviceentry.c [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -15,19 +15,15 @@ > * License along with this library; if not, write to the Free Software > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > -#if 0 > + > #define WIN32_LEAN_AND_MEAN > > #include <windows.h> > +#include "wine/debug.h" > > -#define WINE_FIXME printf > -#define WINE_TRACE printf > +WINE_DEFAULT_DEBUG_CHANNEL(telnetd); > > -//#include "wine/debug.h" > - > -//WINE_DEFAULT_DEBUG_CHANNEL(spoolsv); > - > -static WCHAR telnetdW[] = {'T','e','l','n','e','t','D',0}; > +static WCHAR telnetdW[] = {'t','e','l','n','e','t','d',0}; > > static SERVICE_STATUS_HANDLE service_handle; > static HANDLE stop_event; > @@ -106,6 +102,5 @@ > StartServiceCtrlDispatcherW(servtbl); > return 0; > } > -#endif > /* EOF */ > > > Modified: trunk/reactos/base/services/telnetd/telnetd.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/teln… > ============================================================================== > --- trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] (original) > +++ trunk/reactos/base/services/telnetd/telnetd.c [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -45,7 +45,7 @@ > * rename this function > * int kickoff_telnetd(void) > */ > -int main(int argc, char **argv) > +int kickoff_telnetd(void) > { > printf("Attempting to start Simple TelnetD\n"); > > > Modified: trunk/reactos/base/services/telnetd/telnetd.rbuild > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/telnetd/teln… > ============================================================================== > --- trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1] (original) > +++ trunk/reactos/base/services/telnetd/telnetd.rbuild [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -6,6 +6,7 @@ > <library>kernel32</library> > <library>advapi32</library> > <library>ws2_32</library> > + <library>wine</library> > > <file>telnetd.c</file> > <file>serviceentry.c</file> > > Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… > ============================================================================== > --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -1061,6 +1061,15 @@ > HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Start",0x00010001,0x00000003 > HKLM,"SYSTEM\CurrentControlSet\Services\tcpsvcs","Type",0x00010001,0x00000020 > > +; ReactOS Telnet Daemon > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Description",0x00000000,"ReactOS Telnet Daemon" > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","DisplayName",0x00000000,"ReactOS Telnet Daemon" > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ErrorControl",0x00010001,0x00000001 > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Group",0x00000000,"Network" > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","ImagePath",0x00020000,"%SystemRoot%\system32\telnetd.exe" > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Start",0x00010001,0x00000002 > +HKLM,"SYSTEM\CurrentControlSet\Services\telnetd","Type",0x00010001,0x00000020 > + > ; Sound Blaster (NT4) > ;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","Description",0x00000000,"Sound Blaster (NT4)" > ;HKLM,"SYSTEM\CurrentControlSet\Services\sndblst","ErrorControl",0x00010001,0x00000001 > > Modified: trunk/reactos/boot/bootdata/packages/reactos.dff > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… > ============================================================================== > --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] (original) > +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Mon Apr 13 20:26:49 2009 > @@ -90,6 +90,7 @@ > base\services\rpcss\rpcss.exe 1 > base\services\spoolsv\spoolsv.exe 1 > base\services\tcpsvcs\tcpsvcs.exe 1 > +base\services\telnetd\telnetd.exe 1 > base\services\tcpsvcs\quotes 5 > base\services\umpnpmgr\umpnpmgr.exe 1 > base\services\wlansvc\wlansvc.exe 1 > _________________________________________________________________ Quante ne sai? Scoprilo con CrossWire! http://clk.atdmt.com/GBL/go/140630367/direct/01/

15 years, 9 months

Re: [ros-dev] [ros-diffs] [sedwards] 40485: add telnet service, enable it by default

by WaxDragon

Those of us willing and able to help you test telnetd already are building rosapps. On Apr 15, 2009 2:13 AM, "Steven Edwards" <winehacker(a)gmail.com> wrote: On Tue, Apr 14, 2009 at 2:14 PM, Ged <gedmurphy(a)gmail.com> wrote: > Because we recently had a discus... Sure I agree with keeping down the build time but I thought we were going to implement a subset of build targets so the apps that make up the main distro would still be in the reactos checkout. If there is consensus that telnetd should be disabled or set to manual then I'll turn it off. Otherwise my plan was to leave it on until we reach 0.4 in the hopes that people would stress it out and help me develop it. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an id... Ros-dev mailing list Ros-dev(a)reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

15 years, 9 months

Re: [ros-dev] [ros-diffs] [dchapyshev] 40480: - Add more check on CodePage = 0. +2 passed wine tests

by Aleksey Bragin

Shouldn't it have only the return STATUS_UNSUCCESSFUL; changed to return STATUS_INVALID_PARAMETER; in the original version? I doubt IsValidCodePage should return true for a 0 codepage. WBR, Aleksey Bragin. On Apr 13, 2009, at 4:33 PM, dchapyshev(a)svn.reactos.org wrote: > Author: dchapyshev > Date: Mon Apr 13 16:33:33 2009 > New Revision: 40480 > > URL: http://svn.reactos.org/svn/reactos?rev=40480&view=rev > Log: > - Add more check on CodePage = 0. +2 passed wine tests > > Modified: > trunk/reactos/subsystems/win32/csrss/win32csr/conio.c > > Modified: trunk/reactos/subsystems/win32/csrss/win32csr/conio.c > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ > win32/csrss/win32csr/conio.c?rev=40480&r1=40479&r2=40480&view=diff > ====================================================================== > ======== > --- trunk/reactos/subsystems/win32/csrss/win32csr/conio.c > [iso-8859-1] (original) > +++ trunk/reactos/subsystems/win32/csrss/win32csr/conio.c > [iso-8859-1] Mon Apr 13 16:33:33 2009 > @@ -3023,12 +3023,20 @@ > > Request->Header.u1.s1.TotalLength = sizeof(CSR_API_MESSAGE); > Request->Header.u1.s1.DataLength = sizeof(CSR_API_MESSAGE) - > sizeof(PORT_MESSAGE); > - if (IsValidCodePage(Request- > >Data.SetConsoleOutputCodePage.CodePage)) > + if (Request->Data.SetConsoleOutputCodePage.CodePage == 0) > + { > + ConioUnlockConsole(Console); > + return STATUS_INVALID_PARAMETER; > + } > + else > + { > + if (IsValidCodePage(Request- > >Data.SetConsoleOutputCodePage.CodePage)) > { > Console->OutputCodePage = Request- > >Data.SetConsoleOutputCodePage.CodePage; > ConioUnlockConsole(Console); > return STATUS_SUCCESS; > } > + } > ConioUnlockConsole(Console); > return STATUS_UNSUCCESSFUL; > } >

15 years, 9 months

Re: [ros-dev] [ros-diffs] [sedwards] 40481: move telnetd to main tree, not enabled yet

by Ged

Why? Do we really need a telnet server in trunk? -----Original Message----- From: ros-diffs-bounces(a)reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of sedwards(a)svn.reactos.org Sent: 13 April 2009 14:29 To: ros-diffs(a)reactos.org Subject: [ros-diffs] [sedwards] 40481: move telnetd to main tree, not enabled yet Author: sedwards Date: Mon Apr 13 17:29:21 2009 New Revision: 40481 URL: http://svn.reactos.org/svn/reactos?rev=40481&view=rev Log: move telnetd to main tree, not enabled yet Added: trunk/reactos/base/services/telnetd/ (props changed) - copied from r40480, trunk/rosapps/applications/sysutils/telnetd/ Modified: trunk/reactos/boot/bootdata/packages/reactos.dff Propchange: trunk/reactos/base/services/telnetd/ ------------------------------------------------------------------------------ svn:mergeinfo = Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… ============================================================================== --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Mon Apr 13 17:29:21 2009 @@ -670,7 +670,6 @@ modules\rosapps\applications\sysutils\pedump\pedump.exe 1 optional modules\rosapps\applications\sysutils\regexpl\regexpl.exe 1 optional modules\rosapps\applications\sysutils\tcat\tcat.exe 1 optional -modules\rosapps\applications\sysutils\telnetd\telnetd.exe 1 optional modules\rosapps\applications\sysutils\tlist\tlist.exe 1 optional modules\rosapps\applications\sysutils\screenshot\screenshot.exe 1 optional modules\rosapps\applications\sysutils\utils\binpatch\binpatch.exe 1 optional

15 years, 9 months

Year 2038 problem

by Javier Agustìn Fernàndez Arroyo

Hi all, i hope you have already taken into account this: http://en.wikipedia.org/wiki/Year_2038_problem Regards, Javier

15 years, 9 months

Re: [ros-dev] [ros-diffs] [cgutman] 40471: - Don't close the connection handle and dereference the connection object when we run out of memory because it will cause a crash when AfdCleanupSocket tries to do the same - Fixes bug 4362

by Aleksey Bragin

On Apr 12, 2009, at 9:07 AM, cgutman(a)svn.reactos.org wrote: > - /* Is this correct? */ > - TdiCloseDevice( FCB->Connection.Handle, > - FCB->Connection.Object ); Turned out it was not :)

15 years, 9 months

Downloader tool

by Ged

I think we should make an exception for the downloader tool and move it out of rosapps into the main source. I think the argument for having it in there would exceed the argument against. Any thoughts?

15 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-dev